[PATCH v2 08/20] lpfc: Fix duplicate NVME rport entries and namespaces.

apping. This allowed the 2nd rport to sneak in as it was considered a separate device. This patch adds the fixes to Swap the nrport in each ndlp and take care of the reference counts on the ndlps similar to FCP rports. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by:

[PATCH v2 02/20] lpfc: Fix loop mode target discovery

target discovery fails. Fix by checking the topology during discovery. If it is loop, set the NLP FC4 type to FCP. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_nportdisc.c | 3 +++ 1 file cha

[PATCH v2 03/20] lpfc: Fix rediscovery on switch blade pull

evloss. Since the driver believes that a LOGO is outstanding, it does not issue a PLOGI to the target upon link up Correct by placing the ndlp in UNUSED state When devloss happens in LOGO_ISSUE state. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm.

[PATCH v2 01/20] lpfc: Fix plogi collision that causes illegal state transition

n the node again and drop the REGLOGIN mailbox command. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_els.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) di

[PATCH v2 04/20] lpfc: Fix oops when NVME Target is discovered in a nonNVME environment

ed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_nvme.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/lpfc/lpfc_nvme.c b/drivers/scsi/lpfc/lpfc_nvme.c index 0a0a1b92d01d..2

[PATCH v2 00/20] lpfc updates for 11.4.0.3

bad sgl reposting after 2nd adapter reset lpfc: lpfc version bump 11.4.0.3 James Smart (2): lpfc: remove console log clutter lpfc: Add Buffer to Buffer credit recovery support Maurizio Lombardi (1): scsi: lpfc: fix "integer constant too large" error on 32bit archs drivers/scs

[PATCH v2 17/20] lpfc: remove console log clutter

Change hw queue binding messages to info - not error. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc

[PATCH v2 12/20] lpfc: Limit amount of work processed in IRQ

rk per itteration. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_sli.c | 31 +++ drivers/scsi/lpfc/lpfc_sli4.h | 1 + 2 files changed, 20 insertions(+), 12 deleti

[PATCH v2 16/20] lpfc: Fix bad sgl reposting after 2nd adapter reset

ailbox handling that was used to remove the sgl lists - causing multiple 60s mbx timeouts. Fix by preserving all SGL lists over the fc port reset. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpf

[PATCH v2 13/20] lpfc: Fix MRQ > 1 context list handling

w cpus until a single resource can be allocated. if the condition reoccurs, it starts looking at a different cpu. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_attr.c| 11 +- drivers/scs

[PATCH v2 07/20] lpfc: Fix handling of FCP and NVME FC4 types in Pt2Pt topology

P PRLI. The multiple protocol PRLI's are sent simultaneously. However, driver will now only state transition after both PRLI's are complete. New flags were added to aid tracking the responses from the different PRLI's. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by:

[PATCH v2 18/20] lpfc: Add Buffer to Buffer credit recovery support

Add Buffer to buffer credit recovery support to the driver. This is a negotiated feature with the peer that allows for both sides to detect dropped RRDY's and FC Frames and recover credit. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@bro

[PATCH v2 19/20] scsi: lpfc: fix "integer constant too large" error on 32bit archs

m> Signed-off-by: James Smart <james.sm...@broadcom.com> --- v2: use rol64() --- drivers/scsi/lpfc/lpfc_init.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c index 19af7e2c2ac0..8c512e494353 100644

[PATCH v2 20/20] lpfc: lpfc version bump 11.4.0.3

From: Dick Kennedy <dick.kenn...@broadcom.com> Update driver version to 11.4.0.3 Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH v2 09/20] lpfc: Fix crash in lpfc nvmet when fc port is reset

r list. Corrected the sgl buffer recovery as well as strengthening the initialization of the bufferlist. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_init.c | 16 1 file chan

[PATCH v2 10/20] lpfc: Fix NVME PRLI handling during RSCN

C-NVME. Corrected by making the assumption that the target always supports FC-NVME thus a PRLI is sent. It's ok for the target to reject it. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_els.c | 10

[PATCH v2 15/20] lpfc: Fix nvme target failure after 2nd adapter reset

could not take place. Corrected by recreating the localport in the adapter reset recovery routine. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_init.c | 18 +- 1 file changed, 1

[PATCH v2 11/20] lpfc: Correct issues with FAWWN and FDISCs

FDISCs. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_els.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c index 9a8808abe61f..f

[PATCH v2 14/20] lpfc: Fix relative offset error on large nvmet target ios

Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_nvmet.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_nvmet.c b/drivers/scsi/lpfc/lpfc_nvmet.c

[PATCH v2 1/2] nvmet_fc: add defer_req callback for deferment of cmd buffer return

to the LLDD to signify to hold off on recycling the cmd iu buffer. And later, when a job struct is allocated and the buffer copied, a new LLDD callback is introduced to notify the LLDD and allow it to recycle it's command iu buffer. Signed-off-by: James Smart <james.sm...@broadcom.com>

[PATCH v2 2/2] lpfc: support nvmet_fc defer_rcv callback

. This patch adds support for the new nvmet_fc transport defer_rcv callback and recognition of the new error code when passing commands to the transport. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- This patch is inten

[PATCH v2 0/2] nvmet_fc: work around overalloc of queue elements

status code return from nvmet_fc_rcv_fcp_req(). v2: respond to comments from Johannes. James Smart (2): nvmet_fc: add defer_req callback for deferment of cmd buffer return lpfc: support nvmet_fc defer_rcv callback drivers/nvme/target/fc.c | 210

Re: [PATCH 01/21] lpfc: Fix opps when ExpressLane is enabled

On 8/3/2017 3:43 AM, Nikola Pajkovsky wrote: James Smart <jsmart2...@gmail.com> writes: From: Dick Kennedy <dick.kenn...@broadcom.com> Null pointer dereference in lpfc_sli4_fof_intr_handler The driver does not set up cq->assoc_qp for sli4_hba->oas_cq Initialize cq->asso

Re: [PATCH 1/2] nvmet_fc: add defer_req callback for deferment of cmd buffer return

On 8/2/2017 1:16 AM, Johannes Thumshirn wrote: + for (;;) { + deferfcp = list_first_entry_or_null(>pending_cmd_list, + struct nvmet_fc_defer_fcp_req, req_list); + if (!deferfcp) + break; while

Re: [PATCH 2/2] lpfc: support nvmet_fc defer_rcv callback

On 8/2/2017 1:32 AM, Johannes Thumshirn wrote: len += snprintf(buf+len, PAGE_SIZE-len, - "FCP: Rcv %08x Release %08x Drop %08x\n", + "FCP: Rcv %08x Defer %08x Release %08x " + "Drop %08x\n",

Re: [PATCH v2 12/20] lpfc: Limit amount of work processed in IRQ

On 8/7/2017 1:43 AM, Johannes Thumshirn wrote: On Fri, Aug 04, 2017 at 05:47:23PM -0700, James Smart wrote: From: Dick Kennedy <dick.kenn...@broadcom.com> Various oops being seen on being in the ISR too long and cpu lockups, when under heavy load. The amount of work being post

Re: [PATCH v2 04/20] lpfc: Fix oops when NVME Target is discovered in a nonNVME environment

On 8/7/2017 1:00 AM, Johannes Thumshirn wrote: On Fri, Aug 04, 2017 at 05:47:15PM -0700, James Smart wrote: From: Dick Kennedy <dick.kenn...@broadcom.com> lpfc oops when it discovers a NVME target but is configured for SCSI only operation. Oops is in lpfc_nvme_register_port+0x33/0x300.

Re: [PATCH] scsi: lpfc: double lock typo in lpfc_ns_rsp()

c_ct.c b/drivers/scsi/lpfc/lpfc_ct.c Yep. looks good Reviewed-by: James Smart <james.sm...@broadcom.com>

Re: [PATCH v2 02/15] lpfc: Fix system crash when port is reset.

On 5/16/2017 5:26 AM, Guilherme G. Piccoli wrote: On 05/15/2017 07:20 PM, James Smart wrote: The driver panic when using the els_wq during port reset. Check for NULL els_wq before dereferencing. James/Dick, if possible please take a look on: https://marc.info/?l=linux-scsi=149487670315697

Re: [PATCH 04/15] lpfc: Fix nvmet RQ resource needs for large block writes.

On 5/10/2017 11:18 PM, Hannes Reinecke wrote: On 05/10/2017 09:07 PM, James Smart wrote: Large block writes to the nvme target were failing because the default number of RQs posted was insufficient. Expand the NVMET RQs to 2048 RQEs and ensure a minimun of 2048

[PATCH] lpfc: fix build issue if NVME_FC_TARGET is not defined

fix build issue if NVME_FC_TARGET is not defined. noop the code. The code will never be invoked if target mode is not enabled. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_nvmet.c | 2 ++ 1

Re: [PATCH 12/15] lpfc: Cleanup entry_repost settings on SLI4 queues

On 5/11/2017 12:49 AM, Hannes Reinecke wrote: If this is a fix to a previous patch (Patch 6/15 ?), please merge it with that. It was, in some areas. Split those areas out and merged into the prior patches. Affected patches 0004, 0006, and 0008. -- james

Re: [PATCH 10/15] lpfc: Fix NVME I+T not registering NVME as a supported FC4 type

On 5/11/2017 12:35 AM, Hannes Reinecke wrote: On 05/10/2017 09:07 PM, James Smart wrote: When the driver send the RPA command, it does not send supported FC4 Type NVME to the management server. Encode NVME (type x28) in the AttribEntry in the RPA command. Signed-off-by: Dick Kennedy

[PATCH 14/15] lpfc: Add MDS Diagnostic support.

Added code to support Cisco MDS loopback diagnostic. The diagnostics run various loopbacks including one which loops-back frame through the driver. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi

[PATCH 11/15] lpfc: Fix debugfs root inode "lpfc" not getting deleted on driver unload.

on lpfc_debugfs_hba_count because this parameter tracks the fnX instance tracked per driver instance. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_debugfs.c | 6 -- 1 file changed, 4 insertions(+),

[PATCH 12/15] lpfc: Cleanup entry_repost settings on SLI4 queues

enn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_init.c | 3 -- drivers/scsi/lpfc/lpfc_sli.c | 64 +++ drivers/scsi/lpfc/lpfc_sli4.h | 8 -- 3 files changed, 21 insertions(+), 54 deletions(-) diff --g

[PATCH 05/15] lpfc: Fix NVMEI driver not decrementing counter causing bad rport state.

, to retry the PRLI, always decrement the fc4_prli_sent counter. This allows the PRLI completion to resolve to UNMAPPED when NVMET rejects the PRLI. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lp

[PATCH 06/15] lpfc: Fix NMI watchdog assertions when running nvmet IOPS tests

the doorbell with NOARM and continue processing. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_debugfs.c | 30 +++--- drivers/scsi/lpfc/lpfc_sli.c | 8 ++-- 2 files

[PATCH 07/15] lpfc: Separate NVMET data buffer pool fir ELS/CT.

Using 2048 byte buffer and onle 128 bytes is needed. Create nee LFPC_NVMET_DATA_BUF_SIZE define to use for NVMET RQ/MRQs. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc.h | 1 + drive

[PATCH 09/15] lpfc: Added recovery logic for running out of NVMET IO context resources

Previous logic would just drop the IO Added logic to queue the IO to wait for an IO context resource from an IO thats already in progress. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc.h

[PATCH 10/15] lpfc: Fix NVME I+T not registering NVME as a supported FC4 type

When the driver send the RPA command, it does not send supported FC4 Type NVME to the management server. Encode NVME (type x28) in the AttribEntry in the RPA command. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> ---

[PATCH 08/15] lpfc: Separate NVMET RQ buffer posting from IO resources SGL/iocbq/context

MRQ. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc.h | 11 +- drivers/scsi/lpfc/lpfc_attr.c | 11 -- drivers/scsi/lpfc/lpfc_crtn.h | 8 +- drivers/scsi/lpfc/lpfc_i

[PATCH 00/15] lpfc updates for 11.2.0.14

should merge via Martin's tree. James Smart (15): lpfc: Fix used-RPI accounting problem. lpfc: Fix system crash when port is reset. lpfc: Adding additional stats counters for nvme. lpfc: Fix nvmet RQ resource needs for large block writes. lpfc: Fix NVMEI driver not decrementing counter

[PATCH 01/15] lpfc: Fix used-RPI accounting problem.

when the FCOE_POST_HDR_TEMPLATE succeeds. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_els.c | 3 ++- drivers/scsi/lpfc/lpfc_init.c | 24 +--- drivers/scsi/lpfc/lpfc

[PATCH 02/15] lpfc: Fix system crash when port is reset.

The driver panic when using the els_wq during port reset. Check for NULL els_wq before dereferencing. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc.h | 8 ++-- drivers/scsi/lpfc/lp

[PATCH 03/15] lpfc: Adding additional stats counters for nvme.

More debug messages added for nvme statistics. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_attr.c| 24 - drivers/scsi/lpfc/lpfc_debugfs.c | 27 +---

[PATCH 04/15] lpfc: Fix nvmet RQ resource needs for large block writes.

ed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_attr.c | 4 ++-- drivers/scsi/lpfc/lpfc_init.c | 20 +++- drivers/scsi/lpfc/lpfc_nvmet.c | 2 +- drivers/scsi/lpfc/lpfc_nvmet.h | 1 + drivers/scsi/lpfc/lpfc_sli.c | 18 ++

[PATCH 15/15] lpfc: update version to 11.2.0.14

Change driver version to 11.2.0.14 Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_version

[PATCH 13/15] lpfc: Fix NVMEI's handling of NVMET's PRLI response attributes

rport, it uses the stored ndlp attributes to set the rport port_roles correctly. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_disc.h | 1 + drivers/scsi/lpfc/lpfc_nportdisc.c | 6 ++ 2 file

Re: [PATCH] scsi: fix typos and grammar in comments of scsi_transport_fc.c

On 6/21/2017 1:24 PM, Tyrel Datwyler wrote: Signed-off-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> --- drivers/scsi/scsi_transport_fc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) Reviewed-by: James Smart <james.sm...@broadcom.com>

[PATCH] lpfc: fix refcount error on node list

A change in remote port removal introduced a spurious put which can cause a premature structure teardown. The affects were most notable when the driver attempted to unload as a null pointer would be hit. Fix by removing the unnecessary put. Signed-off-by: James Smart <james.sm...@broadcom.

[PATCH] lpfc: Fix nvme io stoppage after link bounce

to proceed. Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_nvme.c | 35 +-- 1 file changed, 1 insertion(+), 34 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_nvme.c b/drivers/scsi/lpfc/lpfc_nvme.c index 8206aa5493e3..0a0a1b

Re: [PATCH 1/6] qla2xxx: Add FC-NVMe port discovery and PRLI handling

On 6/16/2017 3:47 PM, Himanshu Madhani wrote: /* FCP-4 types */ #define FC4_TYPE_FCP_SCSI 0x08 +#define FC4_TYPE_NVME 0x28 #define FC4_TYPE_OTHER0x0 #define FC4_TYPE_UNKNOWN 0xff please use the types from include/uapi/scsi/fc/fc_fs.h

Re: [PATCH 2/6] qla2xxx: Add FC-NVMe command handling

On 6/16/2017 3:47 PM, Himanshu Madhani wrote: @@ -615,8 +620,25 @@ struct sts_entry_24xx { uint32_t rsp_residual_count;/* FCP RSP residual count. */ uint32_t sense_len; /* FCP SENSE length. */ - uint32_t rsp_data_len; /* FCP response data length. */ -

Re: [PATCH 4/6] qla2xxx: Send FC4 type NVMe to the management server

om> Signed-off-by: Himanshu Madhani <himanshu.madh...@cavium.com> --- Reviewed-By: James Smart <james.sm...@broadcom.com>

Re: [PATCH 5/6] qla2xxx: Use FC-NMVe FC4 type for FDMI registration

ff-by: Giridhar Malavali <giridhar.malav...@cavium.com> Signed-off-by: Himanshu Madhani <himanshu.madh...@cavium.com> --- Reviewed-by: James Smart <james.sm...@broadcom.com>

Re: [PATCH 6/6] qla2xxx: Update Driver version to 10.00.00.00-k

On 6/16/2017 3:47 PM, Himanshu Madhani wrote: Signed-off-by: Himanshu Madhani <himanshu.madh...@cavium.com> Reviewed-by: James Smart <james.sm...@broadcom.com>

Re: [PATCH 3/6] qla2xxx: Add FC-NVMe F/W initialization and transport registration

On 6/16/2017 3:47 PM, Himanshu Madhani wrote: From: Duane Grigsby This code provides the interfaces to register remote and local ports of FC4 type 0x28 with the FC-NVMe transport and transports the requests (FC-NVMe FC link services and FC-NVMe commands IUs) to the

Re: [PATCH] lpfc: Fix nvme io stoppage after link bounce

On 6/22/2017 12:41 AM, Johannes Thumshirn wrote: On Wed, Jun 21, 2017 at 10:37:58AM -0700, James Smart wrote: [...] - /* -* Catch race where our node has transitioned, but the -* transport is still transitioning. -*/ The patch looks fine but can you please

Re: [PATCH] scsi: lpfc: prevent potential null pointer dereference

Looks good Signed-off-by: James Smart <james.sm...@broadcom.com> -- james On 5/23/2017 8:09 AM, Gustavo A. R. Silva wrote: Null check at line 966: if (ndlp) {, implies that ndlp might be NULL. Functions lpfc_nlp_set_state() and lpfc_issue_els_prli() dereference pointer ndlp. I

Re: [PATCH] scsi: lpfc: Avoid NULL pointer dereference in lpfc_els_abort()

Change looks good Signed-off-by: James Smart <james.sm...@broadcom.com> -- james On 5/24/2017 2:48 PM, Guilherme G. Piccoli wrote: We might have a NULL pring in lpfc_els_abort(), for example on error recovery path, since queues are destroyed during error recovery mechanism. In thi

Re: [PATCH] lpfc: nvmet_fc: fix format string

Patch is fine. Signed-off-by: James Smart <james.sm...@broadcom.com> -- james On 5/19/2017 1:04 AM, Arnd Bergmann wrote: The lpfc_nvmeio_data() tracing helper always takes a format string and three additional arguments. The latest caller has a format string with only two integer arg

Re: [PATCH] scsi: lpfc: Fix crash on PCI hotplug remove path

looks good Signed-off-by: James Smart <james.sm...@broadcom.com> -- james On 5/28/2017 2:45 PM, Guilherme G. Piccoli wrote: During a PCI hotplug remove event we could have a NULL pointer dereference on lpfc_sli_abort_iocb(), if pring is NULL. This patch adds a check for thi

Re: [PATCH] scsi: lpfc: fix spelling mistake "entrys" -> "entries"

it's good :) Signed-off-by: James Smart <james.sm...@broadcom.com> -- james On 5/26/2017 3:11 AM, Colin King wrote: From: Colin Ian King <colin.k...@canonical.com> Trivial fix to spelling mistake in debugfs message Signed-off-by: Colin Ian King <colin.k...@canonical.com>

Re: [PATCH] scsi: lpfc: make a couple of functions static

Patch is fine. Signed-off-by: James Smart <james.sm...@broadcom.com> -- james On 5/18/2017 2:35 AM, Colin King wrote: From: Colin Ian King <colin.k...@canonical.com> functions lpfc_nvmet_cleanup_io_context and lpfc_nvmet_setup_io_context can be made static as they

[PATCH 04/15] lpfc: Add changes to assist in NVMET debugging

-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_nvmet.c | 208 - drivers/scsi/lpfc/lpfc_nvmet.h | 14 +-- 2 files changed, 151 insertions(+), 71 deletions(-)

[PATCH 07/15] lpfc: Fix Port going offline after multiple resets.

fails during reset. Add SGL buffer back to list before returning NULL. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_sli.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/lpfc/

[PATCH 09/15] lpfc: Fix return value of board_mode store routine in case of online failure

code (-EIO) in case of failure. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_attr.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_att

[PATCH 00/15] lpfc updates for 11.4.0.0

This patch set provides a number of bug fixes, code cleanups, and error handling in lpfc. The patches were cut against the Martin's 4.12/scsi-fixes tree. There are no outside dependencies. The patches should merge via Martin's tree. James Smart (15): lpfc: Add nvme initiator devloss support

[PATCH 15/15] lpfc: update to revision to 11.4.0.0

Set lpfc driver revision to 11.4.0.0 Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_version

[PATCH 10/15] lpfc: Fix crash on powering off BFS VM with passthrough device

Null pointer dereference when BFS VM is powered off The driver incorrectly uses sli3_ring on SLI-4 adapters Use the correct ring structure based on sli_rev Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drive

[PATCH 13/15] lpfc: Fix PRLI retry handling when target rejects it.

on the PRLI retry. This was enough to allow the REG_RPI to complete at the target. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_els.c | 17 ++--- 1 file changed, 14 insertions(+),

[PATCH 14/15] lpfc: Fix vports not logging into target

not send GFF_ID only if this NPortID is previously identified as FCP target. Send GFF_ID if it is a newly identified remote port from GID_FT response. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lp

[PATCH 06/15] lpfc: Fix nvmet node ref count handling

when NVMET and the old state was UNMAPPED or MAPPED. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_hbadisc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drive

[PATCH 01/15] lpfc: Add nvme initiator devloss support

as resumed if the rport handed back matches the ndlp->nrport pointer. Otherwise, devloss fired and the ndlp's nrport is NULL. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_attr.c | 7 ++- driv

[PATCH 02/15] lpfc: Fix transition nvme-i rport handling to nport only.

on a devloss action. Convert debugfs and nvme_info in sysfs to use the fc_nodes list in the vport. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_attr.c| 11 ++- drivers/scsi/lpfc/lpfc_de

[PATCH 12/15] lpfc: Null pointer dereference when log_verbose is set to 0xffffffff

Kernel panic when log_verbose is set to 0x phba->pport is dereferenced before it is initialized Fix: Do not dereference phba->pport if it is NULL Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> ---

[PATCH 08/15] lpfc: Fix counters so outstandng NVME IO count is accurate

enn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc.h | 20 ++-- drivers/scsi/lpfc/lpfc_attr.c| 32 +--- drivers/scsi/lpfc/lpfc_debugfs.c | 30 +- drivers/scsi/lpfc

[PATCH 11/15] lpfc: Fix System panic after loading the driver

handler_name. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_init.c | 11 ++- drivers/scsi/lpfc/lpfc_sli4.h | 4 ++-- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/drive

[PATCH 05/15] lpfc: Fix Lun Priority level shown as NA

Lun Priority level shown as NA Remote port is not getting registered for nameserver and fdmi. Due to which dfc SendCTPassThru cmd is failing. Made changes to register the remote port for both. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <

[PATCH 03/15] lpfc: Fix nvme port role handling in sysfs and debugfs handlers.

info handlers. The full port role was added to the NVME data only not the generic nodelist. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_attr.c| 22 ++ drive

[PATCH v2 03/17] lpfc: Fix nvme port role handling in sysfs and debugfs handlers.

info handlers. The full port role was added to the NVME data only not the generic nodelist. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_attr.c| 22 ++ drive

[PATCH v2 05/17] lpfc: Fix Lun Priority level shown as NA

Lun Priority level shown as NA Remote port is not getting registered for nameserver and fdmi. Due to which dfc SendCTPassThru cmd is failing. Made changes to register the remote port for both. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <

[PATCH v2 07/17] lpfc: Fix Port going offline after multiple resets.

fails during reset. Add SGL buffer back to list before returning NULL. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_sli.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/lpfc/

[PATCH v2 04/17] lpfc: Add changes to assist in NVMET debugging

-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_nvmet.c | 208 - drivers/scsi/lpfc/lpfc_nvmet.h | 14 +-- 2 files changed, 151 insertions(+), 71 deletions(-)

[PATCH v2 02/17] lpfc: Fix transition nvme-i rport handling to nport only.

on a devloss action. Convert debugfs and nvme_info in sysfs to use the fc_nodes list in the vport. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_attr.c| 11 ++- drivers/scsi/lpfc/lpfc_de

[PATCH v2 06/17] lpfc: Fix nvmet node ref count handling

when NVMET and the old state was UNMAPPED or MAPPED. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_hbadisc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drive

[PATCH v2 01/17] lpfc: Add nvme initiator devloss support

as resumed if the rport handed back matches the ndlp->nrport pointer. Otherwise, devloss fired and the ndlp's nrport is NULL. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_attr.c | 7 ++- driv

[PATCH v2 00/17] lpfc updates for 11.4.0.0

additional patches (Coverity scan and EQ delay). James Smart (17): lpfc: Add nvme initiator devloss support lpfc: Fix transition nvme-i rport handling to nport only. lpfc: Fix nvme port role handling in sysfs and debugfs handlers. lpfc: Add changes to assist in NVMET debugging lpfc: Fix Lun

[PATCH v2 15/17] lpfc: Fix defects reported by Coverity Scan

/scsi/lpfc/lpfc_nvmet.c: 2131 in lpfc_nvmet_unsol_fcp_abort_cmp() ** CID 1411555: Memory - illegal accesses (UNINIT) /drivers/scsi/lpfc/lpfc_nvmet.c: 180 in lpfc_nvmet_ctxbuf_post() Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broa

[PATCH v2 09/17] lpfc: Fix return value of board_mode store routine in case of online failure

code (-EIO) in case of failure. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_attr.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_att

[PATCH v2 12/17] lpfc: Null pointer dereference when log_verbose is set to 0xffffffff

Kernel panic when log_verbose is set to 0x phba->pport is dereferenced before it is initialized Fix: Do not dereference phba->pport if it is NULL Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> ---

[PATCH v2 16/17] lpfc: Add auto EQ delay logic

selection can be disabled by the new lpfc_auto_imax module_parameter. Older hardware can only change interrupt coalescing by mailbox command. Newer hardware supports change via a register. The patch support both. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James

[PATCH v2 10/17] lpfc: Fix crash on powering off BFS VM with passthrough device

Null pointer dereference when BFS VM is powered off The driver incorrectly uses sli3_ring on SLI-4 adapters Use the correct ring structure based on sli_rev Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> Tested-by: R

[PATCH v2 11/17] lpfc: Fix System panic after loading the driver

handler_name. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_init.c | 11 ++- drivers/scsi/lpfc/lpfc_sli4.h | 4 ++-- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/drive

[PATCH v2 17/17] lpfc: update to revision to 11.4.0.0

Set lpfc driver revision to 11.4.0.0 Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_version

[PATCH v2 08/17] lpfc: Fix counters so outstandng NVME IO count is accurate

enn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc.h | 20 ++-- drivers/scsi/lpfc/lpfc_attr.c| 32 +--- drivers/scsi/lpfc/lpfc_debugfs.c | 30 +- drivers/scsi/lpfc

[PATCH v2 14/17] lpfc: Fix vports not logging into target

not send GFF_ID only if this NPortID is previously identified as FCP target. Send GFF_ID if it is a newly identified remote port from GID_FT response. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lp

[PATCH v2 13/17] lpfc: Fix PRLI retry handling when target rejects it.

on the PRLI retry. This was enough to allow the REG_RPI to complete at the target. Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> Signed-off-by: James Smart <james.sm...@broadcom.com> --- drivers/scsi/lpfc/lpfc_els.c | 17 ++--- 1 file changed, 14 insertions(+),

Re: [PATCH v2 00/17] lpfc updates for 11.4.0.0

On 6/5/2017 6:13 PM, Martin K. Petersen wrote: Hi James, This patch set provides a number of bug fixes, code cleanups, and error handling in lpfc. The patches were cut against the Martin's 4.12/scsi-fixes tree. There are no outside dependencies. The patches should merge via Martin's tree.

<    5   6   7   8   9   10   11   12   13   14   >