' defined but not used
[-Wunused-function]
drivers/scsi/isci/init.c:743:12: warning: 'isci_resume' defined but not used
[-Wunused-function]
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/scsi/isci/init.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers
This patch uses module_platform_driver_probe() macro which makes
the code smaller and simpler.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/scsi/a4000t.c | 15 +--
1 files changed, 1 insertions(+), 14 deletions(-)
diff --git a/drivers/scsi/a4000t.c b/drivers/scsi
This patch uses module_platform_driver_probe() macro which makes
the code smaller and simpler.
Acked-by: Geert Uytterhoeven ge...@linux-m68k.org
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/scsi/a3000.c | 13 +
1 files changed, 1 insertions(+), 12 deletions(-)
diff
after device_release or on probe failure.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/scsi/jazz_esp.c |4 ++--
drivers/scsi/qlogicpti.c |4 ++--
drivers/scsi/sni_53c710.c |4 ++--
drivers/scsi/sun3x_esp.c |4 ++--
drivers/scsi/sun_esp.c|6 ++
5 files
The usage of strict_strtoul() is not preferred, because
strict_strtoul() is obsolete. Thus, kstrtoul() should be
used.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/scsi/pmcraid.c|2 +-
drivers/scsi/scsi_sysfs.c |2 +-
2 files changed, 2 insertions(+), 2 deletions
The usage of strict_strtoul() is not preferred, because
strict_strtoul() is obsolete. Thus, kstrtoul() should be
used.
Signed-off-by: Jingoo Han jg1@samsung.com
---
Changes since v1:
- Used return code from kstrtoul().
drivers/scsi/pmcraid.c|6 --
drivers/scsi/scsi_sysfs.c
The usage of strict_strtoul() is not preferred, because
strict_strtoul() is obsolete. Thus, kstrtoul() should be
used.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/scsi/pmcraid.c|6 --
drivers/scsi/scsi_sysfs.c |6 --
2 files changed, 8 insertions(+), 4 deletions
The usage of strict_strtoul() and strict_strtoull() is not preferred,
because strict_strtoul() and strict_strtoull() are obsolete. Thus,
kstrtoul() and kstrtoull() should be used.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/target/iscsi/iscsi_target_configfs.c |8
Use the wrapper function for retrieving the platform data instead of
accessing dev-platform_data directly.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/scsi/sgiwd93.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/sgiwd93.c b/drivers/scsi
it be static?
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/scsi/scsi_sysfs.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
index 7e50061..043150e 100644
--- a/drivers/scsi/scsi_sysfs.c
+++ b/drivers/scsi
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/scsi/scsi_tgt_lib.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/scsi_tgt_lib.c b/drivers/scsi/scsi_tgt_lib.c
index 84a1fdf..bd82ea6 100644
--- a/drivers/scsi/scsi_tgt_lib.c
+++ b/drivers/scsi
)
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/scsi/dc395x.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c
index e73445b..3b09c16 100644
--- a/drivers/scsi/dc395x.c
+++ b/drivers/scsi/dc395x.c
@@ -1526,7
:got void *noident
drivers/scsi/megaraid.c:4653:26: warning: incorrect type in argument 1
(different address spaces)
drivers/scsi/megaraid.c:4653:26:expected void volatile [noderef]
asn:2*addr
drivers/scsi/megaraid.c:4653:26:got void *noident
Signed-off-by: Jingoo Han jg1@samsung.com
'initio_bus_device_reset' was not
declared. Should it be static?
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/scsi/initio.c | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/drivers/scsi/initio.c b/drivers/scsi/initio.c
index 1befc26..527b247 100644
:expected void *reg
drivers/scsi/3w-sas.c:1328:55:got unsigned char [noderef] asn:2*
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/scsi/3w-sas.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/3w-sas.c b/drivers/scsi/3w-sas.c
index c845bdb..0d9c722
it be static?
drivers/scsi/osst.c:5766:1: warning: symbol 'dev_attr_file_count' was not
declared. Should it be static?
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/scsi/osst.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/osst.c b
Bit masking should happen before casting (u16), thus parentheses
are necessary in order to fix the following sparse warning:
drivers/scsi/aic94xx/aic94xx_seq.c:748:35: warning: cast truncates bits from
constant value (93ef7f becomes ef7f)
Signed-off-by: Jingoo Han jg1@samsung.com
On Wednesday, August 07, 2013 3:50 PM, Oliver Neukum wrote:
On Wed, 2013-08-07 at 12:55 +0900, Jingoo Han wrote:
@@ -4183,15 +4183,17 @@ static void check_eeprom(struct NvRamType *eeprom,
unsigned long io_port)
*/
dprintkl(KERN_WARNING
On Wednesday, August 07, 2013 3:50 PM, Oliver Neukum wrote:
On Wed, 2013-08-07 at 12:55 +0900, Jingoo Han wrote:
@@ -4183,15 +4183,17 @@ static void check_eeprom(struct NvRamType *eeprom,
unsigned long io_port)
*/
dprintkl(KERN_WARNING
-Original Message-
From: Julian Calaby [mailto:julian.cal...@gmail.com]
Sent: Wednesday, August 07, 2013 5:21 PM
To: Jingoo Han
Cc: Oliver Neukum; James Bottomley; Ali Akcaagac; Jamie Lenehan;
dc3...@twibble.org; James Bottomley;
linux-scsi
Subject: Re: [PATCH 3/8] [SCSI] dc395x
On Wed, Wednesday, August 07, 2013 5:40 PM, Julian Calaby wrote:
On Wed, Aug 7, 2013 at 6:36 PM, Jingoo Han jg1@samsung.com wrote:
On Wednesday, August 07, 2013 5:21 PM, Julian Calaby wrote:
On Wed, Aug 7, 2013 at 5:45 PM, Jingoo Han jg1@samsung.com wrote:
On Wednesday, August 07
it be static?
Signed-off-by: Jingoo Han jg1@samsung.com
---
No changes since v1:
drivers/scsi/scsi_sysfs.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
index 7e50061..043150e 100644
--- a/drivers/scsi/scsi_sysfs.c
Signed-off-by: Jingoo Han jg1@samsung.com
---
No changes since v1:
drivers/scsi/scsi_tgt_lib.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/scsi_tgt_lib.c b/drivers/scsi/scsi_tgt_lib.c
index 84a1fdf..bd82ea6 100644
--- a/drivers/scsi/scsi_tgt_lib.c
:got void *noident
drivers/scsi/megaraid.c:4653:26: warning: incorrect type in argument 1
(different address spaces)
drivers/scsi/megaraid.c:4653:26:expected void volatile [noderef]
asn:2*addr
drivers/scsi/megaraid.c:4653:26:got void *noident
Signed-off-by: Jingoo Han jg1@samsung.com
'initio_bus_device_reset' was not
declared. Should it be static?
Signed-off-by: Jingoo Han jg1@samsung.com
---
No changes since v1:
drivers/scsi/initio.c | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/drivers/scsi/initio.c b/drivers/scsi/initio.c
index
:expected void *reg
drivers/scsi/3w-sas.c:1328:55:got unsigned char [noderef] asn:2*
Signed-off-by: Jingoo Han jg1@samsung.com
---
No changes since v1:
drivers/scsi/3w-sas.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/3w-sas.c b/drivers/scsi/3w-sas.c
it be static?
drivers/scsi/osst.c:5766:1: warning: symbol 'dev_attr_file_count' was not
declared. Should it be static?
Signed-off-by: Jingoo Han jg1@samsung.com
---
No changes since v1:
drivers/scsi/osst.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git
Bit masking should happen before casting (u16), thus parentheses
are necessary in order to fix the following sparse warning:
drivers/scsi/aic94xx/aic94xx_seq.c:748:35: warning: cast truncates bits from
constant value (93ef7f becomes ef7f)
Signed-off-by: Jingoo Han jg1@samsung.com
/mptsas.c:5327:1: warning: symbol 'mptsas_shutdown' was
not declared. Should it be static?
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/message/fusion/mptbase.c |2 +-
drivers/message/fusion/mptsas.c |6 +++---
drivers/message/fusion/mptspi.c |2 +-
3 files changed, 5
Since commit scsi: Fix error handling in SCSI_IOCTL_SEND_COMMAND,
the 'out' label is not used anymore. Thus, remove the unnecesary
label.
Cc: Jan Kara j...@suse.cz
Signed-off-by: Jingoo Han jg1@samsung.com
---
block/scsi_ioctl.c |1 -
1 file changed, 1 deletion(-)
diff --git a/block
This patch uses module_platform_driver_probe() macro which makes
the code smaller and simpler.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/scsi/a4000t.c | 15 +--
1 files changed, 1 insertions(+), 14 deletions(-)
diff --git a/drivers/scsi/a4000t.c b/drivers/scsi
This patch uses module_platform_driver_probe() macro which makes
the code smaller and simpler.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/scsi/a3000.c | 13 +
1 files changed, 1 insertions(+), 12 deletions(-)
diff --git a/drivers/scsi/a3000.c b/drivers/scsi/a3000.c
, unnecessary dev_set_drvdata() is removed, because the driver core
clears the driver data to NULL after device_release or on probe failure.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/scsi/jazz_esp.c |4 ++--
drivers/scsi/qlogicpti.c |4 ++--
drivers/scsi/sni_53c710.c |4
On Thursday, August 22, 2013 12:05 AM, Steffen Maier wrote:
From: Martin Peschke mpesc...@linux.vnet.ibm.com
strict_strtoul and friends are obsolete. Use kstrtoul functions
instead.
Signed-off-by: Martin Peschke mpesc...@linux.vnet.ibm.com
Cc: Jingoo Han jg1@samsung.com
Reviewed
Casting the return value which is a void pointer is redundant.
The conversion from void pointer to any other pointer type is
guaranteed by the C programming language.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/scsi/osst.c | 12 ++--
1 file changed, 6 insertions(+), 6
Casting the return value which is a void pointer is redundant.
The conversion from void pointer to any other pointer type is
guaranteed by the C programming language.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/scsi/ufs/ufshcd-pci.c |2 +-
1 file changed, 1 insertion(+), 1
Casting the return value which is a void pointer is redundant.
The conversion from void pointer to any other pointer type is
guaranteed by the C programming language.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/scsi/be2iscsi/be_main.c |2 +-
1 file changed, 1 insertion(+), 1
Since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound),
the driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
---
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/scsi/lpfc/lpfc_init.c |3 ---
1 file changed, 3 deletions(-)
diff --git
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/scsi/arcmsr/arcmsr_hba.c |1 -
1 file changed, 1 deletion(-)
diff --git
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/scsi/atp870u.c |2 --
1 file changed, 2 deletions(-)
diff --git
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/scsi/bfa/bfad.c |1 -
1 file changed, 1 deletion(-)
diff --git
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/scsi/csiostor/csio_init.c |2 --
1 file changed, 2 deletions(-)
diff
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/scsi/gdth.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/scsi/fnic/fnic_main.c |1 -
1 file changed, 1 deletion(-)
diff --git
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/scsi/hpsa.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/scsi/megaraid/megaraid_mbox.c |6 --
drivers/scsi/megaraid
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/scsi/mvumi.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/scsi/mvsas/mv_init.c |1 -
1 file changed, 1 deletion(-)
diff --git
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/scsi/pm8001/pm8001_init.c |1 -
1 file changed, 1 deletion(-)
diff
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/scsi/pmcraid.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/scsi/qla2xxx/qla_os.c |1 -
1 file changed, 1 deletion(-)
diff --git
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/scsi/qla4xxx/ql4_os.c |1 -
1 file changed, 1 deletion(-)
diff --git
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/scsi/stex.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/scsi/ufs/ufshcd-pci.c |1 -
1 file changed, 1 deletion(-)
diff --git
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/scsi/dc395x.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/scsi/tmscsim.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers
-by: Jingoo Han jg1@samsung.com
Cc: James Bottomley jbottom...@parallels.com
---
drivers/scsi/arcmsr/arcmsr_hba.c |1 -
drivers/scsi/atp870u.c|2 --
drivers/scsi/bfa/bfad.c |1 -
drivers/scsi/csiostor/csio_init.c |2 --
drivers/scsi
On Tuesday, September 24, 2013 3:55 AM, James Bottomley wrote:
On Mon, 2013-09-23 at 09:54 +0900, Jingoo Han wrote:
Since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound),
the driver core clears the driver data to NULL after
Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro
is not preferred.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/scsi/BusLogic.c |2 +-
drivers/scsi/be2iscsi/be_main.c |2 +-
drivers/scsi/csiostor/csio_init.c|2 +-
drivers/scsi/isci/init.c
60 matches
Mail list logo
