Re: [PATCH] [SCSI] sd: fix crash when UA received on DIF enabled device

2012-11-06 Thread Martin K. Petersen
ATTENTION. This change moves the Ewan code to free the larger CDB into sd_unprep_fn instead, which is Ewan invoked after the request is complete. The 32-byte CDB support predates unprep. This fix is obviously the correct approach. Acked-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K

Re: [PATCH 3/3] target/iblock: Add WRITE_SAME w/ UNMAP=0 emulation support

2012-11-15 Thread Martin K. Petersen
from? At Doug least somebody who cares when they see that comment might contact Doug Martin Petersen and ask why he chose that value. And the answer is that WRITE SAME(10) takes a two-byte block count. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send

Re: [PATCH] firewire: sbp2: allow WRITE SAME and REPORT SUPPORTED OPERATION CODES

2012-11-26 Thread Martin K. Petersen
of them? Stefan Hence let's remove the no_report_opcodes and no_write_same Stefan blacklist flags so that these commands can be used on Stefan respectively capable targets. I just erred on the side of caution. If you are happy without belt and suspenders that's perfectly ok with me :) -- Martin K

Re: [PATCH 0/2] Change type-2 dif to use rq embedded 32 byte cdb

2012-11-26 Thread Martin K. Petersen
is a really rare corner case. So while I agree we should handle the UA scenario correctly, I'm not sure I agree with the fix. Why are you messing with Type 2 devices in the first place? These should really only be used inside disk arrays. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 0/2] Change type-2 dif to use rq embedded 32 byte cdb

2012-12-19 Thread Martin K. Petersen
that we need. Also shouldn't be a problem. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

LSF/MM Summit CFP

2013-01-17 Thread Martin K. Petersen
, please also send that to: lsf...@lists.linux-foundation.org Thank you on behalf of the program committee: Storage: Martin K. Petersen Jens Axboe James Bottomley Filesystems: Ric Wheeler Christoph Hellwig Jaegeuk Kim Jeffrey Layton

Re: [LSF/MM TOPIC][ATTEND] protection information and userspace

2013-02-07 Thread Martin K. Petersen
or the HBA hardware do the remapping. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [LSF/MM TOPIC][ATTEND] protection information and userspace

2013-02-07 Thread Martin K. Petersen
a few IOCB fields than it is to rewrite how an application does I/O. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [LSF/MM TOPIC][ATTEND] protection information and userspace

2013-02-07 Thread Martin K. Petersen
is really only good for disk drives. Most array vendors use it internally. And going forward we're going to use it for access control instead of opaque storage. So exposing the application tag space to userland applications is of very limited use at this point. -- Martin K. Petersen Oracle Linux

Re: [SCSI] sd: Ensure we correctly disable devices with unknown protection type

2013-02-07 Thread Martin K. Petersen
Dan == Dan Carpenter dan.carpen...@oracle.com writes: Dan This patch wasn't applied. Nope, but it hasn't been forgotten. I have it in my resubmit queue with a couple of other stable fixes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line

Re: [LSF/MM TOPIC][ATTEND] protection information and userspace

2013-02-07 Thread Martin K. Petersen
Darrick == Darrick J Wong darrick.w...@oracle.com writes: Darrick Is there a newer one than this? Darrick https://oss.oracle.com/projects/oracleasm/files/sources/ UEK2 git. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux

Re: Incorrect LBA Returned from scsi_get_lba() and blk_rq_pos() (Possible DIF Impact)

2013-02-12 Thread Martin K. Petersen
patches in the pipeline that fixes this. They also add support for protection intervals different from the logical block size. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org

Re: [PATCH] scsi: fix the build warning

2013-08-21 Thread Martin K. Petersen
reorganization of this code in question fixed the warning. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 2/4] scsi_debug: fix logical block provisioning support when unmap_alignment != 0

2013-08-21 Thread Martin K. Petersen
Doug == Douglas Gilbert dgilb...@interlog.com writes: Doug This is Martin's area of expertise so I hope he also acks it. Doug Acked-by: Douglas Gilbert dgilb...@interlog.com I believe I already did, but: Acked-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen

Re: [PATCH 0/9] target: Add support for EXTENDED_COPY (VAAI) offload emulation

2013-08-23 Thread Martin K. Petersen
, just 100 times worse :( Anyway. Excited to see nab posting the patches! My copy offload code from the spring has been getting stale both in the T10 and the kernel sense. But at least we know what I'll be working on next week :) -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe

Re: State of big-endian for MegaRAID SAS driver

2013-08-26 Thread Martin K. Petersen
in function Sumit megasas_init_fw()(inside file: megaraid_sas_base.c), Patches welcome! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: State of big-endian for MegaRAID SAS driver

2013-08-26 Thread Martin K. Petersen
of the driver... -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: SCSI's heuristics for enabling WRITE SAME still need work [was: dm mpath: disable WRITE SAME if it fails]

2013-09-20 Thread Martin K. Petersen
to trigger a restacking of the queue limits I think it's inevitable. We see more and more devices that change properties after a firmware upgrade. I think we'll just have to bite the bullet and work on that... -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send

Re: [PATCH 1/5] scsi_debug: fix buffer overrun when DIF/DIX is enabled and virtual_gb 0

2013-09-20 Thread Martin K. Petersen
-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/5] scsi_debug: factor out copying PI from dif_storep to prot_sglist

2013-09-20 Thread Martin K. Petersen
to prot_sglist. Akinobu This factors out the portion of copying protection info into a Akinobu separate function. It will also be reused in the next change Akinobu after supporting the opposite direction (copying prot_sglist to Akinobu dif_storep). Acked-by: Martin K. Petersen martin.peter

Re: [PATCH 4/5] scsi_debug: fix invalid value check for guard module parameter

2013-09-20 Thread Martin K. Petersen
int' instead of adding extra check for a negative Akinobu value. Acked-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org

Re: [PATCH 5/5] scsi_debug: fix sparse warnings related to data integrity field

2013-09-20 Thread Martin K. Petersen
Akinobu == Akinobu Mita akinobu.m...@gmail.com writes: Akinobu Each member in data integrity field tuple is big-endian. But Akinobu the endianness of the values being compared with these members Akinobu are not annotated. So this fixes these sparse warnings. Acked-by: Martin K. Petersen

Re: [PATCH] sd: dif sector calculation

2013-09-20 Thread Martin K. Petersen
Keith == Keith Busch keith.bu...@intel.com writes: Keith The ref tag should be the device's physical LBA rather than the Keith 512 byte bio sector. The bip sector is just a seed value set by the application. It is not correct to scale it based on sector size or PI interval. -- Martin K

Re: [PATCH 3/5] scsi_debug: avoid partial copying PI from prot_sglist to dif_storep

2013-09-20 Thread Martin K. Petersen
. Akinobu Reusing dif_copy_prot() with supporting the opposite direction Akinobu simplifies this fix. Acked-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body

Re: [PATCH] scsi disk: Use its own buffer for the vpd request

2013-09-20 Thread Martin K. Petersen
Seagate drive. However, skip_vpd_pages is also set by USB. I'm still completely in favor of your patch to reduce the VPD buffer size. Please resubmit and feel free to add my Acked-by:. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe

Re: SCSI's heuristics for enabling WRITE SAME still need work [was: dm mpath: disable WRITE SAME if it fails]

2013-09-24 Thread Martin K. Petersen
the matching at discovery time instead of once a WRITE SAME is issued. This would also permit HBA drivers to toggle the feature on a per instance basis. I.e. if RAID controller firmware rev is lower than XYZ, do not support WRITE SAME. I'll do a PoC later today... -- Martin K. Petersen Oracle Linux

Re: SCSI's heuristics for enabling WRITE SAME still need work [was: dm mpath: disable WRITE SAME if it fails]

2013-09-25 Thread Martin K. Petersen
that can't be handled. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: SCSI's heuristics for enabling WRITE SAME still need work [was: dm mpath: disable WRITE SAME if it fails]

2013-09-26 Thread Martin K. Petersen
there's an off-by-one bug in the UNMAP translation. Sumit, is this something you guys can look into? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH RESEND] sd: disk offlined prematurely from media access timeout

2013-10-23 Thread Martin K. Petersen
. David The resetting of sdkp-medium_access_timed_out should occur David before the check for sense data. David Signed-off-by: David Jeffery djeff...@redhat.com Acked-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from

Re: BLKDISCARD and AIO

2013-10-23 Thread Martin K. Petersen
? Not at this time, no. However, you can fork a child process to execute the ioctl and wait for that to complete. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 1/3] scsi: Fix erratic device offline during EH

2013-10-23 Thread Martin K. Petersen
that such a device doesn't exist, of course, but the patch was originally done to handle the irreparably broken error case. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More

[PATCH] SCSI: Disable WRITE SAME for RAID and virtual host adapter drivers

2013-10-23 Thread Martin K. Petersen
-by: Martin K. Petersen martin.peter...@oracle.com --- I was torn between using the existing emulated flag or introducing a new one. I ended up doing the latter but I'm also OK with setting emulated for drivers that don't already and keying off of that. Comments welcome... diff --git a/drivers/ata

Re: [PATCH] SCSI: Disable WRITE SAME for RAID and virtual host adapter drivers

2013-10-23 Thread Martin K. Petersen
TRIM support in Christoph libata entirely. The flag effectively disables advertising REQ_WRITE_SAME support to the block layer (max_write_same_sectors). It doesn't prevent anyone from issuing write same commands in general. Such as the sd discard prep_fn and users of sg/bsg. -- Martin K. Petersen

Re: [PATCH 1/2] target: Pass through I/O topology for block backstores

2013-11-11 Thread Martin K. Petersen
. Looks good to me, Andy. Acked-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: 3.12.0: sda2: WRITE SAME failed. Manually zeroing. with 3w-xxxx driver

2013-11-28 Thread Martin K. Petersen
/?l=linux-scsim=138252394614920w=2 -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: 3.12.0: sda2: WRITE SAME failed. Manually zeroing. with 3w-xxxx driver

2013-11-28 Thread Martin K. Petersen
, thank you! This patch is over a month old, do you know Justin if is currently in mainline? Nope. - James? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo

Re: 3.12.0: sda2: WRITE SAME failed. Manually zeroing. with 3w-xxxx driver

2013-12-05 Thread Martin K. Petersen
. James has it queued in scsi/fixes. It'll make it to Linus on the next pull and it has been tagged for inclusion in stable. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org

Re: [PATCH v3.13-rc3] firewire: sbp2: bring back WRITE SAME support

2013-12-17 Thread Martin K. Petersen
of complaints about WRITE SAME failed. Manually zeroing. But I guess I can only blame myself for not making it clear that that's a warning and not an error... -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message

Re: status of block-integrity

2013-12-23 Thread Martin K. Petersen
that needs to be done in this area I'll be happy to do so... -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: status of block-integrity

2014-01-03 Thread Martin K. Petersen
passthrough interface? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: bio_integrity_verify() bug causing READ verify to be silently skipped

2014-01-03 Thread Martin K. Petersen
the current bio-bi_idx value after bio_advance(). That breaks partial completion, though. I'll take a look at Kent's changes... -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord

Re: Bug#733565: SIX messages per on boot console should be TWO

2014-01-03 Thread Martin K. Petersen
enough to deserve logging at ERR severity? I guess we could extend the first_scan logic to cover the error case scenarios. But it is quite unusual for a device to not implement the caching mode page... -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line

Re: Bug#733565: SIX messages per on boot console should be TWO

2014-01-03 Thread Martin K. Petersen
Martin == Martin K Petersen martin.peter...@oracle.com writes: Martin I guess we could extend the first_scan logic to cover the error Martin case scenarios. [SCSI] sd: Quiesce mode sense error messages Messages about discovered disk properties are only printed once unless they are found

mptNsas MSI-X fixes

2014-01-03 Thread Martin K. Petersen
++ 2 files changed, 44 insertions(+), 93 deletions(-) -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More

[PATCH 1/2] [SCSI] mpt2sas: Rework the MSI-X grouping code

2014-01-03 Thread Martin K. Petersen
From: Martin K. Petersen martin.peter...@oracle.com On systems with a non power-of-two CPU count the existing MSI-X grouping code failed to distribute interrupts correctly. Rework the code to handle arbitrary processor counts. Also remove the hardcoded upper limit on the number of processors so

[PATCH 2/2] [SCSI] mpt3sas: Rework the MSI-X grouping code

2014-01-03 Thread Martin K. Petersen
From: Martin K. Petersen martin.peter...@oracle.com On systems with a non power-of-two CPU count the existing MSI-X grouping code failed to distribute interrupts correctly. Rework the code to handle arbitrary processor counts. Also remove the hardcoded upper limit on the number of processors so

Re: status of block-integrity

2014-01-08 Thread Martin K. Petersen
K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: iSCSI request keep rejected by microsoft iSCSI target because of write_same check

2014-01-09 Thread Martin K. Petersen
handling in the iscsi layer for it. I Mike can make a patch if you have not already. It would be awfully nice to get it turned into an ILLEGAL REQUEST/0x20/0x0. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body

Re: status of block-integrity

2014-01-09 Thread Martin K. Petersen
that. Doesn't in any way preclude LID4 being supported as well. Hannes As said, Doug and me are working on putting this into sg3_utils, Hannes then we'll have a better idea on the actual workings. Cool! That'll save me some headaches when we start seeing LID4 devices. -- Martin K. Petersen Oracle Linux

Re: [PATCH 00/14] target: Initial support for DIF Type1+Type3 emulation

2014-01-09 Thread Martin K. Petersen
with this? I'll start reviewing the pieces tomorrow. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 03/14] target/sbc: Add sbc_check_prot + update sbc_parse_cdb for DIF

2014-01-10 Thread Martin K. Petersen
own tree. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 05/14] target/spc: Add protection bit to standard INQUIRY output

2014-01-10 Thread Martin K. Petersen
OK. It doesn't make much sense to create a PI LUN and then not have PI enabled. Reviewed-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord

Re: [PATCH 06/14] target/spc: Add protection related bits to INQUIRY EVPD=0x86

2014-01-10 Thread Martin K. Petersen
nab == Nicholas A Bellinger n...@daterainc.com writes: nab This patch updates spc_emulate_evpd_86() (extended INQUIRY) to nab report GRD_CHK (Guard Check) and REF_CHK (Reference Check) bits nab when DIF emulation is enabled by the backend device. Reviewed-by: Martin K. Petersen martin.peter

Re: [PATCH 07/14] target/sbc: Add P_TYPE + PROT_EN bits to READ_CAPACITY_16

2014-01-10 Thread Martin K. Petersen
nab == Nicholas A Bellinger n...@daterainc.com writes: nab This patch updates sbc_emulate_readcapacity_16() to set P_TYPE and nab PROT_EN bits when DIF emulation is enabled by the backend device. Reviewed-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle

Re: [PATCH 07/14] target/sbc: Add P_TYPE + PROT_EN bits to READ_CAPACITY_16

2014-01-10 Thread Martin K. Petersen
using the array management interface. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 07/14] target/sbc: Add P_TYPE + PROT_EN bits to READ_CAPACITY_16

2014-01-10 Thread Martin K. Petersen
are following what scsi_debug is nab currently exposing minus FORMAT_UNIT support..? PROT_EN and P_TYPE should be fine for now. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org

Re: [PATCH 07/14] target/sbc: Add P_TYPE + PROT_EN bits to READ_CAPACITY_16

2014-01-10 Thread Martin K. Petersen
Andy -- requiring offset calculations, non-aligned read-modify-write, Andy and all that unpleasantness to be handled? I only think interleaved makes sense if you're passing the PI through instead of emulating. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list

Re: [PATCH 08/14] target/spc: Expose ATO bit in control mode page

2014-01-10 Thread Martin K. Petersen
nab == Nicholas A Bellinger n...@daterainc.com writes: nab This patch updates spc_modesense_control() to set the Application nab Tag Owner (ATO) bit when when DIF emulation is enabled by the nab backend device. Reviewed-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen

Re: [PATCH 09/14] target/configfs: Expose protection device attributes

2014-01-10 Thread Martin K. Petersen
-accelerated T10 CRC I don't think it's a big deal. (scsi_debug supports IP checksum because it's both initiator and target). -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord

Re: [PATCH 13/14] target/rd: Add DIF protection into rd_execute_rw

2014-01-10 Thread Martin K. Petersen
should turn off Sagi the backstore DIF verify emulation to sustain performance. Yeah, for SAS and FC it would be nice to leverage DIX and let the ASIC do the actual checking and splitting. I assume the same is true for your hw. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 14/14] tcm_loop: Enable DIF/DIX modes in SCSI host LLD

2014-01-10 Thread Martin K. Petersen
. And ideally you'd have a way to choose between IP and T10 CRC for the guard type. Otherwise OK. Reviewed-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body

Re: [PATCH 3/6] scsi_debug: fix duplicate dif_errors increment

2014-01-10 Thread Martin K. Petersen
: reduce duplication between prot_verify_read and Akinobu prot_verify_write) Acked-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord

Re: [PATCH 1/6] scsi_debug: fix false positive logical block reference tag check fail

2014-01-10 Thread Martin K. Petersen
unwritten sector is skipped. Acked-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 07/14] target/sbc: Add P_TYPE + PROT_EN bits to READ_CAPACITY_16

2014-01-12 Thread Martin K. Petersen
target and initiator from performing PI-verification when that block is read. If a block is subsequently written and no PI is sent from the host (WRPROTECT=0), the target must generate valid PI for each block. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list

Re: [PATCH 09/14] target/configfs: Expose protection device attributes

2014-01-12 Thread Martin K. Petersen
read. But it makes no sense to do that given that you will have to do the T10 CRC calculation regardless. Even if the backing store is DIX-capable and supports the IP checksum. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi

Re: [PATCH 07/14] target/sbc: Add P_TYPE + PROT_EN bits to READ_CAPACITY_16

2014-01-12 Thread Martin K. Petersen
the blocks are unwritten or not. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 14/14] tcm_loop: Enable DIF/DIX modes in SCSI host LLD

2014-01-13 Thread Martin K. Petersen
nab == Nicholas A Bellinger n...@linux-iscsi.org writes: nab Sure, this can be exposed at a tcm_loop configfs attribute that is nab accessible after scsi_add_host() has been called, which I assume is nab OK to do.. As long as it's set before we discover devices. -- Martin K. Petersen

Re: [PATCH 09/14] target/configfs: Expose protection device attributes

2014-01-13 Thread Martin K. Petersen
). So we revived our original Type 4 proposal which is 16 bytes of protection information per interval (CRC32C, 48-bit LBA and 6 bytes of app tag). The proposal has been sitting around for a while waiting for SBC-4 to open. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from

Re: [PATCH 09/14] target/configfs: Expose protection device attributes

2014-01-13 Thread Martin K. Petersen
of the T10 spec that doesn't mandate block sizes or accompanying PI types). -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 00/14] target: Initial support for DIF Type1+Type3 emulation

2014-01-15 Thread Martin K. Petersen
() of protection information in nab the bio_endio READ completion path. Only if the submit_bio() caller hasn't attached protection information already. If you submit a bio with a bip already attached the block layer will not generate/verify. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 00/14] target: Initial support for DIF Type1+Type3 emulation

2014-01-15 Thread Martin K. Petersen
the protection type nab by looking at struct blk_integrity, but it would be helpful to make nab this explicit with bi-prot_type. You need to match on the integrity profile string. T10-DIF-TYPE1-IP means it's DIF Type 1 format with IP checksum. -- Martin K. Petersen Oracle Linux Engineering

Re: bio_integrity_verify() bug causing READ verify to be silently skipped

2014-01-17 Thread Martin K. Petersen
. The latter requires a bit of massaging that interferes with other pending changes. Given that your patch does address a valid issue I'm OK with Jens putting it in as is. I'll build upon it for my changes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send

Re: [PATCH-v2 11/17] target/iblock: Add blk_integrity + BIP passthrough support

2014-01-21 Thread Martin K. Petersen
of an HBA-enforced global). -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH-v2 11/17] target/iblock: Add blk_integrity + BIP passthrough support

2014-01-21 Thread Martin K. Petersen
nab prototyping, and is not supported by any real backend storage nab hardware. We are shipping several products with support for the IP checksum. But it's between application and initiator only. From there on it's all T10 CRC as required by the spec. -- Martin K. Petersen Oracle Linux

Re: [Lsf-pc] [LSF/MM TOPIC] really large storage sectors - going beyond 4096 bytes

2014-01-22 Thread Martin K. Petersen
that this is something we'll need to address sooner rather than later. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [Lsf-pc] [LSF/MM TOPIC] really large storage sectors - going beyond 4096 bytes

2014-01-22 Thread Martin K. Petersen
for enterprise drives. The vendors appear to be divided between 4Kn and 512e with RMW mitigation. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH] bio_integrity_add_page: check for BIO_POOL_NONE before determining nr_vecs on slab

2014-02-03 Thread Martin K. Petersen
. Ensure that we check against BIP_INLINE_VECS in that case. Reported-by: David Milburn dmilb...@redhat.com Signed-off-by: Martin K. Petersen martin.peter...@oracle.com diff --git a/fs/bio-integrity.c b/fs/bio-integrity.c index fc60b31453ee..6dea2b90b4d5 100644 --- a/fs/bio-integrity.c +++ b/fs

Re: [PATCH v2 0/7] scsi_debug: several bug fixes and enable clustering support

2014-02-03 Thread Martin K. Petersen
Doug == Douglas Gilbert dgilb...@interlog.com writes: Doug The parts of this patch that I understand look fine. Perhaps Doug Martin should ack it, if he sees fit. Just had another look at the updated pieces. Patch series looks good to me. Reviewed-by: Martin K. Petersen martin.peter

Re: [PATCH] st: Do not rewind for SG_IO

2014-02-06 Thread Martin K. Petersen
to /sbin/scsi_id. I'll take a look at your patch later today... -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH] st: Do not rewind for SG_IO

2014-02-06 Thread Martin K. Petersen
that in udev rules I guess that's OK with me. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: LSI SAS2008 SATA TRIM not working

2014-02-07 Thread Martin K. Petersen
# sg_vpd -p lbpv /dev/sdc -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Dynamic scsi_debug module

2014-02-07 Thread Martin K. Petersen
losetup, rather than using module Phillip parameters. The question is how much sense it makes to invest in scsi_debug now that we have the LIO target in the kernel? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body

Re: LSI SAS2008 SATA TRIM not working

2014-02-07 Thread Martin K. Petersen
. Kurtprovisioning: lbpme=0, lbprz=0 Last logical block ^^^ This indicates the SAT on the mpt2sas board didn't enable discard support for the drive. Please provide the full output of hdparm -I. Maybe we can get some clues as to why that is... -- Martin K. Petersen

Re: LSI SAS2008 SATA TRIM not working

2014-02-07 Thread Martin K. Petersen
whether to support logical block provisioning (in addition to support for the DSM TRIM command). -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: 3x check of Caching mode page

2014-02-14 Thread Martin K. Petersen
Toralf == Toralf Förster toralf.foers...@gmx.de writes: Toralf I'm just wondering why it happens 3 times in a row : http://marc.info/?l=linux-scsim=138879119205889 James: Ping on this patch. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line

Re: loading scsi_debug with data integrity hits BUG_ON

2014-02-20 Thread Martin K. Petersen
+ pickup..? Please remove total as suggested by Akinobu. Acked-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] st: use dev_printk() to avoid linebreaks in kernel messages.

2014-02-20 Thread Martin K. Petersen
branch Hannes scsi-logging.v3 I like the printk cleanups and the more sensible sense printing. But why perpetuate the crufty old SCSI logging stuff when we have SCSI tracing? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi

Re: [RFC 0/6] vhost/scsi: Add T10 PI SGL passthrough support

2014-02-25 Thread Martin K. Petersen
with a GUARD or REFERENCE TAG nab failure. nab MKP..? Yeah, that should be OK. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 3/5] Add EVPD page 0x83 to sysfs

2014-03-12 Thread Martin K. Petersen
page query for every command (~32 megs of data)? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 02/11][SCSI]mpt2sas: Added new driver module Parameter disable_eedp to Disable EEDP Support

2014-03-14 Thread Martin K. Petersen
. Why don't you just set the prot_mask module parameter to 0? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 08/11][SCSI]mpt2sas: Added Reply Descriptor Post Queue (RDPQ) Array support

2014-03-14 Thread Martin K. Petersen
contiguous block of memory pool. Please also consider these patches that fix MSI-X issues on large systems: http://marc.info/?l=linux-scsim=138879464506586 http://marc.info/?l=linux-scsim=138879465206588 -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send

Re: [PATCH 1/4] target/core: T10-Dif: check HW support capabilities

2014-04-01 Thread Martin K. Petersen
protection scheme internally. And then synthesize PI on the host-facing side. Some even do T10 PI to an internal protection scheme and then back to T10 PI when talking to the disk drives in the back end. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send

[PATCH] block: Ensure we only enable integrity metadata for reads and writes

2014-04-08 Thread Martin K. Petersen
From: Martin K. Petersen martin.peter...@oracle.com We'd occasionally attempt to generate protection information for flushes and other requests with a zero payload. Make sure we only attempt to enable integrity for reads and writes. Signed-off-by: Martin K. Petersen martin.peter...@oracle.com

Re: [PATCH 2/2] block: Fix integrity verification

2014-04-08 Thread Martin K. Petersen
Martin == Martin K Petersen martin.peter...@oracle.com writes: Martin Commit bf36f9cfa6d3d caused a regression by effectively Martin reverting Nic's fix from 5837c80e870b that ensures we traverse Martin the full bio_vec list upon completion. Btw. I have a much better fix for this in the next

[PATCH] scsi: Make sure cmd_flags are 64-bit

2014-04-09 Thread Martin K. Petersen
From: Martin K. Petersen martin.peter...@oracle.com cmd_flags in struct request is now 64 bits wide but the scsi_execute functions truncated arguments passed to int leading to errors. Make sure the flags parameters are u64. Signed-off-by: Martin K. Petersen martin.peter...@oracle.com Cc: Jens

Re: [PATCH] sd: medium access timeout counter fails to reset

2014-04-17 Thread Martin K. Petersen
objections. FWIW, the reason my patch didn't handle the recovery scenario is that the devices I originally wrote it for never came back (irreversibly stuck head assembly or dead FTL). -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi

Re: LSI SAS - SSDs with DRAT and DZAT

2014-04-17 Thread Martin K. Petersen
Bernd == Bernd Schubert bernd.schub...@itwm.fraunhofer.de writes: Bernd Any other suggestions for ~240GB SSDs supporting DRAT and DZAT or Bernd trim-on-lsi-sas in general? intel drives (other than the 510 which was a one-off) are generally very well-behaved. -- Martin K. Petersen Oracle

Re: [target:for-next 20/20] drivers/scsi/virtio_scsi.c:531:48: error: dereferencing pointer to incomplete type

2014-05-26 Thread Martin K. Petersen
not entirely sure it worth the hassle to do the same for target and virtio. The memory savings aren't that big to begin with. And besides, the bip pointer field in struct bio is about to become generic with my impending copy offload patches anyway, -- Martin K. Petersen Oracle Linux Engineering

Data integrity update

2014-05-28 Thread Martin K. Petersen
|7 lib/Makefile |2 lib/t10-pi.c | 164 23 files changed, 627 insertions(+), 644 deletions(-) -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line

[PATCH 01/14] block: Get rid of bdev_integrity_enabled()

2014-05-28 Thread Martin K. Petersen
bdev_integrity_enabled() is only used by bio_integrity_enabled(). Combine these two functions. Signed-off-by: Martin K. Petersen martin.peter...@oracle.com --- Documentation/block/data-integrity.txt | 10 - block/bio-integrity.c | 39

<    1   2   3   4   5   6   7   8   9   10   >