[PATCH v3 06/32] cxlflash: Fix to avoid sizeof(bool)

Using sizeof(bool) is considered poor form for various reasons and sparse warns us of that. Correct by changing type from bool to u8. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> Reviewed-by: Bri

Re: [PATCH v3 08/32] cxlflash: Fix to avoid CXL services during EEH

> On Sep 24, 2015, at 8:23 PM, Brian King <brk...@linux.vnet.ibm.com> wrote: > On 09/24/2015 02:38 PM, Matthew R. Ochs wrote: >> diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlflash/main.c >> index 3e3ccf1..6e85c77 100644 >> --- a/drivers/scsi/cxlflas

Re: [PATCH v3 31/32] cxlflash: Fix to avoid corrupting adapter fops

> On Sep 25, 2015, at 4:23 PM, Brian King <brk...@linux.vnet.ibm.com> wrote: > On 09/24/2015 02:44 PM, Matthew R. Ochs wrote: >> @@ -1293,8 +1291,8 @@ static int cxlflash_disk_attach(struct scsi_device >> *sdev, >> >> int fd = -1; >&g

[PATCH v4 00/32] cxlflash: Miscellaneous bug fixes and corrections

rporate comments from Ian Munsie - Rework commit messages to be more descriptive - Add state change serialization patch Manoj Kumar (4): cxlflash: Fix to avoid invalid port_sel value cxlflash: Replace magic numbers with literals cxlflash: Fix read capacity timeout cxlflash: Fix to double the

[PATCH v4 13/32] cxlflash: Fix to avoid stall while waiting on TMF

such that a bigger hammer reset can occur. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/common.h | 1 + drivers/scsi/cxlf

[PATCH v4 12/32] cxlflash: Fix to avoid spamming the kernel log

- pr_debug to pr_debug_ratelimited - pr_err to dev_err - pr_debug to dev_dbg Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> Conflicts: drivers/sc

[PATCH v4 16/32] cxlflash: Fix async interrupt bypass logic

-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/cxlflash/mai

[PATCH v4 14/32] cxlflash: Fix location of setting resid

The resid is incorrectly set which can lead to unnecessary retry attempts by the stack. This is due to resid _always_ being set using a value returned from the adapter. Instead, the value should only be interpreted and set when in an underrun scenario. Signed-off-by: Matthew R. Ochs <

[PATCH v4 15/32] cxlflash: Fix host link up event handling

-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> Conflicts: drivers/scsi/cxlflash/common.h --- drivers/scsi/cxlflash/common.h | 1 + drivers/scsi/cxlf

[PATCH v4 18/32] cxlflash: Fix AFU version access/storage and add check

-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/common.h | 2 +- drivers/scsi/cxlflash/main.c| 18 -- drivers/scsi/cxlfl

[PATCH v4 11/32] cxlflash: Refine host/device attributes

Implement the following suggestions and add two new attributes to allow for debugging the port LUN table. - use scnprintf() instead of snprintf() - use DEVICE_ATTR_RO and DEVICE_ATTR_RW Suggested-by: Shane Seymour <shane.seym...@hp.com> Signed-off-by: Matthew R. Ochs <mro...@linux.vne

[PATCH v4 17/32] cxlflash: Remove dual port online dependency

R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/main.c | 23 --- 1 file changed, 8 insertions(+), 15 deletions(-) diff --git a/dri

[PATCH v4 19/32] cxlflash: Correct usage of scsi_host_put()

on remove to be the last cleanup action taken and introduce a call to scsi_host_put() in the one initialization error path that does not use remove to cleanup. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> Reviewed-by: Bri

[PATCH v4 23/32] cxlflash: Fix function prolog parameters and return codes

Several function prologs have incorrect parameter names and return code descriptions. This can lead to confusion when reviewing the source and creates inaccurate documentation. To remedy, update the function prologs to properly reflect parameter names and return codes. Signed-off-by: Matthew R

[PATCH v4 29/32] cxlflash: Fix to double the delay each time

From: Manoj Kumar <ma...@linux.vnet.ibm.com> The operator used to double the delay is incorrect and does not result in delay doubling. To fix, use a left shift instead of the XOR operator. Reported-by: Tomas Henzl <the...@redhat.com> Signed-off-by: Matthew R. Ochs <mro...@lin

[PATCH v4 30/32] cxlflash: Fix to avoid corrupting adapter fops

R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/common.h| 3 +-- drivers/scsi/cxlflash/main.c | 1 + drivers/scsi/cxlflash/superpipe.c | 11 +-- 3 files changed, 3 insertions(+), 12 deletions(-)

[PATCH v4 28/32] MAINTAINERS: Add cxlflash driver

Add stanza for cxlflash SCSI driver. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com&

[PATCH v4 31/32] cxlflash: Correct trace string

The trace following the failure of alloc_mem() incorrectly identifies which function failed. This can lead to misdiagnosing a failure. Fix the string to correctly indicate that alloc_mem() failed. Reported-by: Brian King <brk...@linux.vnet.ibm.com> Signed-off-by: Matthew R. Och

[PATCH v4 01/32] cxlflash: Fix to avoid invalid port_sel value

n from find_and_create_lun(), the value of port_sel will be set incorrectly to indicate a single port, though in this case it should have been set to both ports. To fix, use the global mutex to serialize the lookup of the WWID and the subsequent modification of port_sel. Signed-off-by: Matthew R. Och

[PATCH v4 27/32] cxlflash: Fix to prevent stale AFU RRQ

after each reset. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dri

[PATCH v4 25/32] cxlflash: Fix to prevent EEH recovery failure

mutex is reacquired and the context is made available again. The context can be safely moved to the error state if needed during the unavailable window as no other threads will hold its reference. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kum

[PATCH v4 26/32] cxlflash: Correct spelling, grammar, and alignment mistakes

and consistency. Remove extra lines and a few unneeded variables/statements. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/common.h|

[PATCH v4 21/32] cxlflash: Correct behavior in device reset handler following EEH

the TMF was not sent. To fix, the state is rechecked after coming out of the reset state. When the state is normal, a TMF will be sent out. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> Reviewed-by: Bri

[PATCH v4 20/32] cxlflash: Fix to prevent workq from accessing freed memory

() as there is not a need to process any scheduled work when shutting down. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/main.c | 2 +-

[PATCH v4 24/32] cxlflash: Fix MMIO and endianness errors

Sparse uncovered several errors with MMIO operations (accessing directly) and handling endianness. These can cause issues when running in different environments. Introduce __iomem and proper endianness tags/swaps where appropriate to make driver sparse clean. Signed-off-by: Matthew R. Ochs <

[PATCH v4 22/32] cxlflash: Remove unnecessary scsi_block_requests

The host reset handler is called with I/O already blocked, thus there is no need to explicitly block and unblock I/O in the handler. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> Reviewed-by: Bri

[PATCH v4 32/32] cxlflash: Fix to avoid potential deadlock on EEH

-by: Brian King <brk...@linux.vnet.ibm.com> Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/superpipe.c | 30 +- drivers/scsi/cxlflash/superpipe.h | 2 ++ dri

Re: [PATCH v3 28/32] cxlflash: Fix to avoid state change collision

> On Sep 25, 2015, at 4:10 PM, Brian King <brk...@linux.vnet.ibm.com> wrote: > On 09/24/2015 02:42 PM, Matthew R. Ochs wrote: >> diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlflash/main.c >> index ab11ee6..325ba31 100644 >> --- a/drivers/scsi/cxlflas

[PATCH v4 09/32] cxlflash: Correct naming of limbo state and waitq

Limbo is not an accurate representation of this state and is also not consistent with the terminology that other drivers use to represent this concept. Rename the state and and its associated waitq to 'reset'. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: M

[PATCH v4 10/32] cxlflash: Make functions static

*); struct afu_cmd *cxlflash_cmd_checkout(struct afu *); void cxlflash_cmd_checkin(struct afu_cmd *); void init_pcr(struct cxlflash_cfg *); int init_global(struct cxlflash_cfg *); Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vne

[PATCH v4 08/32] cxlflash: Fix to avoid CXL services during EEH

ioctls by wrapping the ioctl handler call in a read semaphore and then implementing a small routine that obtains the write semaphore, effectively creating a wait point for all currently executing ioctls. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kum

[PATCH v4 07/32] cxlflash: Fix context encode mask width

The context encode mask covers more than 32-bits, making it a long integer. This should be noted by appending the ULL width suffix to the mask. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> Reviewed-by: Bri

[PATCH v4 05/32] cxlflash: Fix data corruption when vLUN used over multiple cards

for that card needs to be programmed. The mode word would be setup by the first card, causing the LUN table for the second card to not be programmed. By unconditionally initializing the LUN table (not depending on the mode word), the problem is avoided. Signed-off-by: Matthew R. Ochs <

[PATCH v4 03/32] cxlflash: Fix read capacity timeout

e used in sd.c) and rework the timeout literal to a more appropriate description. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/superpipe.

[PATCH v4 02/32] cxlflash: Replace magic numbers with literals

From: Manoj Kumar <kuma...@us.ibm.com> Magic numbers are not meaningful and can create confusion. As a remedy, replace them with descriptive literals. Replace 512 with literal MAX_SECTOR_UNIT. Replace 5 with literal CMD_RETRIES. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.co

[PATCH v4 04/32] cxlflash: Fix potential oops following LUN removal

. This resolves a potential Oops in the release handler when a dealing with a LUN that has already been removed. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> --- dri

[PATCH v4 06/32] cxlflash: Fix to avoid sizeof(bool)

Using sizeof(bool) is considered poor form for various reasons and sparse warns us of that. Correct by changing type from bool to u8. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> Reviewed-by: Bri

Re: [PATCH v2 11/30] cxlflash: Make functions static

> On Sep 21, 2015, at 7:18 AM, Tomas Henzl <the...@redhat.com> wrote: > On 16.9.2015 23:28, Matthew R. Ochs wrote: >> >> + >> +write_rrin: >> +nretry = 0; >> +writeq_be(rrin, >host_map->ioarrin); >> +do { >> +r

Re: [PATCH v2 14/30] cxlflash: Fix to avoid stall while waiting on TMF

> On Sep 21, 2015, at 1:24 PM, Brian King <brk...@linux.vnet.ibm.com> wrote: > On 09/16/2015 04:30 PM, Matthew R. Ochs wrote: >> Borrowing the TMF waitq's spinlock causes a stall condition when >> waiting for the TMF to complete. To remedy, introduce our own spin >>

Re: [PATCH v2 29/30] cxlflash: Fix to avoid state change collision

> On Sep 21, 2015, at 7:44 AM, Tomas Henzl <the...@redhat.com> wrote: > On 16.9.2015 23:32, Matthew R. Ochs wrote: >> The adapter state machine is susceptible to missing and/or >> corrupting state updates at runtime. This can lead to a variety >> of unintended

Re: [PATCH v2 09/30] cxlflash: Fix to stop interrupt processing on remove

> On Sep 21, 2015, at 6:33 AM, Tomas Henzl <the...@redhat.com> wrote: > On 19.9.2015 01:26, Matthew R. Ochs wrote: >>> On Sep 18, 2015, at 6:59 AM, Tomas Henzl <the...@redhat.com> wrote: >>> On 17.9.2015 19:16, Matthew R. Ochs wrote: >>&g

Re: [PATCH v2 03/30] cxlflash: Fix read capacity timeout

> On Sep 21, 2015, at 6:36 AM, Tomas Henzl <the...@redhat.com> wrote: > On 16.9.2015 23:26, Matthew R. Ochs wrote: >> From: Manoj Kumar <kuma...@us.ibm.com> >> >> The timeout value for read capacity is too small. Certain devices >> may take longer to re

Re: [patch] cxlflash: a couple off by one bugs

> On Sep 22, 2015, at 7:32 AM, Dan Carpenter <dan.carpen...@oracle.com> wrote: > > The "> MAX_CONTEXT" should be ">= MAX_CONTEXT". Otherwise we go one > step beyond the end of the cfg->ctx_tbl[] array. Acked-by: Matthew R. Ochs <mro...@linu

Re: [PATCH v2 04/30] cxlflash: Fix potential oops following LUN removal

> On Sep 17, 2015, at 8:26 PM, Brian King <brk...@linux.vnet.ibm.com> wrote: > > On 09/16/2015 04:27 PM, Matthew R. Ochs wrote: >> >> lun_access = kzalloc(sizeof(*lun_access), GFP_KERNEL); >> if (unlikely(!lun_access)) { >> dev_err(

[PATCH v3 26/32] cxlflash: Correct spelling, grammar, and alignment mistakes

and consistency. Remove extra lines and a few unneeded variables/statements. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/common.h|

[PATCH v3 28/32] cxlflash: Fix to avoid state change collision

-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> Conflicts: drivers/scsi/cxlflash/main.c --- drivers/scsi/cxlflash/common.h| 1 + drivers/scsi/cxlflash/main.c | 48 ++- drivers/s

[PATCH v3 27/32] cxlflash: Fix to prevent stale AFU RRQ

after each reset. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dri

[PATCH RESEND] cxlflash: drop unlikely before IS_ERR_OR_NULL

From: Geliang Tang <geliangt...@163.com> IS_ERR_OR_NULL already contain an unlikely compiler flag. Drop it. Signed-off-by: Geliang Tang <geliangt...@163.com> Acked-by: Manoj Kumar <ma...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-

[PATCH RESEND] cxlflash: a couple off by one bugs

a...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> --- This patch was originally sent by Dan Carpenter in September 2015. I had based my large patch series that went into 4.4 off of it but this pat

Re: [PATCH 1/3] hpsa: fix path_info_show

Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] hpsa: change SAS transport devices to bus 0.

> On Dec 9, 2015, at 3:18 PM, Don Brace wrote: > > sas transport places devices on bus 0 but driver was setting > the bus to 3. > > Reviewed-by: Justin Lindley > Reviewed-by: Kevin Barnett > Reviewed-by: Scott Teel

Re: [PATCH 3/3] hpsa: add box and bay information for enclosure devices

> On Dec 9, 2015, at 3:18 PM, Don Brace wrote: No commit message? > > Reviewed-by: Justin Lindley > Reviewed-by: Kevin Barnett > Reviewed-by: Scott Teel > Signed-off-by: Don Brace

Re: [PATCH 16/17] lpfc: Use kzalloc instead of kmalloc

Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 3/6] cxlflash: Removed driver date print

Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/6] cxlflash: Fix to resolve cmd leak after host reset

Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 5/6] cxlflash: Resolve oops in wait_port_offline

Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 6/6] cxlflash: Enable device id for future IBM CXL adapter

Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/6] cxlflash: Fix to escalate LINK_RESET also on port 1

Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] ipr: fix out-of-bounds null overwrite

f(fname, 99, "%s", buf); Changing the 99 to sizeof(fname) as part of this change would also make for cleaner code in my opinion. Will leave it up to you if you'd like to do a v3. Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this li

Re: [PATCH 2/3] hpsa: change SAS transport devices to bus 0.

> On Dec 15, 2015, at 9:25 AM, Don Brace <brace77...@gmail.com> wrote: > > On 12/09/2015 05:21 PM, Matthew R. Ochs wrote: >>> On Dec 9, 2015, at 3:18 PM, Don Brace <don.br...@pmcs.com> wrote: >>> >>> sas transport places devices on bus 0 but driver

Re: [PATCH 3/3] hpsa: add box and bay information for enclosure devices

Hi Don, Did you see these comments I had from my review of this patch? -matt > On Dec 9, 2015, at 5:41 PM, Matthew R. Ochs <mro...@linux.vnet.ibm.com> wrote: > >> On Dec 9, 2015, at 3:18 PM, Don Brace <don.br...@pmcs.com> wrote: > > No commit message? You can d

Re: [PATCH v2 3/3] hpsa: add box and bay information for enclosure devices

Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/3] hpsa: fix path_info_show

don.br...@pmcs.com> FYI, I did review and stamp this one back on 12/9. Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] cxlflash: Fix to drain operations from previous reset

drain_ioctls() was static, it had to be moved up a bit to be before > cxlflash_eh_host_reset_handler(). > > Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/3] cxlflash: Shutdown notify support for CXL Flash cards

the card and returns. When the device > is removed in the PCI remove path, notification code will > wait for shutdown processing to complete. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe fr

Re: [PATCH 5/7] hpsa: check for a null phys_disk pointer in ioaccel2 path

Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/7] hpsa: correct abort tmf for hba devices

Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/7] hpsa: correct lun data caching bitmap definition

Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 6/7] hpsa: remove function definition for sanitize_inquiry_string

Thanks again for implementing this feedback! Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/7] hpsa: add SMR drive support

Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] imm: check parport_claim

Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] osd: remove deadcode

Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/7] hpsa: do not get enclosure info for external devices

Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 7/7] hpsa: update copyright information

Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] hpsa: update MAINTAINERS with new e-mail

Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] lpfc: Remove redundant code block in lpfc_scsi_cmd_iocb_cmpl

Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] sd: Optimal I/O size is in bytes, not sectors

Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] scsi: export function scsi_scan.c:sanitize_inquiry_string

ggestion when reviewing the same patch: https://www.marc.info/?l=linux-scsi=144613827316617=2 Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> > > Suggested-by: Hannes Reinecke <h...@suse.de> > Reviewed-by: Kevin Barnett <kevin.barn...@pmcs.com> > Reviewed-by: Justin Lindl

Re: [PATCH 2/2] cxlflash: Move to exponential back-off when cmd_room is not available

ad the least > overall cost. Cost as being defined as overall time spent waiting. > > The fix is to change the linear back-off to an exponential back-off. > This solution also takes care of the problem with the initial > delay (starts with 1 usec). > > Signed

Re: [PATCH 1/2] cxlflash: Fix regression issue with re-ordering patch

o keep the initialization process symmetric, separate the AFU interrupt > setup also to a distinct function: init_intr(). > > Fixes: 6ded8b3cbd9a ("cxlflash: Unmap problem state area before detaching > master context") > Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm

Re: [PATCH v6 19/20] cxlflash: Use new cxl_pci_read_adapter_vpd() API

This patch should have also been sent to the SCSI list (included now). Changes look fine. Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> > On Mar 4, 2016, at 5:26 AM, Frederic Barrat <fbar...@linux.vnet.ibm.com> > wrote: > > To read the adapter VPD, drivers

Re: [PATCH 1/7] cxlflash: Simplify PCI registration

the call the > pci_release_regions() from cxlflash_remove(). > > Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 5/7] cxlflash: Reorder user context initialization

ix this problem, cxl_start_work() is called before obtaining > the process element id. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-sc

Re: [PATCH 7/7] cxlflash: Increase cmd_per_lun for better throughput

. > > Increase the value of cmd_per_lun to 256 to improve > throughput. With this change a single adapter is able to > attain close to the maximum throughput (380kIOPS). > Also change the number of RRQ entries that can be queued. > > Signed-off-by: Manoj N. Kumar <ma...@linux.vne

Re: [PATCH 6/7] cxlflash: Fix to avoid unnecessary scan with internal LUNs

gt;max_channel is retained. This > causes an unnecessary scan over the second port/channel. > > This fix alters the host->max_channel to 0 (1 port), if internal > LUNs are configured and switches it back to 1 (2 ports) while > going back to external LUNs. > > Sign

Re: [PATCH 2/7] cxlflash: Unmap problem state area before detaching master context

> > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] cxlflash: Fix to resolve dead-lock during EEH recovery

Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] cxlflash: Verify problem state area is mapped before notifying shutdown

tdown notify support > for CXL Flash cards"). > > As a fix, shutdown notification should only occur when the AFU is mapped. > > Fixes: 704c4b0ddc03 ("cxlflash: Shutdown notify support for CXL Flash cards") > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com&

Re: [PATCH 2/2] MAINTAINERS: Update cxlflash maintainers

> On Jul 21, 2016, at 3:44 PM, Uma Krishnan <ukri...@linux.vnet.ibm.com> wrote: > > Adding myself as a cxlflash maintainer. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscr

[PATCH 1/6] cxlflash: Avoid mutex when destroying context

of these context management paths are superfluous. This commit removes the obtaining of the context mutex in the context initialization routine and assumes the mutex is not held in the context free path. Inspired-by: Al Viro <v...@zeniv.linux.org.uk> Signed-off-by: Matthew R. Och

[PATCH 4/6] cxlflash: Transition to application close model

that they are responsible for the close following the cleanup (detach) of a context. The documentation is also updated to reflect this change in behavior. Inspired-by: Al Viro <v...@zeniv.linux.org.uk> Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> --- Documentation/powerpc/cxlfl

[PATCH 3/6] cxlflash: Add kref to context

bug injection. To improve code comprehension and better protect against future bugs, add explicit reference counting to contexts and migrate the context removal code to the kref release handler. Inspired-by: Al Viro <v...@zeniv.linux.org.uk> Signed-off-by: Matthew R. Och

[PATCH 6/6] cxlflash: Update documentation

Update the block library link in the API documentation. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> --- Documentation/powerpc/cxlflash.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/powerpc/cxlflash.txt b/Documentation/powerpc/cxlfla

[PATCH 5/6] cxlflash: Remove adapter file descriptor cache

t;v...@zeniv.linux.org.uk> Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/superpipe.c | 26 +- drivers/scsi/cxlflash/superpipe.h | 1 - 2 files changed, 13 insertions(+), 14 deletions(-) diff --git a/drivers/scsi/cxlflash/superpipe.

[PATCH 2/6] cxlflash: Cache owning adapter within context

reference as the sole parameter, another means is needed to derive the owning adapter. As a remedy, the owning adapter reference is saved off within the context during initialization. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/superpipe.c | 1 + driver

[PATCH 0/6] cxlflash: Improvements and cleanup

alongside the modifications. The series is based upon 4.8-rc1, intended for 4.9, and is bisectable. Matthew R. Ochs (6): cxlflash: Avoid mutex when destroying context cxlflash: Cache owning adapter within context cxlflash: Add kref to context cxlflash: Transition to application close model

Re: [PATCH] cxl: remove dead Kconfig options

perst_reloads_same_image() in cxlflash which is > only used if CXL_EEH isn't defined (i.e. never). > > Suggested-by: Ian Munsie <imun...@au1.ibm.com> > Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com

Re: [PATCH 2/6] cxlflash: Remove the device cleanly in the system shutdown path

ime, the remove hook is updated to protect against being > called when the device is not enabled. > > Fixes: 704c4b0ddc03 ("cxlflash: Shutdown notify support for CXL Flash > cards") > Signed-off-by: Uma Krishna <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs

Re: [PATCH 1/6] cxlflash: Scan host only after the port is ready for I/O

problem, scsi_scan_host() should be called only after the > 'login succeeded' interrupt. > > Signed-off-by: Uma Krishna <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux

Re: [PATCH 03/14] cxlflash: Improve context_reset() logic

itionally it adds a debug trace to help pinpoint > hardware errors when a context reset does not complete. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line

<    1   2   3   4   5   >