On Mon, Jan 24, 2005 at 10:46:29AM +0100, Heiko Carstens wrote:
@@ -1099,9 +1099,9 @@
}
void
-zfcp_dummy_release(struct device *dev)
+zfcp_generic_services_release(struct device *dev)
{
- return;
+ kfree(dev);
}
/*
I thought that having release methods that just
On Tue, Feb 01, 2005 at 02:11:48AM +, S Iremonger wrote:
I would like if anybody out there knwos why linux-2.6 (well, at
least 2.6.8.1 and 2.6.10) seems to have seagate as an
incomplete or experimental driver, at least that it
does not appear in the SCSI low level drivers list
it.
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
--- linux-2.6/drivers/scsi/scsi.c 2005-01-23 21:46:55.0 -0500
+++ scsi-2.6/drivers/scsi/scsi.c2005-02-06 14:57:07.0 -0500
@@ -920,12 +920,9 @@ EXPORT_SYMBOL(scsi_finish_command);
* the right thing depending
On Mon, Feb 07, 2005 at 08:47:36AM -0500, Ju, Seokmann wrote:
On Monday, February 07, 2005 4:40 AM, Alex wrote:
is anything going to happen with the below listed locations?
(Some are part of the USB system, one is in block device, rest is SCSI.)
Note that a few locations do still lack the
On Tue, Feb 15, 2005 at 12:01:11PM +0200, Meelis Roos wrote:
The messages about registration of sda appear tiwice for some reason. This
is only cosmetic but still a little strange:
Yes, that happens for everyone.
--
Next the statesmen will invent cheap lies, putting the blame upon
the
On Thu, Feb 17, 2005 at 04:51:44PM +0100, Roger Håkansson wrote:
I've seen that there are more people having similar problem and some
patches have also been suggested, but I haven't tested any of them yet.
Yeah, I don't think any existing patch will help you. Could you try
this one?
Index:
On Fri, Feb 18, 2005 at 11:05:51AM +0100, Roger Håkansson wrote:
Matthew Wilcox wrote:
Yeah, I don't think any existing patch will help you.
Actually I got it to work when I applied the patch frage schnell posted
jan.20 (http://marc.theaimsgroup.com/?l=linux-scsim=110624183606642)
Oh. I
On Fri, Feb 18, 2005 at 06:05:22PM +0100, Roger Håkansson wrote:
Matthew Wilcox wrote:
Oh. I think I'm confused as to which version of sym2 is in which version
of Linus' tree. The same line in my development tree reads:
Well, I guess that part of the driver is rewritten a bit, I get
On Mon, Nov 15, 2004 at 10:21:28PM +0100, Ingo Korb wrote:
While trying to run 2.6.9 on my AlphaStation 200, I noticed that
sym53c8xx_2 doesn't seem to like the onboard 53c810 rev. 02 (see
bootlog below).
Just going through my old bug reports ...
sym0: 810 rev 0x2 at pci :00:06.0 irq
On Sun, Feb 20, 2005 at 08:11:58PM -0500, Jeff Garzik wrote:
Patch doesn't apply with -p1.
Doesn't matter; I can cope with both.
--- drivers/scsi/sym53c8xx_2/sym_glue.c 20 Feb 2005 23:49:27 -
1.84
This file does not include linux/config.h.
Doesn't need to -- sym_glue.h does.
On Sun, Feb 20, 2005 at 09:09:36PM -0500, Jeff Garzik wrote:
Incorrect. linux/config.h is not a standard include; you need to
include linux/config.h in each file that uses a CONFIG_xxx define.
sym_hipd.c includes sym_glue.h
sym_glue.h includes linux/config.h
There is no problem.
--
Next the
On Mon, Feb 21, 2005 at 04:09:37PM -0800, Andrew Vasquez wrote:
* must be done from process context -- depending on transport type,
discovery can occur from a non-process context
* potentially _long_ scan times -- even if discovery is done from a
'sleeping' capable context, halting a LLDD
On Tue, Feb 22, 2005 at 04:50:00PM -0500, Tim Wesemann wrote:
I was apparently incorrectly basing it on the register's address space from
the lspci output. Can you perhaps help me tell a better way to tell if my
2200S card is using 64-bit mode (as in whatever the hell marketing people
mean
to calculate the speed I needed to be able to convert from
period factor to period in picoseconds. That required changing
(show|store)_spi_transport_period to work in picoseconds rather than
a string.
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
Index: ./drivers/scsi/scsi_transport_spi.c
Found a funny in the sym2 driver I'm not sure how to resolve:
cp-sensecmd[0] = REQUEST_SENSE;
cp-sensecmd[1] = 0;
if (tp-tinfo.curr.scsi_version = 2 cp-lun = 7)
cp-sensecmd[1] = cp-lun 5;
Thing is, we
On Fri, Feb 25, 2005 at 02:02:20PM +1000, Douglas Gilbert wrote:
Matthew Wilcox wrote:
3w-9xxx Never fills in LUN
53c700 Always fills in LUN
BusLogic Doesn't send REQUEST_SENSE
aic7xxx Same as sym2 (except it sets its equivalent of scsi_version)
dc395x Always fills
On Thu, Mar 03, 2005 at 10:31:19AM +0200, James Bottomley wrote:
On Sun, 2005-02-06 at 20:51 +0100, Andi Kleen wrote:
This patch fixes one of Christroph's fixme comments in the SCSI midlayer.
Could you reroll this against scsi-misc-2.6, please? I get mainly
rejections when I try to apply
factor to period in picoseconds. That required changing
(show|store)_spi_transport_period to work in picoseconds rather than
a string.
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
Index: ./drivers/scsi/scsi_transport_spi.c
===
RCS
This isn't for applying so much as it is for showing people where I am
with this driver. As with the sym2 driver, I commit each piece to the
parisc-linux CVS tree (since parisc is currently the only user of this
driver, it makes even more sense to do development there). This patch
contains
On Sun, Mar 06, 2005 at 11:27:17PM +0100, [EMAIL PROTECTED] wrote:
convert from pci_module_init to pci_register_driver
(from:http://kerneljanitors.org/TODO).
Already applied to the sym2 driver in my tree, thanks.
--
Next the statesmen will invent cheap lies, putting the blame upon
the nation
On Sun, Mar 06, 2005 at 11:27:24PM +0100, [EMAIL PROTECTED] wrote:
I have added a KERN macro to a printk() function as requested in the Kernel
Janitor's TODO list.
Already taken care of in the parisc tree, thanks.
--
Next the statesmen will invent cheap lies, putting the blame upon
the
On Mon, Mar 07, 2005 at 12:40:15AM +, Christoph Hellwig wrote:
On Sun, Mar 06, 2005 at 08:11:53PM +, Matthew Wilcox wrote:
This isn't for applying so much as it is for showing people where I am
with this driver. As with the sym2 driver, I commit each piece to the
parisc-linux CVS
On Mon, Mar 07, 2005 at 05:14:16AM -0500, Jes Sorensen wrote:
domen == domen [EMAIL PROTECTED] writes:
domen Use the DMA_{64,32}BIT_MASK constants from dma-mapping.h when
domen calling pci_set_dma_mask() or pci_set_consistent_dma_mask() See
domen
On Wed, Mar 09, 2005 at 11:54:57AM -0500, Guy wrote:
A narrow SCSI bus will support 8 devices.
A wide SCSI bus will support 16 devices.
A narrow bus uses 50 pins.
A wide bus uses 68 pins.
We need a SCSI Wiki for all this kind of information ... maybe Wikipedia?
There is a standard for auto
On Fri, Mar 11, 2005 at 11:33:56AM -0500, Luben Tuikov wrote:
Q: I've been wondering how exactly does the transport class work?
Can anyone give an intro on attribute container, attribute group,
transport class template, etc. I've been looking at those but not
100% sure I understand it all.
The patch is almost 200k, so I shall save you the bandwidth and not
post it here. As I've mentioned before, I develop it in the PA-RISC
CVS tree which you can view here:
http://cvs.parisc-linux.org/linux-2.6/drivers/scsi/sym53c8xx_2/
You can download the full patch from
On Wed, Mar 16, 2005 at 05:04:47PM +0100, Jens Axboe wrote:
The kmap() isn't just inefficient, it's a problem to iterate over the sg
list and kmap all the pages. That is illegal.
But it's not so tricky to get right, if the punting just happens in the
isr. Basically just iterate over every sg
On Wed, Mar 16, 2005 at 10:44:50AM -0800, Mike Christie wrote:
I got lost here. If you are talking about the need to kmap a sglist then
software iscsi has it. iscsi-sfnet used to do
while (...)
kmap()
but I fixed that (I think I need to use kmap_atomic though, is that
correct or
Misc Lasi 700 fixes
- Use the DMA_32BIT_MASK constants when calling dma_set_mask()
Signed-off-by: Tobias Klauser [EMAIL PROTECTED]
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
- ioremap fixes
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
diff -urpNX dontdiff linus-2.6/drivers/scsi
Improve 53c700 /proc/interrupt output
Request the IRQ in the name of the chip rather than the bus address.
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
diff -urpNX dontdiff linus-2.6/drivers/scsi/53c700.c
parisc-2.6/drivers/scsi/53c700.c
--- linus-2.6/drivers/scsi/53c700.c 2005-03-18 06
Zalon updates
- Add KERN_INFO to printk
Signed-off-by: Andrew McGregor [EMAIL PROTECTED]
Signed-off-by: Domen Puncer [EMAIL PROTECTED]
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
- Remove iomem-related warnings
- Improve printk message
- Use cpu_relax()
Signed-off-by: Matthew Wilcox
Fix small bug in scsi_transport_spi
reserved was being printed without a trailing \n.
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
diff -urpNX dontdiff linus-2.6/drivers/scsi/scsi_transport_spi.c
parisc-2.6/drivers/scsi/scsi_transport_spi.c
--- linus-2.6/drivers/scsi/scsi_transport_spi.c
use PRINT_ADDR or dev_info
- Replace PRINT_TARGET() with a direct call to dev_info()
- Whitespace cleanups
- Get rid of superfluous ; after } of if/switch statements
- Use IDENTIFY() instead of M_IDENTIFY | ...
- Convert to use spi_display_xfer_agreement()
Signed-off-by: Matthew Wilcox [EMAIL
On Sat, Mar 19, 2005 at 09:53:07AM -0600, James Bottomley wrote:
On Fri, 2005-03-18 at 20:56 -0700, Matthew Wilcox wrote:
Request the IRQ in the name of the chip rather than the bus address.
This I don't really like for two reasons:
1) I don't know of any other driver that uses the actual
On Sat, Mar 19, 2005 at 02:19:32PM +0100, [EMAIL PROTECTED] wrote:
Use the DMA_32BIT_MASK constants from dma-mapping.h
when calling dma_set_mask().
Already submitted. I told you I'd take it through the parisc tree.
--
Next the statesmen will invent cheap lies, putting the blame upon
the
Reformat the comments to make them easy to read in 80 columns.
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
Index: ./include/scsi/scsi_cmnd.h
===
RCS file: /var/lib/cvs/linux-2.6/include/scsi/scsi_cmnd.h,v
retrieving revision
scsi_mid_low_api doesn't seem to have been updated for the scsi_add_host /
scsi_scan_host split. Here's a patch.
diff -u -p -r1.9 scsi_mid_low_api.txt
--- ./Documentation/scsi/scsi_mid_low_api.txt 12 Jan 2005 20:14:58 -
1.9
+++ ./Documentation/scsi/scsi_mid_low_api.txt 21 Mar 2005
On Mon, Mar 21, 2005 at 09:50:07AM -0500, [EMAIL PROTECTED] wrote:
+ * successful call to scsi_host_alloc(). The LLD must call
+ * scsi_scan_host() in order to scan the bus. The LLD must set up
+ * the transport template before calling this function and may only
+ * access the
On Sat, Apr 02, 2005 at 02:52:14PM -0600, James Bottomley wrote:
This driver has had it's own different infrastructure for doing this for
ages, but it's time it used the common one.
Thanks. I'd been looking at this for a while but hadn't got round tuit yet.
#ifdef CONFIG_53C700_LE_ON_BE
On Mon, Apr 04, 2005 at 03:47:01PM +0200, Fillod Stephane wrote:
--- linux/drivers/ide/ide.c 26 Mar 2005 03:28:17 - 1.1.1.2
+++ linux/drivers/ide/ide.c 4 Apr 2005 13:24:29 -
@@ -1562,9 +1562,11 @@
return 0;
}
+#ifdef CONFIG_SCSI_IOCTL
On Sat, Apr 09, 2005 at 12:57:22AM +0200, Peter Missel wrote:
It also makes the driver ignore the adapter ordering in multiple-channel
setups. This machine here has an LSI 21002, where the LVD channel is on
device function 1 and the UW channel is on 0. Naturally the user will set the
On Sun, Apr 10, 2005 at 01:58:27PM -0500, James Bottomley wrote:
If anyone has a 79xx card and wants to play too, this should be a simple
cut and paste, doing s/ahc_/ahd_/ in all my functions. The 79xx will
also need QAS, IU and all the other ultra320 transport properties ...
I thought QAS
No variable is ever set to SYM_EH_DO_COMPLETE:
$ grep SYM_EH_DO_COMPLETE drivers/scsi/sym53c8xx_2/*
drivers/scsi/sym53c8xx_2/sym_glue.c:#define SYM_EH_DO_COMPLETE 1
drivers/scsi/sym53c8xx_2/sym_glue.c:case SYM_EH_DO_COMPLETE:
drivers/scsi/sym53c8xx_2/sym_glue.c:if (to_do ==
On Tue, Jul 05, 2005 at 11:08:17AM +1000, Neil Brown wrote:
On 2.6.13-rc1 the same test takes just short on 1 minute and reports
slightly less than 2 M/Second.
That sounds like your drives have negotiated an asynchronous transfer
agreement. Could you provide your dmesg to confirm that
On Tue, Jul 19, 2005 at 10:12:49PM -0500, Matt Domsch wrote:
What you illustrated above is not going to work.
If your doing #ifndef around a function, such as scsi_device_online, it's
not going to compile
when scsi_device_online is already implemented in the kernel tree.
The routine
A paper at FAST2012
(http://static.usenix.org/events/fast12/tech/full_papers/Yang.pdf) pointed
out the performance overhead of taking interrupts for low-latency block
I/Os. The solution the author investigated was to spin waiting for each
I/O to complete. This is inefficient as Linux submits
On Mon, Jun 24, 2013 at 09:15:45AM +0200, Jens Axboe wrote:
Willy, I think the general design is fine, hooking in via the bdi is the
only way to get back to the right place from where you need to sleep.
Some thoughts:
- This should be hooked in via blk-iopoll, both of them should call into
On Mon, Jun 24, 2013 at 08:11:02PM -0400, Steven Rostedt wrote:
What about hooking into the idle_balance code? That happens if we are
about to go to idle but before the full schedule switch to the idle
task.
In __schedule(void):
if (unlikely(!rq-nr_running))
On Mon, Jun 24, 2013 at 10:07:51AM +0200, Ingo Molnar wrote:
I'm wondering, how will this scheme work if the IO completion latency is a
lot more than the 5 usecs in the testcase? What if it takes 20 usecs or
100 usecs or more?
There's clearly a threshold at which it stops making sense, and
On Tue, Jul 29, 2014 at 07:37:49PM +0300, Boaz Harrosh wrote:
But before we are running to fix this bug. Could we please do better and just
remove the support for partitions
all together.
Since it *never* worked anyway, so probably no one needs it! Surly no
one used it
I fixed this
On Wed, Jul 30, 2014 at 05:18:47PM +0300, Boaz Harrosh wrote:
When brd_direct_access() is called on a partition-bdev
it would access the wrong sector. And caller would then
corrupt the device's data.
This is a preliminary fix, Matthew Wilcox has a patch
in his DAX patchset which will define
On Tue, Sep 11, 2007 at 05:00:27AM +0900, FUJITA Tomonori wrote:
On Sun, 9 Sep 2007 08:53:58 -0600
Matthew Wilcox [EMAIL PROTECTED] wrote:
Here's another mammoth patch series for the advansys driver against
scsi-misc. I've tested that it compiles at each stage and that the
final result
On Sat, Sep 15, 2007 at 09:39:05AM -0500, James Bottomley wrote:
I get a compile failure at this point in your patch sequence:
Thanks. I'd been compiling with CONFIG_ISA=n, so hadn't spotted these
two problems. I've set it back to Y now.
I've put 1-15 in .. could you rebase against scsi-misc
Replace it with !ASC_NARROW_BOARD
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
---
drivers/scsi/advansys.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 5e6bcf2..a5bb4e4 100644
--- a/drivers/scsi/advansys.c
It was only ever set; never tested, nor cleared.
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
---
drivers/scsi/advansys.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 52ea41d..5e6bcf2 100644
--- a/drivers
- Don't need to set ASC_HOST_IN_RESET any more
- Don't need to test scp-device-host for NULL -- if it's NULL, we
couldn't've been called.
- Use scmd_printk instead of ASC_PRINT
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
---
drivers/scsi/advansys.c | 83
-by: Matthew Wilcox [EMAIL PROTECTED]
---
drivers/scsi/advansys.c | 131 ++-
1 files changed, 39 insertions(+), 92 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 737c0e4..3dd7856 100644
--- a/drivers/scsi/advansys.c
+++ b
asc_board_t was simply a typedef for struct asc_board. ASC_BOARDP()
can be replaced by shost_priv() except in the ASC_STATS* macros which
rely on the cast; add an explicit cast there.
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
---
drivers/scsi/advansys.c | 132
of this patch is rearranging structures so everything's declared
in the right order.
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
---
drivers/scsi/advansys.c | 193 ++
1 files changed, 92 insertions(+), 101 deletions(-)
diff --git a/drivers/scsi
It's somewhat neater to make this a pointer to one of two tables
than initialising an array in the driver. Also delete the unused
AscSynIndexToPeriod and rename host_init_sdtr_index to min_sdtr_index
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
---
drivers/scsi/advansys.c | 90
It's always a mistake to have your own index of boards; just use the
scsi host number.
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
---
drivers/scsi/advansys.c | 236 ---
1 files changed, 100 insertions(+), 136 deletions(-)
diff --git a/drivers
with no overlapping values.
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
---
drivers/scsi/advansys.c | 40
1 files changed, 16 insertions(+), 24 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index ad9639d..4c792db 100644
With the ASC and ADV libraries merged into the driver, there really is
no point in reporting their version numbers, or even trying to maintain
them.
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
---
drivers/scsi/advansys.c | 60 +++---
1 files changed
into three functions (one for each bus
type that needs it) and add some commentary to explain what's going on.
Also get rid of the AscSetChipIRQ function as we only ever set the
interrupt number to the same value it already had.
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
---
drivers/scsi
The board lock was essentially identical with the host lock.
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
---
drivers/scsi/advansys.c | 21 +
1 files changed, 5 insertions(+), 16 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 95df291
.
- ASC_DBG_PRT_SCSI_CMND isn't being used, so delete asc_prt_scsi_cmnd
too.
- A missing semicolon
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
---
drivers/scsi/advansys.c | 628 ---
1 files changed, 262 insertions(+), 366 deletions(-)
diff
On Sun, Sep 16, 2007 at 09:37:41AM -0600, Matthew Wilcox wrote:
@@ -2475,7 +2469,7 @@ typedef struct adv_req {
* of the 'Scsi_Host' structure starting at the 'hostdata'
* field. It is guaranteed to be allocated from DMA-able memory.
*/
-typedef struct asc_board {
+struct asc_board
asc_board_t was simply a typedef for struct asc_board. ASC_BOARDP()
can be replaced by shost_priv() except in the ASC_STATS* macros which
rely on the cast; add an explicit cast there.
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
---
drivers/scsi/advansys.c | 132
' tree.
Thanks. I took care of a few other things too .. here's the patch I
ended up committing. James, if you want to take this now, that's fine
by me, otherwise I'll send it as part of my next round of updates.
commit da1910c08d03b97d98ebefc3b28d1c147e77e02e
Author: Matthew Wilcox [EMAIL
The pid field is a duplicate of the serial_number field and has been
scheduled for removal for a long time. A few drivers were still using
it, so just change them to use serial_number instead.
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
drivers/scsi/dc395x.c | 110
I haven't even compile-tested this. But look how much ugly code it
deletes if it works!
diff --git a/drivers/scsi/qlogicpti.c b/drivers/scsi/qlogicpti.c
index 5948872..346bed6 100644
--- a/drivers/scsi/qlogicpti.c
+++ b/drivers/scsi/qlogicpti.c
@@ -310,8 +310,6 @@ static inline void
I've removed all uses of bus_to_virt[1] and virt_to_bus from the advansys
driver for the narrow card; it's now at the point where I can get 8MB/s
on a parisc machine [2]. But I don't have a wide advansys card, and the code
paths in the driver are very, very different. I think I know everything
?
With that change, Acked-by: Matthew Wilcox [EMAIL PROTECTED]
--
Intel are signing my paycheques ... these opinions are still mine
Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step.
-
To unsubscribe from
with it was not to clean up
the driver (though it does a little), but to get gdth out of the way of
cleaning up scsi_cmnd.
commit 06142e2394d83929b8b25feab70caab47ddfb791
Author: Matthew Wilcox [EMAIL PROTECTED]
Date: Sat Sep 22 22:57:06 2007 -0400
gdth: Make one abuse of scsi_cmnd less obvious
On Tue, Sep 25, 2007 at 02:17:44PM +0200, Boaz Harrosh wrote:
This patch looks grate, Thanks. It is very good for the direction
I'm going to. However it does have a smallish conflict with One
of Jeff's patches where he completely removes the 2.4.x support.
If it is OK with you I will add
Christoph grabbed me on IRC and we debated some of my plans for scsi_cmnd;
with his permission I'm summarising the result of that debate for posterity.
There's four main things discussed:
1. I'm going to be writing and posting patches over the next week or so
to kill all the (ab)uses of
On Tue, Sep 25, 2007 at 02:47:50PM +0100, Christoph Hellwig wrote:
On Tue, Sep 25, 2007 at 07:37:33AM -0600, Matthew Wilcox wrote:
2. Thanks to a thinko, we also discussed the upper-layer -done. We think
it should be feasible to move this from the scsi_cmnd to the scsi_device
since sg
On Tue, Sep 25, 2007 at 04:51:06PM +0200, Boaz Harrosh wrote:
As I said, it's ambitious. But it'll let us get rid of scsi_pointer
and host_scribble entirely.
This all is an excellent idea and you will find that in the patchset to
gdth, I have made the work of one driver a bit easier for
From: Matthew Wilcox [EMAIL PROTECTED]
We can simply call the internal done function directly
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
---
drivers/scsi/pluto.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/pluto.c b/drivers/scsi/pluto.c
index
This series of four patches gets rid of -done from scsi_cmnd. It applies
on top of the patch I sent earlier today to improve gdth's abuse of
scsi_done. Sorry, Boaz. I'd like to thank Christoph for talking me
through some of the bits of the block layer I didn't grok.
-
To unsubscribe from this
From: Matthew Wilcox [EMAIL PROTECTED]
All these drivers meant to call -scsi_done() but got confused.
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
---
drivers/scsi/NCR5380.c |8
drivers/scsi/NCR53C9x.c |2 +-
drivers/scsi/atari_NCR5380.c |4 ++--
drivers/scsi
From: Matthew Wilcox [EMAIL PROTECTED]
The -done member was being used to mark commands as being internal.
I decided to put a magic number in -underflow instead. I believe this
to be safe as no current user of -underflow has any of the bottom 9
bits set.
Signed-off-by: Matthew Wilcox [EMAIL
From: Matthew Wilcox [EMAIL PROTECTED]
The ULD -done callback moves into the scsi_driver. By moving the call
to scsi_io_completion() from scsi_blk_pc_done() to scsi_finish_command(),
we can eliminate the latter entirely. By returning 'good_bytes' from
the -done callback (rather than invoking
On Tue, Sep 25, 2007 at 07:05:09PM +0200, Boaz Harrosh wrote:
@@ -694,7 +702,13 @@ void scsi_finish_command(struct scsi_cmnd *cmd)
Notifying upper driver of completion
(result %x)\n, cmd-result));
- cmd-done(cmd);
+
On Tue, Sep 25, 2007 at 07:30:29PM +0200, Boaz Harrosh wrote:
OK This is on top of the first patch that I will take care of,
right? (http://www.spinics.net/lists/linux-scsi/msg19470.html)
That's right.
Here 2 it will not merge with my patchset. So I'll take it off your hands
and rebase it to
On Tue, Sep 25, 2007 at 10:37:33PM -0400, Jeff Garzik wrote:
Are there any const-ness worries for scsi_host_template, or plans for
the future? I do not see any other examples of the host template
members getting modified.
Goodness, Jeff, you haven't looked too hard. There's dozens of
On Tue, Sep 25, 2007 at 11:34:00PM -0400, Jeff Garzik wrote:
Well, sure, the driver is the owner of that memory.
We're talking about common code.
If everybody agrees SHT is R/W in the core, Fujita-san's patch is fine.
Oh ... harder to find, but scsi_module.c does that, as does
On Wed, Sep 26, 2007 at 10:50:20AM +0200, Stefan Boresch wrote:
Just curious: Is the patch for scsi_transport_spi.c you sent me for my
hardware problem going to make it into an official kernel?
That patch has been requested to go into 2.6.23, so isn't in this list.
--
Intel are signing my
On Fri, Apr 20, 2007 at 03:47:20PM -0500, Linas Vepstas wrote:
Implement the so-called first failure data capture (FFDC) for the
symbios PCI error recovery. After a PCI error event is reported,
the driver requests that MMIO be enabled. Once enabled, it
then reads and dumps assorted status
On Thu, Sep 27, 2007 at 05:00:22PM -0500, Linas Vepstas wrote:
On Wed, Sep 26, 2007 at 09:02:16AM -0600, Matthew Wilcox wrote:
I'm a little concerned by the mention of MMIO. It's entirely possible
for the sym2 driver to be using ioports to access the card rather than
MMIO. Is it simply
On Fri, Sep 28, 2007 at 04:15:56PM -0600, Moore, Eric wrote:
On Tuesday, September 25, 2007 7:38 AM, Matthew Wilcox wrote:
As I said, it's ambitious. But it'll let us get rid of scsi_pointer
and host_scribble entirely.
Are you serious about removing the host_scribble? In fusion we
On Sun, Sep 30, 2007 at 10:28:13PM +0100, Christoph Hellwig wrote:
I think it would be better if your whole patch series goes ontop of
willy's -done removal series instead. I really hope we can get that
one into scsi-misc ASAP.
Actually, I think if Boaz simply flips this patch to be after his
By configuring targets in slave_configure, we can eliminate a shadow
queuecommand, a shadow scsi_done, a write to the host template, abuse of
SCp-Message and SCp-Status, a use of kmap_atomic() and sniffing the
results of INQUIRY.
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
Acked-by: David S
On Thu, Sep 27, 2007 at 06:34:37PM -0500, Linas Vepstas wrote:
Good catch. But no ... and I had to study this a bit. Bear with me:
I agree with the analysis which I've now snipped.
I think the race you describe above is harmless. The first time
that sym_eh_handler() will run, it will be with
On Mon, Oct 01, 2007 at 05:41:32PM -0500, Linas Vepstas wrote:
On Mon, Oct 01, 2007 at 02:12:47PM -0600, Matthew Wilcox wrote:
I think the fundamental problem is that completions aren't really
supposed to be used like this. Here's one attempt at using completions
perhaps a little more
On Mon, Oct 01, 2007 at 07:36:10PM -0400, James Bottomley wrote:
One possibility we could do is to add a
struct dma_device {
struct device dev;
u64 dma_mask;
u64 coherent_dma_mask;
unsigned int max_segment_size;
/* plus any other DMA parameters */
};
but
On Tue, Oct 02, 2007 at 05:23:39PM +0200, Kay Sievers wrote:
Just looking at the number of devices, it seems that allocating it
dynamically would be the better deal. We allocate the name of every
kobject dynamically today, so I guess it's fine to do that with the
DMA data too.
But we don't
Using dev_printk to implement shost_printk leads to somewhat lacklustre
results:
host2: SCSI BUS has been reset
scsi2 : sym-2.2.3
By reimplementing shost_printk directly on top of printk, we can get
the more pleasing:
scsi 0: SCSI BUS has been reset
scsi 0: sym-2.2.3
It fits in well with
On Tue, Oct 02, 2007 at 02:38:00PM -0700, [EMAIL PROTECTED] wrote:
From: Linas Vepstas [EMAIL PROTECTED]
Various PCI bus errors can be signaled by newer PCI controllers. This
patch adds the PCI error recovery callbacks to the Symbios SCSI device
driver. The patch has been tested, and
On Tue, Oct 02, 2007 at 02:38:08PM -0700, [EMAIL PROTECTED] wrote:
From: Joe Korty [EMAIL PROTECTED]
Fix section mismatch in the Adaptec DPT SCSI Raid driver.
Acked-by: Matthew Wilcox [EMAIL PROTECTED]
Mathew: isn't a module exit routine a little too strong to be calling on the
failure
1 - 100 of 501 matches
Mail list logo
