Re: [PATCH 10/28] proc: Add proc_mkdir_data() [RFC]

-off-by: David Howells dhowe...@redhat.com cc: Neela Syam Kolli megaraidli...@lsi.com cc: Jerry Chuang jerry-chu...@realtek.com cc: Mauro Carvalho Chehab mche...@redhat.com cc: linux-scsi@vger.kernel.org cc: de...@driverdev.osuosl.org cc: linux-wirel...@vger.kernel.org --- drivers/message/i2o

Re: SYSFS errors

Em Mon, 18 Feb 2013 20:46:33 +0200 Felipe Balbi ba...@ti.com escreveu: Hi, On Mon, Feb 18, 2013 at 09:49:16AM -0800, Greg KH wrote: Input/output error - /sys/devices/cpu/power/autosuspend_delay_ms The issue with this file is, if the power.use_autosuspend flag is not set for the device,

Re: SYSFS errors

Em Mon, 18 Feb 2013 22:05:42 +0200 Felipe Balbi ba...@ti.com escreveu: Hi, On Mon, Feb 18, 2013 at 04:46:38PM -0300, Mauro Carvalho Chehab wrote: No such device - /sys/devices/system/edac/mc/mc0/sdram_scrub_rate Odd, go ask the edac developers will do ;-) Well

Re: SYSFS errors

Em Mon, 18 Feb 2013 23:44:05 +0100 Borislav Petkov b...@alien8.de escreveu: On Mon, Feb 18, 2013 at 02:26:18PM -0800, Greg KH wrote: I don't know, it depends on if userspace can handle this properly or not. What tools rely on this sysfs file? WHat happens when they get a non-number in the

Re: SYSFS errors

Em Tue, 19 Feb 2013 12:11:21 +0200 Felipe Balbi ba...@ti.com escreveu: Hi, On Tue, Feb 19, 2013 at 07:03:10AM -0300, Mauro Carvalho Chehab wrote: But my gut feeling says to stay concervative and not touch this code - we don't know what uses it and how much we would break by fixing

Re: SYSFS errors

Em Tue, 19 Feb 2013 12:43:46 +0100 Borislav Petkov b...@alien8.de escreveu: On Tue, Feb 19, 2013 at 08:11:49AM -0300, Mauro Carvalho Chehab wrote: I remember I saw some discussions about it in the past at bluesmoke ML, saying that -ENODEV is the expected behavior when

Re: SYSFS errors

Em Tue, 19 Feb 2013 13:35:02 +0100 Borislav Petkov b...@alien8.de escreveu: On Tue, Feb 19, 2013 at 09:16:10AM -0300, Mauro Carvalho Chehab wrote: I'm not sure if is there a way to pass fs permissions to something similar to device_create_file(). struct device_attribute.attr.mode? I.e

Re: SYSFS errors

Em Tue, 19 Feb 2013 14:06:26 +0100 Borislav Petkov b...@alien8.de escreveu: No, on both cases, open() will return an error (-ENOENT against -EPERM). What if it is a shell script doing: cat /sys/devices/system/edac/mc/mc0/sdram_scrub_rate or similar? Well, cat will return 1 if an error

Re: SYSFS errors

Em Tue, 19 Feb 2013 15:38:09 +0200 Felipe Balbi ba...@ti.com escreveu: Hi, On Tue, Feb 19, 2013 at 02:28:54PM +0100, Borislav Petkov wrote: On Tue, Feb 19, 2013 at 03:15:00PM +0200, Felipe Balbi wrote: what's the problem with that ? Not a problem - simply annoying. $ ./test.sh

Re: SYSFS errors

will already create the file anyway: if (mci-set_sdram_scrub_rate || mci-get_sdram_scrub_rate) Adjusting the permissions is simply the last missing piece to this patch to make the interface to userspace 100% coherent. -- From: Mauro Carvalho Chehab mche...@redhat.com Date: Tue

Re: SYSFS errors

the scub rate. Change the logic to only create this device node when the operation is supported. Reported-by: Felipe Balbi ba...@ti.com Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c index 9c58da6..4f4b613 100644

Re: [PATCH 19/51] DMA-API: media: dt3155v4l: replace dma_set_mask()+dma_set_coherent_mask() with new helper

, right? If so: Acked-by: Mauro Carvalho Chehab m.che...@samsung.com Regards, Hans --- drivers/staging/media/dt3155v4l/dt3155v4l.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/staging/media/dt3155v4l/dt3155v4l.c b/drivers/staging

[PATCH 06/13] ia64, scsi: update references for the device-io book

The book is now at Documentation/driver-api/device-io.rst. Update such references. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- arch/ia64/include/asm/io.h | 2 +- arch/ia64/sn/kernel/iomv.c | 2 +- drivers/scsi/qla1280.c | 2 +- 3 files changed, 3 insertions

[PATCH 34/36] scsi: fix some kernel-doc markups

-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/scsi/scsi_scan.c | 7 --- drivers/scsi/scsi_transport_fc.c | 18 ++ drivers/scsi/scsicam.c | 4 ++-- 3 files changed, 16 insertions(+), 13 deletions(-) diff --git a/drivers/scsi/scsi_sc

[PATCH v2 46/53] ia64, scsi: update references for the device-io book

The book is now at Documentation/driver-api/device-io.rst. Update such references. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- arch/ia64/include/asm/io.h | 2 +- arch/ia64/sn/kernel/iomv.c | 2 +- drivers/scsi/qla1280.c | 2 +- 3 files changed, 3 insertions

[PATCH v2 33/53] scsi: fix some kernel-doc markups

-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/scsi/scsi_scan.c | 7 --- drivers/scsi/scsi_transport_fc.c | 18 ++ drivers/scsi/scsicam.c | 4 ++-- 3 files changed, 16 insertions(+), 13 deletions(-) diff --git a/drivers/scsi/scsi_sc

Re: [PATCH 00/18] use ARRAY_SIZE macro

Em Sun, 1 Oct 2017 20:52:20 -0400 Jérémy Lefaure escreveu: > Anyway, I can tell to each maintainer that they can apply the patches > they're concerned about and next time I may send individual patches. In the case of media, we'll handle it as if they were individual

Re: [trivial PATCH] treewide: Align function definition open/close braces

e gnu complexity to work > properly for these modified functions. > > Miscellanea: > > o Remove extra trailing ; and blank line from xfs_agf_verify > > Signed-off-by: Joe Perches <j...@perches.com> For the media patch: Acked-by: Mauro Carvalho Chehab <mche...@s-op

Re: [PATCH v6 12/13] Documentation: remove stale firmware API reference

ds to > execute > code which sends the BIOS update request to the BIOS. So on the next > reboot > the BIOS knows about the new image downloaded and it updates itself. You should likely remove the "Also" here. With that, Reviewed-by: Mauro Carvalho Chehab <mchehab+sams...@kernel.org> Regards, Mauro

Re: [PATCH v6 13/13] Documentation: clarify firmware_class provenance and why we can't rename the module

ism we now use as a fallback mechanism, which which registers a > +struct class firmware_class. Because the attributes exposed are part of the > +module name, the module name firmware_class cannot be renamed in the future, > to > +ensure backward compatibilty with old userspace.