Re: [RFC 00/11] Add support for iSCSI Extentions for RDMA (ISER) target

On 08/03/2013 03:45, Nicholas A. Bellinger wrote: This series is first RFC for iSCSI Extentions for RDMA (ISER) target support with existing iscsi-target TCP based socket code for a future v3.10 merge. This code is available in git here:

Re: [RFC 10/11] iser-target: Add logic for core

On 08/03/2013 03:45, Nicholas A. Bellinger wrote: +void +isert_dump_ib_wc(struct ib_wc *wc) +{ + pr_debug(wc-wr_id: %llu\n, wc-wr_id); + pr_debug(wc-status: 0x%08x\n, wc-status); This helper is called for a CQ completion with error, but when this happens all the WC fields except

Re: [RFC 09/11] iser-target: Add logic for verbs

On 08/03/2013 03:45, Nicholas A. Bellinger wrote: +++ b/drivers/infiniband/ulp/isert/isert_verbs.c +#define ISERT_ADDR_ROUTE_TIMEOUT 1000 remove this define, its irrelevant and you don't use that anywhere +static void +isert_qp_event_callback(struct ib_event *e, void *context) +{ +

Re: [RFC 09/11] iser-target: Add logic for verbs

On 08/03/2013 03:45, Nicholas A. Bellinger wrote: isert_conn-conn_rx_cq = ib_create_cq(ib_dev, isert_cq_rx_callback, + isert_cq_event_callback, + (void *)isert_conn, +

Re: [RFC 10/11] iser-target: Add logic for core

On 08/03/2013 03:45, Nicholas A. Bellinger wrote: +void +iser_cq_tx_tasklet(unsigned long data) +{ + struct isert_conn *isert_conn = (struct isert_conn *)data; + struct ib_cq *tx_cq = isert_conn-conn_tx_cq; + struct iser_tx_desc *tx_desc; + struct ib_wc wc; + +

Re: [RFC-v2 10/12] iser-target: Add logic for verbs

On 23/03/2013 01:55, Nicholas A. Bellinger wrote: +++ b/drivers/infiniband/ulp/isert/isert_verbs.h @@ -0,0 +1,5 @@ +extern void isert_connect_release(struct isert_conn *); +extern void isert_put_conn(struct isert_conn *); +extern int isert_cma_handler(struct rdma_cm_id *, struct rdma_cm_event

Re: [RFC-v2 11/12] iser-target: Add logic for core

On 23/03/2013 01:55, Nicholas A. Bellinger wrote: +++ b/drivers/infiniband/ulp/isert/isert_core.h @@ -0,0 +1,11 @@ +#include linux/socket.h +#include linux/in.h +#include linux/in6.h +#include rdma/ib_verbs.h +#include rdma/rdma_cm.h + +extern void iser_cq_tx_tasklet(unsigned long); +extern void

Re: [RFC-v2 10/12] iser-target: Add logic for verbs

On Sat, Mar 23, 2013 at 1:55 AM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: [...] +static void +isert_qp_event_callback(struct ib_event *e, void *context) +{ + struct isert_conn *isert_conn = (struct isert_conn *)context; + + pr_err(isert_qp_event_callback event: %d\n,

Re: [RFC-v2 10/12] iser-target: Add logic for verbs

On Sat, Mar 23, 2013 at 1:55 AM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: + device-dev_mr = ib_get_dma_mr(device-dev_pd, + IB_ACCESS_LOCAL_WRITE | + IB_ACCESS_REMOTE_WRITE | +

Re: [RFC-v2 11/12] iser-target: Add logic for core

On Sat, Mar 23, 2013 at 1:55 AM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: +static int +isert_put_response(struct iscsi_conn *conn, struct iscsi_cmd *cmd) +{ + struct isert_cmd *isert_cmd = container_of(cmd, + struct isert_cmd, iscsi_cmd);

Re: [RFC-v3 9/9] iser-target: Add iSCSI Extensions for RDMA (iSER) target driver

On 04/04/2013 10:24, Nicholas A. Bellinger wrote: + +void isert_cq_tx_callback(struct ib_cq *, void *); +void isert_cq_rx_callback(struct ib_cq *, void *); +void isert_free_rx_descriptors(struct isert_conn *); any reason not to have these as static functions (same for isert_cq_rx_work) -- To

Re: [RFC-v3 9/9] iser-target: Add iSCSI Extensions for RDMA (iSER) target driver

On 04/04/2013 10:24, Nicholas A. Bellinger wrote: +#define ISER_RECV_DATA_SEG_LEN 8192 +#define ISER_RX_PAYLOAD_SIZE(ISER_HEADERS_LEN + ISER_RECV_DATA_SEG_LEN) [...] +#define ISER_RX_PAD_SIZE (16384 - (ISER_RX_PAYLOAD_SIZE + \ + sizeof(u64) +

Re: [RFC-v3 9/9] iser-target: Add iSCSI Extensions for RDMA (iSER) target driver

On 04/04/2013 10:24, Nicholas A. Bellinger wrote: +static int +isert_put_response(struct iscsi_conn *conn, struct iscsi_cmd *cmd) +{ + struct isert_cmd *isert_cmd = container_of(cmd, + struct isert_cmd, iscsi_cmd); + struct isert_conn *isert_conn

Re: [RFC-v4 9/9] iser-target: Add iSCSI Extensions for RDMA (iSER) target driver

S.O.B here Signed-off-by: Or Gerlitz ogerl...@mellanox.com -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: initial LIO iSER performance numbers [was: GIT PULL] target updates for v3.10-rc1)

test the raw iSER wire performance. Or. Thanks to Or Gerlitz + Mellanox for supporting the iser-target development effort! Thank you, --nab Andy Grover (2): target/iscsi: Remove chap_set_random() target/iscsi: Use ISCSI_LOGIN_CURRENT/NEXT_STAGE macros Asias He (10): target/file

Re: initial LIO iSER performance numbers [was: GIT PULL] target updates for v3.10-rc1)

On Thu, May 2, 2013 at 10:31 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: We used RAMDISK_MCP backend which was patched to act as NULL device, so we can test the raw iSER wire performance. Btw, I'll be including a similar patch to allow for RAMDISK_NULL to be configured as a NULL

Re: [GIT PULL] target fixes for v3.10-rc2

On Wed, May 15, 2013 at 5:50 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: A handful of fixes + minor changes this time around, along with one important = v3.9 regression fix for IBLOCK backends. The highlights include: Hi Nic, Are you pushing also a patch which would allow to

Re: [GIT PULL] target fixes for v3.10-rc2

On Thu, May 16, 2013 at 7:53 AM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: Yes, that's the patch included in the PULL request here: http://git.kernel.org/cgit/linux/kernel/git/nab/target-pending.git/commit/?h=queueid=52c07423a819091b0fe9abbf26977098b996f85b Cool! Btw, It still needs

Re: [PATCH v3 0/13] IB SRP initiator patches for kernel 3.11

On 03/07/2013 15:41, Bart Van Assche wrote: [...] Bart, The individual patches in this series are as follows: 0001-IB-srp-Fix-remove_one-crash-due-to-resource-exhausti.patch 0002-IB-srp-Fix-race-between-srp_queuecommand-and-srp_cla.patch

[PATCH] IB/iser: Add Discovery support

that this is discovery session. Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- Hi James, I submit this patch through your tree since it depends on the below iscsi patches (which are acknowledged by Mike) who are targted to 3.12 Or. [PATCH V2 1/4] scsi_transport_iscsi: Exporting new attrs for iscsi session

Re: [PATCH 0/2] Include protection information in iscsi header

On Tue, Jun 3, 2014 at 9:16 AM, Roland Dreier rol...@purestorage.com wrote: On Sun, Jun 1, 2014 at 9:19 AM, Sagi Grimberg sa...@mellanox.com wrote: Although these patches involve 3 subsystems with different maintainers (scsi, iser, target) I would prefer seeing these patches included together.

Re: [PATCH v1 1/3] scsi_cmnd: Introduce scsi_transfer_length helper

On Tue, Jun 10, 2014 at 10:02 PM, Martin K. Petersen martin.peter...@oracle.com wrote: Sagi == Sagi Grimberg sa...@mellanox.com writes: +static inline unsigned scsi_prot_length(unsigned data_length, + unsigned sector_size) +{ + switch (sector_size)

Re: [PATCH 5/8] IB/srp: Remove stale connection retry mechanism

On Fri, Sep 19, 2014 at 3:58 PM, Bart Van Assche bvanass...@acm.org wrote: Attempting to connect three times may be insufficient after an initiator system that was using multiple RDMA channels tries to relogin. Additionally, this login retry mechanism is a workaround for particular behavior of

Re: [PATCH 00/11] First pass at merging Bart's HA work

On Mon, Nov 26, 2012 at 6:44 AM, David Dillow dillo...@ornl.gov wrote: One may also pull this series from github: git pull git://github.com/dillow/srp-initiator.git ha-merge-v1 Hi Dave, The kernel maintainers file specifies the following tree

Re: [PATCH 00/11] First pass at merging Bart's HA work

On 27/11/2012 06:04, David Dillow wrote: We can push it through James's tree if need be, but Bart's code is pretty self-contained, and going through the SCSI tree will introduce merge dependencies. It'd be much easier to push it all through the RDMA tree Yep, this makes sense to me even

Re: [PATCH 00/11] First pass at merging Bart's HA work

On Fri, Nov 30, 2012 at 4:21 AM, David Dillow dillo...@ornl.gov wrote: [...] Modulo a few style issues (braces around one line if branches, etc.) and having three state variables vs one, I can live with everything up to aabfa852acd27962 at git://github.com/bvanassche/linux.git#srp-ha. Those

Re: [PATCH 00/11] First pass at merging Bart's HA work

On Wed, Dec 5, 2012 at 8:50 PM, Bart Van Assche bvanass...@acm.org wrote: [...] The only way to make I/O work reliably if a failure can occur at the transport layer is to use multipathd on top of ib_srp. If a connection fails for some reason, then the SRP SCSI host will be removed after the

Re: [PATCH 00/11] First pass at merging Bart's HA work

On 06/12/2012 16:10, Bart Van Assche wrote: On 12/05/12 22:32, Or Gerlitz wrote: On Wed, Dec 5, 2012 at 8:50 PM, Bart Van Assche bvanass...@acm.org wrote: [...] The only way to make I/O work reliably if a failure can occur at the transport layer is to use multipathd on top of ib_srp

Re: [PATCH 00/11] First pass at merging Bart's HA work

On 06/12/2012 17:04, Bart Van Assche wrote: On 12/06/12 15:27, Or Gerlitz wrote: The core problem here seems to be that scsi_remove_host simply never ends. Hello Or, The later patches in the srp-ha patch series avoided such behavior by checking whether the connection between SRP initiator

Re: [PATCH 00/11] First pass at merging Bart's HA work

On Thu, Dec 6, 2012 at 4:27 PM, Or Gerlitz ogerl...@mellanox.com wrote: [...] looking on the current locks in the system, we see that this kworker task holds four locks, but none of them seems to be mutually held by another task, That was ofcourse a wrong assertion, as a lock can't be mutually

Re: [RFC 01/11] iscsi-target: Add iscsit_transport API template

On Fri, Mar 8, 2013 at 6:14 AM, Roland Dreier rol...@kernel.org wrote: Nicholas A. Bellinger n...@linux-iscsi.org wrote: +EXPORT_SYMBOL(iscsit_get_transport); It's not clear to me why this needs to be exported. Who would use it outside the core iscsi target module? Yep, as Nic noted, we're

[PATCH 0/3] SCSI/libiscsi: Reduce locking contention in fast path

Hi James, This series is about reducing locking contention in the IO submission/response processing fast path of libiscsi and the various iscsi transports usage of libiscsi code. We replace the session lock with two locks, a forward lock and a backwards lock named frwd_lock and back_lock

[PATCH 3/3] SCSI/libiscsi: Remove unneeded code

From: Shlomo Pongratz shlo...@mellanox.com We never will have a closed window and something on one of those lists. Signed-off-by: Mike Christie micha...@cs.wisc.edu Signed-off-by: Shlomo Pongratz shlo...@mellanox.com --- drivers/scsi/libiscsi.c | 12 1 files changed, 0

[PATCH 1/3] SCSI/libiscsi: Restructure iscsi_tcp r2t response logic

prior to the allocation, we can pre-check and thus avoid futile allocations. Signed-off-by: Shlomo Pongratz shlo...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/scsi/libiscsi_tcp.c | 43 ++- 1 files changed, 22 insertions(+), 21

[PATCH 2/3] SCSI/libiscsi: Reduce locking contention in fast path

protects the extracing from the r2t queue and inserting to the r2t pool. Signed-off-by: Shlomo Pongratz shlo...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/scsi/be2iscsi/be_main.c | 26 +++--- drivers/scsi/bnx2i/bnx2i_hwi.c | 46 drivers/scsi/bnx2i

Re: CmdSN greather than MaxCmdSN protocol error in LIO Iser

On 12/11/2013 06:34, Nicholas A. Bellinger wrote: Once iscsi_conn_queue_work() is invoked here to start process context execution of iscsi_xmitworker() - iscsi_data_xmit() code, AFAICT there is no logic in place within iscsi_data_xmit() to honor the last received MaxCmdSN. Or to put it another

Re: [PATCH 06/11] IB/isert: Initialize T10-PI resources

On Thu, Jan 9, 2014 at 6:40 PM, Sagi Grimberg sa...@mellanox.com wrote: @@ -557,8 +629,14 @@ isert_connect_request(struct rdma_cm_id *cma_id, struct rdma_cm_event *event) goto out_mr; } + if (pi_support !device-pi_capable) { + pr_err(Protection

Re: [PATCH 09/11] IB/isert: Accept RDMA_WRITE completions

On Thu, Jan 9, 2014 at 6:40 PM, Sagi Grimberg sa...@mellanox.com wrote: In case of protected transactions, we will need to check the protection status of the transaction before sending SCSI response. So be ready for RDMA_WRITE completions. currently we don't ask for these completions, but for

Re: [PATCH 06/11] IB/isert: Initialize T10-PI resources

On 12/01/2014 14:41, Sagi Grimberg wrote: --- a/drivers/infiniband/ulp/isert/ib_isert.h +++ b/drivers/infiniband/ulp/isert/ib_isert.h @@ -48,11 +48,21 @@ struct iser_tx_desc { struct ib_send_wr send_wr; } __packed; +struct pi_context { + struct ib_mr *prot_mr;

Re: linux rdma 3.14 merge plans

On Wed, Jan 22, 2014, Sagi Grimberg sa...@dev.mellanox.co.il wrote: On 1/22/2014 2:43 AM, Roland Dreier wrote: On Tue, Jan 21, 2014, Or Gerlitz or.gerl...@gmail.com wrote: Roland, ping! the signature patches were posted three months ago. We deserve a response from the maintainer that goes

Re: [PATCH 4/6] iser-target: Fix post_send_buf_count for RDMA READ/WRITE

On 04/03/2014 02:01, Nicholas A. Bellinger wrote: This is necessary because even though IB_SEND_SIGNALED is not set for RDMA WRITEs + READs, during a QP failure event the work requests will be returned with exception status from the TX completion queue. Impossible... for rdma reads we must ask

Re: [PATCH v1 10/13] IB/iser: Support T10-PI operations

On 03/03/2014 06:44, Mike Christie wrote: The xmit_task callout does handle failures like EINVAL. If the above map calls fail then you would get infinite retries. You would currently want to do the mapping in the init_task callout instead. If it makes it easier on the driver implementation then

Re: [PATCH v1 10/13] IB/iser: Support T10-PI operations

On 04/03/2014 11:59, Sagi Grimberg wrote: On 3/4/2014 11:38 AM, Or Gerlitz wrote: On 03/03/2014 06:44, Mike Christie wrote: The xmit_task callout does handle failures like EINVAL. If the above map calls fail then you would get infinite retries. You would currently want to do the mapping

Re: [PATCH v1 10/13] IB/iser: Support T10-PI operations

On 04/03/2014 16:44, Sagi Grimberg wrote: @@ -1707,10 +1707,17 @@ int iscsi_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *sc) goto prepd_fault; } } - if (session-tt-xmit_task(task)) { -

Re: [PATCH v2 00/13] T10-PI support for iSER initiator

patches are available in target-pending git repo (branch rdma-dif) and passed 0-DAY testing. Roland, I would like to hear your feedback on this. Acked-By: Or Gerlitz ogerl...@mellanox.com Roland, given that Sagi addressed all the feedback from the reviewers, specifically from Mike Christie

Re: [PATCH v2 11/13] SCSI/libiscsi: Add check_protection callback for transports

On Wed, Mar 5, 2014 at 7:43 PM, Sagi Grimberg sa...@mellanox.com wrote: iSCSI needs to be at least aware that a task involves protection information. In case it does, after the transaction completed libiscsi will ask the transport to check the protection status of the transaction. Unlike

Re: [PATCH 4/4] Target/dif: Introduce protection-passthough-only mode

On Mon, Mar 17, 2014 at 12:52 PM, Sagi Grimberg sa...@mellanox.com wrote: Target/dif: Introduce protection-passthough-only mode s/passthough/passthrough/ -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH v2 11/13] SCSI/libiscsi: Add check_protection callback for transports

On Mon, Mar 17, 2014, Sagi Grimberg sa...@dev.mellanox.co.il wrote: On 3/17/2014 6:59 PM, Mike Christie wrote: This patch is ok, but happened to the patch for the xmit task path? Hey Mike, Thanks for your Ack on this. The xmit_task fix was posted as a separate patch since it is not specific

Re: [PATCH v1] Target/iser: Fail SCSI WRITE command if device detected integrity error

On 18/03/2014 14:52, Sagi Grimberg wrote: If during data-transfer a data-integrity error was detected we must fail the command with CHECK_CONDITION and not execute the command. Cnages from v0: - Added reported-by Or gerlitz Signed-off-by: Sagi Grimbergsa...@mellanox.com Reported

[PATCH for-3.15] scsi/libiscsi: Fix static checker warning on bh locking

]), which we can eliminate by using non bh locking on the nested spin_lock call. Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Shlomo Pongratz shlo...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/scsi/libiscsi.c |4 ++-- 1 files changed, 2 insertions

Re: [PATCH 1/9] move blk_iopoll to limit and make it generally available

On Fri, Nov 13, 2015 at 3:46 PM, Christoph Hellwig wrote: > The new name is irq_poll as iopoll is already taken. Better suggestions > welcome. Sagi (or Christoph if you can address that), @ some pointer over the last 18 months there was a port done at mellanox for iser to use

Re: [PATCH 1/1] iscsi: fix regression caused by session lock patch

On Thu, Nov 12, 2015 at 10:58 PM, Mike Christie wrote: > On 11/12/2015 06:03 AM, Sagi Grimberg wrote: >>> The bug is caused by this patch: >>> >>> 659743b02c411075b26601725947b21df0bb29c8 >>> >>> which allowed the task lists to be manipulated under different locks >>> in the

Re: [PATCH 9/9] IB/iser: Convert to CQ abstraction

On 11/13/2015 3:46 PM, Christoph Hellwig wrote: From: Sagi Grimberg Care to sparse some text here to assist a reviewer and future bisections?! I have asked multiple times to avoid empty change-logs for patches in this driver. Signed-off-by: Sagi

Re: [PATCH 1/9] move blk_iopoll to limit and make it generally available

On Sun, Nov 15, 2015 at 10:48 AM, Sagi Grimberg wrote: > Or is correct, > > I have attempted to convert iser to use blk_iopoll in the past, however > I've seen inconsistent performance and latency skews (comparing to > tasklets iser is using today). This was manifested

Re: [PATCH 7/9] IB/iser: Use a dedicated descriptor for login

On 11/13/2015 3:46 PM, Christoph Hellwig wrote: From: Sagi Grimberg Makes better sense and we'll need it later with CQ abstraction. iser switch login bufs to void Sagi, few quick comments on this patch, please address for next version.. The 2nd sentence of the change-log

Re: [PATCH 1/1] iscsi: fix regression caused by session lock patch

On Fri, Nov 13, 2015 at 6:51 PM, Mike Christie <micha...@cs.wisc.edu> wrote: > On 11/13/2015 09:06 AM, Or Gerlitz wrote: >>> The patch has caused multiple regressions, did not even compile when >>> > sent to me, and was poorly reviewed and I have not heard from y

Re: [PATCH] ib_srp: initialize dma_length in srp_map_idb

On Sun, Nov 15, 2015, Sagi Grimberg wrote: > On 15/11/2015 19:59, Christoph Hellwig wrote: >> Without this sg_dma_len will return 0 on architectures tha have >> the dma_length field. and what wrong with that? Christoph, probably typo here? "tha" needs to be "that" >>

Re: [PATCH 1/1] iscsi: fix regression caused by session lock patch

On Mon, Nov 16, 2015 at 7:30 PM, Michael Christie <micha...@cs.wisc.edu> wrote: >> On Nov 15, 2015, at 4:10 AM, Or Gerlitz <gerlitz...@gmail.com> wrote: >> After the locking change, adding a task to any of the connection >> mgmtqueue, cmdqueue, or requeue lists is

Re: [PATCH 1/1] iscsi: fix regression caused by session lock patch

On Mon, Nov 16, 2015 at 7:30 PM, Michael Christie <micha...@cs.wisc.edu> wrote: >> On Nov 15, 2015, at 4:10 AM, Or Gerlitz <gerlitz...@gmail.com> wrote: >> On Fri, Nov 13, 2015 at 6:51 PM, Mike Christie <micha...@cs.wisc.edu> wrote: >>> On 11/13/201

Re: [PATCH for-next 05/10] iser: Have initiator and target to share protocol structures and definitions

On 11/16/2015 6:37 PM, Sagi Grimberg wrote: +/** + * struct iser_hello - iSER Hello header + * + * @opcode: opcode (must be set to ISER_HELLO) + * @max_min_ver: maximum and minimum iser versions + * @iser_ird: iSER IRD + * @rsvd: reserved + */ +struct iser_hello { + u8

Re: [PATCH v3 13/13] cxgbit: add files for cxgbit.ko

On Tue, May 24, 2016 at 9:40 AM, Nicholas A. Bellinger <n...@linux-iscsi.org> wrote: > Hi Or & Co, > On Wed, 2016-05-18 at 14:45 +0300, Or Gerlitz wrote: >> On Sat, Apr 30, 2016 at 6:54 PM, Or Gerlitz <gerlitz...@gmail.com> wrote: >> > On Tue, Apr 1

Re: [PATCH v3 13/13] cxgbit: add files for cxgbit.ko

On Wed, May 25, 2016 at 8:40 PM, Steve Wise <sw...@opengridcomputing.com> wrote: >> From: Or Gerlitz [mailto:gerlitz...@gmail.com] >> >> On Tue, May 24, 2016 at 9:40 AM, Nicholas A. Bellinger >> <n...@linux-iscsi.org> wrote: >> > Hi Or & Co, >>

Re: [PATCH v3 13/13] cxgbit: add files for cxgbit.ko

On Tue, Apr 19, 2016 at 9:30 PM, Varun Prakash wrote: > cxgbit.h - This file contains data structure > definitions for cxgbit.ko. > > cxgbit_lro.h - This file contains data structure > definitions for LRO support. > > cxgbit_main.c - This file contains code for > registering

Re: [PATCH v3 13/13] cxgbit: add files for cxgbit.ko

On Sat, Apr 30, 2016 at 6:54 PM, Or Gerlitz <gerlitz...@gmail.com> wrote: > On Tue, Apr 19, 2016 at 9:30 PM, Varun Prakash <va...@chelsio.com> wrote: >> cxgbit.h - This file contains data structure >> definitions for cxgbit.ko. >> >> cxgbit_lro.h - This file

Re: [PATCH 2/2] IB/iser: set max_segment_size

On Tue, Apr 12, 2016 at 5:13 PM, Christoph Hellwig wrote: > So that we don't overflow the number of MR segments allocated because > we have to split on SGL segment into multiple MR segments. > > Signed-off-by: Christoph Hellwig nit, but please fix IB/iser: set [...]

Re: [PATCH v3 13/13] cxgbit: add files for cxgbit.ko

On Fri, Jul 8, 2016 at 9:36 PM, Steve Wise wrote: >> > > In first series libcxgb.ko will have common >> > > iSCSI DDP Page Pod Manager that will be shared >> > > by three Chelsio iSCSI drivers >> > > cxgb3i, cxgb4i, cxgbit. >> > >> > cool >> > >> > > In subsequent

Re: [PATCH v3 13/13] cxgbit: add files for cxgbit.ko

On Wed, Jul 6, 2016 at 8:17 PM, Varun Prakash <va...@chelsio.com> wrote: > On Wed, Jul 06, 2016 at 12:24:43AM +0300, Or Gerlitz wrote: >> On Thu, May 26, 2016 at 9:58 PM, Varun Prakash <va...@chelsio.com> wrote: >> >> > Hi Or, Nicholas and Steve >>

Re: [PATCH v3 13/13] cxgbit: add files for cxgbit.ko

On Thu, May 26, 2016 at 9:58 PM, Varun Prakash wrote: > Hi Or, Nicholas and Steve > Thank you for the feedback and apologies for the delay in my response. > On Wed, May 25, 2016 at 09:55:04PM -0700, Nicholas A. Bellinger wrote: >> Varun + Co have made common improvements