Re: [PATCH 1/1] SCSI-QLA2...: Deletion of unnecessary checks before the function call vfree

If you are convinced that dropping the null tests is a good idea, then you can submit the patch that makes the change to the relevant maintainers and mailing lists. I resent the request once more because another Triple-X software development adventure might follow ...? Regards, Markus

[PATCH 1/1] SCSI: Deletion of unnecessary checks before the function call put_device

From: Markus Elfring elfr...@users.sourceforge.net Date: Thu, 20 Nov 2014 18:48:52 +0100 The put_device() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software.

[PATCH 1/1] SCSI-libfc: Deletion of an unnecessary check before the function call fc_fcp_ddp_done

From: Markus Elfring elfr...@users.sourceforge.net Date: Thu, 20 Nov 2014 20:10:19 +0100 The fc_fcp_ddp_done() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software.

[PATCH 1/1] SCSI-aic94xx: Deletion of an unnecessary check before the function call kfree

From: Markus Elfring elfr...@users.sourceforge.net Date: Thu, 20 Nov 2014 23:18:56 +0100 The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by:

[PATCH 1/1] SCSI-bfa: Deletion of an unnecessary check before the function call vfree

From: Markus Elfring elfr...@users.sourceforge.net Date: Thu, 20 Nov 2014 23:43:17 +0100 The vfree() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH 1/1] SCSI-fnic: Deletion of an unnecessary check before the function call vfree

From: Markus Elfring elfr...@users.sourceforge.net Date: Fri, 21 Nov 2014 09:39:43 +0100 The vfree() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH 1/1] target: Deletion of unnecessary checks before the function call module_put

From: Markus Elfring elfr...@users.sourceforge.net Date: Fri, 21 Nov 2014 10:25:45 +0100 The module_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software.

[PATCH 1/6] isci: Fix a typo for the word destroy

From: Markus Elfring elfr...@users.sourceforge.net Date: Mon, 24 Nov 2014 15:35:48 +0100 A word was corrected in the description for the sci_remote_device_destruct() function. Signed-off-by: Markus Elfring elfr...@users.sourceforge.net --- drivers/scsi/isci/remote_device.c | 2 +- 1 file

[PATCH 2/6] SCSI-libfc: Fix typos for the word destroy

From: Markus Elfring elfr...@users.sourceforge.net Date: Mon, 24 Nov 2014 15:40:41 +0100 Identifiers were corrected in descriptions for the functions fc_fcp_pkt_destroy() and fc_fcp_destroy(). Signed-off-by: Markus Elfring elfr...@users.sourceforge.net --- drivers/scsi/libfc/fc_fcp.c | 4 ++--

[PATCH 4/4] SCSI-QLA4...: Less function calls in qla4xxx_sysfs_ddb_logout() after error detection

From: Markus Elfring elfr...@users.sourceforge.net Date: Fri, 6 Feb 2015 22:44:23 +0100 The vfree() function was called in three cases by the qla4xxx_sysfs_ddb_logout() function during error handling even if the passed variables flash_tddb and tmp_tddb contained still a null pointer. * This

[PATCH 1/4] SCSI-QLA4...: Deletion of unnecessary checks before three function calls

From: Markus Elfring elfr...@users.sourceforge.net Date: Fri, 6 Feb 2015 20:38:23 +0100 The following functions perform also input parameter validation. * iscsi_boot_destroy_kset * kfree * vfree Thus the test around their calls is not needed. This issue was detected by using the Coccinelle

[PATCH 0/4] SCSI-QLA4...: Deletion of some unnecessary checks

From: Markus Elfring elfr...@users.sourceforge.net Date: Fri, 6 Feb 2015 23:03:41 +0100 Further update suggestions were taken into account after a patch was applied from static source code analysis. Markus Elfring (4): Deletion of unnecessary checks before three function calls Less function

[PATCH 2/4] SCSI-QLA4...: Less function calls in qla4xxx_is_session_exists() after error detection

From: Markus Elfring elfr...@users.sourceforge.net Date: Fri, 6 Feb 2015 21:14:40 +0100 The vfree() function was called in two cases by the qla4xxx_is_session_exists() function during error handling even if the passed variables fw_tddb and tmp_tddb contained still a null pointer. * This

[PATCH 3/4] SCSI-QLA4...: Less function calls in qla4xxx_is_flash_ddb_exists() after error detection

From: Markus Elfring elfr...@users.sourceforge.net Date: Fri, 6 Feb 2015 21:55:55 +0100 The vfree() function was called in two cases by the qla4xxx_is_flash_ddb_exists() function during error handling even if the passed variables fw_tddb and tmp_tddb contained still a null pointer. * This

Re: [PATCH 2/4] SCSI-QLA4...: Less function calls in qla4xxx_is_session_exists() after error detection

1) People gloss over initializers without reading them. I would find such a habit strange. You shouldn't put complicated code in initializers. Does the affected memory allocation fall into such a category? 2) It means you have to put a line of separation between the allocation

[PATCH] SCSI-bfa: Delete more unnecessary checks before the function call vfree

From: Markus Elfring elfr...@users.sourceforge.net Date: Thu, 5 Feb 2015 22:02:16 +0100 The vfree() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH] SCSI-aic7...: Delete unnecessary checks before the function call kfree

From: Markus Elfring elfr...@users.sourceforge.net Date: Thu, 5 Feb 2015 22:23:48 +0100 The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by:

[PATCH 0/2] SCSI-lpfc: Deletion of an unnecessary check

From: Markus Elfring elfr...@users.sourceforge.net Date: Thu, 5 Feb 2015 23:17:52 +0100 Another update suggestion was taken into account after a patch was applied from static source code analysis. Markus Elfring (2): Delete an unnecessary check before the function call kfree One function

[PATCH 2/2] SCSI-lpfc: One function call less in lpfc_bsg_hba_set_event() after error detection

From: Markus Elfring elfr...@users.sourceforge.net Date: Thu, 5 Feb 2015 23:03:52 +0100 The kfree() function was called in two cases by the lpfc_bsg_hba_set_event() function during error handling even if the passed variable dd_data contained still a null pointer. This implementation detail could

[PATCH 1/2] SCSI-lpfc: Delete an unnecessary check before the function call kfree

From: Markus Elfring elfr...@users.sourceforge.net Date: Thu, 5 Feb 2015 22:45:02 +0100 The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by:

[PATCH 0/3] SCSI-debug: Deletion of a few unnecessary checks

From: Markus Elfring elfr...@users.sourceforge.net Date: Fri, 6 Feb 2015 18:08:53 +0100 Further update suggestions were taken into account after a patch was applied from static source code analysis. Markus Elfring (3): Deletion of unnecessary checks before the function call vfree Less

[PATCH 1/3] SCSI-debug: Deletion of unnecessary checks before the function call vfree

From: Markus Elfring elfr...@users.sourceforge.net Date: Fri, 6 Feb 2015 16:56:57 +0100 The vfree() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH 2/3] SCSI-debug: Less function calls in scsi_debug_init() after error detection

From: Markus Elfring elfr...@users.sourceforge.net Date: Fri, 6 Feb 2015 17:48:34 +0100 The vfree() function was called in two cases by the scsi_debug_init() function during error handling even if the passed variables dif_storep and map_storep contained null pointers eventually. This

[PATCH 3/3] SCSI-debug: Fix exception handling for an alignment/granularity mismatch in scsi_debug_init()

From: Markus Elfring elfr...@users.sourceforge.net Date: Fri, 6 Feb 2015 17:57:32 +0100 The scsi_debug_init() function returned directly if the data items alignment and granularity did not fit together. Let us improve the affected exception handling by replacing the return statement by a goto

[PATCH] SCSI-csiostor: Delete an unnecessary check before the function call release_firmware

From: Markus Elfring elfr...@users.sourceforge.net Date: Fri, 6 Feb 2015 19:10:25 +0100 The release_firmware() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software.

[PATCH 0/3] block: Deletion of checks before three function calls

From: Markus Elfring elfr...@users.sourceforge.net Date: Sun, 18 Jan 2015 14:50:06 +0100 Functions which release a system resource are occasionally documented in the way that they tolerate the passing of a null pointer for example. I do not see a need because of this fact that a function caller

[PATCH 3/3] block: Deletion of checks before the function call iounmap

From: Markus Elfring elfr...@users.sourceforge.net Date: Sun, 18 Jan 2015 13:33:25 +0100 The iounmap() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH 1/3] block-cciss: Deletion of an unnecessary check before the function call put_disk

From: Markus Elfring elfr...@users.sourceforge.net Date: Sun, 18 Jan 2015 11:14:16 +0100 The put_disk() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by:

[PATCH] SCSI-OSD: Delete an unnecessary check before the function call put_disk

From: Markus Elfring elfr...@users.sourceforge.net Date: Wed, 24 Jun 2015 16:06:21 +0200 The put_disk() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by:

[PATCH] SCSI-libfc: Delete an unnecessary check before the function call fc_fcp_ddp_done

From: Markus Elfring elfr...@users.sourceforge.net Date: Wed, 24 Jun 2015 17:50:32 +0200 The fc_fcp_ddp_done() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software.

[PATCH] SCSI-wd33c93: Deletion of a check before the function call wd33c93_setup

From: Markus Elfring elfr...@users.sourceforge.net Date: Wed, 24 Jun 2015 17:15:17 +0200 The wd33c93_setup() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH] SCSI-fnic: Delete an unnecessary check before the function call vfree

From: Markus Elfring elfr...@users.sourceforge.net Date: Wed, 24 Jun 2015 20:40:35 +0200 The vfree() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH] SCSI: Delete unnecessary checks before the function call put_device

From: Markus Elfring elfr...@users.sourceforge.net Date: Wed, 24 Jun 2015 19:24:01 +0200 The put_device() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software.

Re: [PATCH] SCSI-aic94xx: Deletion of an unnecessary check before the function call kfree

From: Markus Elfring elfr...@users.sourceforge.net Date: Thu, 20 Nov 2014 23:18:56 +0100 The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software.

Re: [PATCH] SCSI-bfa: Deletion of an unnecessary check before the function call vfree

Patch looks good. Thanks! Acked-by: Anil Gurumurthy anil.gurumur...@qlogic.com -Original Message- From: SF Markus Elfring [mailto:elfr...@users.sourceforge.net] Sent: 21 November 2014 04:17 To: Anil Gurumurthy; James E. J. Bottomley; Sudarsana Kalluru; linux-scsi Cc: linux

[PATCH] SCSI-libfc: Delete an unnecessary check before the function call "kmem_cache_destroy"

From: Markus Elfring Date: Mon, 16 Nov 2015 09:39:12 +0100 The kmem_cache_destroy() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software.

Re: [PATCH] SCSI-libcxgbi: Deletion of an unnecessary check before the function call dst_release

From: Markus Elfring elfr...@users.sourceforge.net Date: Fri, 21 Nov 2014 09:15:10 +0100 The dst_release() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software.

Re: [PATCH] SCSI-aic7...: Delete unnecessary checks before the function call kfree

Am 05.02.2015 um 22:27 schrieb SF Markus Elfring: From: Markus Elfring elfr...@users.sourceforge.net Date: Thu, 5 Feb 2015 22:23:48 +0100 The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue

[PATCH] scsi_lib: Delete unnecessary checks before two function calls

From: Markus Elfring Date: Tue, 17 Nov 2015 09:00:31 +0100 The functions kmem_cache_destroy() and mempool_destroy() test whether their argument is NULL and then return immediately. Thus the tests around their calls are not needed. This issue was detected by using

[PATCH] SCSI-aic94xx: Delete unnecessary checks before the function call "kmem_cache_destroy"

From: Markus Elfring Date: Tue, 17 Nov 2015 08:14:52 +0100 The kmem_cache_destroy() function tests whether its argument is NULL and then returns immediately. Thus the test around the calls is not needed. This issue was detected by using the Coccinelle software.

[PATCH] SCSI-lpfc: Delete unnecessary checks before the function call "mempool_destroy"

From: Markus Elfring Date: Tue, 17 Nov 2015 09:34:27 +0100 The mempool_destroy() function tests whether its argument is NULL and then returns immediately. Thus the test around the calls is not needed. This issue was detected by using the Coccinelle software.

Re: [PATCH 4/7] iscsi-target: Make a variable initialisation a bit more obvious in iscsi_create_default_params()

>> @@ -200,9 +200,8 @@ free_param: >> int iscsi_create_default_params(struct iscsi_param_list **param_list_ptr) >> { >> struct iscsi_param *param; >> -struct iscsi_param_list *pl; >> +struct iscsi_param_list *pl = kzalloc(sizeof(*pl), GFP_KERNEL); >> >> -pl =

[PATCH 0/7] iSCSI-target: Fine-tuning for three function implementations

From: Markus Elfring Date: Sat, 12 Dec 2015 15:25:20 +0100 Some update suggestions were taken into account from static source code analysis. Markus Elfring (7): Use a variable initialisation in iscsi_set_default_param() directly Less checks in

[PATCH 7/7] iscsi-target: Make two variable initialisations a bit more obvious in iscsi_check_valuelist_for_support()

From: Markus Elfring Date: Sat, 12 Dec 2015 15:04:57 +0100 The variable "acceptor_values" and "proposer_values" were initialized by null pointers and immediately assigned values from input parameters by separate statements. Let us express the desired variable

[PATCH 6/7] iscsi-target: Delete unnecessary variable initialisations in iscsi_check_valuelist_for_support()

From: Markus Elfring Date: Sat, 12 Dec 2015 14:34:26 +0100 The variables "tmp1" and "tmp2" will eventually be set to appropriate pointers from a call of the strchr() function. Thus let us omit the explicit initialisation at the beginning. Signed-off-by: Markus

[PATCH 1/7] iscsi-target: Use a variable initialisation in iscsi_set_default_param() directly

From: Markus Elfring Date: Sat, 12 Dec 2015 11:36:02 +0100 Omit the unnecessary setting to a null pointer for the variable "param" at the beginning of the function "iscsi_set_default_param" because it can be directly initialized with the return value from the

[PATCH 2/7] iscsi-target: Less checks in iscsi_set_default_param() after error detection

From: Markus Elfring Date: Sat, 12 Dec 2015 12:50:10 +0100 This issue was detected by using the Coccinelle software. A sanity check would be performed by the iscsi_set_default_param() function even if it is known already that the passed variable contained a null

[PATCH 4/7] iscsi-target: Make a variable initialisation a bit more obvious in iscsi_create_default_params()

From: Markus Elfring Date: Sat, 12 Dec 2015 13:44:06 +0100 The variable "pl" was declared and immediately assigned a return value from a function call in a separate statement. * Let us express the desired variable initialisation directly. * Avoid the repetition

[PATCH 5/7] iscsi-target: Rename a jump label in iscsi_create_default_params()

From: Markus Elfring Date: Sat, 12 Dec 2015 14:12:50 +0100 This issue was detected by using the Coccinelle software. Choose a jump label according to the current Linux coding style convention. Signed-off-by: Markus Elfring ---

[PATCH 3/7] iscsi-target: Delete an unnecessary variable initialisation in iscsi_create_default_params()

From: Markus Elfring Date: Sat, 12 Dec 2015 13:20:08 +0100 The variable "param" will eventually be set to an appropriate pointer from a call of the iscsi_set_default_param() function. Thus let us omit the explicit initialisation at the beginning. Signed-off-by:

Re: [PATCH 1/7] iscsi-target: Use a variable initialisation in iscsi_set_default_param() directly

>> @@ -127,9 +127,8 @@ static struct iscsi_param >> *iscsi_set_default_param(struct iscsi_param_list *para >> char *name, char *value, u8 phase, u8 scope, u8 sender, >> u16 type_range, u8 use) >> { >> -struct iscsi_param *param = NULL; >> +struct iscsi_param

[PATCH] SCSI-lpfc: Use a signed return type for two functions

From: Markus Elfring Date: Sat, 19 Dec 2015 19:32:27 +0100 The return type "size_t" was used by the functions "lpfc_wwn_set" and "lpfc_oas_lun_state_set" despite of the aspect that they will eventually return a negative error code. Improve this implementation

[PATCH] scsi: Delete an unnecessary check before the function call "kfree"

From: Markus Elfring Date: Sun, 24 Jul 2016 14:20:21 +0200 The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by:

Re: [PATCH] SCSI-aic94xx: Delete unnecessary checks before the function call "kmem_cache_destroy"

> From: Markus Elfring > Date: Tue, 17 Nov 2015 08:14:52 +0100 > > The kmem_cache_destroy() function tests whether its argument is NULL > and then returns immediately. Thus the test around the calls is not needed. > > This issue was detected by using the

Re: [PATCH 2/3] xen-scsiback: One function call less in scsiback_device_action() after error detection

>> @@ -606,7 +606,7 @@ static void scsiback_device_action(struct vscsibk_pend >> *pending_req, >> tmr = kzalloc(sizeof(struct scsiback_tmr), GFP_KERNEL); >> if (!tmr) { >> target_put_sess_cmd(se_cmd); >> -goto err; >> +goto do_resp; >> } > >

Re: [PATCH 2/3] xen-scsiback: One function call less in scsiback_device_action() after error detection

@@ -606,7 +606,7 @@ static void scsiback_device_action(struct vscsibk_pend *pending_req, tmr = kzalloc(sizeof(struct scsiback_tmr), GFP_KERNEL); if (!tmr) { target_put_sess_cmd(se_cmd); - goto err; + goto do_resp; } >>>

[PATCH v2 0/3] xen-scsiback: Fine-tuning for scsiback_device_action()

From: Markus Elfring Date: Wed, 20 Jul 2016 13:20:04 +0200 Further update suggestions were taken into account after a patch was applied from static source code analysis. Markus Elfring (3): Delete an unnecessary check before the function call "kfree" Rename

[PATCH v2 1/3] xen-scsiback: Delete an unnecessary check before the function call "kfree"

From: Markus Elfring Date: Tue, 19 Jul 2016 15:42:19 +0200 The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by:

[PATCH v2 3/3] xen-scsiback: Pass a failure indication as a constant

From: Markus Elfring Date: Wed, 20 Jul 2016 13:12:33 +0200 Pass the constant "FAILED" in a function call directly instead of using an intialisation for a local variable. Signed-off-by: Markus Elfring --- v2: Rebased on source files

[PATCH v2 2/3] xen-scsiback: Rename jump labels in scsiback_device_action()

From: Markus Elfring Date: Wed, 20 Jul 2016 13:03:16 +0200 * Adjust jump targets according to the Linux coding style convention. * A bit of refactoring for the control flow Suggested-by: Jürgen Groß Signed-off-by: Markus Elfring

[PATCH 0/3] xen-scsiback: Fine-tuning for scsiback_device_action()

From: Markus Elfring Date: Sat, 16 Jul 2016 22:06:54 +0200 Further update suggestions were taken into account after a patch was applied from static source code analysis. Markus Elfring (3): Delete an unnecessary check before the function call "kfree" One

[PATCH 1/3] xen-scsiback: Delete an unnecessary check before the function call "kfree"

From: Markus Elfring Date: Sat, 16 Jul 2016 21:21:05 +0200 The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by:

[PATCH 2/3] xen-scsiback: One function call less in scsiback_device_action() after error detection

From: Markus Elfring Date: Sat, 16 Jul 2016 21:42:42 +0200 The kfree() function was called in one case by the scsiback_device_action() function during error handling even if the passed variable "tmr" contained a null pointer. Adjust jump targets according to the

[PATCH 3/3] xen-scsiback: Pass a failure indication as a constant

From: Markus Elfring Date: Sat, 16 Jul 2016 21:55:01 +0200 Pass the constant "FAILED" in a function call directly instead of using an intialisation for a local variable. Signed-off-by: Markus Elfring --- drivers/xen/xen-scsiback.c

[PATCH 6/7] aacraid: Improve determination of a few sizes

From: Markus Elfring Date: Sun, 21 Aug 2016 08:04:48 +0200 Replace the specification of data structures by references for variables as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding

[PATCH 2/7] aacraid: One function call less in aac_send_raw_srb() after error detection

>From e8187662ee30aab709a260c72fb86c51673f8e0d Mon Sep 17 00:00:00 2001 From: Markus Elfring Date: Sat, 20 Aug 2016 20:40:47 +0200 Subject: [PATCH 2/7] aacraid: One function call less in aac_send_raw_srb() after error detection The kfree() function was called in a

[PATCH 5/7] aacraid: Add spaces after control flow keywords

From: Markus Elfring Date: Sun, 21 Aug 2016 07:10:43 +0200 Keywords which belong to the category "control flow" in the C programming language should be followed by a space character according to the Linux coding style convention. Signed-off-by: Markus Elfring

[PATCH] megaraid_sas: Use memdup_user() rather than duplicating its implementation

From: Markus Elfring Date: Sun, 21 Aug 2016 10:39:04 +0200 Reuse existing functionality from memdup_user() instead of keeping duplicate source code. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH 0/7] aacraid: Fine-tuning for a few functions

From: Markus Elfring Date: Sun, 21 Aug 2016 09:03:21 +0200 Several update suggestions were taken into account from static source code analysis. Markus Elfring (7): Use memdup_user() rather than duplicating its implementation One function call less in

[PATCH 1/7] aacraid: Use memdup_user() rather than duplicating its implementation

From: Markus Elfring Date: Sat, 20 Aug 2016 20:05:24 +0200 Reuse existing functionality from memdup_user() instead of keeping duplicate source code. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH 4/7] aacraid: Delete unnecessary braces

From: Markus Elfring Date: Sun, 21 Aug 2016 07:07:08 +0200 Do not use curly brackets at some source code places where a single statement should be sufficient. Signed-off-by: Markus Elfring --- drivers/scsi/aacraid/commctrl.c | 18

[PATCH 3/7] aacraid: Delete unnecessary initialisations in aac_send_raw_srb()

From: Markus Elfring Date: Sat, 20 Aug 2016 21:25:20 +0200 Six local variables will be set to an appropriate value a bit later. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring ---

[PATCH 7/7] aacraid: Apply another recommendation from "checkpatch.pl"

From: Markus Elfring Date: Sun, 21 Aug 2016 08:23:25 +0200 The script "checkpatch.pl" can point out that assignments should usually not be performed within condition checks. Thus move the assignment for the variable "srbfib" to a separate statement. Signed-off-by:

Re: [PATCH 1/7] aacraid: Use memdup_user() rather than duplicating its implementation

>> @@ -526,15 +526,9 @@ static int aac_send_raw_srb(struct aac_dev* dev, void >> __user * arg) >> goto cleanup; >> } >> >> - user_srbcmd = kmalloc(fibsize, GFP_KERNEL); >> - if (!user_srbcmd) { >> - dprintk((KERN_DEBUG"aacraid: Could not make a

[PATCH 0/5] block-cciss: Fine-tuning for two function implementations

From: Markus Elfring Date: Thu, 18 Aug 2016 11:40:04 +0200 Some update suggestions were taken into account from static source code analysis. Markus Elfring (5): Use memdup_user() Less function calls after error detection Delete unnecessary initialisations

[PATCH 1/5] block-cciss: Use memdup_user() rather than duplicating its implementation

From: Markus Elfring Date: Wed, 17 Aug 2016 22:10:29 +0200 * Reuse existing functionality from memdup_user() instead of keeping duplicate source code. This issue was detected by using the Coccinelle software. * Return directly if this copy operation failed.

[PATCH 5/5] block-cciss: Replace three kzalloc() calls by kcalloc()

From: Markus Elfring Date: Thu, 18 Aug 2016 11:26:18 +0200 * The script "checkpatch.pl" can point information out like the following. WARNING: Prefer kcalloc over kzalloc with multiply Thus fix the affected source code places. * Replace the specification of

[PATCH 4/5] block-cciss: Move an assignment for the variable "sg_used" in cciss_bigpassthru()

From: Markus Elfring Date: Wed, 17 Aug 2016 23:04:46 +0200 Move the assignment for the local variable "sg_used" behind the source code for some memory allocations by this function. Signed-off-by: Markus Elfring ---

[PATCH 2/5] block-cciss: Less function calls in cciss_bigpassthru() after error detection

From: Markus Elfring Date: Wed, 17 Aug 2016 22:39:31 +0200 The kfree() function was called in a few cases by the cciss_bigpassthru() function during error handling even if a passed variable contained a null pointer. Adjust jump targets according to the Linux

[PATCH 3/5] block-cciss: Delete unnecessary initialisations in cciss_bigpassthru()

From: Markus Elfring Date: Wed, 17 Aug 2016 22:55:51 +0200 Three local variables will be set to an appropriate value a bit later. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring ---

[PATCH 3/3] iscsi-target: Improve size determinations in four functions

From: Markus Elfring Date: Sun, 9 Apr 2017 16:00:39 +0200 Replace the specification of four data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determinations a bit safer according to the Linux coding

[PATCH 0/3] iSCSI-target: Fine-tuning for some function implementations

From: Markus Elfring Date: Sun, 9 Apr 2017 16:11:23 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (3): Use kcalloc() in iscsit_allocate_iovecs() Delete error messages for failed memory allocations

[PATCH 1/3] iscsi-target: Use kcalloc() in iscsit_allocate_iovecs()

From: Markus Elfring Date: Sun, 9 Apr 2017 15:06:00 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kcalloc". This issue was detected

[PATCH 2/3] iscsi-target: Delete error messages for failed memory allocations

From: Markus Elfring Date: Sun, 9 Apr 2017 15:34:50 +0200 The script "checkpatch.pl" pointed information out like the following. WARNING: Possible unnecessary 'out of memory' message Thus remove such statements here. Link:

[PATCH 0/5] target: Fine-tuning for some function implementations

From: Markus Elfring Date: Sun, 9 Apr 2017 21:33:21 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (5): rd: Use kcalloc() in two functions rd: Delete error messages for failed memory allocations rd:

[PATCH 2/5] target: Delete error messages for failed memory allocations

From: Markus Elfring Date: Sun, 9 Apr 2017 19:20:26 +0200 The script "checkpatch.pl" pointed information out like the following. WARNING: Possible unnecessary 'out of memory' message Thus remove such statements here. Link:

[PATCH 4/5] target: Use kmalloc_array() in compare_and_write_callback()

From: Markus Elfring Date: Sun, 9 Apr 2017 20:25:11 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was

[PATCH 1/5] target: Use kcalloc() in two functions

From: Markus Elfring Date: Sun, 9 Apr 2017 19:02:38 +0200 * Multiplications for the size determination of memory allocations indicated that array data structures should be processed. Thus use the corresponding function "kcalloc". This issue was detected by

[PATCH 3/5] target: Improve size determinations in two functions

From: Markus Elfring Date: Sun, 9 Apr 2017 20:15:12 +0200 Replace the specification of two data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determinations a bit safer according to the Linux coding

Re: scsi: ufs: Delete an error message for a failed memory allocation in ufshcd_memory_alloc()

> Although i don't know "out of memory" messages will be printed out by > dmam_alloc_coherent() APIs > or not. Would such information belong to the programming interface documentation? Are there any related tags or source code annotations needed? Regards, Markus

Re: Checking error messages for failed memory allocations

> Basically most everything that has a gfp_t argument does a > dump_stack() on OOM unless __GFP_NOWARN is specified by that gfp_t. How do you think about to improve any programming interface documentation around such a function property? Are there any special checks needed for function

Re: Checking error messages for failed memory allocations

> Feel free to submit documentation patches. Do involved software developers agree on the functionality for stack dumps because of out of memory situations? Regards, Markus

[PATCH 0/3] SCSI-UFSHCD: Fine-tuning for two function implementations

From: Markus Elfring Date: Tue, 25 Apr 2017 22:20:02 +0200 Three update suggestions were taken into account from static source code analysis. Markus Elfring (3): Use devm_kcalloc() in ufshcd_memory_alloc() Delete an error message for a failed memory allocation

[PATCH 1/3] scsi: ufs: Use devm_kcalloc() in ufshcd_memory_alloc()

From: Markus Elfring Date: Tue, 25 Apr 2017 21:45:25 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "devm_kcalloc". * Replace the

[PATCH 2/3] scsi: ufs: Delete an error message for a failed memory allocation in ufshcd_memory_alloc()

From: Markus Elfring Date: Tue, 25 Apr 2017 21:50:43 +0200 The script "checkpatch.pl" pointed information out like the following. WARNING: Possible unnecessary 'out of memory' message Thus remove such a statement here. Link:

[PATCH 3/3] scsi: ufs: Delete an unnecessary return statement in ufshcd_exception_event_handler()

From: Markus Elfring Date: Tue, 25 Apr 2017 22:00:05 +0200 The script "checkpatch.pl" pointed information out like the following. WARNING: void function return statements are not generally useful Thus remove such a statement here. Signed-off-by: Markus Elfring

Re: [PATCH 0/5] block-cciss: Fine-tuning for two function implementations

> Date: Thu, 18 Aug 2016 11:40:04 +0200 > > Some update suggestions were taken into account > from static source code analysis. > > Markus Elfring (5): > Use memdup_user() > Less function calls after error detection > Delete unnecessary initialisations > Move an assignment for the

[PATCH 3/3] SCSI-sg: Fix a typo in a comment line in sg_ioctl()

From: Markus Elfring Date: Fri, 25 Aug 2017 22:06:59 +0200 Fix a word in this description. Signed-off-by: Markus Elfring --- drivers/scsi/sg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/sg.c

[PATCH 1/3] SCSI-sg: Delete an error message for a failed memory allocation in sg_alloc()

From: Markus Elfring Date: Fri, 25 Aug 2017 21:48:11 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 2/3] SCSI-sg: Improve a size determination in sg_alloc()

From: Markus Elfring Date: Fri, 25 Aug 2017 21:55:14 +0200 Replace the specification of a data type by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

  1   2   >