[PATCH] ipr: qc_fill_rtf() method should not store alternate status register

the alternate status register's value in the 'ctl' field of 'qc-result_tf', hence this driver should not do this as well... Signed-off-by: Sergei Shtylyov sergei.shtyl...@cogentembedded.com --- The patch is against the recent Linus' tree. drivers/scsi/ipr.c |1 - 1 file changed, 1 deletion

Re: [PATCH] ipr: qc_fill_rtf() method should not store alternate status register

. No other 'libata' driver except 'drivers/scsi/ipr.c' stores the alternate status register's value in the 'ctl' field of 'qc-result_tf', hence this driver should not do this as well... Signed-off-by: Sergei Shtylyov sergei.shtyl...@cogentembedded.com Acked-by: Brian King brk...@linux.vnet.ibm.com

Re: [RFC/RFT PATCH 3/5] scsi: Use dma_max_pfn(dev) helper for bounce_limit calculations

Hello. On 07/13/2013 01:48 AM, Santosh Shilimkar wrote: DMA bounce limit is the maximum direct DMA'able memory beyond which bounce buffers has to be used to perform dma operations. SCSI driver relies on dma_mask but its calculation is based on max_*pfn which don't have uniform meaning across

Re: [RFC/RFT PATCH 3/5] scsi: Use dma_max_pfn(dev) helper for bounce_limit calculations

Hello. On 07/13/2013 02:25 AM, Russell King - ARM Linux wrote: DMA bounce limit is the maximum direct DMA'able memory beyond which bounce buffers has to be used to perform dma operations. SCSI driver relies on dma_mask but its calculation is based on max_*pfn which don't have uniform meaning

Re: [RFC/RFT PATCH 3/5] scsi: Use dma_max_pfn(dev) helper for bounce_limit calculations

On 07/13/2013 03:08 AM, Sergei Shtylyov wrote: DMA bounce limit is the maximum direct DMA'able memory beyond which bounce buffers has to be used to perform dma operations. SCSI driver relies on dma_mask but its calculation is based on max_*pfn which don't have uniform meaning across

Re: [PATCH v0 1/3] ata: Fix the watermark threshold for the APM X-Gene SATA host controller driver.

Hello. On 06/20/2014 12:32 PM, Suman Tripathi wrote: This patch fixes the watermark threshold of the receive FIFO for the APM X-Gene SATA host controller driver. Signed-off-by: Loc Ho l...@apm.com Signed-off-by: Suman Tripathi stripa...@apm.com --- drivers/ata/ahci_xgene.c | 8

Re: [PATCH v0 2/3] ata: Fix the link down in first attempt for the APM X-Gene SoC AHCI SATA host controller driver.

On 06/20/2014 12:32 PM, Suman Tripathi wrote: This patch fixes the link down issue by retry for the APM X-Gene SoC SATA host controller driver. Due to board design issue and short margin limitation, it is observed that once out of many thousands power cycle test, the sata link may not link up.

Re: [PATCH v1 3/3] arm64: Fix the APM X-Gene SoC SATA PHY clock DTS node csr-mask of the SATA Host Controller 1.

Hello. On 06/23/2014 02:15 PM, Suman Tripathi wrote: This patch fixes the SATA PHY clock DTS node csr-mask of the SATA Host controller 1. This patch also fixes the status of the PHY clock node of SATA Host controller 1. Signed-off-by: Loc Ho l...@apm.com Signed-off-by: Suman Tripathi

Re: [PATCH v8 2/3] ahci_xgene: Skip the PHY and clock initialization if already configured by the firmware.

Hello. On 08/23/2014 10:37 PM, Suman Tripathi wrote: This patch implements the feature to skip the PHY and clock initialization if it is already configured by the firmware. Signed-off-by: Loc Ho l...@apm.com Signed-off-by: Suman Tripathi stripa...@apm.com --- drivers/ata/ahci_xgene.c | 16

Re: [PATCH v2 10/24] uas: zap_pending: data urbs should have completed at this time

Hello. On 9/13/2014 1:26 PM, Hans de Goede wrote: The data urbs are all killed before calling zap_pending, and their completion handler should have cleared their inflight flag. Do not 0 the data inflight flags, and add a check for try_complete succeeding, as it should always succeed when

Re: [PATCH fix for 3.17 v2] uas: Add a quirk for rejecting ATA_12 and ATA_16 commands

Hello. On 9/13/2014 10:21 PM, Thomas Backlund wrote: And set this quirk for the Seagate Expansion Desk (0bc2:2312), as that one seems to hang upon receiving an ATA_12 or ATA_16 command. https://bugzilla.kernel.org/show_bug.cgi?id=79511 While at it also add missing documentation for the u

Re: [PATCH 1/2] xhci: Add broken-streams quirk for Fresco Logic FL1000G xhci controllers

Hello. On 12/5/2014 1:11 PM, Hans de Goede wrote: Streams do not work reliabe on Fresco Logic FL1000G xhci controllers, s/reliabe/reliably/? trying to use them results in errors like this: 21:37:33 kernel: xhci_hcd :04:00.0: ERROR Transfer event for disabled endpoint or

Re: [PATCH 26/28] blk_end_request: changing ide-cd (take 3)

PROTECTED] Cc: [EMAIL PROTECTED] Cc: Kiyoshi Ueda [EMAIL PROTECTED] Cc: Jun'ichi Nomura [EMAIL PROTECTED] Cc: Tejun Heo [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line

Re: [PATCH 1/3] Revert ata: make ata port as parent device of scsi host

Hello. On 27-09-2012 21:04, Gwendal Grignou wrote: This reverts commit 9a6d6a2ddabbd32c07f6a38b659e5f3db319fa5a. Instead, melt libata transport sysfs object in scsi objects. Change-Id: I8c709f63ddf7ba97b9e6f449d5c0b8b85e44e818 Remove this line please, it has no place in the upstream

Re: [PATCH 00/16] treewide: Convert dev_printk(KERN_LEVEL to dev_level(

Hello. On 28-10-2012 12:05, Joe Perches wrote: dev_level create smaller objects than dev_printk(KERN_LEVEL. Convert non-debug calls to this form. Joe Perches (16): tile: Convert dev_printk(KERN_LEVEL to dev_level( [...] tile: Convert dev_printk(KERN_LEVEL to dev_level( [...]

Re: [PATCH] Try #3: Use SCSI read/write(16) with 32-bit LBA drives

Hello. On 15-11-2012 2:03, Jason J. Herne wrote: From: Jason J. Herne hern...@gmail.com You have already posted Try #3. And preferrably, information about patch version should be included with [PATCH] prefix like this [PATCH v4]. Force large capacity ( 0x blocks) drives to use

Re: [PATCH v11 9/9] libata: do not suspend port if normal ODD is attached

Hello. On 06-01-2013 6:48, Aaron Lu wrote: For ODDs, the upper layer will poll for media change every a few seconds, which will make it enter and leave suspend state very oftern. And as each suspend will also cause a hard/soft reset, s/oftern/often/ the gain of runtime suspend is very

Re: [PATCH] Fix libata-eh don't retry command after reset succeeded.

Hello. On 01/14/2013 05:01 PM, Mark Lord wrote: From 9cc9a85f17a8525e53caf430611d762c105d324c Mon Sep 17 00:00:00 2001 From: Bian Yu ycbzzj...@gmail.com Date: Tue, 18 Dec 2012 05:58:34 -0500 Subject: [PATCH] Fix libata-eh don't retry command after reset succeeded. It's introduced by commit

Re: [PATCH/RESEND 2/2] Hard disk S3 resume time optimization

Hello. On 06-09-2013 4:44, Todd E Brandt wrote: Part 2 of the hard disk resume optimization patch, this one applies to the scsi subsystem. Don't give the same name to both patches. In this case, you could prefix the patch name with e.g. sd: . Signed-off-by: Todd Brandt

Re: [PATCH 2/6] libata: avoid waking disk to check power

Hello. On 10-11-2013 1:03, Phillip Susi wrote: When a disk is in SLEEP mode it can not respond to commands, including the CHECK POWER command. Instead of waking up the sleeping disk, fake the reply to the CHECK POWER command to indicate the disk is in standby mode. This prevents udisks from

Re: [PATCH 3/6] sd: don't bother spinning up disks on resume

Hello. On 10-11-2013 1:03, Phillip Susi wrote: Don't bother forcing disks to spin up on resume, as they will do so automatically when accessed, and forcing them to spin up slows down the resume. Add a second bit to the manage_start_stop flag to restore the previous behavior. ---

Re: [PATCH 4/6] libata: resume in the background

On 10-11-2013 1:03, Phillip Susi wrote: Don't block the resume path waiting for the disk to spin up. --- drivers/ata/libata-core.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 686c441..128ce0d

Re: [PATCH v2 0/5] ata: Add APM X-Gene SATA controller support

Hello. On 12-11-2013 19:40, Bartlomiej Zolnierkiewicz wrote: Please remember to include linux-...@vger.kernel.org on CC: for ATA patches. Also from the quick look it seems that: - patch #4 (ata: Add APM X-Gene SATA serdes functions) should come before patch #3 (ata: Add APM X-Gene SATA

Re: [PATCH v2 4/4] arm64: Add APM X-Gene SoC 6.0Gbps SATA PHY DTS entries

Hello. On 20-11-2013 3:53, Loc Ho wrote: arm64: Add APM X-Gene SoC 6.0Gbps SATA PHY DTS entries This patch adds the DTS entries for the APM X-Gene SoC 6.0Gbps SATA PHY driver. The PHY for controller 0 and 1 are enabled by default. Signed-off-by: Loc Ho l...@apm.com Signed-off-by: Tuan

Re: [PATCH v2 1/4] PHY: Add function set_speed to generic PHY framework

Hello. On 20=11-2013 3:53, Loc Ho wrote: PHY: Add function set_speed to generic PHY framework There's no need to duplicate the subject in the changelog verbatim. This patch adds function set_speed to the generic PHY framework operation structure. This function can be called to instruct

Re: [PATCH v3 4/4] arm64: Add APM X-Gene SoC 15Gbps Multi-purpose PHY DTS entries

Hello. On 26-11-2013 9:46, Loc Ho wrote: arm64: Add APM X-Gene SoC 15Gbps Multi-purpose PHY DTS entries As I already said, there's no need to repeat the patch summary line (the mail subject) in the changelog verbatim. This patch adds the DTS entries for the APM X-Gene SoC 15Gbps

Re: [PATCH 6/6] libata: return power status in REQUEST SENSE command

Hello. On 12/17/2013 02:30 AM, Phillip Susi wrote: SAT-3 says REQUEST SENSE should issue CHECK POWER and return a sense status indicating the drive's power status. --- drivers/ata/libata-scsi.c | 40 ++-- 1 file changed, 34 insertions(+), 6 deletions(-)

Re: [PATCH] libata: fix probe_ent alloc/free bugs

Hello. Tejun Heo wrote: ata_probe_ent_alloc() had a temporary hack such that devm_kzalloc() was used for allocation if devres had been previously initialized on the device; otherwise, plain kzalloc() was used. This was to make the code useable from both the old and devres-aware libata drivers

Re: [PATCH] libata: fix probe_ent alloc/free bugs

Hello. James Bottomley wrote: +probe_ent = devm_kzalloc(dev, sizeof(*probe_ent), GFP_KERNEL); if (!probe_ent) { printk(KERN_ERR DRV_NAME (%s): out of memory\n, kobject_name((dev-kobj))); [...] The patch certainly looks mangled tab-wise. :-) It isn't,

Re: impact of 4k sector size on the IO FS stack

Hello. Bryan Henderson wrote: DOS partitions start partitions on odd-numbered sectors I don't get this. If you mean partitions defined by the classic DOS partition table format, then AFAICS, such a partition can start in any sector. Only at logical cylinder boudary (except for the

Re: [PATCH 4/5] scsi: pm: use runtime resume callback if available

Hello. On 07/23/2012 10:49 AM, Aaron Lu wrote: When runtime resume a scsi device, if the device's driver has implemented runtime resume callback, use that instead of the resume callback. sr driver needs this to properly do different things for system resume and runtime resume.

Re: [PATCH v3 6/7] scsi: sr: balance sr disk events block depth

Hello. On 26-07-2012 14:05, Aaron Lu wrote: When the ODD is resumed, disk_unblock_events should be called when: 1 The ODD is runtime resumed; 2 System is resuming from S3 and the ODD is runtime suspended before S3; But not when the system is resuming from S3 and the ODD is runtime active

Re: [PATCH net v2 3/5] cxgb4i: handle non-pdu-aligned rx and additional types of negative advice

Hello. On 12/8/2014 12:58 PM, k...@chelsio.com wrote: [PATCH net v2 3/5] cxgb4i: handle non-pdu-aligned rx data and additional types of negative advice The patch summary shouldn't be duplicated in the change log, at least not like this... From: Karen Xie k...@chelsio.com - abort

Re: [PATCH net v3 1/6] cxgb4i: fix tx credit calculation

Hello. On 12/09/2014 08:32 PM, Karen Xie wrote: [PATCH net v3 1/6] cxgb4i: fix tx credit calculation From: Karen Xie k...@chelsio.com - Only data skbs need the wr header added while control skbs do not. Make sure they are treated differently. - Any credit related checking should be done

Re: [PATCH net v5 2/7] cxgb4i: fix credit check for tx_data_wr

Hello. On 12/10/2014 4:43 AM, Karen Xie wrote: [PATCH net v5 2/7] cxgb4i: fix credit check for tx_data_wr From: Karen Xie k...@chelsio.com make sure any tx credit related checking is done before adding the wr header. Signed-off-by: Karen Xie k...@chelsio.com ---

Re: [PATCH net v6 7/7] libcxgbi: free skb after debug prints

Hello. On 12/10/2014 07:25 PM, Karen Xie wrote: [PATCH net v6 7/7] libcxgbi: free skb after debug prints Please, do not duplicate the subject in the changelog -- DaveM would have to edit it out by hand. From: Karen Xie k...@chelsio.com The debug print was accessing the skb after it

Re: [PATCH 2/2] ahci_xgene: Fix the dma state machine lockup for the ATA_CMD_PACKET PIO mode command.

Hello. On 12/16/2014 07:49 PM, Suman Tripathi wrote: This patch addresses the issue with ATA_CMD_PACKET pio mode command for enumeration and device detection with ATAPI devices.It is the same issue as in patch www.spinics.net/lists/linux-ide/msg49092.html Signed-off-by: Suman Tripathi

Re: [PATCH 2/2] ahci_xgene: Fix the dma state machine lockup for the ATA_CMD_PACKET PIO mode command.

Hello. On 12/17/2014 08:21 AM, Suman Tripathi wrote: This patch addresses the issue with ATA_CMD_PACKET pio mode command for enumeration and device detection with ATAPI devices.It is the same issue as in patch Ugh, HTML... Please stick to plain text when posting to the

Re: [PATCH 2/2] ahci_xgene: Fix the dma state machine lockup for the ATA_CMD_PACKET PIO mode command.

Hello. On 12/29/2014 8:35 AM, Suman Tripathi wrote: This patch addresses the issue with ATA_CMD_PACKET pio mode command for enumeration and device detection with ATAPI devices.It is the same issue as in patch Ugh, HTML... Please stick to plain text when

Re: [PATCH v1] ahci_xgene: Fix the dma state machine lockup for the ATA_CMD_SMART PIO mode command.

Hello. On 2/2/2015 1:18 PM, Suman Tripathi wrote: This patch addresses the issue with ATA_CMD_SMART pio mode command for enumeration and device detection with ATA devices. The X-Gene AHCI controller has an errata in which it cannot clear the BSY bit after the PIO setup FIS. The dma state

Re: [PATCH v3] ahci_xgene: Fix the dma state machine lockup for the ATA_CMD_SMART PIO mode command.

On 02/02/2015 10:37 PM, Suman Tripathi wrote: Ugh, please avoid using HTML when posting to the lists hosted on vger.kernel.org -- it's configured to ignore such mails AFAIK. This patch addresses the issue with ATA_CMD_SMART pio mode command for enumeration and device detection

Re: [PATCH v2] ahci_xgene: Fix the dma state machine lockup for the ATA_CMD_SMART PIO mode command.

Hello. On 02/02/2015 02:57 PM, Suman Tripathi wrote: This patch addresses the issue with ATA_CMD_SMART pio mode command for enumeration and device detection with ATA devices. The X-Gene AHCI controller has an errata in which it cannot clear the BSY bit after the PIO setup FIS. The dma state

Re: [PATCH v3] ahci_xgene: Fix the dma state machine lockup for the ATA_CMD_SMART PIO mode command.

Hello. On 02/02/2015 09:07 PM, Suman Tripathi wrote: This patch addresses the issue with ATA_CMD_SMART pio mode command for enumeration and device detection with ATA devices. The X-Gene AHCI controller has an errata in which it cannot clear the BSY bit after the PIO setup FIS. The dma state

Re: [PATCH 1/2] ahci_xgene: Fix the xgene_ahci_restart_engine function to support Port Multiplier for APM X-Gene SoC AHCI SATA host controller driver.

Hello. On 1/5/2015 1:21 PM, Suman Tripathi wrote: Your patch summary seems too long. This patch implements the function xgene_ahci_poll_reg_val to poll PxCI for multiple IDENTIFY DEVICE commands to finish before restarting the DMA engine in case of Port Multiplier. Signed-off-by: Suman

Re: [PATCH 02/14] ALSA: portman2x4: return proper error values from attach

Hello. On 4/8/2015 2:20 PM, Sudip Mukherjee wrote: now that we are monitoring the return value from attach, make the So you've first changed the method prototype and follow up with the changes to the actual implementations? That's backward. I'm afraid such changes can't be done

Re: [PATCH] uas: Limit qdepth at the scsi-host level

Hello. On 3/19/2016 11:59 AM, Hans de Goede wrote: Commit 64d513ac31bd ("scsi: use host wide tags by default") causes the scsi-core to queue more cmnds then we can handle on devices with SCSI core? Commands? multiple LUNs, limit the qdepth at the scsi-host level instead of Queue

Re: [PATCH 08/14] libata: evaluate SCSI sense code

On 4/4/2016 12:44 PM, Hannes Reinecke wrote: Whenever a sense code is set it would need to be evaluated to update the error mask. Signed-off-by: Hannes Reinecke --- drivers/ata/libata-eh.c | 28 +++- drivers/scsi/scsi_error.c | 3 ++-

Re: [PATCH 03/14] libata-scsi: sanitize ata_gen_ata_sense()

On 4/4/2016 12:43 PM, Hannes Reinecke wrote: ata_to_sense_error() is called conditionally, so we should be generating a default sense if the condition is not met. Signed-off-by: Hannes Reinecke --- drivers/ata/libata-scsi.c | 6 ++ 1 file changed, 6 insertions(+) diff

Re: [PATCH 3/4] libata: support device-managed ZAC devices

Hello. On 4/4/2016 12:47 PM, Hannes Reinecke wrote: Device-managed ZAC devices just set the zoned capabilities field in INQUIRY byte 69 (cf ACS-4). This corresponds to the 'zoned' field in the block device characteristics VPD page. As this is only defined in SPC-5/SBC-4 we also need to update

Re: [PATCH 03/14] libata-scsi: sanitize ata_gen_ata_sense()

On 04/04/2016 07:22 PM, Tejun Heo wrote: + } else { + /* Could not decode error */ + ata_dev_warn(dev, "could not decode error status 0x%x err_mask 0x%x\n", "%#x" is equivalent and takes up less space. Oops, gmail for some reason put Sergei's messages

Re: [PATCHv3 13/14] libata: support device-managed ZAC devices

Hello. On 4/25/2016 1:45 PM, Hannes Reinecke wrote: Device-managed ZAC devices just set the zoned capabilities field in INQUIRY byte 69 (cf ACS-4). This corresponds to the 'zoned' field in the block device characteristics VPD page. As this is only defined in SPC-5/SBC-4 we also need to update

Re: [PATCH resend 1/5] libata-scsi: minor cleanup in ata_mselect_*()

Hello. On 07/21/2016 09:41 PM, tom.t...@gmail.com wrote: From: Tom Yan 1. Removed a repeated bit masking in ata_mselect_control() 2. Moved `wce`/`d_sense` assignment below the page validity checks 3. Added/Removed empty lines where appropriate Signed-off-by: Tom Yan

Re: [PATCH v2 2/2] libata-core: do not set dev->max_sectors for LBA48 devices

Hello. On 08/09/2016 05:45 PM, tom.t...@gmail.com wrote: From: Tom Yan Currently block layer limit max_hw_sectors is set to ATA_MAX_SECTORS_LBA48 (65535), for devices with LBA48 support. However, block layer limit max_sectors (which is the effective one; also adjustable,

Re: [PATCH 1/2] libata-scsi: use dev->max_sectors from libata-core appropriately

On 08/12/2016 02:56 PM, tom.t...@gmail.com wrote: From: Tom Yan Currently we use dev->max_sectors to set max_hw_sectors, which is actually supposed to be a host controller limit (that get set Gets. by the host controller driver like ahci, and if not it would be the

Re: [PATCH 1/2] libata-scsi: use dev->max_sectors from libata-core appropriately

Hello. On 8/12/2016 5:36 PM, Tom Yan wrote: diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index be9c76c..4e2d8e7 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -1204,14 +1204,26 @@ static int ata_scsi_dev_config(struct scsi_device *sdev,

Re: [PATCH v2 2/2] libata-scsi: better style in ata_msense_caching()

Hello. On 7/12/2016 4:28 PM, tom.t...@gmail.com wrote: From: Tom Yan Signed-off-by: Tom Yan diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index bfec66f..6f7c626 100644 --- a/drivers/ata/libata-scsi.c +++

Re: [PATCH 2/2] libata-scsi: do not response with "invalid field" for FORMAT UNIT

On 07/04/2016 11:53 PM, tom.t...@gmail.com wrote: From: Tom Yan It does not make sense and is confusing to response with "Invalid Respond here and in the subject. field in cbd" while we have no support at all implemented for FORMAT UNIT. It is decent to let it go to

Re: [PATCH 2/2] libata-scsi: do not response with "invalid field" for FORMAT UNIT

On 07/05/2016 12:27 AM, Sergei Shtylyov wrote: From: Tom Yan <tom.t...@gmail.com> It does not make sense and is confusing to response with "Invalid Respond here and in the subject. field in cbd" while we have no support at all implemented for CDB. FORMAT UNIT. It

Re: [PATCH 1/2] libata-scsi: improve TRIM translation

On 07/04/2016 11:53 PM, tom.t...@gmail.com wrote: From: Tom Yan Define TRIM_RANGE_SIZE and TRIM_RANGE_NUM so that the corresponding functions can be more generalized. Also, conform SBC by rejecting Conform to SBC, perhaps? WRITE SAME (16) commands with number of

Re: [PATCH v2 1/2] libata-scsi: improve TRIM translation

Hello. On 7/5/2016 9:45 AM, tom.t...@gmail.com wrote: From: Tom Yan Define TRIM_RANGE_SIZE and TRIM_RANGE_NUM so that the corresponding functions can be more generalized. Also, conform to SBC by rejecting WRITE SAME (16) commands with number of blocks that exceeds the

Re: [PATCH v2 2/2] libata-scsi: do not respond with "invalid field" for FORMAT UNIT

On 7/5/2016 9:45 AM, tom.t...@gmail.com wrote: From: Tom Yan It does not make sense and is confusing to respond with "Invalid field in CDB" while we have no support at all implemented for FORMAT UNIT. It is decent to let it go to the default, which will respond with

Re: [PATCH 2/2] libata-scsi: better style in ata_msense_caching()

On 07/07/2016 03:44 PM, Tom Yan wrote: Sorry I am a bit new in this. Does that mean I should also use {} for the if clause even it has only one line of statement, because I (needed to) use that for the else clause? So it should be like: if ... { ... } else { ... ... }

Re: [PATCH v3 1/2] libata-scsi: reject WRITE SAME (16) with n_block that exceeds limit

On 07/06/2016 07:44 PM, tom.t...@gmail.com wrote: From: Tom Yan Currently if a WRITE SAME (16) command is issued to the SATL with "number of blocks" that is larger than the "Maximum write same length" (which is the maximum number of blocks per TRIM command allowed in

Re: [PATCH 2/2] libata-scsi: do not return t10 designator if drive has WWN

Hello. On 7/7/2016 1:12 AM, tom.t...@gmail.com wrote: From: Tom Yan SAT (as of sat4r05f.pdf) only requires the t10 designator if the drive does not support/have WWN. Besides, we already have the ATA information VPD. Signed-off-by: Tom Yan diff --git

Re: [PATCH 2/2] libata-scsi: better style in ata_msense_caching()

On 7/7/2016 4:43 AM, tom.t...@gmail.com wrote: From: Tom Yan Signed-off-by: Tom Yan diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index bfec66f..e3f5751 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@

Re: [PATCH resend v2 3/5] libata-scsi: use u8 array to store mode page copy

Hello. On 7/22/2016 2:29 AM, tom.t...@gmail.com wrote: From: Tom Yan ata_mselect_*() would initialize a char array for storing a copy of the current mode page. However, char could be signed char. In that case, bytes larger than 127 would be converted to negative number.

Re: [PATCH 11/29] drivers, media: convert cx88_core.refcount from atomic_t to refcount_t

Hello. On 03/06/2017 05:20 PM, Elena Reshetova wrote: refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by:

Re: [PATCH 11/29] drivers, media: convert cx88_core.refcount from atomic_t to refcount_t

On 3/7/2017 10:52 AM, Reshetova, Elena wrote: refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena

Re: [PATCH v4 08/19] scsi: be2iscsi: Replace PCI pool old API

On 3/1/2017 6:55 PM, Romain Perier wrote: The PCI pool API is deprecated. This commits replaces the PCI pool old Commit. API by the appropriated function with the DMA pool API. Appropriate perhaps? Signed-off-by: Romain Perier Acked-by: Peter Senna

Re: [PATCH v4 09/19] scsi: csiostor: Replace PCI pool old API

Hello! On 3/1/2017 6:55 PM, Romain Perier wrote: The PCI pool API is deprecated. This commits replaces the PCI pool old Commit. API by the appropriated function with the DMA pool API. It also updates Appropriate perhaps? the name of some variables and the content of comments,

Re: [PATCH 4/6] libata: factor out a ata_identify_page_supported helper

Hello! On 06/04/2017 03:42 PM, Christoph Hellwig wrote: Signed-off-by: Christoph Hellwig --- drivers/ata/libata-core.c | 59 +-- 1 file changed, 32 insertions(+), 27 deletions(-) diff --git a/drivers/ata/libata-core.c

Re: [PATCH V8 5/5] libata: Align DMA buffer to dma_get_cache_alignment()

On 10/17/2017 11:05 AM, Huacai Chen wrote: In non-coherent DMA mode, kernel uses cache flushing operations to maintain I/O coherency, so in ata_do_dev_read_id() the DMA buffer should be aligned to ARCH_DMA_MINALIGN. Otherwise, If a DMA buffer and a kernel structure share a same cache line, and

Re: [PATCH 6/6] scsi: Check sense buffer size at build time

Hello! On 5/22/2018 9:15 PM, Kees Cook wrote: To avoid introducing problems like those fixed in commit f7068114d45e ("sr: pass down correctly sized SCSI sense buffer"), this creates a macro wrapper for scsi_execute() that verifies the size of the sense buffer similar to what was done for