Hello,
On Tue, Oct 08, 2013 at 11:07:16AM +0200, Alexander Gordeev wrote:
Multipe MSIs is just a handful of drivers, really. MSI-X impact still
Yes, so it's pretty nice to try out things there before going full-on.
will be huge. But if we opt a different name for the new pci_enable_msix()
Hey, guys.
On Tue, Nov 19, 2013 at 04:53:16PM -0700, Loc Ho wrote:
This patch adds support for APM X-Gene SoC 6.0Gbps SATA PHY. This is the
physical layer interface for the corresponding SATA host controller. This
driver uses the new PHY generic framework posted by Kishon Vijay Abrahm.
Hmm...
Hello, Arnd.
On Wed, Nov 20, 2013 at 10:41 AM, Arnd Bergmann a...@arndb.de wrote:
It needs to be in drivers/phy, which is currently being prepared for
the next merge window and which contains the generic interface used
in this driver.
Ah, cool, so I don't need to worry about this one, right?
Hello, guys.
(cc'ing Greg)
On Fri, Dec 13, 2013 at 01:19:36PM -0500, Alan Stern wrote:
On Fri, 13 Dec 2013, Sarah Sharp wrote:
Given the way things work now, I suspect these warnings are truly
harmless. We could simply get rid of the WARN in sysfs_remove_group.
The alternative
On Mon, Nov 11, 2013 at 12:08:49PM -0500, Phillip Susi wrote:
No, I did not tune my system; I fixed the kernel so that userspace's
activities do not start those disks.
So, umm, implementing things in kernel to facilitate userland is great
but please don't try to work around userland from
driver-core now supports synchrnous self-deletion of attributes and
the asynchrnous removal mechanism is scheduled for removal. Use it
instead of device_schedule_callback(). This makes delete behave
synchronously.
Signed-off-by: Tejun Heo t...@kernel.org
Cc: James E.J. Bottomley jbottom
driver-core now supports synchrnous self-deletion of attributes and
the asynchrnous removal mechanism is scheduled for removal. Use it
instead of device_schedule_callback(). This makes delete behave
synchronously.
Signed-off-by: Tejun Heo t...@kernel.org
Cc: James E.J. Bottomley jbottom
driver-core now supports synchrnous self-deletion of attributes and
the asynchrnous removal mechanism is scheduled for removal. Use it
instead of device_schedule_callback(). This makes delete behave
synchronously.
Signed-off-by: Tejun Heo t...@kernel.org
Cc: James E.J. Bottomley jbottom
Hello,
On Tue, Jan 07, 2014 at 04:56:07PM -0800, Todd E Brandt wrote:
On resume, the ATA port driver currently waits until the AHCI controller
finishes executing the port wakeup command. This patch changes the
Is there anything ahci specific about this? There shouldn't be.
This patch only
Hello, David.
On Fri, Jan 10, 2014 at 02:07:21PM -0600, David Milburn wrote:
Tejun, to avoid some of the interrupt handling code duplication, would
it better to have a AHCI_HFLAG_FLUSH and then change
this driver to set flush
hpriv-hpriv.flush = (void *) xgene_ahci_iob_flush;
and then
Hello,
On Sat, Jan 11, 2014 at 07:58:04PM -0800, Loc Ho wrote:
The flush has to occurred immediately after reading the CI
register. It can not wrap around the isr routine and issue the flush
after or before the library ahci isr routine.
I see. So, you're saying that if PMP support is
Hello, Loc.
On Sun, Jan 12, 2014 at 08:01:59PM -0800, Loc Ho wrote:
Yes but Let me summary what overrides are required for this X-Gene
SATA controller driver:
1. For Query ID, these two functions - ahci_read_id and ahci_qc_issue
requires override.
But the comment in ahci_qc_issue() says
Hello,
On Mon, Jan 13, 2014 at 11:55:44AM -0800, Todd E Brandt wrote:
I see your point, why have two paths if one will do. The only thing that
worries me is that the PM resume from hibernate function doesn't have
an error handler. What happens when it tries to read the image from swap
and the
Hello, Todd.
On Mon, Jan 13, 2014 at 03:30:26PM -0800, Todd E Brandt wrote:
Ahh, sorry, yea I think async should work for the entire resume pathway. Would
you be willing to accept this ata patch separately from the scsi one? It
wouldn't provide any performance benefit on its own, but would
Hello, Gwendal.
On Mon, Jan 13, 2014 at 04:36:52PM -0800, Gwendal Grignou wrote:
Won't this patch defeat staggered spinup at resume? If you have a jbod
with a smallish power supply, with a 12V rail designed for the steady
state and 1 or 2 devices spinning up at once, you may be in trouble
Hey,
On Tue, Jan 14, 2014 at 07:57:19AM -0800, Loc Ho wrote:
No, they don't and the comments in your driver don't really explain
what's going on. Why are we having retry loops inside hardreset
itself? This can prolong recovery time significantly in corner cases.
Why is this necessary?
On Tue, Jan 14, 2014 at 11:03:12AM -0500, Tejun Heo wrote:
As mentioned, the flush requires immediately after reading the CI.
Otherwise, there is still an chance that the command is completed and
the OS notified the upper layer while the data is still in flight. For
the initial version, I
On Tue, Jan 14, 2014 at 08:21:28AM -0800, Loc Ho wrote:
In the ISR, the AHCI library code reads the CI register and then
performs XOR to determine which commands are completed. Then it goes
and processes the completed command(s). I am worry that the process of
processing the completed
On Tue, Jan 14, 2014 at 08:37:18AM -0800, Loc Ho wrote:
This issue has NOT been observed but the design has this issue and
observed from verification. As a mean to ensure that this never occur
from design itself, this is the workaround and only apply to SATA and
SDIO. The SDIO don't need this
Please start a new thread when you're posting a new version of the
whole series don't use the same patch title for the patches. They
do different things. They need different names.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a
Hello,
On Tue, Jan 14, 2014 at 04:31:40PM -0800, Todd E Brandt wrote:
Signed-off-by: Todd Brandt todd.e.bra...@intel.com
Signed-off-by: Arjan van de Ven ar...@linux.intel.com
drivers/ata/libata-core.c | 32 +---
1 file changed, 17 insertions(+), 15
Hello,
On Fri, Jan 17, 2014 at 11:16:49AM +0100, Oliver Neukum wrote:
The START-STOP may result in an error. What do you do in that case?
At least for libata, worrying about suspend/resume failures don't make
whole lot of sense. If suspend failed, just proceed with suspend. If
the device
Hello, James.
On Fri, Jan 17, 2014 at 10:39:37AM -0800, James Bottomley wrote:
The specific worry is the writeback cache. If the flush fails and we
power down with dirty blocks in the cache, those blocks are lost but the
filesystem still thinks they're committed. I think as long as you're
On Fri, Jan 17, 2014 at 03:15:54PM -0500, Alan Stern wrote:
You will have to argue this point with Phillip.
If necessary, we could add a sysfs attribute to force a spin-up during
system resume. Or you could disable runtime PM for the disk, but that
has its own disadvantages.
Isn't
Hello,
On Fri, Jan 17, 2014 at 08:41:00PM -0500, Alan Stern wrote:
The intention is that this will help on systems with more than one
disk drive. The one containing the core OS files and the journal will
certainly spin up right away, but the others may not.
To tell the truth, I'm not sure
Hello, Phillip.
On Fri, Jan 17, 2014 at 03:55:30PM -0500, Phillip Susi wrote:
What kind of use cases are we expecting for the lazy behavior?
Not all systems only have a single drive. There may be a tendency for
IO to the drive with the root fs on it after a resume, but multi drive
systems
pretty
much too late.
Tejun, if you want to ack that one, I can put it in either the first
3.14 pull request or a subsequent one. Either way, since it's a
regression fix, we should be able to get it in 3.14.
Acked-by: Tejun Heo t...@kernel.org
Please feel free to route it any way you see
driver-core now supports synchrnous self-deletion of attributes and
the asynchrnous removal mechanism is scheduled for removal. Use it
instead of device_schedule_callback(). This makes delete behave
synchronously.
Signed-off-by: Tejun Heo t...@kernel.org
Cc: James E.J. Bottomley jbottom
driver-core now supports synchrnous self-deletion of attributes and
the asynchrnous removal mechanism is scheduled for removal. Use it
instead of device_schedule_callback(). This makes delete behave
synchronously.
Signed-off-by: Tejun Heo t...@kernel.org
Cc: James E.J. Bottomley jbottom
Hello, Loc.
On Thu, Feb 13, 2014 at 03:28:01PM -0800, Loc Ho wrote:
1. There are a number of errata that require workaround. Some can be
fixed by adding broken flags while others are better to just wrap
around the existent libahci library routines and not overly polluting
the libahci
PREPARE_DELAYED_WORK().
It would probably be best to route this with other related updates
through the workqueue tree.
Compile tested.
Signed-off-by: Tejun Heo t...@kernel.org
Cc: Stefan Richter stef...@s5r6.in-berlin.de
Cc: linux1394-de...@lists.sourceforge.net
Cc: Chris Boot bo...@bootc.net
Cc: linux-scsi
On Thu, Feb 20, 2014 at 09:07:27PM -0500, Peter Hurley wrote:
On 02/20/2014 08:59 PM, Tejun Heo wrote:
Hello,
On Thu, Feb 20, 2014 at 08:44:46PM -0500, Peter Hurley wrote:
+static void fw_device_workfn(struct work_struct *work)
+{
+ struct fw_device *device = container_of(to_delayed_work
On Fri, Feb 21, 2014 at 12:13:16AM -0500, Peter Hurley wrote:
CPU 0| CPU 1
|
INIT_WORK(fw_device_workfn) |
|
workfn = funcA |
queue_work_on() |
.
Yo,
On Fri, Feb 21, 2014 at 11:53:46AM -0500, Peter Hurley wrote:
Ok, I can do that. But AFAIK it'll have to be an smp_rmb(); there is
no mb__after unlock.
We do have smp_mb__after_unlock_lock().
[ After thinking about it some, I don't think preventing speculative
writes before clearing
On Fri, Feb 21, 2014 at 06:01:29PM -0500, Peter Hurley wrote:
smp_mb__after_unlock_lock() is only for ordering memory operations
between two spin-locked sections on either the same lock or by
the same task/cpu. Like:
i = 1
spin_unlock(lock1)
spin_lock(lock2)
Hello, Loc.
Almost there. Just one more thing.
On Sun, Feb 23, 2014 at 10:54:24PM -0700, Loc Ho wrote:
+static int xgene_ahci_init_memram(struct xgene_ahci_context *ctx)
+{
+ void __iomem *diagcsr = ctx-csr_base + SATA_DIAG_OFFSET;
+ int try;
+ u32 val;
+
+ val =
Hey,
On Mon, Feb 24, 2014 at 05:02:52PM -0800, Loc Ho wrote:
The completion of the RAM removal from shutdown is quite fast. As per
spec, the max time is 1ms but from the run-time code, it only take one
(1us) or two (2us) read for this to completed. An 1 ms hard delay is more
than 100 time
PREPARE_DELAYED_WORK().
This fixes a variety of possible regressions since a2c1c57be8d9
workqueue: consider work function when searching for busy work items
due to which fw_workqueue lost its required non-reentrancy property.
Signed-off-by: Tejun Heo t...@kernel.org
Acked-by: Stefan Richter stef...@s5r6
Hello,
On Wed, Mar 05, 2014 at 12:17:30PM -0800, Dan Williams wrote:
+#define ata_port_resume_sync(ap, msg) ata_port_resume_common((ap), (msg),
false)
+#define queue_ata_port_resume(ap, msg) ata_port_resume_common((ap), (msg),
true)
Let's please use proper static functions. The compiler
On Fri, Mar 07, 2014 at 06:52:06PM -0800, Dan Williams wrote:
From: Dan Williams dan.j.willi...@intel.com
async_schedule() sd resume work to allow disks and other devices to
resume in parallel.
This moves the entirety of scsi_device resume to an async context to
ensure that
On Mon, Mar 10, 2014 at 04:29:47PM -0400, Tejun Heo wrote:
Let's please use proper static functions. The compiler can deal with
inlining. Also, maybe ata_port_resume() and ata_port_resume_async()
are better names for the wrappers?
So, if the suggested names don't jive well with the rest
On Sun, Mar 09, 2014 at 10:23:33PM -0700, Loc Ho wrote:
Hi Tejun,
On Fri, Mar 7, 2014 at 9:28 AM, Loc Ho l...@apm.com wrote:
This patch adds the DTS entries for the APM X-Gene SoC 15Gbps Multi-purpose
PHY driver. The PHY for SATA controller 2 and 3 are enabled by default.
On Wed, Mar 05, 2014 at 03:44:49PM -0700, Loc Ho wrote:
This patch adds APM X-Gene SoC AHCI SATA host controller DTS entries.
I pulled the phy branch into libata/for-3.15 but this patch fails to
apply. Can you please regenerate the patches which need to be applied
on top of libata/for-3.15.
Hello, Loc.
On Tue, Mar 11, 2014 at 08:51:37AM -0700, Loc Ho wrote:
Kishon didn't applied the PHY DTS patch. Did you first apply the PHY
DTS patch? We agreed that you will first pull in the PHY DTS as well
as the host controller patches. I don't see any reason why it wouldn't
apply if both
On Fri, Mar 14, 2014 at 05:53:17PM -0600, Loc Ho wrote:
This patch adds support for the APM X-Gene SoC AHCI SATA host controller. In
order for the host controller to work, the corresponding PHY driver
musts also be available. Currently, only Gen3 disk is supported with this
initial version.
://marc.info/?l=linux-scsim=138995409532286w=2
Cc: Phillip Susi ps...@ubuntu.com
Cc: Alan Stern st...@rowland.harvard.edu
Suggested-by: Tejun Heo t...@kernel.org
Signed-off-by: Todd Brandt todd.e.bra...@intel.com
Signed-off-by: Dan Williams dan.j.willi...@intel.com
Can somebody ack the sas
On Tue, Mar 18, 2014 at 12:14:37PM -0600, Loc Ho wrote:
This patch fixes an compiler warning with APM X-Gene host controller
driver when compiled with DEBUG enabled.
Signed-off-by: Loc Ho l...@apm.com
Applied to libata/for-3.15.
Thanks.
--
tejun
--
To unsubscribe from this list: send the
://marc.info/?l=linux-scsim=138995409532286w=2
Cc: Phillip Susi ps...@ubuntu.com
Cc: Alan Stern st...@rowland.harvard.edu
Suggested-by: Tejun Heo t...@kernel.org
Signed-off-by: Todd Brandt todd.e.bra...@intel.com
Signed-off-by: Dan Williams dan.j.willi...@intel.com
Applied 1-2 to libata
On Wed, Mar 19, 2014 at 10:46:25AM -0700, Randy Dunlap wrote:
From: Randy Dunlap rdun...@infradead.org
Fix build error when CONFIG_PM is not enabled by adding a stub
function in linux/libata.h.
drivers/scsi/libsas/sas_ata.c: In function 'sas_resume_sata':
On Wed, Mar 19, 2014 at 11:14:15AM -0700, Dan Williams wrote:
Subject: libata: remove unused ata_sas_port_async_resume() stub
From: Dan Williams dan.j.willi...@intel.com
Commit bc6e7c4b0d1a libata, libsas: kill pm_result and related cleanup
renamed ata_sas_port_async_resume() to
On Thu, Apr 24, 2014 at 09:27:03PM +0800, Xiangliang Yu wrote:
This patch set will support SATA port multiplier(PM) in LIBSAS.
LIBSAS is need to implement several key handling to support SATA PM:
First,low level driver notify libsas that SATA PM is attached to HBA port.
Then, LIBSAS will
Justin Piszcz wrote:
On Thu, 5 Apr 2007, Justin Piszcz wrote:
Had a quick question, this is the first time I have seen this happen,
and it was not even under during heavy I/O, hardly anything was going
on with the box at the time.
.. snip ..
# /usr/bin/time badblocks -b 512 -s -v
James Bottomley wrote:
On Tue, 2007-04-17 at 11:20 -0400, Jeff Garzik wrote:
then, unless there are dependencies in libata-dev, how about Tejun
pushes patches 3-4 through scsi-misc as well?
Sure ... as long as there are no dependencies.
James, are you going to rebase scsi-misc-2.6 before
Kristen Carlson Accardi wrote:
Send an uevent to user space to indicate that a media change event has
occurred.
Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED]
Index: 2.6-git/block/genhd.c
===
---
Frank van Maarseveen wrote:
On Fri, May 04, 2007 at 10:16:32AM +0200, Tejun Heo wrote:
Michal Piotrowski wrote:
On 01/05/07, Mark Lord [EMAIL PROTECTED] wrote:
Forwarding to linux-scsi and linux-ide mailing lists.
Frank van Maarseveen wrote:
Tested on 2.6.20.6 and 2.6.21.1
I decided
Kristen Carlson Accardi wrote:
This patch series implements Asynchronous Notification (AN) for SATA
ATAPI devices as defined in SATA 2.5 and AHCI 1.1 and higher. Drives
which support this feature will send a notification when new media is
inserted and removed, preventing the need for user
Hello, Henrique.
Henrique de Moraes Holschuh wrote:
On Mon, 14 May 2007, Francesco Pretto wrote:
Ubuntu [1] ang Gentoo [2] bugs opened. Sent a mail to Miquel van
Smoorenburg, dev of sysvinit.
For all Debian sysvinit issues, please send email to
[EMAIL PROTECTED] (added to CC).
For the
Alan Stern wrote:
This patch (as909) fixes a couple of refcounting errors in the sd
driver's suspend and resume methods.
Signed-off-by: Alan Stern [EMAIL PROTECTED]
Acked-by: Tejun Heo [EMAIL PROTECTED]
Thanks.
--
tejun
-
To unsubscribe from this list: send the line unsubscribe linux-scsi
Kristen Carlson Accardi wrote:
Hi,
This series of patches enables Aggressive Link Power Management for AHCI
devices, as documented in the AHCI spec. On my laptop (a Lenovo X60), this
saves me a full watt of power. On other systems, reported power savings
range from .5-1.5 Watts. It has
Arjan van de Ven wrote:
I'm not sure about this. We need better PM framework to support
powersaving in other controllers and some ahcis don't save much
when only link power management is used,
do you have data to support this?
Yeah, it was some Lenovo notebook. Pavel is more familiar
Arjan van de Ven wrote:
The data we have from this patch is that it saves typically a Watt of
power (depends on the machine of course, but the range is 0.5W to
1.5W). If you want to also have an even more agressive thing where
you want to start disabling the entire controller... I don't see
Matthew Garrett wrote:
On Tue, Jun 12, 2007 at 11:17:14AM -0300, Henrique de Moraes Holschuh wrote:
On Tue, 12 Jun 2007, Matthew Garrett wrote:
Laptop bays are designed to deal with hotplugging PATA - I don't think
this is too much of an issue :)
The new SATA ones use the SATA hardware
Kristen Carlson Accardi wrote:
I'm not sure about this. We need better PM framework to support
powersaving in other controllers and some ahcis don't save much
when only link power management is used,
do you have data to support this?
Yeah, it was some Lenovo notebook. Pavel is more
Jens Axboe wrote:
1. It didn't have proper interface with userland. This was mainly
because of missing ATA sysfs nodes. I'm not sure whether adding this to
scsi node is a good idea.
2. It was focused on SATA link PS and couldn't cover the Lenovo case.
I think we need something at the
Salyzyn, Mark wrote:
Updated patch to address overlap with patches introduced by FUJITA
Tomonori [EMAIL PROTECTED]. Tejun, please inspect.
I'm sorry but this patch is really out of my hand. James?
--
tejun
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a
Michael Tokarev wrote:
[Offtopic notice: For the first time I demonstrated some
speed testing results on linux-ide mailinglist, as a
demonstration how [NT]CQ can help. But later, someone
becomes curious and posted that email to lkml, asking
for more details. Since that, I become more
Hello,
Michael Tokarev wrote:
Well. It looks like the results does not depend on the
elevator. Originally I tried with deadline, and just
re-ran the test with noop (hence the long delay with
the answer) - changing linux elevator changes almost
nothing in the results - modulo some random
[cc'ing Albert]
Vasily Averin wrote:
Tejun, Jeff
I've noticed that some scsi commands for DVD-drive attached to pata_via
successfully finishes without any delays but reports about TIMEOUT condition.
It
happens because of ATA_ERR bit is set in status register. As result for each
command
Vasily Averin wrote:
Albert Lee wrote:
Vasily Averin wrote:
I've noticed that some scsi commands for DVD-drive attached to pata_via
successfully finishes without any delays but reports about TIMEOUT
condition. It
happens because of ATA_ERR bit is set in status register. As result for
each
Jeff Garzik wrote:
Any chance the SCSI peeps could ACK this, and then let me include it in
the ALPM patchset in the libata tree?
ATA link PS is pretty complex with HIPM, DIPM and AHCI ALPM. I'm not
sure whether this three level knob would be sufficient. It might be
good enough if we're gonna
Arjan van de Ven wrote:
On Tue, 2007-07-31 at 15:27 +0900, Tejun Heo wrote:
Jeff Garzik wrote:
Any chance the SCSI peeps could ACK this, and then let me include it in
the ALPM patchset in the libata tree?
ATA link PS is pretty complex with HIPM, DIPM and AHCI ALPM. I'm not
sure whether
Arjan van de Ven wrote:
either sucks. AHCI ALPM ought to work if it's supported; it's what other
operating systems also use...
A question. Does the other OS enable ALPM without checking against
white/black list? Or is it enabled only on certain configurations -
e.g. specific notebooks, etc?
Hello, Kristen.
Kristen Carlson Accardi wrote:
On Tue, 31 Jul 2007 23:45:25 +0900
Tejun Heo [EMAIL PROTECTED] wrote:
Anyways, I don't really think this attribute belongs to SCSI sysfs
hierarchy. There currently isn't any alternative but sysfs is part of
userland visible interface
Kristen Carlson Accardi wrote:
I think what you are saying is that you'd like a way to use your HIPM
and DIPM without ALPM on the AHCI driver. Fine - it's really easy
to add these levels later - if they don't make sense at the sysfs interface
we can add module params to specify the definition
Arjan van de Ven wrote:
They were hardware problems. I don't think any amount of proper
implementation can fix them. I have one DVD RAM somewhere in my pile of
hardware which locks up solidly if any link PS mode is used and had a
and the AHCI ALPM code decides to use power savings on this
Kristen Carlson Accardi wrote:
So at current rate of development and kernel release schedule, the best
possible scenario is still 6 months away - whereas this patchset is already
tested and ready for merging now.
The best possible scenario is .24-rc1 merge window with or without
waiting.
Kristen Carlson Accardi wrote:
I don't think the interface you're suggesting is a good one. Do you?
I think if it's applicable to SCSI at all it is fine. If it is not, then
I think we need to make do with the interface we are given. I do not think
we should hold up a feature for libata
Kristen Carlson Accardi wrote:
libata drivers can define a function (enable_pm) that will
perform hardware specific actions to enable whatever power
management policy the user set up from the scsi sysfs
interface if the driver supports it. This power management
policy will be activated
Kristen Carlson Accardi wrote:
Use a stored value for which interrupts to enable. Changing this allows
us to selectively turn off certain interrupts later and have them
stay off.
Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED]
Acked-by: Tejun Heo [EMAIL PROTECTED]
--
tejun
Tejun Heo wrote:
Arjan van de Ven wrote:
They were hardware problems. I don't think any amount of proper
implementation can fix them. I have one DVD RAM somewhere in my pile of
hardware which locks up solidly if any link PS mode is used and had a
and the AHCI ALPM code decides to use power
Kristen Carlson Accardi wrote:
On Wed, 01 Aug 2007 17:27:39 +0900
Tejun Heo [EMAIL PROTECTED] wrote:
Kristen Carlson Accardi wrote:
snippy
Is it safe to use ALPM on a device which only claims to support DIPM?
Yes - I doubled checked this with the AHCI people - and of course you
have
James Bottomley wrote:
Our current implementation has a generic set of barrier functions that
go through the SCSI driver model. Realistically, this is unnecessary,
because the only device that can use barriers (sd) can set the flush
functions up at probe or revalidate time. This patch pulls
Hi, Jeff.
Jeff Garzik wrote:
Tejun,
In an email I cannot find anymore, you asked why I was interested in
converting libata to use the fine-grained EH hooks in the SCSI layer,
rather than continued with the current -eh_strategy_handler() method.
Several reasons:
1) The fine-grained
Hello, fellow SCSI/ATA developers.
This is the first draft of SCSI EH document. This document tries to
describe how SCSI EH works and what choirs should be done to maintain
SCSI midlayer integrity. It's intended that this document can be used
as reference for implementing either fine-grained
Albert Lee wrote:
4. Corresponding scmd's result code is set to
SAM_STAT_CHECK_CONDITION and qc-scsidone() callback is called
directly. As we haven't filled sense data,
scsi_determine_disposition() will return FAILED and SCSI EH will
be scheduled. Note that as we directly call
Luben Tuikov wrote:
On 08/30/05 06:26, Tejun Heo wrote:
Albert Lee wrote:
4. Corresponding scmd's result code is set to
SAM_STAT_CHECK_CONDITION and qc-scsidone() callback is called
directly. As we haven't filled sense data,
scsi_determine_disposition() will return FAILED and SCSI EH
Hello, Jeff.
On Wed, Aug 31, 2005 at 10:22:17PM -0400, Jeff Garzik wrote:
Tejun Heo wrote:
IMHO, it's a good idea to maintain one qc to one ATA/ATAPI command
mapping as long as possible. And, in the suggested framework, it's
guaranteed that no other command can come inbetween CHECK_SENSE
Hi, Luben.
On Wed, Aug 31, 2005 at 08:30:27PM -0700, Luben Tuikov wrote:
--- Tejun Heo [EMAIL PROTECTED] wrote:
IMHO, it's a good idea to maintain one qc to one ATA/ATAPI command
mapping as long as possible. And, in the suggested framework, it's
Yes, that makes sense.
guaranteed
Hello, Luben.
Luben Tuikov wrote:
--- Tejun Heo [EMAIL PROTECTED] wrote:
As implementing autosensing will probably need rewriting failed qc
for REQUEST SENSE command, I'm opposing it. My proposal is to do the
following, which, in effect, should be equivalent to autosensing.
1. ATAPI CHECK
Hello, Jeff James.
Jeff Garzik wrote:
Tejun Heo wrote:
Hello, fellow SCSI/ATA developers.
This is the first draft of SCSI EH document. This document tries to
describe how SCSI EH works and what choirs should be done to maintain
SCSI midlayer integrity. It's intended that this document
.
This patch also adds sdev local variable for shorter notation where
multiple references to sdev are added.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
Sorry, the original post had [EMAIL PROTECTED] instead of
[EMAIL PROTECTED] Reposting.
drivers/scsi/osst.c | 78
Kai Makisara wrote:
On Sun, 19 Nov 2006, Tejun Heo wrote:
Each high level driver uses scsi_device-timeout diffrently.
...
Index: scsi-misc-2.6/drivers/scsi/st.c
===
--- scsi-misc-2.6.orig/drivers/scsi/st.c
+++ scsi-misc-2.6
Hello,
Kai Makisara wrote:
* st uses three retry limits - MAX_RETRIES, MAX_WRITE_RETRIES and
MAX_READY_RETRIES, which are all zero. This patch only converts
MAX_RETRIES to sdev-retries. Defining WRITE and READY retries in
terms of sdev-retries would make more sense.
I am neither acking
Upper layer is already passing in enough information via req-cmd_len
and requiring it to do the same thing twice makes it easy to miss -
scsi_execute() doesn't do it.
Now that libata is updated to handle garbage after CDB, remove
unnecessary CDB clearing.
Signed-off-by: Tejun Heo [EMAIL
/focus=14605
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index 1748e27..644f711 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -191,6 +191,7 @@ int scsi_execute(struct scsi_device *sdev, const unsigned
char *cmd
sr_block_ioctl() should proceed to SCSI ioctls if cdrom_ioctl()
returns -ENOSYS. However it tested for ENOSYS instead of -ENOSYS
rendering all SCSI ioctls other than GET_IDLUN and GET_BUS_NUMBER
inaccessible. Fix it.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
diff --git a/drivers/scsi/sr.c b
stop_on_shutdown_default which defaults
to 0. So, this patch does not change the default behavior.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
Acked-by: Henrique de Moraes Holschuh [EMAIL PROTECTED]
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 978bfc1..f21e5fe 100644
--- a/drivers/scsi/sd.c
+++ b
Darrick J. Wong wrote:
Tejun Heo wrote:
sd doesn't stop (unload head) on shutdown. This behavior is necessary
for multi initiator cases. Unloading head by powering off stresses
the drive and sometimes produces distinct clunking noise which
apparently disturbs users considering multiple
Jeff Garzik wrote:
Tejun Heo wrote:
For ATA, it's currently being done inside libata proper (a bit ugly).
It would be nice to have those implemented at sd layer but I wonder how
useful it's going to be for actual SCSI devices. Do people actually
suspend using SCSI? If it's useful
Mark Lord wrote:
In an ideal world, we would use the existing ATA_12 opcode
to issue 12-byte ATA passthrough commands for libata ATAPI drives
from userspace.
But ATA_12 happens to have the same SCSI opcode value as the older
CD/RW BLANK command, widely used by cdrecord and friends.
So,
301 - 400 of 637 matches
Mail list logo
