.18, of course.
Slowly getting through it, though as of next Friday I'll be disappearing
from the face of the earth for 3 weeks and I'm not sure I'll be finished
by then.
Fred: could you take a look at this series if you have spare cycles?
--
Andrew Donnellan OzLabs, ADL Canbe
range is used.
Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com>
Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
.
Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com>
Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
diff --git a/drivers/scsi/cxlflash/ocxl_hw.h b/drivers/scsi/cxlflash/ocxl_hw.h
index f6af247..9c675fa 10
thew R. Ochs <mro...@linux.vnet.ibm.com>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
. For cxlflash devices only a single
function per host is expected and thus the entire range is assigned.
Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com>
Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.co
atthew R. Ochs <mro...@linux.vnet.ibm.com>
Nitpick below
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
drivers/scsi/cxlflash/ocxl_hw.c | 41 +
drivers/scsi/cxlflash/ocxl_hw.h | 2 ++
2 files changed, 43 insertions(+)
di
and exit paths of the driver.
Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com>
Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>
One comment below
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
drivers/scsi/cxlflash/backend.h | 1 +
drivers/scsi
Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>
Per my response to the first version of this series, at some point we
might want to make this not depend on OCXL in all cases, but I don't
feel strongly on that.
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
-
kri...@linux.vnet.ibm.com>
Is it necessary to depend on OCXL in all cases? IMHO it should be
possible to build a cxl-only version without ocxl, though I don't feel
very strongly on this.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
xl-specific stuff as I can get to,
though I'm a bit busy with the OpenCAPI skiboot work and reviewing the
libocxl userspace library at the moment.
Andrew
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
;hwq_index = hwq_index;
+ cmd->sa.ioasc = 0;
cmd->rcb.ctx_id = hwq->ctx_hndl;
cmd->rcb.msi = SISL_MSI_RRQ_UPDATED;
cmd->rcb.port_sel = CHAN2PORTMASK(scp->device->channel);
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
On 16/08/17 06:18, Christophe JAILLET wrote:
'rc' is known to be 0 at this point.
If 'create_context()' fails, returns -ENOMEM instead of 0 which means
success.
Signed-off-by: Christophe JAILLET <christophe.jail...@wanadoo.fr>
ENOMEM seems right here.
Reviewed-by: Andrew Don
onfusing given how the term is already used in the context of EEH :)
Andrew
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
On 10/01/17 16:00, Martin K. Petersen wrote:
The first three patches in the series were submitted by you but do not
carry your Signed-off-by:...
hmm, over in linuxppc-land I don't think we particularly enforce this.
Thanks for the reminder!
--
Andrew Donnellan OzLabs, ADL
of ints to bools, which isn't strictly print-related. :)
Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>
An impressive cleanup! Nothing bad which stands out to me.
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan OzLabs, ADL C
be = cxlflash_probe,
.remove = cxlflash_remove,
- .shutdown = cxlflash_shutdown,
+ .shutdown = cxlflash_remove,
What's the justification for using cxlflash_remove() as the shutdown
hook, rather than just not having a shutdown hook at all?
--
Andrew Donnellan OzLabs, ADL Canber
ed.
Fixes: 704c4b0ddc03 ("cxlflash: Shutdown notify support for CXL Flash cards")
Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au
On 18/07/16 14:52, Andrew Donnellan wrote:
Remove the CXL_KERNEL_API and CXL_EEH Kconfig options, as they were only
needed to coordinate the merging of the cxlflash driver. Also remove the
stub implementation of cxl_perst_reloads_same_image() in cxlflash which is
only used if CXL_EEH isn't
<imun...@au1.ibm.com>
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
Acked-by: Ian Munsie <imun...@au1.ibm.com>
Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>
---
Applies on top of powerpc#next, now that the Mellanox CX-4 patches have
been applie
On 14/07/16 12:05, Andrew Donnellan wrote:
Sorry for not stating explicitly - I'd like this taken through powerpc
as the cxlflash change is incidental to the cxl changes.
I'll also be submitting a v2 that applies on top of another cxl series
that hasn't been merged yet.
--
Andrew Donnellan
On 14/07/16 12:02, Martin K. Petersen wrote:
"Andrew" == Andrew Donnellan <andrew.donnel...@au1.ibm.com> writes:
Andrew> Remove the CXL_KERNEL_API and CXL_EEH Kconfig options, as they
Andrew> were only needed to coordinate the merging of the cxlflash
Andrew> dri
On 04/07/16 17:12, Andrew Donnellan wrote:
Remove the CXL_KERNEL_API and CXL_EEH Kconfig options, as they were only
needed to coordinate the merging of the cxlflash driver. Also remove the
stub implementation of cxl_perst_reloads_same_image() in cxlflash which is
only used if CXL_EEH isn't
<imun...@au1.ibm.com>
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
Applies on top of powerpc#next
---
drivers/misc/cxl/Kconfig | 10 --
drivers/scsi/cxlflash/main.h | 4
2 files changed, 14 deletions(-)
diff --git a/drivers/misc/cxl/Kconfig b/
om>
Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>
Looks reasonable.
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)
.vnet.ibm.com>
Assuming that the final card won't break in a particularly nasty way in
the absence of later code changes, all looks good.
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Austral
ed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com>
Without the card-specific code, how does the driver behave if the new
card is plugged in?
Andrew
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 620
() for the tmf_slock during probe.
Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work
evaluation for an unset bit.
Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>
Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com>
Reviewed-by: Brian King <brk...@linux.vnet.ibm.com>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnell
On 22/10/15 07:16, Matthew R. Ochs wrote:
The port selection mask of a LUN can be corrupted when the manage LUN
ioctl (DK_CXLFLASH_MANAGE_LUN) is issued more than once for any device.
> ...
Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>
Reviewed-by: Andrew
-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Austr
com>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia Limited
--
To unsubscribe from this list: send the line
and return codes.
Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>
Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com>
Reviewed-by: Brian King <brk...@linux.vnet.ibm.com>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
See further comments bel
ux.vnet.ibm.com>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
Changes mostly look fine, further comments below.
--- a/drivers/scsi/cxlflash/main.c
+++ b/drivers/scsi/cxlflash/main.c
@@ -58,8 +58,8 @@ static struct afu_cmd *cmd_checkout(struct afu *afu)
atthew R. Ochs <mro...@linux.vnet.ibm.com>
Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com>
Reviewed-by: Brian King <brk...@linux.vnet.ibm.com>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan Software Engineer, OzLab
ed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>
Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com>
Reviewed-by: Brian King <brk...@linux.vnet.ibm.com>
The commit message could explain the patch a bit better.
Andrew
--
Andrew Donnellan Software Engine
clean.
Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>
Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com>
Reviewed-by: Brian King <brk...@linux.vnet.ibm.com>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan S
com>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia Limited
--
To unsubscribe from this list: send the line
com>
Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>
Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com>
Reviewed-by: Brian King <brk...@linux.vnet.ibm.com>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan
On 25/09/15 05:44, Matthew R. Ochs wrote:
Add stanza for cxlflash SCSI driver.
Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>
Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com>
Reviewed-by: Brian King <brk...@linux.vnet.ibm.com>
Reviewed-by: Andrew Donnel
39 matches
Mail list logo
