RE: [PATCH/RESEND v2 1/2] Hard disk S3 resume time optimization

2014-01-10 Thread Brandt, Todd E
On Thursday, January 09, 2014 9:04 AM, Phillip Susi wrote: > I think my patch for this "libata: resume in the background" was a LOT > simpler. It just used the existing behavior of becoming async when > the async argument was !NULL, and fixed the one caller that didn't > actually care about the re

RE: [PATCH/RESEND 1/2] Hard disk S3 resume time optimization

2013-09-10 Thread Brandt, Todd E
Good suggestion on the reuse of the existing ata_port_request_pm function. I have this habit of introducing new changes in such a way that they can be easily turned on and off for testing, but that's not appropriate here. I'll redo this patch with the functionality weaved into all the existing f

RE: [PATCH v3 2/2] Hard disk S3 resume time optimization

2013-08-27 Thread Brandt, Todd E
- From: Oliver Neukum [mailto:oneu...@suse.de] Sent: Saturday, August 24, 2013 1:21 AM To: Brandt, Todd E Cc: linux-...@vger.kernel.org; linux-scsi@vger.kernel.org; t...@kernel.org; gre...@linuxfoundation.org; st...@rowland.harvard.edu Subject: Re: [PATCH v3 2/2] Hard disk S3 resume time optimizati

[PATCH v3 2/2] Hard disk S3 resume time optimization

2013-08-27 Thread Brandt, Todd E
This is v3 of the non-blocking S3 resume patch. It's been broken into two pieces, this part is for the scsi subsystem. I've addressed Alan Stern's comments in particular by reformatting the call to conform to the proper style guidelines. Note - the two patches will function separately but both ar

[PATCH v3 1/2] Hard disk S3 resume time optimization

2013-08-27 Thread Brandt, Todd E
This is v3 of the non-blocking S3 resume patch. It's been broken into two pieces, this part is for the ata subsystem. I've addressed Oliver Neukum's comments in particular by removing any potential race conditions. In the previous version I used the ata_port_request_pm function to handle the ca

RE: [PATCH v2] Hard disk S3 resume time optimization

2013-08-09 Thread Brandt, Todd E
_ From: Alan Stern [st...@rowland.harvard.edu] Sent: Friday, August 09, 2013 11:06 AM To: Brandt, Todd E Cc: linux-...@vger.kernel.org; linux-scsi@vger.kernel.org; Oliver Neukum; Tejun Heo; Greg Kroah-Hartman Subject: Re: [PATCH v2] Hard disk S3 resume time optimization Your email message

RE: [PATCH v2] Hard disk S3 resume time optimization

2013-08-09 Thread Brandt, Todd E
day, August 09, 2013 12:25 AM To: Brandt, Todd E Cc: linux-...@vger.kernel.org; linux-scsi@vger.kernel.org; Tejun Heo; Greg Kroah-Hartman; Alan Stern Subject: Re: [PATCH v2] Hard disk S3 resume time optimization On Fri, 2013-08-09 at 01:09 +, Brandt, Todd E wrote: > static struct ata_f

[PATCH v2] Hard disk S3 resume time optimization

2013-08-08 Thread Brandt, Todd E
This patch essentially removes the disk spinup wait time from the system S3 resume delay. It can be a very significant improvement on systems with large SATA disks which can take several seconds to spin up. On the systems I've tested this patch reduces the resume time to around half a second (as

RE: [PATCH] Hard disk S3 resume time optimization

2013-08-02 Thread Brandt, Todd E
randt Linux Kernel Developer OTC, Hillsboro OR https://opensource.intel.com/linux-wiki/ToddBrandt From: Oliver Neukum [oneu...@suse.de] Sent: Friday, August 02, 2013 10:05 AM To: Brandt, Todd E Cc: linux-...@vger.kernel.org; linux-scsi@vger.kernel.org S

RE: [PATCH] Hard disk S3 resume time optimization

2013-08-02 Thread Brandt, Todd E
From: linux-scsi-ow...@vger.kernel.org [linux-scsi-ow...@vger.kernel.org] on behalf of Oliver Neukum [oneu...@suse.de] Sent: Friday, August 02, 2013 5:42 AM To: Brandt, Todd E Cc: linux-...@vger.kernel.org; linux-scsi@vger.kernel.org Subject: Re: [PATCH

[PATCH] Hard disk S3 resume time optimization

2013-08-01 Thread Brandt, Todd E
This patch is a potential way to reduce the S3 resume time for SATA drives. Essentially this patch removes the hard disk resume time from the total system resume time, with the disks still taking as long to come back online but in the background. The major bottleneck is in the ata port resume w

RE: [PATCH v2 2/2] Adds new device resume mode in PM core, async plus non-blocking

2013-06-03 Thread Brandt, Todd E
o OR https://opensource.intel.com/linux-wiki/ToddBrandt From: Alan Stern [st...@rowland.harvard.edu] Sent: Friday, May 17, 2013 12:44 PM To: Brandt, Todd E Cc: linux-...@vger.kernel.org; linux-scsi@vger.kernel.org; linux...@vger.kernel.org; Jeff Garzik; Jens A

RE: [PATCH v2 2/2] Adds new device resume mode in PM core, async plus non-blocking

2013-05-17 Thread Brandt, Todd E
Hi, will do, thanks for the feedback. I used the goto to make the code addition smaller, but I obviously sacrificed code clarity. From: Greg Kroah-Hartman [gre...@linuxfoundation.org] Sent: Friday, May 17, 2013 12:11 PM To: Brandt, Todd E Cc: linux

[PATCH v2 2/2] Adds new device resume mode in PM core, async plus non-blocking

2013-05-17 Thread Brandt, Todd E
Updates the drivers/base/power subsystem to allow any devices which have registred as asynchronous and who have not registered "complete" callbacks to be non-blocking. i.e system resume can finish and return control to the user while these devices continue resuming. Changelog: v2: - Update

[PATCH v2 1/2] ATA/SCSI subsystem resume path made fully asynchronous

2013-05-17 Thread Brandt, Todd E
This patch goes through and sets the power.async_suspend flag for every device in the ATA/SCSI resume path. This includes the ata port, link, and dev devices, the scsi host and target devices, all their associated transport devices, the block devices, and block partitions. This allows the entire AT

[PATCH v2 0/2] Hard disk S3 resume time optimization

2013-05-17 Thread Brandt, Todd E
The vast majority of time spent in S3 resume is consumed by the ATA subsystem as it resumes the computer's hard drives. For large hard disks this time can be upwards of 10 seconds, which makes S3 suspend/resume too costly to use frequently. This time needs to be reduced. More details here: https:

[PATCH] Hard disk S3 resume time optimization

2013-05-16 Thread Brandt, Todd E
Hello, my name's Todd Brandt and I'm the project owner for Intel Open Source Technology Center's new project to optimize suspend/resume time. Our website is: https://01.org/suspendresume [The Problem] The vast majority of time spent in S3 resume is consumed by the ATA subsystem as it resumes the