Re: [PATCH] scsi: storvsc: missing error code in storvsc_probe()

2018-01-16 Thread Cathy Avery
} #endif return 0; Reviewed-by: Cathy Avery <cav...@redhat.com>

[PATCH] scsi: storvsc: Fix scsi_cmd error assignments in storvsc_handle_error

2017-12-19 Thread Cathy Avery
/O to complete while holding scsi_sd_probe_domain. Also returning the default error of DID_TARGET_FAILURE causes multipath to not retry the I/O resulting in applications receiving I/O errors before a failover can occur. Signed-off-by: Cathy Avery <cav...@redhat.com> Signed-off-by: Long L

Re: [PATCH] storvsc: Avoid excessive host scan on controller change

2017-11-06 Thread Cathy Avery
ailover while running fio and taking hyperV snap shots while luns are being hot added and removed. Tested-by: Cathy Avery <cav...@redhat.com>

[PATCH V3] scsi: storvsc: Allow only one remove lun work item to be issued per lun

2017-10-31 Thread Cathy Avery
kqueue to serialize work in storvsc_handle_error [Christoph Hellwig] Changes since v2: Replaced create_singlethread_workqueue with alloc_ordered_workqueue [Christoph Hellwig] Added reviewed by's. Signed-off-by: Cathy Avery <cav...@redhat.com> Reviewed-by: Christoph Hellwig <h...@lst.de> Reviewe

Re: [PATCH V2] scsi: storvsc: Allow only one remove lun work item to be issued per lun

2017-10-31 Thread Cathy Avery
On 10/31/2017 08:24 AM, Martin K. Petersen wrote: If you use alloc_ordered_workqueue directly instead of create_singlethread_workqueue you can pass a format string and don't need the separate allocation. But I'm not sure if Tejun is fine with using __WQ_LEGACY directly.. The only thing that

[PATCH V2] scsi: storvsc: Allow only one remove lun work item to be issued per lun

2017-10-17 Thread Cathy Avery
kqueue to serialize work in storvsc_handle_error [Christoph Hellwig] Signed-off-by: Cathy Avery <cav...@redhat.com> --- drivers/scsi/storvsc_drv.c | 27 ++- 1 file changed, 22 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c i

[PATCH] scsi: storvsc: Allow only one remove lun work item to be issued per lun

2017-10-17 Thread Cathy Avery
kqueue to serialize work in storvsc_handle_error [Christoph Hellwig] Signed-off-by: Cathy Avery <cav...@redhat.com> --- drivers/scsi/storvsc_drv.c | 27 ++- 1 file changed, 22 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c i

Re: [PATCH V4 0/10] block/scsi: safe SCSI quiescing

2017-09-12 Thread Cathy Avery
inux/blk-mq.h| 15 ++-- include/linux/blkdev.h| 32 +-- 16 files changed, 313 insertions(+), 104 deletions(-) I've tested this patch set for spi_transport issuing a domain validation under low blk_request conditions. Tested-by: Cathy Avery <cav...@redhat.com>

Re: [PATCH] scsi: storvsc: Allow only one remove lun work item to be issued per lun

2017-04-17 Thread Cathy Avery
On 04/15/2017 10:06 AM, Christoph Hellwig wrote: Just add a singlethreaded workqueue for storvsc_handle_error and you'll get serialization for all error handling for free. The problem I am seeing is that many work items can be queued up for the same lun before it goes away. The single

[PATCH v3 2/2] scsi: storvsc: Add support for FC rport.

2017-04-17 Thread Cathy Avery
to scan the scsi stack via echo "- - -" > /sys/class/scsi_host/hostX/scan. Signed-off-by: Cathy Avery <cav...@redhat.com> --- drivers/scsi/storvsc_drv.c | 23 ++- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/storvsc_drv.c b/drivers

[PATCH v3 1/2] scsi: scsi_transport_fc: Add dummy initiator role to rport

2017-04-17 Thread Cathy Avery
rport's role in fc_rport_identifiers. This insures that a valid scsi_target_id is assigned to the newly created rport and it can meet the requirements of fc_user_scan_tgt calling scsi_scan_target. Signed-off-by: Cathy Avery <cav...@redhat.com> --- drivers/scsi/scsi_transport_fc.c | 10 +

[PATCH v3 0/2] scsi: storvsc: Add support for FC rport

2017-04-17 Thread Cathy Avery
. Changes since v2: - Additional patch adding FC_PORT_ROLE_FCP_DUMMY_INITIATOR role to fc_transport - Changed storvsc rport role to FC_PORT_ROLE_FCP_DUMMY_INITIATOR Changes since v1: - Fix fc_rport_identifiers init [Stephen Hemminger] - Better error checking Cathy Avery (2): scsi

[PATCH] scsi: storvsc: Allow only one remove lun work item to be issued per lun

2017-04-15 Thread Cathy Avery
ted as scsi_remove_device also tries to take host->scan_mutex. This results in dragging the VM down and sometimes completely. This patch only allows one remove lun to be issued to a particular lun while it is an instantiated member of the scsi stack. Signed-off-by: Cathy Avery <cav...@r

[PATCH v3 2/2] scsi: storvsc: Add support for FC rport.

2017-04-05 Thread Cathy Avery
to scan the scsi stack via echo "- - -" > /sys/class/scsi_host/hostX/scan. Signed-off-by: Cathy Avery <cav...@redhat.com> --- drivers/scsi/storvsc_drv.c | 23 ++- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/storvsc_drv.c b/drivers

[PATCH v3 1/2] scsi: scsi_transport_fc: Add dummy initiator role to rport

2017-04-05 Thread Cathy Avery
rport's role in fc_rport_identifiers. This insures that a valid scsi_target_id is assigned to the newly created rport and it can meet the requirements of fc_user_scan_tgt calling scsi_scan_target. Signed-off-by: Cathy Avery <cav...@redhat.com> --- drivers/scsi/scsi_transport_fc.c | 10 +

[PATCH v3 0/2] scsi: storvsc: Add support for FC rport

2017-04-05 Thread Cathy Avery
. Changes since v2: - Additional patch adding FC_PORT_ROLE_FCP_DUMMY_INITIATOR role to fc_transport - Changed storvsc rport role to FC_PORT_ROLE_FCP_DUMMY_INITIATOR Changes since v1: - Fix fc_rport_identifiers init [Stephen Hemminger] - Better error checking Cathy Avery (2): scsi

Re: [PATCH v2] scsi: storvsc: Add support for FC rport.

2017-04-03 Thread Cathy Avery
On 04/03/2017 08:17 AM, Christoph Hellwig wrote: if (host->transportt == fc_transport_template) { + struct fc_rport_identifiers ids = { + .roles = FC_PORT_ROLE_FCP_TARGET, + }; I don't think storvsc ever acts as FCP target. In order to

[PATCH v2] scsi: storvsc: Add support for FC rport.

2017-04-03 Thread Cathy Avery
"- - -" > /sys/class/scsi_host/hostX/scan now works. Signed-off-by: Cathy Avery <cav...@redhat.com> --- Changes since v1: - Fix fc_rport_identifiers init [Stephen Hemminger] - Better error checking --- drivers/scsi/storvsc_drv.c | 23 ++- 1 file changed, 18 inserti

[PATCH v2] scsi: storvsc: Add support for FC rport.

2017-03-17 Thread Cathy Avery
"- - -" > /sys/class/scsi_host/hostX/scan now works. Signed-off-by: Cathy Avery <cav...@redhat.com> --- Changes since v1: - Fix fc_rport_identifiers init [Stephen Hemminger] - Better error checking --- drivers/scsi/storvsc_drv.c | 23 ++- 1 file changed, 18 inserti

Re: [PATCH] scsi: storvsc: Add support for FC rport.

2017-03-14 Thread Cathy Avery
Good catch. Thanks! On 03/14/2017 12:42 PM, Stephen Hemminger wrote: On Tue, 14 Mar 2017 12:01:03 -0400 Cathy Avery <cav...@redhat.com> wrote: #if IS_ENABLED(CONFIG_SCSI_FC_ATTRS) if (host->transportt == fc_transport_template) { + struct fc_rport_identi

[PATCH] scsi: storvsc: Add support for FC rport.

2017-03-14 Thread Cathy Avery
"- - -" > /sys/class/scsi_host/hostX/scan now works. Signed-off-by: Cathy Avery <cav...@redhat.com> --- drivers/scsi/storvsc_drv.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c index 638e

Re: [PATCH] scsi: storvsc: Add support for FC rport.

2017-03-13 Thread Cathy Avery
Hi, I haven't received any feedback yet. Should I resend? Thanks, Cathy On 02/28/2017 01:45 PM, Cathy Avery wrote: Included in the current storvsc driver for Hyper-V is the ability to access luns on an FC fabric via a virtualized fiber channel adapter exposed by the Hyper-V host. The driver

[PATCH] scsi: storvsc: Add support for FC rport.

2017-02-28 Thread Cathy Avery
"- - -" > /sys/class/scsi_host/hostX/scan now works. Signed-off-by: Cathy Avery <cav...@redhat.com> --- drivers/scsi/storvsc_drv.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c index 585e

[PATCH v2 1/2] scsi: scsi_transport_fc: Provide a lightweight option for Virtual FC Hosts.

2017-01-26 Thread Cathy Avery
created when the transport driver loads. They are just not populated when running in lightweight mode. Conceptually both lightweight and heavyweight clients could coexist. 4) fc_transport_template->user_scan is now null and the bus can be scanned. Signed-off-by: Cathy Avery <cav...@redh

[PATCH v2 0/2] scsi: storvsc: Add support for FC lightweight host.

2017-01-26 Thread Cathy Avery
ed that the word lightweight may not be the best choice of terms when describing the new FC transport option. I can offer a few new ones but I am not particularly imaginative. Virtual FC Mini FC Host only FC Changes from V1: Added more comments and documentation in the code regarding the lightweight

[PATCH v2 2/2] scsi: storvsc: Add support for FC lightweight host.

2017-01-26 Thread Cathy Avery
scsi_times_out() scsi_error.c. So the workaround is no longer necessary. Signed-off-by: Cathy Avery <cav...@redhat.com> --- drivers/scsi/storvsc_drv.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c index 8

Re: [PATCH 2/2] scsi: storvsc: Add support for FC lightweight host.

2017-01-23 Thread Cathy Avery
; /sys/class/scsi_host/hostX/scan. Cathy On 01/22/2017 10:13 PM, Fam Zheng wrote: On Wed, 01/18 15:28, Cathy Avery wrote: Enable FC lightweight host option so that the luns exposed by the driver may be manually scanned. Hi Cathy, out of curiosity: how does this relate to issue_lip opera

Re: [PATCH 2/2] scsi: storvsc: Add support for FC lightweight host.

2017-01-22 Thread Cathy Avery
necessitating its own patch. I will break it out in the next go round. Thanks, Cathy On 01/20/2017 04:31 AM, Dan Carpenter wrote: On Thu, Jan 19, 2017 at 12:55:27PM -0500, Cathy Avery wrote: On 01/18/2017 06:15 PM, Dan Carpenter wrote: On Wed, Jan 18, 2017 at 03:28:58PM -0500, Cathy Avery wrote

Re: [PATCH 2/2] scsi: storvsc: Add support for FC lightweight host.

2017-01-19 Thread Cathy Avery
On 01/18/2017 06:15 PM, Dan Carpenter wrote: On Wed, Jan 18, 2017 at 03:28:58PM -0500, Cathy Avery wrote: Enable FC lightweight host option so that the luns exposed by the driver may be manually scanned. Signed-off-by: Cathy Avery <cav...@redhat.com> --- drivers/scsi/storvsc_drv

Re: [PATCH 1/2] scsi: scsi_transport_fc: Provide a lightweight option for Virtual FC Hosts.

2017-01-19 Thread Cathy Avery
On 01/19/2017 10:11 AM, Christoph Hellwig wrote: On Wed, Jan 18, 2017 at 03:28:57PM -0500, Cathy Avery wrote: The patch provides a means to offer a lightweight option to the current FC transport class. The new option is selected by a driver when it indicates it wants the lightweight transport

[PATCH 2/2] scsi: storvsc: Add support for FC lightweight host.

2017-01-18 Thread Cathy Avery
Enable FC lightweight host option so that the luns exposed by the driver may be manually scanned. Signed-off-by: Cathy Avery <cav...@redhat.com> --- drivers/scsi/storvsc_drv.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/scsi/storvsc_drv.c b/driver

[PATCH 1/2] scsi: scsi_transport_fc: Provide a lightweight option for Virtual FC Hosts.

2017-01-18 Thread Cathy Avery
The patch provides a means to offer a lightweight option to the current FC transport class. The new option is selected by a driver when it indicates it wants the lightweight transport via fc_function_template. Signed-off-by: Cathy Avery <cav...@redhat.com> --- drivers/scsi/scsi_transpor

[PATCH 0/2] scsi: Create a lightweight FC Transport option for Virtual FC Hosts.

2017-01-18 Thread Cathy Avery
. Patch 1: The patch provides a lightweight option to the current FC transport class. The new option is selected by a driver when it indicates it wants the lightweight transport in fc_function_template. Patch 2: storvsc elects using the new lightweight FC host option. Cathy Avery (2): scsi

[RFC PATCH] scsi: scsi_transport_fc: Create a lightweight option for Virtual FC Hosts.

2017-01-04 Thread Cathy Avery
the lightweight transport in fc_function_template. I have included the changes for storvsc_drv.c in this patch as an example of a driver making use of the lightweight transport option. Signed-off-by: Cathy Avery <cav...@redhat.com> --- drivers/scsi/scsi_transport_fc.c

[PATCH v2] [hv] storvsc: Payload buffer incorrectly sized for 32 bit kernels.

2016-11-23 Thread Cathy Avery
On a 32 bit kernel sizeof(void *) is not 64 bits as hv_mpb_array requires. Also the buffer needs to be cleared or the upper bytes will contain junk. Suggested-by: Vitaly Kuznetsov <vkuzn...@redhat.com> Signed-off-by: Cathy Avery <cav...@redhat.com> ChangeLog: v1) Initial submissio

[PATCH] [hv] storvsc: Payload buffer incorrectly sized for 32 bit kernels.

2016-11-22 Thread Cathy Avery
On a 32 bit kernel sizeof(void *) is not 64 bits as hv_mpb_array requires. Also the buffer needs to be cleared or the upper bytes could contain junk. Suggested-by: Vitaly Kuznets <vkuzn...@redhat.com> Signed-off-by: Cathy Avery <cav...@redhat.com> --- drivers/scsi/storvsc_drv.c | 3

[PATCH 1/1] scsi: storvsc: Filter out storvsc messages CD-ROM medium not present

2016-05-23 Thread Cathy Avery
When a virtual scsi DVD device is present with no image file attached the storvsc driver logs all resulting unnecessary sense errors whenever IO is issued to the device. [storvsc] Sense Key : Not Ready [current] [storvsc] Add. Sense: Medium not present - tray closed Signed-off-by: Cathy Avery