NAK: [PATCH] scsi: lpfc: fix spelling mistake: "mabilbox" -> "mailbox"

2018-05-03 Thread Colin Ian King
On 03/05/18 10:19, Colin King wrote: > From: Colin Ian King <colin.k...@canonical.com> > > Trivial fix to spelling mistake in lpfc_printf_log log message > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Ignore this, I've found more issues, sending a V2.

Re: [PATCH] isci: Fix infinite loop in while loop

2018-04-20 Thread Colin Ian King
On 20/04/18 10:45, James Bottomley wrote: > On Fri, 2018-04-20 at 10:03 +0100, Colin King wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> In the case when the phy_mask is bitwise anded with the >> phy_index bit is zero the continue statement current

re: scsi: sg: fix SG_DXFER_FROM_DEV transfers

2017-07-13 Thread Colin Ian King
Hi, minor nit-pick on the following commit: scsi: sg: fix SG_DXFER_FROM_DEV transfers SG_DXFER_FROM_DEV transfers do not necessarily have a dxferp as we set it to NULL for the old sg_io read/write interface, but must have a length bigger than 0. This fixes a regression introduced by commit

NAK: [PATCH] scsi: snic: fix a couple of spelling mistakes/typos

2017-06-30 Thread Colin Ian King
Incorrect commit message, I'll resend. On 30/06/17 14:54, Colin King wrote: > From: Colin Ian King <colin.k...@canonical.com> > > Trivial fix to spelling mistakes/typos: > > "Allodating" -> "Allocating" > "incative" -> "inact

Re: [PATCH] scsi: lpfc: fix spelling mistake "entrys" -> "entries"

2017-06-01 Thread Colin Ian King
On 01/06/17 15:35, Dan Carpenter wrote: > On Fri, May 26, 2017 at 11:11:37AM +0100, Colin King wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> Trivial fix to spelling mistake in debugfs message >> > > Are you using a tool to find all t

Re: [PATCH] target/iscsi: make function target_parse_xcopy_cmd static

2017-05-11 Thread Colin Ian King
On 11/05/17 14:55, Bart Van Assche wrote: > On Thu, 2017-05-11 at 11:16 +0100, Colin King wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> Making target_parse_xcopy_cmd static fixes sparse warning: >> >> "warning: symbol 'targe

Re: [PATCH] scsi: fcoe: sanity check string size for store_ctrl_mode option

2017-03-22 Thread Colin Ian King
On 22/03/17 19:39, Dan Carpenter wrote: > On Wed, Mar 22, 2017 at 02:01:37PM +, Colin King wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> Reading and writing to mode[count - 1] implies the count should not >> be less than 1 so add a sani

Re: [PATCH] scsi: aacraid: rcode is unsigned, so can never be less than zero

2017-02-07 Thread Colin Ian King
On 07/02/17 11:37, Dan Carpenter wrote: > On Tue, Feb 07, 2017 at 11:27:38AM +, Colin King wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> The check on rcode >= 0 is always true because rcode is unsigned >> and can never be less th

Re: [PATCH v1] scsi: ufs: fix arguments order some trace calls

2017-01-11 Thread Colin Ian King
On 11/01/17 00:48, Subhash Jadavani wrote: > Colin Ian King <colin.k...@canonical.com> reported that with > commit 7ff5ab473633 ("scsi: ufs: add tracing support") static analysis > is reporting that we may have swapped arguments on calls to: >