Re: [PATCH v2 3/7] drivers/base: Probe devices concurrently if requested by the driver

2018-10-18 Thread Greg KH
On Thu, Oct 18, 2018 at 09:51:03AM -0700, Alexander Duyck wrote: > On 10/18/2018 9:46 AM, Bart Van Assche wrote: > > On Thu, 2018-10-18 at 08:25 -0700, Alexander Duyck wrote: > > > On 10/17/2018 5:54 PM, Dan Williams wrote: > > > > On Wed, Oct 17, 2018 at 4:41 PM Bart Van Assche > > > > wrote: >

Re: [PATCH v2 3/7] drivers/base: Probe devices concurrently if requested by the driver

2018-10-17 Thread Greg KH
On Wed, Oct 17, 2018 at 05:54:56PM -0700, Dan Williams wrote: > On Wed, Oct 17, 2018 at 4:41 PM Bart Van Assche wrote: > > > > Instead of probing devices sequentially in the PROBE_PREFER_ASYNCHRONOUS > > mode, scan devices concurrently. This helps when the wall clock time for > > a single probe

Re: [PATCH 2/2] ata: Fix ZBC_OUT all bit handling

2018-06-26 Thread Greg KH
On Tue, Jun 26, 2018 at 04:18:38PM +0900, Damien Le Moal wrote: > If the ALL bit is set in the ZBC_OUT command, the command zone ID field > (block) should be ignored. > > Reported-by: David Butterfield > Signed-off-by: Damien Le Moal > --- > drivers/ata/libata-scsi.c | 11 --- > 1 file

Re: [PATCH 1/2] ata: Fix ZBC_OUT command block check

2018-06-26 Thread Greg KH
On Tue, Jun 26, 2018 at 04:18:37PM +0900, Damien Le Moal wrote: > The block (LBA) specified must not exceed the last addressable LBA, > which is dev->nr_sectors - 1. So fix the correct check is > "if (block >= dev->n_sectors)" and not "if (block > dev->n_sectords)". > > Additionally, the asc/ascq

Re: [PATCH] [SCSI] mpt3sas: Fix secure erase premature termination (v4)

2018-04-24 Thread Greg KH
On Mon, Apr 23, 2018 at 06:28:03PM +, Igor Rybak wrote: > Hi, > > We are running kernel 4.4.0-22 and the patch below does not seem to be > present in the mpt3sas driver. Can you please confirm? Please update your kernel, this patch was in the 4.4.36 kernel release which came out December 2,

Re: [PATCH 00/15] mpt3sas: Enhancements and Defect fixes.

2018-03-30 Thread Greg KH
On Fri, Mar 30, 2018 at 03:07:09PM +0530, Chaitra P B wrote: > Chaitra P B (15): > mpt3sas: Fixed warnings. > mpt3sas: Pre-allocate RDPQ Array at driver boot time. > mpt3sas: Add sanity checks for scsi tracker before accessing it. > mpt3sas: Lockless access for chain buffers. > mpt3sas:

Re: [PATCH] scsi: storvsc: missing error code in storvsc_probe()

2018-02-09 Thread Greg KH
On Thu, Feb 08, 2018 at 04:50:40PM -0700, Long Li wrote: > From: Long Li No, Dan wrote the first patch here, don't change the authorship of a patch :( Now fixed up by hand...

Re: [PATCH v4 01/10] ufs: sysfs: attribute group for existing sysfs entries.

2018-02-04 Thread Greg KH
On Sun, Feb 04, 2018 at 01:09:09PM +, Stanislav Nijnikov wrote: > > > > -Original Message- > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > Sent: Sunday, February 4, 2018 2:34 PM > > To: Stanislav Nijnikov <stanislav.nijni...@wdc.com>

Re: [PATCH v4 01/10] ufs: sysfs: attribute group for existing sysfs entries.

2018-02-04 Thread Greg KH
On Sun, Feb 04, 2018 at 12:29:06PM +, Stanislav Nijnikov wrote: > > > + curr_len += snprintf((buf + curr_len), (PAGE_SIZE - curr_len), > > > + "\nAll available Runtime PM levels info:\n"); > > > + for (lvl = UFS_PM_LVL_0; lvl < UFS_PM_LVL_MAX; lvl++) > > > +

Re: [PATCH v4 10/10] ufs: sysfs: attributes

2018-02-01 Thread Greg KH
On Thu, Feb 01, 2018 at 06:15:46PM +0200, Stanislav Nijnikov wrote: > +#define UFS_LUN_ATTRIBUTE(_name, _uname) > \ > +static ssize_t _name##_attribute_show(struct device *dev, > \ > + struct device_attribute *attr, char *buf)

Re: [PATCH v4 03/10] ufs: sysfs: interconnect descriptor

2018-02-01 Thread Greg KH
On Thu, Feb 01, 2018 at 06:15:39PM +0200, Stanislav Nijnikov wrote: > This patch introduces a sysfs group entry for the UFS interconnect > descriptor parameters. The group adds "interconnect_descriptor" folder > under the UFS driver sysfs entry (/sys/bus/platform/drivers/ufshcd/*). > The

Re: [PATCH v4 02/10] ufs: sysfs: device descriptor

2018-02-01 Thread Greg KH
On Thu, Feb 01, 2018 at 06:15:38PM +0200, Stanislav Nijnikov wrote: > +#define UFS_DESC_PARAM(_name, _puname, _duname, _size) > \ > +static ssize_t _name##_show(struct device *dev, > \ > + struct device_attribute *attr, char *buf)

Re: [PATCH v4 01/10] ufs: sysfs: attribute group for existing sysfs entries.

2018-02-01 Thread Greg KH
On Thu, Feb 01, 2018 at 06:15:37PM +0200, Stanislav Nijnikov wrote: > This patch introduces attribute group to show existing sysfs entries. > > Signed-off-by: Stanislav Nijnikov > --- > drivers/scsi/ufs/Makefile| 3 +- > drivers/scsi/ufs/ufs-sysfs.c | 164 >

Re: [PATCH 10/18] qla2xxx: prevent bounds-check bypass via speculative execution

2018-01-11 Thread Greg KH
On Thu, Jan 11, 2018 at 02:15:12PM -0800, Dan Williams wrote: > On Sat, Jan 6, 2018 at 1:03 AM, Greg KH <gre...@linuxfoundation.org> wrote: > > On Fri, Jan 05, 2018 at 05:10:48PM -0800, Dan Williams wrote: > >> Static analysis reports that 'handle' may be a user controlled

Re: [PATCH 10/18] qla2xxx: prevent bounds-check bypass via speculative execution

2018-01-06 Thread Greg KH
On Sat, Jan 06, 2018 at 10:03:22AM +0100, Greg KH wrote: > On Fri, Jan 05, 2018 at 05:10:48PM -0800, Dan Williams wrote: > > Static analysis reports that 'handle' may be a user controlled value > > that is used as a data dependency to read 'sp' from the > > 'req->outstandin

Re: [PATCH 10/18] qla2xxx: prevent bounds-check bypass via speculative execution

2018-01-06 Thread Greg KH
On Fri, Jan 05, 2018 at 05:10:48PM -0800, Dan Williams wrote: > Static analysis reports that 'handle' may be a user controlled value > that is used as a data dependency to read 'sp' from the > 'req->outstanding_cmds' array. In order to avoid potential leaks of > kernel memory values, block

Re: [PATCH v3 1/9] ufs: sysfs: device descriptor

2018-01-02 Thread Greg KH
On Tue, Jan 02, 2018 at 02:04:39PM +, Stanislav Nijnikov wrote: > > > > -Original Message- > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > Sent: Friday, December 29, 2017 11:23 AM > > To: Stanislav Nijnikov <stanislav.nijni...@wdc.com>

Re: [PATCH v3 1/9] ufs: sysfs: device descriptor

2017-12-29 Thread Greg KH
On Thu, Dec 28, 2017 at 03:29:06PM +0200, Stanislav Nijnikov wrote: > --- /dev/null > +++ b/drivers/scsi/ufs/ufs-sysfs.c > @@ -0,0 +1,170 @@ > +/* > +* UFS Device Management sysfs > +* > +* Copyright (C) 2017 Western Digital Corporation > +* > +* This program is free software; you can redistribute

Re: [PATCH v2 6/9] ufs: sysfs: string descriptors

2017-12-27 Thread Greg KH
On Wed, Dec 27, 2017 at 05:13:44PM +0200, Stanislav Nijnikov wrote: > This patch introduces a sysfs group entry for the UFS string descriptors. > The group adds "string_descriptors" folder under the UFS driver > sysfs entry (/sys/bus/platform/drivers/ufshcd/*). The folder will contain > 5 files

Re: [PATCH v2 9/9] ufs: sysfs: attributes

2017-12-27 Thread Greg KH
On Wed, Dec 27, 2017 at 05:13:47PM +0200, Stanislav Nijnikov wrote: > This patch introduces a sysfs group entry for the UFS attributes. The > group adds "attributes" folder under the UFS driver sysfs entry > (/sys/bus/platform/drivers/ufshcd/*). The attributes are shown > as hexadecimal numbers.

Re: [PATCH v2 8/9] ufs: sysfs: flags

2017-12-27 Thread Greg KH
On Wed, Dec 27, 2017 at 05:13:46PM +0200, Stanislav Nijnikov wrote: > This patch introduces a sysfs group entry for the UFS flags. The group adds > "flags" folder under the UFS driver sysfs entry > (/sys/bus/platform/drivers/ufshcd/*). The flags are shown as boolean value > ("true" or "false").

Re: [PATCH v2 7/9] ufs: sysfs: unit descriptor

2017-12-27 Thread Greg KH
On Wed, Dec 27, 2017 at 05:13:45PM +0200, Stanislav Nijnikov wrote: > This patch introduces a sysfs group entry for the UFS unit descriptor > parameters. The group adds "unit_descriptor" folder under the corresponding > SCSI device sysfs entry (/sys/class/scsi_device/*/device/). The parameters >

Re: [PATCH v2 5/9] ufs: sysfs: power descriptor

2017-12-27 Thread Greg KH
On Wed, Dec 27, 2017 at 05:13:43PM +0200, Stanislav Nijnikov wrote: > This patch introduces a sysfs group entry for the UFS power descriptor > parameters. The group adds "power_descriptor" folder under the UFS driver > sysfs entry (/sys/bus/platform/drivers/ufshcd/*). The parameters are shown > as

Re: [PATCH v2 4/9] ufs: sysfs: health descriptor

2017-12-27 Thread Greg KH
On Wed, Dec 27, 2017 at 05:13:42PM +0200, Stanislav Nijnikov wrote: > This patch introduces a sysfs group entry for the UFS health descriptor > parameters. The group adds "health_descriptor" folder under the UFS driver > sysfs entry (/sys/bus/platform/drivers/ufshcd/*). The parameters are shown >

Re: [PATCH v2 3/9] ufs: sysfs: geometry descriptor

2017-12-27 Thread Greg KH
On Wed, Dec 27, 2017 at 05:13:41PM +0200, Stanislav Nijnikov wrote: > This patch introduces a sysfs group entry for the UFS geometry descriptor > parameters. The group adds "geometry_descriptor" folder under the UFS > driver sysfs entry (/sys/bus/platform/drivers/ufshcd/*). The parameters > are

Re: [PATCH v2 2/9] ufs: sysfs: interconnect descriptor

2017-12-27 Thread Greg KH
On Wed, Dec 27, 2017 at 05:13:40PM +0200, Stanislav Nijnikov wrote: > This patch introduces a sysfs group entry for the UFS interconnect > descriptor parameters. The group adds "interconnect_descriptor" folder > under the UFS driver sysfs entry (/sys/bus/platform/drivers/ufshcd/*). > The

Re: [PATCH v2 1/9] ufs: sysfs: device descriptor

2017-12-27 Thread Greg KH
On Wed, Dec 27, 2017 at 05:13:39PM +0200, Stanislav Nijnikov wrote: > diff --git a/drivers/scsi/ufs/ufs-sysfs.c b/drivers/scsi/ufs/ufs-sysfs.c > new file mode 100644 > index 000..63a8e68 > --- /dev/null > +++ b/drivers/scsi/ufs/ufs-sysfs.c > @@ -0,0 +1,158 @@ > +#include > +#include > + >

Re: [PATCH v2 1/9] ufs: sysfs: device descriptor

2017-12-27 Thread Greg KH
On Wed, Dec 27, 2017 at 05:13:39PM +0200, Stanislav Nijnikov wrote: > +EXPORT_SYMBOL(ufs_sysfs_add_device_management); Whhy is this exported? What external module uses it? > + > +void ufs_sysfs_remove_device_management(struct ufs_hba *hba) > +{ > + sysfs_remove_groups(>dev->kobj,

Re: [PATCH v1 1/9] ufs: sysfs: device descriptor

2017-12-27 Thread Greg KH
On Wed, Dec 27, 2017 at 03:49:28PM +0200, Stanislav Nijnikov wrote: > Signed-off-by: Stanislav Nijnikov > --- I never want to take a patch with no changelog text at all, and to have a 9 patch series with nothing written in them at all? That's not good. Please fix

Re: [PATCH 1/2] scsi: ufs: introduce static sysfs entries

2017-12-20 Thread Greg KH
On Tue, Dec 19, 2017 at 12:02:53PM -0800, Jaegeuk Kim wrote: > From: Jaegeuk Kim <jaeg...@google.com> > > This patch introduces attribute group to show existing sysfs entries. > > Cc: Greg KH <gre...@linuxfoundation.org> > Signed-off-by: Jaegeuk Kim <jaeg...@goog

Re: [PATCH] driver core: Make it safe to use get_device() if the reference count is zero

2017-12-14 Thread Greg KH
On Thu, Dec 14, 2017 at 04:27:56PM +0800, Jason Yan wrote: > > > On 2017/12/14 16:10, Greg KH wrote: > > On Thu, Dec 14, 2017 at 03:56:46PM +0800, Jason Yan wrote: > > > > > > On 2017/12/14 15:42, Greg KH wrote: > > > > On Thu, Dec 14, 2017 at 11:3

Re: [PATCH] driver core: Make it safe to use get_device() if the reference count is zero

2017-12-14 Thread Greg KH
On Thu, Dec 14, 2017 at 03:56:46PM +0800, Jason Yan wrote: > > On 2017/12/14 15:42, Greg KH wrote: > > On Thu, Dec 14, 2017 at 11:39:36AM +0800, Jason Yan wrote: > > > Some driviers may have the chance to increase a reference count that > > > has dropped to zero w

Re: [PATCH] driver core: Make it safe to use get_device() if the reference count is zero

2017-12-13 Thread Greg KH
On Thu, Dec 14, 2017 at 11:39:36AM +0800, Jason Yan wrote: > Some driviers may have the chance to increase a reference count that > has dropped to zero when using get_device() because of their design. Then those drivers are broken :) > We have met such a issue with scsi: >

Re: UFS utilities

2017-11-29 Thread Greg KH
On Wed, Nov 29, 2017 at 03:39:19PM +, Bean Huo (beanhuo) wrote: > Hi, Greg > > >On Mon, Nov 27, 2017 at 11:25:47AM +, Bean Huo (beanhuo) wrote: > >> Hi, all > >> Is there someone knows if exists one utilis dedicated to UFS device, rather > >than SCSI utils? > >> I have tried sg3-utils,

Re: UFS utilities

2017-11-27 Thread Greg KH
On Mon, Nov 27, 2017 at 11:25:47AM +, Bean Huo (beanhuo) wrote: > Hi, all > Is there someone knows if exists one utilis dedicated to UFS device, rather > than SCSI utils? > I have tried sg3-utils, but it is not convenient for the embedded ARM-based > system. > And also it doesn't support

Re: [PATCH v3] scsi: require CAP_SYS_ADMIN to write to procfs interface

2017-11-05 Thread Greg KH
A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Sun, Nov 05, 2017 at

Re: [PATCH v3] scsi: require CAP_SYS_ADMIN to write to procfs interface

2017-11-05 Thread Greg KH
On Sun, Nov 05, 2017 at 01:56:35PM +1100, Aleksa Sarai wrote: > Previously, the only capability effectively required to operate on the > /proc/scsi interface was CAP_DAC_OVERRIDE (or for some other files, > having an fsuid of GLOBAL_ROOT_UID was enough). This means that > semi-privileged processes

Re: [PATCH v2 11/15] stm class: make config_item_type const

2017-10-17 Thread Greg KH
On Mon, Oct 16, 2017 at 05:18:50PM +0200, Bhumika Goyal wrote: > Make config_item_type structures const as they are either passed to a > function having the argument as const or used inside a if statement or > stored in the const "ci_type" field of a config_item structure. > > Done using

Re: [PATCH v2 01/15] configfs: make ci_type field, some pointers and function arguments const

2017-10-17 Thread Greg KH
On Mon, Oct 16, 2017 at 05:18:40PM +0200, Bhumika Goyal wrote: > The ci_type field of the config_item structure do not modify the fields > of the config_item_type structure it points to. And the other pointers > initialized with ci_type do not modify the fields as well. > So, make the ci_type

Re: [PATCH v2 00/15] make structure field, function arguments and structures const

2017-10-17 Thread Greg KH
On Tue, Oct 17, 2017 at 12:16:18PM +0200, Julia Lawall wrote: > > > On Tue, 17 Oct 2017, Greg KH wrote: > > > On Mon, Oct 16, 2017 at 05:18:39PM +0200, Bhumika Goyal wrote: > > > Make the ci_type field and some function arguments as const. After this > >

Re: [PATCH v2 00/15] make structure field, function arguments and structures const

2017-10-17 Thread Greg KH
On Mon, Oct 16, 2017 at 05:18:39PM +0200, Bhumika Goyal wrote: > Make the ci_type field and some function arguments as const. After this > change, make config_item_type structures as const. > > * Changes in v2- Combine all the followup patches and the constification > patches into a series. Who

Re: [PATCH 00/18] use ARRAY_SIZE macro

2017-10-01 Thread Greg KH
On Sun, Oct 01, 2017 at 08:52:20PM -0400, Jérémy Lefaure wrote: > On Mon, 2 Oct 2017 09:01:31 +1100 > "Tobin C. Harding" wrote: > > > > In order to reduce the size of the To: and Cc: lines, each patch of the > > > series is sent only to the maintainers and lists concerned by the

Re: [PATCH] scsi: qla2xxx: Fix an integer overflow in sysfs code

2017-08-30 Thread Greg KH
On Wed, Aug 30, 2017 at 03:21:07PM +0300, Dan Carpenter wrote: > The value of "size" comes from the user. When we add "start + size" > it could lead to an integer overflow bug. > > It means we vmalloc() a lot more memory than we had intended. I believe > that on 64 bit systems vmalloc() can

Re: [PATCH] storvsc: do not assume SG list is continuous when doing bounce buffers (for 4.1 stable only)

2017-08-23 Thread Greg KH
On Tue, Aug 22, 2017 at 11:43:19PM -0700, Christoph Hellwig wrote: > Ok. If the stable maintainers are ok with your small fix > I'm not going to complain too loudly. But I'm always worried about > stable trees divering too much from mainline. Given that 90% of the time we do this, something

Re: [PATCH] scsi: sg: Prevent potential double frees in sg driver

2017-08-03 Thread Greg KH
On Thu, Aug 03, 2017 at 12:34:51PM -0700, Nick Desaulniers wrote: > > Why no one on the to: line? > > I usually cc everyone from get_maintainer.pl. Should I be using > --to= then explicitly for named folks, and --cc= for lists? That's usually a good idea, many email clients throw away stuff if

Re: [PATCH] scsi: sg: Prevent potential double frees in sg driver

2017-08-03 Thread Greg KH
On Thu, Aug 03, 2017 at 12:02:47PM -0700, Nick Desaulniers wrote: > From: Robb Glasser > > sg_ioctl could be spammed by requests, leading to a double free in > __free_pages. This protects the entry points of sg_ioctl where the > memory could be corrupted by a double call to

[PATCH] SCSI: remove DRIVER_ATTR() usage

2017-07-19 Thread Greg KH
From: Greg Kroah-Hartman It's better to use the DRIVER_ATTR_RW() and DRIVER_ATTR_RO() macros to explicitly show that this is a read/write or read/only sysfs file. So convert the remaining SCSI drivers that use the old style to use the newer macros. Bonus is that

Re: [REGRESSION][Stable][v3.12.y][v4.4.y][v4.9.y][v4.10.y][v4.11-rc1] scsi: storvsc: properly set residual data length on errors

2017-03-30 Thread Greg KH
On Tue, Mar 28, 2017 at 04:14:09PM +, Stephen Hemminger wrote: > I decided not to send it to stable since problem was only observed on > 4.11 but it is probably endemic to all GEN2 VM's So, what does this mean? What should stable@ do? Nothing? Ok, now dropped this from my patch queue :)

Re: [PATCH v3 01/16] lpfc: Correct WQ creation for pagesize

2017-03-07 Thread Greg KH
On Tue, Mar 07, 2017 at 10:44:51AM -0300, Mauricio Faria de Oliveira wrote: > Hello stable kernel maintainers, > > On 03/07/2017 12:35 AM, Martin K. Petersen wrote: > > Mauricio> Please flag this patch for stable. > > > > Mauricio> This patch resolves a serious problem on IBM Power systems at >

Re: [PATCH] drivers: block: Remove unnecessary cast

2017-01-11 Thread Greg KH
On Wed, Jan 11, 2017 at 12:41:05PM -0600, Gustavo A. R. Silva wrote: > This issue was detected using Coccinelle and the following semantic patch: > > @@ > expression * e; > expression arg1, arg2; > type T; > @@ > > - e = (T *) > + e = > kmalloc(arg1, arg2); > > Signed-off-by: Gustavo A. R.

Re: [PATCH] ibmvscsis: Fix srp_transfer_data fail return code

2017-01-09 Thread Greg KH
On Mon, Jan 09, 2017 at 11:23:23AM -0600, Bryant G. Ly wrote: > On 1/9/17 10:47 AM, Greg KH wrote: > > > On Mon, Jan 09, 2017 at 10:21:20AM -0600, Bryant G. Ly wrote: > > > From: "Bryant G. Ly" <b...@us.ibm.com> > > > > > > If

Re: [PATCH] ibmvscsis: Fix srp_transfer_data fail return code

2017-01-09 Thread Greg KH
On Mon, Jan 09, 2017 at 10:21:20AM -0600, Bryant G. Ly wrote: > From: "Bryant G. Ly" > > If srp_transfer_data fails within ibmvscsis_write_pending, then > the most likely scenario is that the client timed out the op and > removed the TCE mapping. Thus it will loop forever

Re: Samsung SSD 1.92TB PM863 Enterprise 2.5" SATA3 errors withc stable 4.4.34

2016-12-14 Thread Greg KH
On Wed, Dec 14, 2016 at 03:07:48PM +0300, Vasiliy Tolstov wrote: > Hi! I have stable problems with all Samsung SSD drivers like PM863 and > EVO 850 Pro. > > Time after time scsi bus reset link with messages: > [ 2477.973617] ata1: exception Emask 0x50 SAct 0x0 SErr 0x4090800 > action 0xe frozen >

Re: [PATCH] mpt2sas: Fix secure erase premature termination.

2016-11-21 Thread Greg KH
On Mon, Nov 21, 2016 at 03:05:38PM +0530, Suganath Prabu Subramani wrote: > Commit id and other details are given below: > > commit 18f6084a989ba1b38702f9af37a2e4049a924be6 > Author: Andrey Grodzovsky > Date:   Thu Nov 10 09:35:27 2016 -0500 > >     scsi: mpt3sas: Fix

Re: [PATCH] mpt2sas: Fix secure erase premature termination.

2016-11-18 Thread Greg KH
On Fri, Nov 18, 2016 at 05:12:49PM +0530, Suganath Prabu S wrote: > Problem: > This is a work around for a bug with LSI Fusion MPT SAS2 when > pefroming secure erase. Due to the very long time the operation > takes commands issued during the erase will time out and will trigger > execution of

Re: [PATCH] [SCSI] mpt3sas: Fix secure erase premature termination (v3)

2016-11-10 Thread Greg KH
On Thu, Nov 10, 2016 at 08:42:52AM -0500, Andrey Grodzovsky wrote: > Problem: > This is a work around for a bug with LSI Fusion MPT SAS2 when > pefroming secure erase. Due to the very long time the operation > takes commands issued during the erase will time out and will trigger > execution of

Re: [PATCH] Avoid that SCSI device removal through sysfs triggers a deadlock

2016-11-07 Thread Greg KH
On Mon, Nov 07, 2016 at 04:32:18PM -0800, Bart Van Assche wrote: > The SCSI core holds scan_mutex around SCSI device addition and > removal operations. sysfs serializes attribute read and write > operations against attribute removal through s_active. Avoid that > grabbing scan_mutex during

Re: [PATCH v2 6/7] megaraid_sas: Do not set MPI2_TYPE_CUDA for JBOD FP path for FW which does not support JBOD sequence map

2016-10-20 Thread Greg KH
On Thu, Oct 20, 2016 at 02:05:04AM -0700, Sumit Saxena wrote: > CC: sta...@vger.kernel.org > Signed-off-by: Sumit Saxena > Reviewed-by: Hannes Reinecke > Reviewed-by: Tomas Henzl > --- > drivers/scsi/megaraid/megaraid_sas_fusion.c |

Re: [PATCH v1 1/3] Synchronization of cmds during termination conditions

2016-10-12 Thread Greg KH
On Tue, Oct 11, 2016 at 05:58:03PM -0500, Michael Cyr wrote: > Signed-off-by: Michael Cyr I almost never accept patches with no changelog information. For a patch that changes 1082 lines in a non-trivial way, you would think that you could explain why you are doing this

Re: [PATCH] scsi: introduce a quirk for false cache reporting

2016-09-09 Thread Greg KH
On Fri, Sep 09, 2016 at 07:26:17AM -0400, Martin K. Petersen wrote: > > "Oliver" == Oliver Neukum writes: > > Oliver> On Thu, 2016-08-18 at 22:19 -0400, Martin K. Petersen wrote: > >> > "Oliver" == Oliver Neukum writes: > >> > Oliver> Some SATA to

Re: [GIT PULL] [PATCH v4 00/26] Delete CURRENT_TIME and CURRENT_TIME_SEC macros

2016-08-16 Thread Greg KH
On Tue, Aug 16, 2016 at 11:18:52AM -0700, Deepa Dinamani wrote: > Thank you for the suggestion. > > > Who are you execting to pull this huge patch series? > > The last pull request was addressed to Al as per Arnd's suggestion. > I'm not completely sure who should it be addressed to. > > > Why

Re: [GIT PULL] [PATCH v4 00/26] Delete CURRENT_TIME and CURRENT_TIME_SEC macros

2016-08-15 Thread Greg KH
On Sat, Aug 13, 2016 at 03:48:12PM -0700, Deepa Dinamani wrote: > The series is aimed at getting rid of CURRENT_TIME and CURRENT_TIME_SEC > macros. > The macros are not y2038 safe. There is no plan to transition them into being > y2038 safe. > ktime_get_* api's can be used in their place. And,

Re: [PATCH v3 1/2] scsi: fix race between simultaneous decrements of ->host_failed

2016-06-02 Thread Greg KH
On Thu, Jun 02, 2016 at 04:42:37PM +0800, Wei Fang wrote: > sas_ata_strategy_handler() adds the works of the ata error handler > to system_unbound_wq. This workqueue asynchronously runs work items, > so the ata error handler will be performed concurrently on different > CPUs. In this case,

Re: [PATCH v3 2/2] Documentation/scsi: update scsi_eh.txt about ->host_failed

2016-06-02 Thread Greg KH
On Thu, Jun 02, 2016 at 04:42:38PM +0800, Wei Fang wrote: > Update the new rules of ->host_failed. > > Signed-off-by: Wei Fang > --- > Documentation/scsi/scsi_eh.txt |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) This is not the correct way to submit

Re: [PATCH] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

2016-05-24 Thread Greg KH
On Tue, May 24, 2016 at 09:44:43AM -0700, Bart Van Assche wrote: > On 05/24/2016 09:34 AM, Greg KH wrote: > > On Tue, May 24, 2016 at 09:25:05AM -0700, Bart Van Assche wrote: > > > > +static inline long h_send_crq(struct ibmvscsis_adapter *adapter, > > > > +

Re: [PATCH] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

2016-05-24 Thread Greg KH
On Tue, May 24, 2016 at 09:25:05AM -0700, Bart Van Assche wrote: > > +static inline long h_send_crq(struct ibmvscsis_adapter *adapter, > > + u64 word1, u64 word2) > > +{ > > + long rc; > > + struct vio_dev *vdev = adapter->dma_dev; > > + > > + pr_debug("ibmvscsis:

Re: [PATCH] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

2016-05-24 Thread Greg KH
On Tue, May 24, 2016 at 08:52:58AM -0500, Bryant G. Ly wrote: > From: bgly Really? Please go get a proper review from the other internal IBM developers to fix this, and the other obvious problems with your patch, before you send it publically and force us to tell you these

Re: [PATCH 1/1] uas: leave can_queue as MAX_CMNDS if device reports larger qdepth

2016-05-23 Thread Greg KH
On Tue, May 24, 2016 at 12:02:43AM +0800, tom.t...@gmail.com wrote: > From: Tom Yan > > Commit 198de51dbc34 ("USB: uas: Limit qdepth at the scsi-host level") made > qdepth limit set in host template (`.can_queue = MAX_CMNDS`) useless. > > Instead of removing the template

Re: [PATCH 0/4] Decouple X86_32 dependency from the ISA Kconfig option

2016-05-01 Thread Greg KH
On Sun, May 01, 2016 at 12:17:07PM -0400, William Breathitt Gray wrote: > On Wed, Apr 13, 2016 at 08:18:26AM -0700, Greg KH wrote: > >On Wed, Apr 13, 2016 at 10:48:42AM -0400, William Breathitt Gray wrote: > >> On Wed, Apr 13, 2016 at 04:38:38PM +0200, Ingo Molnar wrote: >

Re: raid 5 creation fails on usb3 connected drives kernel 4.4.x, 4.5

2016-04-16 Thread Greg KH
On Sun, Apr 17, 2016 at 02:41:51PM +1000, Brian Chadwick wrote: > On 17/04/16 02:46, Greg KH wrote: > > On Sat, Apr 16, 2016 at 09:25:13AM -0700, James Bottomley wrote: > > > On Sat, 2016-04-16 at 09:08 -0700, Greg KH wrote: > > > > On Sat, Apr 09, 2016 at 08:18:26

Re: raid 5 creation fails on usb3 connected drives kernel 4.4.x, 4.5

2016-04-16 Thread Greg KH
On Sat, Apr 16, 2016 at 09:25:13AM -0700, James Bottomley wrote: > On Sat, 2016-04-16 at 09:08 -0700, Greg KH wrote: > > On Sat, Apr 09, 2016 at 08:18:26PM +1000, Brian Chadwick wrote: > > > On 09/04/16 00:24, Greg KH wrote: > > > > On Fri, Apr 08, 2016 at 07:37:12

Re: raid 5 creation fails on usb3 connected drives kernel 4.4.x, 4.5

2016-04-16 Thread Greg KH
On Sat, Apr 09, 2016 at 08:18:26PM +1000, Brian Chadwick wrote: > On 09/04/16 00:24, Greg KH wrote: > > On Fri, Apr 08, 2016 at 07:37:12PM +1000, Brian Chadwick wrote: > > > On 08/04/16 01:59, Greg KH wrote: > > > > On Fri, Apr 08, 2016 at 01:34:51AM +1000, Brian Chad

Re: [PATCH 0/4] Decouple X86_32 dependency from the ISA Kconfig option

2016-04-13 Thread Greg KH
On Wed, Apr 13, 2016 at 10:48:42AM -0400, William Breathitt Gray wrote: > On Wed, Apr 13, 2016 at 04:38:38PM +0200, Ingo Molnar wrote: > >Ah, ok, so it's for enabling real hardware, not just a cleanup, right? You > >might > >want to put that info into the boilerplate mail or so. > > > >I'm

Re: [PATCH] csiostor: Fix backwards locking in the function __csio_unreg_rnode

2016-04-06 Thread Greg KH
On Wed, Apr 06, 2016 at 01:28:24PM -0400, James Bottomley wrote: > On Wed, 2016-04-06 at 13:23 -0400, Bastien Philbert wrote: > > > > On 2016-04-06 01:14 PM, James Bottomley wrote: > > > On Wed, 2016-04-06 at 10:36 -0400, Bastien Philbert wrote: > > > > > > > > On 2016-04-06 10:24 AM, James

Re: [PATCH v7] scsi: ufs: add ioctl interface for query request

2016-03-10 Thread Greg KH
On Thu, Mar 10, 2016 at 06:48:54PM -, yga...@codeaurora.org wrote: > > On Thu, Mar 10, 2016 at 04:29:55PM -, yga...@codeaurora.org wrote: > >> > On Thu, Mar 10, 2016 at 03:52:54PM -, yga...@codeaurora.org wrote: > >> >> > On Wed, Mar 09, 2016 at 08:52:59PM -, yga...@codeaurora.org

Re: [PATCH v7] scsi: ufs: add ioctl interface for query request

2016-03-10 Thread Greg KH
On Thu, Mar 10, 2016 at 04:29:55PM -, yga...@codeaurora.org wrote: > > On Thu, Mar 10, 2016 at 03:52:54PM -, yga...@codeaurora.org wrote: > >> > On Wed, Mar 09, 2016 at 08:52:59PM -, yga...@codeaurora.org wrote: > >> >> > On Wed, Mar 09, 2016 at 07:09:49PM -, yga...@codeaurora.org

Re: [PATCH v7] scsi: ufs: add ioctl interface for query request

2016-03-10 Thread Greg KH
On Thu, Mar 10, 2016 at 03:52:54PM -, yga...@codeaurora.org wrote: > > On Wed, Mar 09, 2016 at 08:52:59PM -, yga...@codeaurora.org wrote: > >> > On Wed, Mar 09, 2016 at 07:09:49PM -, yga...@codeaurora.org wrote: > >> >> > On Wed, Mar 09, 2016 at 04:11:33PM +0200, Yaniv Gardi wrote: >

Re: [PATCH v7] scsi: ufs: add ioctl interface for query request

2016-03-09 Thread Greg KH
On Wed, Mar 09, 2016 at 08:52:59PM -, yga...@codeaurora.org wrote: > > On Wed, Mar 09, 2016 at 07:09:49PM -, yga...@codeaurora.org wrote: > >> > On Wed, Mar 09, 2016 at 04:11:33PM +0200, Yaniv Gardi wrote: > >> >> This patch exposes the ioctl interface for UFS driver via SCSI device > >>

Re: [PATCH v7] scsi: ufs: add ioctl interface for query request

2016-03-09 Thread Greg KH
On Wed, Mar 09, 2016 at 07:09:49PM -, yga...@codeaurora.org wrote: > > On Wed, Mar 09, 2016 at 04:11:33PM +0200, Yaniv Gardi wrote: > >> This patch exposes the ioctl interface for UFS driver via SCSI device > >> ioctl interface. As of now UFS driver would provide the ioctl for query > >>

Re: [PATCH v7] scsi: ufs: add ioctl interface for query request

2016-03-09 Thread Greg KH
On Wed, Mar 09, 2016 at 04:11:33PM +0200, Yaniv Gardi wrote: > This patch exposes the ioctl interface for UFS driver via SCSI device > ioctl interface. As of now UFS driver would provide the ioctl for query > interface to connected UFS device. > > Reviewed-by: Subhash Jadavani

Re: [PATCH v2] megaraid_sas: add an i/o barrier

2016-02-01 Thread Greg KH
On Mon, Feb 01, 2016 at 03:12:04PM +0100, Tomas Henzl wrote: > A barrier should be added to ensure proper > ordering of memory mapped writes. > > V2: - added the barrier also to megasas_fire_cmd_skinny, > as suggested by Kashyap Desai > > Signed-off-by: Tomas Henzl > --- >

Re: [PATCH] megaraid_sas : Add locking to megasas_aen_polling

2015-10-30 Thread Greg KH
On Fri, Oct 30, 2015 at 01:47:50PM -0400, Ben Guthro wrote: > From: Glenn Watkins > > Under conditions of offlining drives, and rescanning the scsi host, > we can get into situations that the megasas_aen_polling kthread > can crash(GPF) in the megasas_aen_polling

Re: [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management

2015-10-16 Thread Greg KH
On Fri, Oct 16, 2015 at 01:03:42PM -0700, Lee Duncan wrote: > Adding linux-usb and linux-hotplug to cc list, in case they wish to comment. > > Summary: I want to change SCSI host number so that it gets re-used, like > disk index numbers, instead of always increasing. > > Please see below. > >

Re: [PATCH v2] hpsa: convert DEVICE_ATTR to RO|WO|RW and show methods must not use snprintf

2015-06-30 Thread Greg KH
On Wed, Jul 01, 2015 at 01:56:03AM +, Seymour, Shane M wrote: Changed DEVICE_ATTR macro usage to DEVICE_ATTR_RO|WO|RW. This also forced some show/store function names to change. Changed all show method snprintf() usage to scnprintf() per Documentation/filesystems/sysfs.txt. Forgot to

Re: [PATCH 3/3] hpsa: Convert DEVICE_ATTR macro usage to DEVICE_ATTR_RO|WR|WO

2015-06-30 Thread Greg KH g...@kroah.com (g...@kroah.com)
On Wed, Jul 01, 2015 at 03:47:10AM +, Seymour, Shane M wrote: Convert DEVICE_ATTR macro usage to DEVICE_ATTR_RO|WR|WO Changes forced some function names to change. Signed-off-by: Shane Seymour shane.seym...@hp.com Acked-by: Greg Kroah-Hartman gre...@linuxfoundation.org -- To

Re: [PATCH] hpsa: convert DEVICE_ATTR to RO|WO|RW and show methods must use scnprintf

2015-06-30 Thread Greg KH
On Tue, Jun 30, 2015 at 05:22:20AM +, Seymour, Shane M wrote: Changed DEVICE_ATTR macro usage to DEVICE_ATTR_RO|WO|RW. This also forced some show/store function names to change. Changed all show method sprint/snprintf usage to scnprintf per Documentation/filesystems/sysfs.txt. There's

Re: Backport of a fix for HPSA (Disabling a disabled device problem during kdump) driver

2015-06-29 Thread Greg KH
On Fri, May 22, 2015 at 12:19:16PM -0700, Vinson Lee wrote: On Sat, May 2, 2015 at 10:56 AM, Greg KH g...@kroah.com wrote: On Mon, Apr 27, 2015 at 03:10:35PM +0200, Tomas Henzl wrote: On 04/27/2015 02:55 PM, Greg KH wrote: On Mon, Apr 27, 2015 at 02:17:32PM +0200, Tomas Henzl wrote

Re: [PATCH] st: convert DRIVER_ATTR macros to DRIVER_ATTR_RO

2015-06-24 Thread Greg KH gre...@linuxfoundation.org (gre...@linuxfoundation.org)
On Wed, Jun 24, 2015 at 03:25:57PM +0900, Sergey Senozhatsky wrote: On (06/24/15 06:10), Seymour, Shane M wrote: [..] /* The sysfs driver interface. Read-only at the moment */ -static ssize_t st_try_direct_io_show(struct device_driver *ddp, char *buf) +static ssize_t

Re: [PATCH] st: convert DRIVER_ATTR macros to DRIVER_ATTR_RO

2015-06-24 Thread Greg KH gre...@linuxfoundation.org (gre...@linuxfoundation.org)
On Wed, Jun 24, 2015 at 03:25:57PM +0900, Sergey Senozhatsky wrote: On (06/24/15 06:10), Seymour, Shane M wrote: [..] /* The sysfs driver interface. Read-only at the moment */ -static ssize_t st_try_direct_io_show(struct device_driver *ddp, char *buf) +static ssize_t

Re: [PATCH v2] st: convert DRIVER_ATTR macros to DRIVER_ATTR_RO

2015-06-24 Thread Greg KH gre...@linuxfoundation.org (gre...@linuxfoundation.org)
On Wed, Jun 24, 2015 at 06:54:35AM +, Seymour, Shane M wrote: Convert DRIVER_ATTR macros to DRIVER_ATTR_RO requested by Greg KH. Also switched to using scnprintf instead of snprintf per Documentation/filesystems/sysfs.txt. Suggested-by: Greg Kroah-Hartman gre...@linuxfoundation.org

Re: [PATCH] st: convert to using driver attr groups for sysfs

2015-06-23 Thread Greg KH
On Tue, Jun 23, 2015 at 08:11:00AM +, Seymour, Shane M wrote: This patch changes the st driver to use attribute groups so driver sysfs files are created automatically. See the following for reference: http://kroah.com/log/blog/2013/06/26/how-to-create-a-sysfs-file-correctly/

Re: Backport of a fix for HPSA (Disabling a disabled device problem during kdump) driver

2015-04-27 Thread Greg KH
On Mon, Apr 27, 2015 at 02:17:32PM +0200, Tomas Henzl wrote: On 04/26/2015 11:27 AM, Greg KH wrote: On Mon, Apr 13, 2015 at 03:18:44PM +0200, Tomas Henzl wrote: On 04/11/2015 12:45 AM, Vinson Lee wrote: On Tue, Jan 27, 2015 at 4:18 PM, Greg KH g...@kroah.com wrote: On Tue, Jan 06, 2015

Re: [RFC] implementing tape statistics single file vs multi-file in sysfs

2015-02-10 Thread Greg KH
On Tue, Feb 10, 2015 at 02:27:20PM +, Bryn M. Reeves wrote: On Sat, Feb 07, 2015 at 12:07:43PM +0800, Greg KH wrote: $ cat /sys/fs/selinux/avc/cache_stats lookups hits misses allocations reclaims frees 18938916 18921707 17209 17209 17328 22215 38164283 38146514 17769 17769 16800 19049

Re: [PATCH] st implement tape statistics v3 (updated patch)

2015-02-09 Thread Greg KH
On Mon, Feb 09, 2015 at 11:56:25AM +, Seymour, Shane M wrote: Hi Greg, Thank you for pushing me to go that little further. The statistics directory is back. Any feedback from anyone would be appreciated. Thanks Shane -- Signed-off-by: shane.seym...@hp.com Tested-by:

Re: [PATCH] st implement tape statistics v3

2015-02-09 Thread Greg KH
On Mon, Feb 09, 2015 at 06:01:39AM +, Seymour, Shane M wrote: Hi All, Please find attached v3 of the patch. It implements the changes requested by Greg. The statistics files aren't in a separate directory any more they're implemented directly as device attributes unless someone has

Re: [PATCH RESEND] st implement tape statistics v3

2015-02-09 Thread Greg KH
Comment about your subject: the v3 needs to go inside the [] And you need to put below the --- line what has changed from the last version, I don't see any of my comments address here :( On Mon, Feb 09, 2015 at 10:41:38PM +, Seymour, Shane M wrote: The following patch exposes statistics for

Re: [RFC] implementing tape statistics single file vs multi-file in sysfs

2015-02-07 Thread Greg KH
On Fri, Feb 06, 2015 at 03:41:58PM +, Bryn M. Reeves wrote: On Fri, Feb 06, 2015 at 04:59:16AM -0800, Greg KH wrote: On Fri, Feb 06, 2015 at 12:20:53AM +, Seymour, Shane M wrote: The current patch that implements tape statistics is here: http://marc.info/?l=linux-scsim

Re: [RFC] implementing tape statistics single file vs multi-file in sysfs

2015-02-07 Thread Greg KH
On Sat, Feb 07, 2015 at 09:27:05PM -0500, Laurence Oberman wrote: Hello Its not going to be tens of thousands of devices. That count was an aggregate based on 1000's of servers. In reality its unlikely to ever be more than 100 tapes drives per individual Linux kernel instance. Therefore

Re: [RFC] implementing tape statistics single file vs multi-file in sysfs

2015-02-06 Thread Greg KH
On Fri, Feb 06, 2015 at 09:13:55AM +, Bryn M. Reeves wrote: The sysfs documentation says that files should contain one item per file (with some small exceptions): Attributes should be ASCII text files, preferably with only one value per file. It is noted that it may not be

Re: [RFC] implementing tape statistics single file vs multi-file in sysfs

2015-02-06 Thread Greg KH
On Fri, Feb 06, 2015 at 12:20:53AM +, Seymour, Shane M wrote: Hello linux-api'ers There has been some ongoing discussion about the best way to implement tape statistics. The original method suggested a long time ago used a single file in sysfs similar to block statistics in sysfs. That

  1   2   3   >