Re: [PATCH v3 01/13] mpt3sas: Update MPI Header

2017-08-08 Thread J Freyensee
Looks like your header has a white space error: Applying: mpt3sas: Update MPI Header .git/rebase-apply/patch:1452: new blank line at EOF. + Also, FYI, this project has a lot of sparse errors that look like existed before your patchset. As your patchset touches a few of the files that have

Re: [PATCH v4] add u64 number parser

2016-09-26 Thread J Freyensee
On Sun, 2016-09-25 at 09:14 -0700, James Smart wrote: > add u64 number parser > > Reverted back to version 2 of the patch.  This adds the interface > using existing logic. Comments from the prior reviewers to move to > kasprintf were rejected by Linus. > > Signed-off-by: James Smart

Re: [PATCH 5/5] nvme-fabrics: Add FC LLDD loopback driver to test FC host and target transport

2016-08-02 Thread J Freyensee
On Fri, 2016-07-22 at 17:23 -0700, James Smart wrote: A couple comments. > Add FC LLDD loopback driver to test FC host and target transport > within > nvme-fabrics > > To aid in the development and testing of the lower-level api of the > FC > transport, this loopback driver has been created to

Re: [PATCH 4/5] nvme-fabrics: Add target FC transport support

2016-08-01 Thread J Freyensee
On Fri, 2016-07-22 at 17:23 -0700, James Smart wrote: A few comments. > Add nvme-fabrics target FC transport support > > Implements the FC-NVME T11 definition of how nvme fabric capsules are > performed on an FC fabric. Utilizes a lower-layer API to FC host > adapters > to send/receive FC-4 LS

Re: [PATCH 1/5] nvme-fabrics: Add FC transport FC-NVME definitions

2016-07-29 Thread J Freyensee
On Mon, 2016-07-25 at 10:56 +0200, Johannes Thumshirn wrote: > On Fri, Jul 22, 2016 at 05:23:55PM -0700, James Smart wrote: > > > > nvme-fabrics: Add FC transport FC-NVME definitions: > > - Formats for Cmd, Data, Rsp IUs > > - Formats FC-4 LS definitions > > > > > > Signed-off-by: James Smart

Re: [PATCH 2/5] nvme-fabrics: Add FC transport LLDD api definitions

2016-07-29 Thread J Freyensee
On Mon, 2016-07-25 at 11:12 +0200, Johannes Thumshirn wrote: > On Fri, Jul 22, 2016 at 05:23:56PM -0700, James Smart wrote: > > > > nvme-fabrics: Add FC transport LLDD api definitions: > > > > Host: > > -LLDD registration with the host transport > > -registering host ports (local ports) and

Re: [PATCH 3/5] nvme-fabrics: Add host FC transport support

2016-07-29 Thread J Freyensee
On Fri, 2016-07-22 at 17:23 -0700, James Smart wrote: A couple of minor comments: > Add nvme-fabrics host FC transport support > > Implements the FC-NVME T11 definition of how nvme fabric capsules are > performed on an FC fabric. Utilizes a lower-layer API to FC host > adapters > to