Re: [PATCH] scsi: ibmvscsi: Improve strings handling

rom ‘ibmvscsi_probe’ at > drivers/scsi/ibmvscsi/ibmvscsi.c:2221:7: > drivers/scsi/ibmvscsi/ibmvscsi.c:265:3: warning: ‘strncpy’ specified > bound 97 equals destination size [-Wstringop-truncation] > > CC: Bart Van Assche > CC: Tyrel Datwyler > Signed-off-by: Breno Leit

[PATCH] ibmvfc: fix misdefined reserved field in ibmvfc_fcp_rsp_info

in a followup patch. Cc: sta...@vger.kernel.org Reported-by: Hannes Reinecke <h...@suse.de> Signed-off-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> --- drivers/scsi/ibmvscsi/ibmvfc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/ibmvscsi/ibmvfc.h b/

Re: [PATCH-next] ibmvfc: Remove unneeded semicolons

he correct email address. :) Acked-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com>

Re: [PATCH-next] ibmvfc: Remove unneeded semicolons

On 01/17/2018 05:38 PM, Christopher Díaz Riveros wrote: > Trivial fix removes unneeded semicolons after switch blocks. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Christopher Díaz Riveros <chris...@gentoo.org> > --- Acked

Re: [PATCH] scsi: ibmvscsi: Convert timers to use timer_setup()

t;martin.peter...@oracle.com> > Cc: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> > Cc: Benjamin Herrenschmidt <b...@kernel.crashing.org> > Cc: Paul Mackerras <pau...@samba.org> > Cc: Michael Ellerman <m...@ellerman.id.au> > Cc: "James E.J. Bottomley

Re: ibmvfc oddities

On 09/21/2017 08:13 AM, Brian King wrote: > On 09/21/2017 05:02 AM, Hannes Reinecke wrote: >> Hi Brian, >> >> I was looking at the ibmvfc code (trying to hook up libfc), and have >> found this definition: >> >> struct ibmvfc_fcp_rsp_info { >> __be16 reserved; >> u8 rsp_code; >> u8

Re: [PATCH] scsi: shost->async_scan should be protected by mutex_lock

On 09/07/2017 11:54 PM, Ouyangzhaowei (Charles) wrote: > shost->async_scan should be protected by mutex_lock, otherwise the check > of "called twice" won't work. > > Signed-off-by: Ouyang Zhaowei > --- > drivers/scsi/scsi_scan.c | 2 +- > 1 file changed, 1

Re: [PATCH 19/31] timer: Remove open-coded casts for .data and .function

On 08/31/2017 04:29 PM, Kees Cook wrote: > This standardizes the callback and data prototypes in several places that > perform casting, in an effort to remove more open-coded .data and > .function uses in favor of setup_timer(). > > Cc: Samuel Ortiz <sam...@sortiz.org> >

Re: [PATCH 19/31] timer: Remove open-coded casts for .data and .function

On 08/31/2017 04:29 PM, Kees Cook wrote: > This standardizes the callback and data prototypes in several places that > perform casting, in an effort to remove more open-coded .data and > .function uses in favor of setup_timer(). > > Cc: Samuel Ortiz <sam...@sortiz.org> >

Re: [PATCH][V2] scsi: qedf: fix spelling mistake: "offlading" -> "offloading"

On 07/03/2017 12:21 PM, Colin King wrote: > From: Colin Ian King <colin.k...@canonical.com> > > Trivial fix to spelling mistake in QEDF_INFO message and > remove duplicated "since" (thanks to Tyrel Datwyler for spotting > the latter issue). > > S

Re: [PATCH] scsi: qedf: fix spelling mistake: "offlading" -> "offloading"

On 07/03/2017 02:44 AM, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in QEDF_INFO message > > Signed-off-by: Colin Ian King > --- > drivers/scsi/qedf/qedf_main.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH] scsi: ibmvfc: constify dev_pm_ops structures.

gned-off-by: Arvind Yadav <arvind.yadav...@gmail.com> Acked-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com>

Re: [PATCH] scsi: ibmvscsi: constify dev_pm_ops structures.

> > Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> Acked-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com>

[PATCH] scsi: fix typos and grammar in comments of scsi_transport_fc.c

Signed-off-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> --- drivers/scsi/scsi_transport_fc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c index d4cf32d..6dd0922 100644 --- a/driver

Re: [PATCH] target: remove dead code

...@embeddedor.com> > --- Reviewed-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com>

Re: [PATCH] scsi: pmcraid: remove redundant check to see if request_size is less than zero

ove it. > > Detected by CoverityScan, CID#146149 ("Logically Dead Code") > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Reviewed-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com>

Re: [PATCH] ibmvscsis: Do not send aborted task response

le convoluted in my opinion, and a bit hard to follow. Otherwise, Reviewed-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> > > SCSI spec says that the initiator that sends the abort task > TM NEVER gets a response to the aborted op and with the current > code it will send a resp

Re: [PATCH] scsi: ibmvfc: don't check for failure from mempool_alloc()

On 04/09/2017 07:15 PM, NeilBrown wrote: > > mempool_alloc() cannot fail when passed GFP_NOIO or any > other gfp setting that is permitted to sleep. > So remove this pointless code. > > Signed-off-by: NeilBrown <ne...@suse.com> Acked-by: Tyrel Datwyler &l

Re: [PATCH] scsi: fc: remove redundant check of an unsigned long being less than zero

> Signed-off-by: Colin Ian King <colin.k...@canonical.com> Reviewed-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> > --- > drivers/scsi/scsi_transport_fc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/scsi_transport_fc.c

Re: [PATCH] ibmvscsi: add write memory barrier to CRQ processing

On 12/09/2016 01:20 PM, Benjamin Herrenschmidt wrote: > On Wed, 2016-12-07 at 17:31 -0600, Tyrel Datwyler wrote: >> The first byte of each CRQ entry is used to indicate whether an entry is >> a valid response or free for the VIOS to use. After processing a >> response the

Re: [PATCH] ibmvscsi: add write memory barrier to CRQ processing

On 12/08/2016 01:06 AM, Johannes Thumshirn wrote: > On Wed, Dec 07, 2016 at 05:31:26PM -0600, Tyrel Datwyler wrote: >> The first byte of each CRQ entry is used to indicate whether an entry is >> a valid response or free for the VIOS to use. After processing a >> response the

Re: [PATCH] ibmvscsi: add write memory barrier to CRQ processing

On 12/08/2016 03:29 PM, Paolo Bonzini wrote: > > > On 08/12/2016 00:31, Tyrel Datwyler wrote: >> The first byte of each CRQ entry is used to indicate whether an entry is >> a valid response or free for the VIOS to use. After processing a >> response the driver

[PATCH] ibmvscsi: add write memory barrier to CRQ processing

are reordered when updating the valid byte. Signed-off-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> --- drivers/scsi/ibmvscsi/ibmvscsi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c index d9534ee..2f5b07e

[PATCH 2/2] ibmvscsi: log bad SRP response opcode in hex format

An unrecogonized or unsupported SRP response has its opcode currently logged in decimal format. Log it in hex format instead so it can easily be validated against the SRP specs values which are in hex. Signed-off-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> --- drivers/scsi/ibmvscsi/ibmv

[PATCH 1/2] ibmvscsi: add vscsi hosts to global list_head

Add each vscsi host adatper to a new global list_head named ibmvscsi_head. There is no functional change. This is meant primarily as a convience for locating adatpers from within the debugger or crash utility. Signed-off-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> --- drivers/scsi/ib

Re: [PATCH RESEND v4 02/15] scsi: don't use fc_bsg_job::request and fc_bsg_job::reply directly

s/scsi/scsi_transport_fc.c | 55 > 10 files changed, 398 insertions(+), 275 deletions(-) For ibmvfc portion... Acked-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message

Re: [PATCH v3 13/16] scsi: fc: use bsg_job_done

e.com> For ibmvfc parts, Acked-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 10/16] scsi: change FC drivers to use 'struct bsg_job'

y: Hannes Reinecke <h...@suse.com> For ibmvfc parts, Acked-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 06/16] scsi: fc: provide fc_bsg_to_rport() helper

use.de> > Reviewed-by: Hannes Reinecke <h...@suse.com> For ibmvfc parts, Acked-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 05/16] scsi: fc: provide fc_bsg_to_shost() helper

use.de> > Reviewed-by: Hannes Reinecke <h...@suse.com> For ibmvfc parts, Acked-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 04/16] scsi: Unify interfaces of fc_bsg_jobdone and bsg_job_done

> Reviewed-by: Hannes Reinecke <h...@suse.com> For ibmvfc parts, Acked-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 0/6] Fixes for ibmvscsis driver

On 10/14/2016 03:25 PM, Steven Royer wrote: > On 2016-10-13 11:02, Michael Cyr wrote: >> Various fixes and cleanups for the ibmvscsis driver. >> The first is a sort of prequel to the second, which is the primary >> change (and the biggest). The rest are fairly small fixes. >> >> Michael Cyr (6):

Re: [PATCH 1/1] ibmvfc: Fix I/O hang when port is not mapped

On 09/19/2016 06:59 AM, Brian King wrote: > If a VFC port gets unmapped in the VIOS, it may not respond with a CRQ init > complete following H_REG_CRQ. If this occurs, we can end up having called > scsi_block_requests and not a resulting unblock until the init complete > happens, which may never

Re: [PATCH 1/1] ibmvfc: Fix I/O hang when port is not mapped

ch may never occur, and we end up hanging I/O requests. > This patch ensures the host action stay set to IBMVFC_HOST_ACTION_TGT_DEL so > we move all rports into devloss state and unblock unless we receive an > init complete. > > Signed-off-by: Brian King <brk...@linux.vnet.ibm.

Re: [PATCH v1] Ibmvscsis: Fixed unused variable

On 09/16/2016 07:25 AM, Bryant G. Ly wrote: > Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com> Reviewed-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> > --- > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --g

Re: [PATCH] scsi: replace broken specification URL

On 09/09/2016 01:16 AM, Michael Opdenacker wrote: > Hi James, > > Thank you very much for your help... > > On 02/07/2016 16:49, James Bottomley wrote: >> On Sat, 2016-07-02 at 08:56 +0200, Michael Opdenacker wrote: >>> The t10.org website containing SCSI-2 draft specifications now >>> requires

Re: [PATCH -next] scsi: ibmvfc: fix typo in parameter description

On 09/08/2016 08:04 AM, Wei Yongjun wrote: > From: Wei Yongjun <weiyongj...@huawei.com> > > Fix typo in parameter description. > > Signed-off-by: Wei Yongjun <weiyongj...@huawei.com> Reviewed-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> -- To unsubscr

Re: [PATCH -next] ibmvscsis: Use list_move_tail instead of list_del/list_add_tail

On 07/22/2016 07:03 AM, Wei Yongjun wrote: > Using list_move_tail() instead of list_del() + list_add_tail(). > > Signed-off-by: Wei Yongjun <weiyj...@gmail.com> Reviewed-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line &q

[PATCH v2] scsi: fix upper bounds check of sense key in scsi_sense_key_string()

Commit 655ee63cf371 added a "Completed" sense string with key 0xF to snstext[], but failed to updated the upper bounds check of the sense key in scsi_sense_key_string(). Fixes: 655ee63cf371 ("[SCSI] scsi constants: command, sense key + additional sense strings") Signed-of

Re: [PATCH] scsi: fix upper bounds check of sense key in scsi_sense_key_string()

On 08/09/2016 01:08 PM, Bart Van Assche wrote: > On 08/04/2016 02:32 PM, Tyrel Datwyler wrote: >> Commit 655ee63cf371 added a "Completed" sense string with key 0xF to >> snstext[], but failed to updated the upper bounds check of the sense key in >> scsi_

Re: [PATCH 0/2] ibmvfc: FC-TAPE Support

On 08/03/2016 02:36 PM, Tyrel Datwyler wrote: > This patchset introduces optional FC-TAPE/FC Class 3 Error Recovery to the > ibmvfc client driver. > > Tyrel Datwyler (2): > ibmvfc: Set READ FCP_XFER_READY DISABLED bit in PRLI > ibmvfc: add FC Class 3 Error Recovery support

[PATCH] scsi: fix upper bounds check of sense key in scsi_sense_key_string()

Commit 655ee63cf371 added a "Completed" sense string with key 0xF to snstext[], but failed to updated the upper bounds check of the sense key in scsi_sense_key_string(). Fixes: 655ee63cf371 ("[SCSI] scsi constants: command, sense key + additional sense strings") Signed-of

[PATCH] ibmvfc: Set READ FCP_XFER_READY DISABLED bit in PRLI

The READ FCP_XFER_READY DISABLED bit is required to always be set to one since FCP-3. Set it in the service parameter page frame during process login. Signed-off-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> --- drivers/scsi/ibmvscsi/ibmvfc.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH 0/2] ibmvfc: FC-TAPE Support

This patchset introduces optional FC-TAPE/FC Class 3 Error Recovery to the ibmvfc client driver. Tyrel Datwyler (2): ibmvfc: Set READ FCP_XFER_READY DISABLED bit in PRLI ibmvfc: add FC Class 3 Error Recovery support drivers/scsi/ibmvscsi/ibmvfc.c | 11 +++ drivers/scsi/ibmvscsi

[PATCH] ibmvfc: add FC Class 3 Error Recovery support

at boot time. When enabled the RETRY service parameter bit is set during PRLI, and ibmvfc_cmd->flags includes the IBMVFC_CLASS_3_ERR bit. Signed-off-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> --- drivers/scsi/ibmvscsi/ibmvfc.c | 10 ++ drivers/scsi/ibmvscsi/ibmvfc.h | 1 +

Re: [PATCH v2] lpfc: Fix possible NULL pointer dereference

On 07/29/2016 06:30 AM, Johannes Thumshirn wrote: > Check for the existence of piocb->vport before accessing it. > > Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> Reviewed-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the

Re: [PATCH] lpfc: Fix possible NULL pointer dereference

On 06/15/2016 06:00 AM, Johannes Thumshirn wrote: > Check for the existance of pciob->vport before accessing it. piocb mispelled. > > Signed-off-by: Johannes Thumshirn > --- > drivers/scsi/lpfc/lpfc_sli.c | 13 - > 1 file changed, 4 insertions(+), 9

SHOST_RECOVERY hang with host_busy < host_failed

I'm seeing a non-deterministic I/O hang with the ibmvfc driver when we migrate a guest/partition to a different machine. So, on the occasions when this hits the systems becomes unresponsive blocked on I/O. I started by inspecting Scsi_Host of the driver which shows shost->state = SHOST_RECOVERY

Re: [PATCH v2 3/7] ibmvscsi: Replace magic values in set_adpater_info() with defines

On 02/12/2016 08:43 AM, James Bottomley wrote: > On Wed, 2016-02-10 at 19:32 -0600, Tyrel Datwyler wrote: >> Add defines for mad version and mad os_type, and replace the magic >> numbers in set_adapter_info() accordingly. >> >> Signed-off-by: Tyrel Datwyler

[PATCH] ibmvfc: byteswap scsi_id, wwpn, and node_name prior to logging

When logging async events the scsi_id, wwpn, and node_name values are used directly from the CRQ struct which are of type __be64. This can be confusing to someone looking through the log on a LE system. Instead byteswap these values to host endian prior to logging. Signed-off-by: Tyrel Datwyler

[PATCH v2 0/7] ibmvscsi code cleanup

lid != VIOSRP_CRQ_FREE before handling in place of hacky bitwise & to check for first bit being set. -Added define for AIX os_type -Left sysfs config attribute to prevent breaking userspace Tyrel Datwyler (7): ibmvscsi: Correct values for several viosrp_crq_format enums ibmvscsi: Add and use enums for va

[PATCH v2 4/7] ibmvscsi: Use of_root to access OF device tree root node

The root node of the OF device tree is exported as of_root. No need to look up the root by path name. Instead just get a reference directly via of_root. Signed-off-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/s

[PATCH v2 6/7] ibmvscsi: Add endian conversions to sysfs attribute show functions

-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/scsi/ibmvscsi/ibmvscsi.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c index e8d4

[PATCH v2 7/7] ibmvscsi: use H_CLOSED instead of magic number

In a couple places the magic value of 2 is used to check the return code of hypercalls. This translates to H_CLOSED. Signed-off-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> --- drivers/scsi/ibmvscsi/ibmvscsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/driver

[PATCH v2 3/7] ibmvscsi: Replace magic values in set_adpater_info() with defines

Add defines for mad version and mad os_type, and replace the magic numbers in set_adapter_info() accordingly. Signed-off-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> --- drivers/scsi/ibmvscsi/ibmvscsi.c | 8 drivers/scsi/ibmvscsi/viosrp.h | 3 +++ 2 files changed, 7 insertions

[PATCH v2 5/7] ibmvscsi: Remove unsupported host config MAD

by any AIX based VIOS. Treating as bit rot and removing the associated host config code. The config attribute and its show function are left as not to break userspace. The behavior remains the same returning nothing. Signed-off-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> --- driver

[PATCH v2 2/7] ibmvscsi: Add and use enums for valid CRQ header values

initialize (0x01) and initialize complete (0x02). Define these values as enums and use them in the code in place of their magic number equivalents. Signed-off-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> --- drivers/scsi/ibmvscsi/ibmvscsi.c | 18 +- drivers/scsi/ibmvscsi/viosrp.h

[PATCH v2 1/7] ibmvscsi: Correct values for several viosrp_crq_format enums

support of PING messages between the VIOS and client adapter relies on VIOSRP_INLINE_FORMAT crq messages. Corrected these enum values to match PAPR definitions. Signed-off-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/s

Re: [PATCH 2/6] ibmvscsi: Add and use enums for valid CRQ header values

On 02/09/2016 09:41 AM, Manoj Kumar wrote: >> Yeah, I can see how that is confusing. Since, all three possible valid >> crq message types have the first bit set I think this was originally a >> cute hack to grab anything that was likely valid. Then in >> ibmvscsi_handle_crq() we explicitly match

Re: [PATCH 2/6] ibmvscsi: Add and use enums for valid CRQ header values

On 02/04/2016 11:55 AM, Manoj Kumar wrote: > On 2/3/2016 5:28 PM, Tyrel Datwyler wrote: >> The PAPR defines four valid header values for the first byte of a >> CRQ message. Namely, an unused/empty message (0x00), a valid >> command/response entry (0x80), a valid initi

Re: [PATCH 5/6] ibmvscsi: Remove unsupported host config MAD and sysfs interface

On 02/04/2016 12:03 AM, Johannes Thumshirn wrote: > On Wed, Feb 03, 2016 at 05:28:33PM -0600, Tyrel Datwyler wrote: >> A VIOSRP_HOST_CONFIG_TYPE management datagram (MAD) has existed in >> the code for some time. From what information I've gathered from >> Brian King this w

[PATCH 4/6] ibmvscsi: Use of_root to access OF device tree root node

The root node of the OF device tree is exported as of_root. No need to look up the root by path name. Instead just get a reference directly via of_root. Signed-off-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> --- drivers/scsi/ibmvscsi/ibmvscsi.c | 14 ++ 1 file chan

[PATCH 3/6] ibmvscsi: Replace magic values in set_adpater_info() with defines

Add defines for mad version and mad os_type, and replace the magic numbers in set_adapter_info() accordingly. Signed-off-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> --- drivers/scsi/ibmvscsi/ibmvscsi.c | 4 ++-- drivers/scsi/ibmvscsi/viosrp.h | 2 ++ 2 files changed, 4 insertions

[PATCH 5/6] ibmvscsi: Remove unsupported host config MAD and sysfs interface

by any AIX based VIOS. Treating as bit rot and removing the sysfs interface and associated host config code accordingly. Signed-off-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> --- drivers/scsi/ibmvscsi/ibmvscsi.c | 78 drivers/scsi/ibmvscsi/vi

[PATCH 6/6] ibmvscsi: Add endian conversions to sysfs attribute show functions

-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> --- drivers/scsi/ibmvscsi/ibmvscsi.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c index a2b8db1..3621ac5 100644 --- a/drivers/scsi/ibmvscsi/ibmvscsi.c

[PATCH 1/6] ibmvscsi: Correct values for several viosrp_crq_format enums

support of PING messages between the VIOS and client adapter relies on VIOSRP_INLINE_FORMAT crq messages. Corrected these enum values to match PAPR definitions. Signed-off-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> --- drivers/scsi/ibmvscsi/viosrp.h | 4 ++-- 1 file changed, 2 insertions

[PATCH 2/6] ibmvscsi: Add and use enums for valid CRQ header values

of their magic number equivalents. Signed-off-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> --- drivers/scsi/ibmvscsi/ibmvscsi.c | 14 +++--- drivers/scsi/ibmvscsi/viosrp.h | 7 +++ 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/d

[PATCH 0/6] ibmvscsi: code cleanup

Fixed up a couple spots that were out of line with the PAPR in regards to its defined VSCSI protocol. Did away with some magic numbers directly in the code. Fixed a minor endian issue. Tyrel Datwyler (6): ibmvscsi: Correct values for several viosrp_crq_format enums ibmvscsi: Add and use enums

Re: [PATCH 1/3] ibmvsci: make parameters max_id and max_channel read-only

On 09/10/2015 02:23 AM, Laurent Vivier wrote: > The value of the parameter is never re-read by the driver, > so a new value is ignored. Let know the user he > can't modify it by removing writable attribute. > > Signed-off-by: Laurent Vivier <lviv...@redhat.com> Acked-by

Re: [PATCH 3/3] ibmvsci: Allow to configure maximum LUN

On 09/10/2015 02:23 AM, Laurent Vivier wrote: > QEMU allows until 32 LUNs. > > Signed-off-by: Laurent Vivier <lviv...@redhat.com> Acked-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> > --- > drivers/scsi/ibmvscsi/ibmvscsi.c | 5 - > 1 file changed, 4 insertio

Re: [PATCH 2/3] ibmvcsci: display default value for max_id, max_lun and max_channel.

On 09/10/2015 02:23 AM, Laurent Vivier wrote: > As devices with values greater than that are silently ignored, > this gives some hints to the sys admin to know why he doesn't see > his devices... > > Signed-off-by: Laurent Vivier <lviv...@redhat.com> Acked-by

Re: [PATCH] ibmvscsi:Make the variable rc to be a integer in the function ibmvfc_handle_crq

in ibmvfc_handle_crq() to match return type of ibmvfc_send_crq_init_complete(). Otherwise, Acked-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com --- drivers/scsi/ibmvscsi/ibmvfc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi

Re: [PATCH] ibmvscsi:Remove no longer required comment for the function send_mad_adapter_info

...@gmail.com Acked-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com --- drivers/scsi/ibmvscsi/ibmvscsi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c index 6a41c36..70ea976 100644 --- a/drivers/scsi/ibmvscsi/ibmvscsi.c

Re: [PATCH] ibmvscsi:Remove no longer required comments about return values in the file ibmvfc.c

about return values from ibmvfc_init_host() and ibmvfc_reinit_host() as they are both declared to have return type void. Otherwise, Acked-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com --- drivers/scsi/ibmvscsi/ibmvfc.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/scsi/ibmvscsi

Re: [PATCH 08/17] ibmvscsi: Fix bidi command test

On 01/23/2015 04:10 AM, Bart Van Assche wrote: Signed-off-by: Bart Van Assche bart.vanass...@sandisk.com Cc: Brian King brk...@linux.vnet.ibm.com Cc: Nathan Fontenot nf...@linux.vnet.ibm.com --- drivers/scsi/ibmvscsi/ibmvscsi.c | 10 ++ 1 file changed, 6 insertions(+), 4

[PATCH 2/2] MAINTAINERS: ibmvfc driver maintainer change

Change maintainer of ibmvfc driver to Tyrel Datwyler. Signed-off-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com Cc: Nathan Fontenot nf...@linux.vnet.ibm.com Cc: Brian King brk...@linux.vnet.ibm.com --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b

[PATCH 1/2] MAINTAINERS: ibmvscsi driver maintainer change

Change maintainer of ibmvscsi driver to Tyrel Datwyler. Signed-off-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com Cc: Nathan Fontenot nf...@linux.vnet.ibm.com Cc: Brian King brk...@linux.vnet.ibm.com --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b

[PATCH] ibmvfc: fix little endian issues

Added big endian annotations to relevant data structure fields, and necessary byte swappings to support little endian builds. Signed-off-by: Brian King brk...@linux.vnet.ibm.com Signed-off-by: Tyrel Datwyler tyr...@linux.vnet.ibm.com --- drivers/scsi/ibmvscsi/ibmvfc.c | 473