Re: [PATCH v5 2/3] libata: async resume
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 03/05/2014 03:17 PM, Dan Williams wrote: From: Todd Brandt todd.e.bra...@linux.intel.com Improve overall system resume time by making libata link recovery actions asynchronous relative to other resume events. Link resume operations are performed using the scsi_eh thread, so commands, particularly the sd resume start/stop command, will be held off until the device exits error handling. Libata already flushes eh with ata_port_wait_eh() in the port teardown paths, so there are no concerns with async operation colliding with the end-of-life of the ata_port object. Also, libata-core is already careful to flush in-flight pm operations before another round of pm starts on the given ata_port. I realize this is a little late but I finally started looking at the patch set I was working on last year again, and now that I look at your version that was accepted, I realize that it only addresses the libata side of things. sd still issues START_STOP_UNIT synchronously in the resume path, so without the patch fixing that, you shouldn't see any actual speed up in resume times. Or are you using the manage_start_stop flag to inhibit that ( at the cost of taking an emergency park on each suspend/shutdown )? -BEGIN PGP SIGNATURE- Version: GnuPG v1 iQEcBAEBCgAGBQJUlLjNAAoJENRVrw2cjl5RU48H/2APBJMJ9XyTEfa7r6+M76zH jf238VwOJUuTUC+Mh2h3AoQVkNy4E8CM/CAnWww8Y1iAvuRTptp9J64NrAQdylCf p3KLIqhXaGmGvgx1SpzwzwGhbvZ9YM8w1uRC1VLACr9ZwySjEXyEv3B2kZDDUMEj xxnnQfM47f2km6pxhV7nzt1jHlvaWhvPsuRSaVFxLQstbGR9U1VLJnESZgBFYipR w5z0dmhssE21A/T8B7dSAx5tDCATeWsMn5fDtQ15MFXgfguXrmmOuHLBtv9EGPZt d5M1rr2E7WXems5pBoxJMcYFblwQ/h30qPEkRNgYXrfTRx7h79q20tWNI+B1D1c= =s6tS -END PGP SIGNATURE- -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v5 2/3] libata: async resume
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 12/19/2014 06:46 PM, Phillip Susi wrote: I realize this is a little late but I finally started looking at the patch set I was working on last year again, and now that I look at your version that was accepted, I realize that it only addresses the libata side of things. sd still issues START_STOP_UNIT synchronously in the resume path, so without the patch fixing that, you shouldn't see any actual speed up in resume times. Or are you using the manage_start_stop flag to inhibit that ( at the cost of taking an emergency park on each suspend/shutdown )? Sorry for the noise, I missed the patch to the scsi core that makes the entire call to sd_resume async. Very nice. -BEGIN PGP SIGNATURE- Version: GnuPG v1 iQEcBAEBCgAGBQJUlNQQAAoJENRVrw2cjl5RUP8H/3hz6qRtSbRJPYya2RCsjgWE dM5tm9RXJurPYCa615NmMX+bym2ooSVlYFZPAkuEtIh+uOeO7S9z5WX6de7ErtyN yNZNSPQXMZDLOzwy0gnZr2BU0Htk4LpX+2mdmos9oVQJJXqc2n1Nje3NXF/F6qm8 I8fjKTyOLQgI8GbJNFkK028rjvxc1DYTGx2hgC2KYpuktdyrJv6c68TZBUF1jFQm UVsp1xpN5BoGGbhb13LBVm1To8V5YyEvR6Ou1Y633VM4089HLUWMwVBwVIjryyiY gR6dHdqs/a/1nuXFGZXAMZXhLFuNJ2a/h98QcX5ZxuaKP8XFEN6V/JyXxiekxK8= =Vtbl -END PGP SIGNATURE- -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v5 2/3] libata: async resume
From: Todd Brandt todd.e.bra...@linux.intel.com
Improve overall system resume time by making libata link recovery
actions asynchronous relative to other resume events.
Link resume operations are performed using the scsi_eh thread, so
commands, particularly the sd resume start/stop command, will be held
off until the device exits error handling. Libata already flushes eh
with ata_port_wait_eh() in the port teardown paths, so there are no
concerns with async operation colliding with the end-of-life of the
ata_port object. Also, libata-core is already careful to flush
in-flight pm operations before another round of pm starts on the given
ata_port.
Reference:
https://01.org/suspendresume/blogs/tebrandt/2013/hard-disk-resume-optimization-simpler-approach
Cc: Len Brown len.br...@intel.com
Cc: Phillip Susi ps...@ubuntu.com
Cc: Alan Stern st...@rowland.harvard.edu
Signed-off-by: Todd Brandt todd.e.bra...@linux.intel.com
[djbw: rebase on cleanup patch, changelog wordsmithing]
Signed-off-by: Dan Williams dan.j.willi...@intel.com
---
drivers/ata/libata-core.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 0f47436c714c..7719ec7d9df9 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -5444,7 +5444,7 @@ static int ata_port_resume(struct device *dev)
{
int rc;
- rc = ata_port_resume_sync(to_ata_port(dev), PMSG_RESUME);
+ rc = queue_ata_port_resume(to_ata_port(dev), PMSG_RESUME);
if (!rc) {
pm_runtime_disable(dev);
pm_runtime_set_active(dev);
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
