[PATCH][SCSI] fix regression in SCSI_IOCTL_SEND_COMMAND

2014-08-22 Thread Tony Battersby
blk_rq_set_block_pc() memsets rq-cmd to 0, so it should come immediately after blk_get_request() to avoid overwriting the user-supplied CDB. Also check for failure to allocate rq. Fixes: f27b087b81b7 (block: add blk_rq_set_block_pc()) Cc: sta...@vger.kernel.org # 3.16.x Signed-off-by: Tony

Re: [PATCH][SCSI] fix regression in SCSI_IOCTL_SEND_COMMAND

2014-08-22 Thread Douglas Gilbert
On 14-08-22 03:53 PM, Tony Battersby wrote: blk_rq_set_block_pc() memsets rq-cmd to 0, so it should come immediately after blk_get_request() to avoid overwriting the user-supplied CDB. Also check for failure to allocate rq. Fixes: f27b087b81b7 (block: add blk_rq_set_block_pc()) Cc:

Re: [PATCH][SCSI] fix regression in SCSI_IOCTL_SEND_COMMAND

2014-08-22 Thread Christoph Hellwig
On Fri, Aug 22, 2014 at 08:28:27PM -0400, Douglas Gilbert wrote: To test this ioctl one option is to get the sg3_utils package and build scsi_ioctl.c in the examples directory with 'make scsi_ioctl'. In lk 3.17-rc1, scsi_ioctl indicates that SCSI_IOCTL_SEND_COMMAND is not working. In my test