Re: [PATCH] add missing class_device_del to transport classes

2005-01-29 Thread James Bottomley
On Wed, 2005-01-26 at 15:59 -0800, Mike Christie wrote: > It appears there is a missing class_device_del. > The comments for transport_remove_device indicate > that transport_remove_classdev should call it > (which the attached patch does), but the comment in > attribute_container_remove_device: O

Re: [PATCH] add missing class_device_del to transport classes

2005-01-27 Thread James Bottomley
On Wed, 2005-01-26 at 15:59 -0800, Mike Christie wrote: > It appears there is a missing class_device_del. Yes, my fault for converting it incorrectly. What it's supposed to use is the (nonexistent) equivalent of attribute_container_class_device_del and attribute_container_add_class_attrs, but bas

[PATCH] add missing class_device_del to transport classes

2005-01-26 Thread Mike Christie
James, It appears there is a missing class_device_del. The comments for transport_remove_device indicate that transport_remove_classdev should call it (which the attached patch does), but the comment in attribute_container_remove_device: If you want a * two phase release: remove from visibility a