Re: [PATCH] bnx2fc: Set no_async_abort to 1 in SCSI host template.

2014-08-07 Thread Christoph Hellwig
On Wed, Aug 06, 2014 at 04:01:12PM -0400, Chad Dupuis wrote: This was on RHEL 7. Should we retry the test case with the latest mainline? Yes. Please always test your patches against latest mainline. If that is for some reason not possible please at least very prominently mention that the

Re: [PATCH] bnx2fc: Set no_async_abort to 1 in SCSI host template.

2014-08-06 Thread Christoph Hellwig
On Tue, Aug 05, 2014 at 05:02:46PM -0400, Chad Dupuis wrote: On Tue, 5 Aug 2014, Venkatesh Srinivas wrote: On Tue, Aug 5, 2014 at 12:45 PM, Chad Dupuis chad.dup...@qlogic.com wrote: Set this to 1 for now as we've observed crashes when this is set to the default value of 0. What sorts of

Re: [PATCH] bnx2fc: Set no_async_abort to 1 in SCSI host template.

2014-08-06 Thread Chad Dupuis
On Wed, 6 Aug 2014, Christoph Hellwig wrote: On Tue, Aug 05, 2014 at 05:02:46PM -0400, Chad Dupuis wrote: On Tue, 5 Aug 2014, Venkatesh Srinivas wrote: On Tue, Aug 5, 2014 at 12:45 PM, Chad Dupuis chad.dup...@qlogic.com wrote: Set this to 1 for now as we've observed crashes when this is

[PATCH] bnx2fc: Set no_async_abort to 1 in SCSI host template.

2014-08-05 Thread Chad Dupuis
Set this to 1 for now as we've observed crashes when this is set to the default value of 0. Signed-off-by: Chad Dupuis chad.dup...@qlogic.com --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c

Re: [PATCH] bnx2fc: Set no_async_abort to 1 in SCSI host template.

2014-08-05 Thread Venkatesh Srinivas
On Tue, Aug 5, 2014 at 12:45 PM, Chad Dupuis chad.dup...@qlogic.com wrote: Set this to 1 for now as we've observed crashes when this is set to the default value of 0. What sorts of crashes have you seen with no_async_abort=0 (default)? At which kernel versions? Thanks, -- vs; -- To

Re: [PATCH] bnx2fc: Set no_async_abort to 1 in SCSI host template.

2014-08-05 Thread Chad Dupuis
On Tue, 5 Aug 2014, Venkatesh Srinivas wrote: On Tue, Aug 5, 2014 at 12:45 PM, Chad Dupuis chad.dup...@qlogic.com wrote: Set this to 1 for now as we've observed crashes when this is set to the default value of 0. What sorts of crashes have you seen with no_async_abort=0 (default)? At which