Re: [PATCH] libsas: remove task_collector mode

2014-11-24 Thread Dan Williams
On Mon, Nov 24, 2014 at 12:41 AM, Christoph Hellwig wrote: > The task_collector mode (or "latency_injector", (C) Dan Willians) is an > optional I/O path in libsas that queues up scsi commands instead of > directly sending it to the hardware. It generall increases latencies > to in the optiomal ca

Re: [PATCH] libsas: remove task_collector mode

2014-11-24 Thread Hannes Reinecke
On 11/24/2014 09:54 AM, Christoph Hellwig wrote: >> Why did you not remove the last argument from asd_can_queue() and >> asd_can_dequeue(), too? >> With that patch it's always '1' ... > > Because I wanted to remove the libsas (mis-)feature and avoid to many boad > driver changes. Especially for a

Re: [PATCH] libsas: remove task_collector mode

2014-11-24 Thread Christoph Hellwig
> Why did you not remove the last argument from asd_can_queue() and > asd_can_dequeue(), too? > With that patch it's always '1' ... Because I wanted to remove the libsas (mis-)feature and avoid to many boad driver changes. Especially for a unmaintained big driver like aic94xx. > This 'while' loo

Re: [PATCH] libsas: remove task_collector mode

2014-11-24 Thread Hannes Reinecke
On 11/24/2014 09:41 AM, Christoph Hellwig wrote: > The task_collector mode (or "latency_injector", (C) Dan Willians) is an > optional I/O path in libsas that queues up scsi commands instead of > directly sending it to the hardware. It generall increases latencies > to in the optiomal case slightly

[PATCH] libsas: remove task_collector mode

2014-11-24 Thread Christoph Hellwig
The task_collector mode (or "latency_injector", (C) Dan Willians) is an optional I/O path in libsas that queues up scsi commands instead of directly sending it to the hardware. It generall increases latencies to in the optiomal case slightly reduce mmio traffic to the hardware. Only the obsolete