Re: mac_scsi boot crash, was Re: [PATCH] m68k link error and NCR5380_exit()

2005-03-08 Thread Brad Boyer
On Wed, Mar 09, 2005 at 02:16:45AM +1100, Finn Thain wrote: > That seems to have helped. It still crashes with the same bus error, but > the preceding issue/disconnect/abort cycle is gone now. Log is below. > Hopefully I'll get a chance to look at the bus error soon. I notice it got through all

Re: mac_scsi boot crash, was Re: [PATCH] m68k link error and NCR5380_exit()

2005-03-08 Thread Finn Thain
On Mon, 7 Mar 2005, Kenn Humborg wrote: > On Mon, Mar 07, 2005 at 09:53:22AM -0800, Brad Boyer wrote: > > ... > > Looks to me like the interrupt came in after the driver already > > decided to give up for some reason. I had a big problem with that > > while I was trying to fix the driver to u

Re: [PATCH] m68k link error and NCR5380_exit()

2005-03-07 Thread Kenn Humborg
On Mon, Mar 07, 2005 at 09:53:22AM -0800, Brad Boyer wrote: > On Tue, Mar 08, 2005 at 12:45:28AM +1100, Finn Thain wrote: > > My main reservation about embarking on this is that I don't think mac_scsi > > ever actually worked under 2.6 (or 2.5?) kernels. I'm not competent enough > > to submit a g

Re: [PATCH] m68k link error and NCR5380_exit()

2005-03-07 Thread Brad Boyer
On Tue, Mar 08, 2005 at 12:45:28AM +1100, Finn Thain wrote: > Having qla1280.c as a guide will help, thanks. My next question is, what > does a NuBus architecture do in place of pci_(un)register_driver? Eventually, you should use macio_(un)register_driver. However, I don't have the support quite

Re: [PATCH] m68k link error and NCR5380_exit()

2005-03-07 Thread Finn Thain
On Mon, 7 Mar 2005, Christoph Hellwig wrote: > > .detect = macscsi_detect, > > - .release= macscsi_release, > > + .release= __exit_p(macscsi_release), > > Please get rid of your ->detect/->release useage instead. A

Re: [PATCH] m68k link error and NCR5380_exit()

2005-03-06 Thread Christoph Hellwig
> .detect = macscsi_detect, > - .release= macscsi_release, > + .release= __exit_p(macscsi_release), Please get rid of your ->detect/->release useage instead. Allocate the host struct directly with scsi_host_allo

[PATCH] m68k link error and NCR5380_exit()

2005-03-06 Thread Finn Thain
If this patch looks okay to you SCSI people, I'll ask the m68k maintainer to apply it. It fixes a link failure in the !CONFIG_HOTPLUG m68k kernel caused by the mac_scsi driver. The patch should apply to v2.6.10. AFAICT, the introduction of __devexit NCR5380_exit() in 2.6.9 necessitated this fix