Re: [PATCH] scsi: aacraid: remove redundant zero check on ret

2017-02-27 Thread Martin K. Petersen
> "Colin" == Colin King writes: Colin, Colin> The check for ret being zero is redundant as a few statements Colin> earlier we break out of the while loop if ret is non-zero. Thus Colin> we can remove the zero check and also the dead-code non-zero case Colin> too.

RE: [PATCH] scsi: aacraid: remove redundant zero check on ret

2017-02-26 Thread Dave Carroll
nel.org; linux-ker...@vger.kernel.org > Subject: [PATCH] scsi: aacraid: remove redundant zero check on ret > > From: Colin Ian King <colin.k...@canonical.com> > > The check for ret being zero is redundant as a few statements earlier we > break out of the while loop if ret is non-zero. Th

[PATCH] scsi: aacraid: remove redundant zero check on ret

2017-02-24 Thread Colin King
From: Colin Ian King The check for ret being zero is redundant as a few statements earlier we break out of the while loop if ret is non-zero. Thus we can remove the zero check and also the dead-code non-zero case too. Detected by CoverityScan, CID#1411632 ("Logically