Re: [PATCH] scsi: qla2xxx: Fix crashes in qla2x00_probe_one on probe failure

2018-02-27 Thread Hannes Reinecke
On 02/27/2018 04:18 PM, Kuzeja, William wrote: > > Thanks for the quick reply and analysis Hannes! My apologies in advance, I'm > stuck on > Outlook here at work - I'll try to format this to be readable (hopefully it > doesn't get > mangled). > > On 02/27/2018 06:01 AM, Hannes Reinecke wrote:

RE: [PATCH] scsi: qla2xxx: Fix crashes in qla2x00_probe_one on probe failure

2018-02-27 Thread Kuzeja, William
Thanks for the quick reply and analysis Hannes! My apologies in advance, I'm stuck on Outlook here at work - I'll try to format this to be readable (hopefully it doesn't get mangled). On 02/27/2018 06:01 AM, Hannes Reinecke wrote: > Hmm. Isn't is rather the case that the labels and gotos are

Re: [PATCH] scsi: qla2xxx: Fix crashes in qla2x00_probe_one on probe failure

2018-02-27 Thread Hannes Reinecke
On 02/26/2018 11:37 PM, Bill Kuzeja wrote: > Because of the shifting around of code in qla2x00_probe_one recently, > failures during adapter initialization can lead to problems, i.e. NULL > pointer crashes and doubly freed data structures which cause eventual > panics. > > To address these

[PATCH] scsi: qla2xxx: Fix crashes in qla2x00_probe_one on probe failure

2018-02-26 Thread Bill Kuzeja
Because of the shifting around of code in qla2x00_probe_one recently, failures during adapter initialization can lead to problems, i.e. NULL pointer crashes and doubly freed data structures which cause eventual panics. To address these problems, I tested all early probe exit points (and debugged