Re: [PATCH] scsi_debug: implement IMMED bit

2018-01-31 Thread Bart Van Assche
On Wed, 2018-01-31 at 17:40 -0500, Douglas Gilbert wrote: > On 2018-01-31 05:05 PM, Bart Van Assche wrote: > > On Wed, 2018-01-31 at 15:26 -0500, Douglas Gilbert wrote: > > > On 2018-01-31 12:06 PM, Bart Van Assche wrote: > > > > On 01/29/18 21:54, Douglas Gilbert wrote: > > > > > +static const

Re: [PATCH] scsi_debug: implement IMMED bit

2018-01-31 Thread Douglas Gilbert
On 2018-01-31 05:05 PM, Bart Van Assche wrote: On Wed, 2018-01-31 at 15:26 -0500, Douglas Gilbert wrote: On 2018-01-31 12:06 PM, Bart Van Assche wrote: On 01/29/18 21:54, Douglas Gilbert wrote: +static const struct opcode_info_t sync_cache_iarr[] = { +{0, 0x91, 0, F_LONG_DELAY |

Re: [PATCH] scsi_debug: implement IMMED bit

2018-01-31 Thread Bart Van Assche
On Wed, 2018-01-31 at 15:26 -0500, Douglas Gilbert wrote: > On 2018-01-31 12:06 PM, Bart Van Assche wrote: > > On 01/29/18 21:54, Douglas Gilbert wrote: > > > +static const struct opcode_info_t sync_cache_iarr[] = { > > > +{0, 0x91, 0, F_LONG_DELAY | F_M_ACCESS, resp_sync_cache, NULL, > > > +

Re: [PATCH] scsi_debug: implement IMMED bit

2018-01-31 Thread Douglas Gilbert
On 2018-01-31 12:06 PM, Bart Van Assche wrote: On 01/29/18 21:54, Douglas Gilbert wrote: +static const struct opcode_info_t sync_cache_iarr[] = { +    {0, 0x91, 0, F_LONG_DELAY | F_M_ACCESS, resp_sync_cache, NULL, +    {16,  0x7, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,

Re: [PATCH] scsi_debug: implement IMMED bit

2018-01-31 Thread Bart Van Assche
On 01/29/18 21:54, Douglas Gilbert wrote: +static const struct opcode_info_t sync_cache_iarr[] = { + {0, 0x91, 0, F_LONG_DELAY | F_M_ACCESS, resp_sync_cache, NULL, + {16, 0x7, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, ^^^ Can you clarify the choice of

[PATCH] scsi_debug: implement IMMED bit

2018-01-29 Thread Douglas Gilbert
The start stop unit command takes in the order of a second to complete on some SAS SSDs and longer on hard disks. Synchronize cache can also take some time. Both commands have an IMMED bit for those apps that don't want to wait. This patch introduces a long delay for those commands when the IMMED