Re: [PATCH] scsi_devinfo: fixup string compare

2017-08-08 Thread Hannes Reinecke
On 08/04/2017 06:38 PM, Bart Van Assche wrote: > On Fri, 2017-08-04 at 18:28 +0200, Hannes Reinecke wrote: >> Well, maybe; however, the current logic fails to match the entry >> >> {"HITACHI", "OPEN-", "*", BLIST_REPORTLUN2}, >> >> against the 'real' name, which is "HITACHI" "OPEN-V". >> And

Re: [PATCH] scsi_devinfo: fixup string compare

2017-08-04 Thread Bart Van Assche
On Fri, 2017-08-04 at 18:28 +0200, Hannes Reinecke wrote: > Well, maybe; however, the current logic fails to match the entry > > {"HITACHI", "OPEN-", "*", BLIST_REPORTLUN2}, > > against the 'real' name, which is "HITACHI" "OPEN-V". > And for some reason we have far more customer using

Re: [PATCH] scsi_devinfo: fixup string compare

2017-08-04 Thread Hannes Reinecke
On 08/04/2017 05:32 PM, Bart Van Assche wrote: > On Fri, 2017-08-04 at 11:40 +0200, Hannes Reinecke wrote: >> When checking the model and vendor string we need to use the >> minimum value of either string, otherwise we'll miss out on >> wildcard matches. >> Without this patch certain Hitachi

Re: [PATCH] scsi_devinfo: fixup string compare

2017-08-04 Thread Bart Van Assche
On Fri, 2017-08-04 at 11:40 +0200, Hannes Reinecke wrote: > When checking the model and vendor string we need to use the > minimum value of either string, otherwise we'll miss out on > wildcard matches. > Without this patch certain Hitachi arrays will not be presenting > VPD pages correctly. > >

[PATCH] scsi_devinfo: fixup string compare

2017-08-04 Thread Hannes Reinecke
When checking the model and vendor string we need to use the minimum value of either string, otherwise we'll miss out on wildcard matches. Without this patch certain Hitachi arrays will not be presenting VPD pages correctly. Fixes: 5e7ff2c ("SCSI: fix new bug in scsi_dev_info_list string