Re: [PATCH 05/22] qla2xxx: Add DebugFS node of irq vector cpuid

[Madhani, Himanshu]

Hi Christoph, 



On 12/14/16, 1:13 PM, "Christoph Hellwig"  wrote:

>Doesn't make sense - an interrupt can be assigned to multiple
>CPUIDs, and you can see the assignment based on the irq count
>in /proc/interrupts
>

We Added this for our debug purpose. We’ll drop this patch in next series.


Thanks,
Himanshu
>

Re: [PATCH 05/22] qla2xxx: Add DebugFS node of irq vector cpuid

[Christoph Hellwig]

On Tue, Dec 06, 2016 at 12:30:34PM -0800, Himanshu Madhani wrote:
> From: Quinn Tran 
> 
> > cat /sys/kernel/debug/qla2xxx/*/irq_cpuid
> qla2xxx_81
> IRQ Name  Vector  CPUID
> qla2xxx (default)  150 9
> qla2xxx (rsp_q)151 9
> qla2xxx (atio_q)   152 9

Doesn't make sense - an interrupt can be assigned to multiple
CPUIDs, and you can see the assignment based on the irq count
in /proc/interrupts
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 05/22] qla2xxx: Add DebugFS node of irq vector cpuid

[Himanshu Madhani]

From: Quinn Tran 

> cat /sys/kernel/debug/qla2xxx/*/irq_cpuid
qla2xxx_81
IRQ Name  Vector  CPUID
qla2xxx (default)  150 9
qla2xxx (rsp_q)151 9
qla2xxx (atio_q)   152 9

Signed-off-by: Quinn Tran 
Signed-off-by: Himanshu Madhani 
---
 drivers/scsi/qla2xxx/qla_dbg.c |  2 +-
 drivers/scsi/qla2xxx/qla_def.h |  1 +
 drivers/scsi/qla2xxx/qla_dfs.c | 52 +-
 drivers/scsi/qla2xxx/qla_isr.c | 14 
 4 files changed, 67 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/qla2xxx/qla_dbg.c b/drivers/scsi/qla2xxx/qla_dbg.c
index 21d9fb7..b2e3167 100644
--- a/drivers/scsi/qla2xxx/qla_dbg.c
+++ b/drivers/scsi/qla2xxx/qla_dbg.c
@@ -59,7 +59,7 @@
  * |  || 0xb13c-0xb140  |
  * |  || 0xb149
|
  * | MultiQ   |   0xc010   |   |
- * | Misc |   0xd301   | 0xd031-0xd0ff |
+ * | Misc |   0xd303   | 0xd031-0xd0ff |
  * |  || 0xd101-0xd1fe |
  * |  || 0xd214-0xd2fe |
  * | Target Mode |   0xe080   ||
diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h
index 84f2cc3..1e3a3fa 100644
--- a/drivers/scsi/qla2xxx/qla_def.h
+++ b/drivers/scsi/qla2xxx/qla_def.h
@@ -3448,6 +3448,7 @@ struct qla_hw_data {
struct dentry *dfs_fce;
struct dentry *dfs_tgt_counters;
struct dentry *dfs_fw_resource_cnt;
+   struct dentry *dfs_irq_cpuid;
 
dma_addr_t  fce_dma;
void*fce;
diff --git a/drivers/scsi/qla2xxx/qla_dfs.c b/drivers/scsi/qla2xxx/qla_dfs.c
index 34272fd..08d7a05 100644
--- a/drivers/scsi/qla2xxx/qla_dfs.c
+++ b/drivers/scsi/qla2xxx/qla_dfs.c
@@ -13,6 +13,42 @@
 static atomic_t qla2x00_dfs_root_count;
 
 static int
+qla2x00_dfs_irq_cpuid_show(struct seq_file *s, void *unused)
+{
+   int i;
+   scsi_qla_host_t *vha = s->private;
+   struct qla_hw_data *ha = vha->hw;
+   struct qla_msix_entry *qentry;
+
+   seq_printf(s, "%s\n", vha->host_str);
+   seq_printf(s, "%20s  Vector  CPUID\n", "IRQ Name");
+
+   for (i = 0; i < ha->msix_count; i++) {
+   qentry = >msix_entries[i];
+   if (qentry->have_irq)
+   seq_printf(s, "%20s  %3d %d\n",
+   qentry->name, qentry->vector,
+   qentry->cpuid);
+   }
+
+   return 0;
+}
+
+static int
+qla2x00_dfs_irq_cpuid_open(struct inode *inode, struct file *file)
+{
+   scsi_qla_host_t *vha = inode->i_private;
+   return single_open(file, qla2x00_dfs_irq_cpuid_show, vha);
+}
+
+static const struct file_operations dfs_irq_cpuid_ops = {
+   .open   = qla2x00_dfs_irq_cpuid_open,
+   .read   = seq_read,
+   .llseek = seq_lseek,
+   .release= single_release,
+};
+
+static int
 qla2x00_dfs_tgt_sess_show(struct seq_file *s, void *unused)
 {
scsi_qla_host_t *vha = s->private;
@@ -293,11 +329,20 @@
ha->tgt.dfs_tgt_sess = debugfs_create_file("tgt_sess",
S_IRUSR, ha->dfs_dir, vha, _tgt_sess_ops);
if (!ha->tgt.dfs_tgt_sess) {
-   ql_log(ql_log_warn, vha, 0x,
+   ql_log(ql_log_warn, vha, 0xd302,
"Unable to create debugFS tgt_sess node.\n");
goto out;
}
 
+   ha->dfs_irq_cpuid = debugfs_create_file("irq_cpuid",
+   S_IRUSR, ha->dfs_dir, vha, _irq_cpuid_ops);
+   if (!ha->dfs_irq_cpuid) {
+   ql_log(ql_log_warn, vha, 0xd303,
+   "Unable to create debugFS irq_cpuid node.\n");
+   goto out;
+   }
+
+
 out:
return 0;
 }
@@ -307,6 +352,11 @@
 {
struct qla_hw_data *ha = vha->hw;
 
+   if (ha->dfs_irq_cpuid) {
+   debugfs_remove(ha->dfs_irq_cpuid);
+   ha->dfs_irq_cpuid = NULL;
+   }
+
if (ha->tgt.dfs_tgt_sess) {
debugfs_remove(ha->tgt.dfs_tgt_sess);
ha->tgt.dfs_tgt_sess = NULL;
diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
index 98e4904..dec4b37 100644
--- a/drivers/scsi/qla2xxx/qla_isr.c
+++ b/drivers/scsi/qla2xxx/qla_isr.c
@@ -3121,6 +3121,20 @@ struct qla_init_msix_entry {
msix_entries[QLA_ATIO_VECTOR].handler,
0, msix_entries[QLA_ATIO_VECTOR].name, rsp);
qentry->have_irq = 1;
+   qentry->irq_notify.notify  = qla_irq_affinity_notify;
+   qentry->irq_notify.release = qla_irq_affinity_release;
+
+   /* Register for CPU affinity notification. */
+