[PATCH 1/1] aacraid: big endian issues

2008-01-08 Thread Salyzyn, Mark
Big endian systems issues discovered in the aacraid driver. Somewhat reverses a patch from November 7th of last year that removed swap operations because they formerly were being assigned to an u8 array when they should have been assigned to an le32 array. This patch is largely inert for any

Re: [PATCH 1/1] aacraid: big endian issues

2008-01-08 Thread Grant Grundler
On Jan 8, 2008 12:48 PM, Salyzyn, Mark [EMAIL PROTECTED] wrote: Big endian systems issues discovered in the aacraid driver. ... --- a/drivers/scsi/aacraid/comminit.c 2008-01-08 15:32:28.329810853 -0500 +++ b/drivers/scsi/aacraid/comminit.c 2008-01-08 15:37:35.633163607 -0500 @@ -301,10

RE: [PATCH 1/1] aacraid: big endian issues

2008-01-08 Thread Salyzyn, Mark
: Tuesday, January 08, 2008 4:17 PM To: Salyzyn, Mark Cc: linux-scsi@vger.kernel.org Subject: Re: [PATCH 1/1] aacraid: big endian issues On Jan 8, 2008 12:48 PM, Salyzyn, Mark [EMAIL PROTECTED] wrote: Big endian systems issues discovered in the aacraid driver. ... --- a/drivers/scsi

Re: [PATCH 1/1] aacraid: big endian issues

2008-01-08 Thread Matthew Wilcox
On Tue, Jan 08, 2008 at 01:17:15PM -0800, Grant Grundler wrote: Why apply le32_to_cpu() to the constant instead of the variable? On systems were le32_to_cpu() is doing something, can gcc or preprocessor optimize the constant? I've always assumed it could not but that might be wrong. $ grep

Re: [PATCH 1/1] aacraid: big endian issues

2008-01-08 Thread Grant Grundler
, January 08, 2008 4:17 PM To: Salyzyn, Mark Cc: linux-scsi@vger.kernel.org Subject: Re: [PATCH 1/1] aacraid: big endian issues On Jan 8, 2008 12:48 PM, Salyzyn, Mark [EMAIL PROTECTED] wrote: Big endian systems issues discovered in the aacraid driver. ... --- a/drivers/scsi