Re: [PATCH 1/4] libfc: fixup lockdep annotations

2018-07-11 Thread Johannes Thumshirn
Looks good,
Reviewed-by: Johannes Thumshirn 
-- 
Johannes Thumshirn  Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850


[PATCH 1/4] libfc: fixup lockdep annotations

2018-07-11 Thread Hannes Reinecke
fc_rport_recv_plogi_req() needs the lport mutex to be held; the
rport mutex will be acquired in the function itself.

Fixes: ee35624e1e4e ("scsi: libfc: Add lockdep annotations")
Reported-by: Stephen Rothwell 
Signed-off-by: Hannes Reinecke 
---
 drivers/scsi/libfc/fc_rport.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/libfc/fc_rport.c b/drivers/scsi/libfc/fc_rport.c
index 6aff9303251a..3d51a936f6d5 100644
--- a/drivers/scsi/libfc/fc_rport.c
+++ b/drivers/scsi/libfc/fc_rport.c
@@ -1835,7 +1835,7 @@ static void fc_rport_recv_plogi_req(struct fc_lport 
*lport,
struct fc_seq_els_data rjt_data;
u32 sid;
 
-   lockdep_assert_held(>rp_mutex);
+   lockdep_assert_held(>lp_mutex);
 
sid = fc_frame_sid(fp);
 
-- 
2.12.3