Re: [PATCH 1/5] arcmsr: Re-name the HBA Type

2012-11-15 Thread James Bottomley
On Thu, 2012-11-15 at 15:24 +0800, NickCheng wrote: From: Nick Cheng nick.ch...@areca.com.tw Replace the nameing, hba, hbb and hbc, with hbaA, hbaB abd hbaC respectively Signed-off-by: Nick Cheng nick.ch...@areca.com.tw I can apply this with manual fixups because of the double // in the

Re: [PATCH 1/5] arcmsr: Re-name the HBA Type

2012-11-15 Thread 鄭守謙
Hi James, You got these errors/warnings before or after you apply these 5 patches? Thanks, 2012/11/15 James Bottomley james.bottom...@hansenpartnership.com: On Thu, 2012-11-15 at 15:24 +0800, NickCheng wrote: From: Nick Cheng nick.ch...@areca.com.tw Replace the nameing, hba, hbb and hbc, with

Re: [PATCH 1/5] arcmsr: Re-name the HBA Type

2012-11-15 Thread James Bottomley
On Thu, 2012-11-15 at 22:53 +0800, 鄭守謙 wrote: Hi James, You got these errors/warnings before or after you apply these 5 patches? I got all of this lot from patch 1/5 only. Please fix at least the errors and the warnings that go to whitespace issues. I don't really care about printk(KERN_ERR

Re: [PATCH 1/5] arcmsr: Re-name the HBA Type

2012-11-15 Thread 鄭守謙
OK. I will fix it. Thank you, 2012/11/15 James Bottomley james.bottom...@hansenpartnership.com: On Thu, 2012-11-15 at 22:53 +0800, 鄭守謙 wrote: Hi James, You got these errors/warnings before or after you apply these 5 patches? I got all of this lot from patch 1/5 only. Please fix at least the

Re: [PATCH 1/5] arcmsr: Re-name the HBA Type

2012-11-13 Thread James Bottomley
On Fri, 2012-10-12 at 17:05 +0800, NickCheng wrote: -#define ARCMSR_HBCMU_OUTBOUND_DOORBELL_ISR_MASK0x0004 /* When clear, the General Outbound Doorbell interrupt routes to the host.*/ The patch is still linebroken here. It is a massively long line (like about 200 characters). I

Re: [PATCH 1/5] arcmsr: Re-name the HBA Type

2012-10-09 Thread James Bottomley
On Wed, 2012-10-03 at 20:39 +0800, NickCheng wrote: From: Nick Cheng nick.ch...@areca.com.tw Replace the nameing, hba, hbb and hbc, with hbaA, hbaB abd hbaC respectively Signed-off-by: Nick Cheng nick.ch...@areca.com.tw --- diff -uprN -X linux-vanilla/Documentation/dontdiff

[PATCH 1/5] arcmsr: Re-name the HBA Type

2012-10-09 Thread NickCheng
From: Nick Cheng nick.ch...@areca.com.tw Replace the nameing, hba, hbb and hbc, with hbaA, hbaB abd hbaC respectively Signed-off-by: Nick Cheng nick.ch...@areca.com.tw --- diff -uprN -X linux-vanilla/Documentation/dontdiff linux-vanilla//drivers/scsi/arcmsr/arcmsr.h

Re: [PATCH 1/5] arcmsr: Re-name the HBA Type

2012-10-09 Thread James Bottomley
On Tue, 2012-10-09 at 21:23 +0800, NickCheng wrote: From: Nick Cheng nick.ch...@areca.com.tw Replace the nameing, hba, hbb and hbc, with hbaA, hbaB abd hbaC respectively Signed-off-by: Nick Cheng nick.ch...@areca.com.tw This is still malformed in exactly the same way diff -uprN -X

[PATCH 1/5] arcmsr: Re-name the HBA Type

2012-10-03 Thread NickCheng
From: Nick Cheng nick.ch...@areca.com.tw Replace the nameing, hba, hbb and hbc, with hbaA, hbaB abd hbaC respectively Signed-off-by: Nick Cheng nick.ch...@areca.com.tw --- diff -uprN -X linux-vanilla/Documentation/dontdiff linux-vanilla//drivers/scsi/arcmsr/arcmsr.h