Re: [PATCH 2/2] relax scsi dma alignment

2008-01-01 Thread Pete Wyckoff
[EMAIL PROTECTED] wrote on Mon, 31 Dec 2007 16:43 -0600: This patch relaxes the default SCSI DMA alignment from 512 bytes to 4 bytes. I remember from previous discussions that usb and firewire have sector size alignment requirements, so I upped their alignments in the respective slave allocs.

Re: [PATCH 2/2] relax scsi dma alignment

2008-01-01 Thread James Bottomley
On Tue, 2008-01-01 at 11:08 -0500, Pete Wyckoff wrote: [EMAIL PROTECTED] wrote on Mon, 31 Dec 2007 16:43 -0600: This patch relaxes the default SCSI DMA alignment from 512 bytes to 4 bytes. I remember from previous discussions that usb and firewire have sector size alignment requirements,

Re: [PATCH 2/2] relax scsi dma alignment

2008-01-01 Thread Alan Stern
On Tue, 1 Jan 2008, James Bottomley wrote: On Mon, 2007-12-31 at 17:57 -0500, Alan Stern wrote: It would be better to move the existing code from the start of slave_configure() up into slave_alloc(). Otherwise it's fine. Um, yes, you're right, I didn't notice there was an existing one

Re: [PATCH 2/2] relax scsi dma alignment

2008-01-01 Thread Pete Wyckoff
[EMAIL PROTECTED] wrote on Tue, 01 Jan 2008 10:27 -0600: On Tue, 2008-01-01 at 11:08 -0500, Pete Wyckoff wrote: [EMAIL PROTECTED] wrote on Mon, 31 Dec 2007 16:43 -0600: This patch relaxes the default SCSI DMA alignment from 512 bytes to 4 bytes. I remember from previous discussions that