Re: [PATCH 4/7] mptfusion: zero kernel-space source of copy_to_user

2014-06-06 Thread Dan Carpenter
On Wed, Jun 04, 2014 at 12:49:46PM -0400, Joe Lawrence wrote: Fixes the following smatch warning: drivers/message/fusion/mptctl.c:1369 mptctl_getiocinfo() warn: possible info leak 'karg' This is a false positive. I will push a fix for this in Smatch next week. regards, dan

Re: [PATCH 4/7] mptfusion: zero kernel-space source of copy_to_user

2014-06-05 Thread Christoph Hellwig
On Wed, Jun 04, 2014 at 12:58:36PM -0400, Joe Lawrence wrote: Hi Dan, kzalloc silenced that smatch warning, but the code looks like: (calculate data_size) ... karg = kmalloc(data_size, GFP_KERNEL); ... if (copy_from_user(karg, uarg, data_size)) { ... if

[PATCH 4/7] mptfusion: zero kernel-space source of copy_to_user

2014-06-04 Thread Joe Lawrence
Fixes the following smatch warning: drivers/message/fusion/mptctl.c:1369 mptctl_getiocinfo() warn: possible info leak 'karg' Signed-off-by: Joe Lawrence joe.lawre...@stratus.com Cc: Christoph Hellwig h...@infradead.org Cc: Dan Carpenter dan.carpen...@oracle.com Cc: Sreekanth Reddy

Re: [PATCH 4/7] mptfusion: zero kernel-space source of copy_to_user

2014-06-04 Thread Joe Lawrence
On Wed, 4 Jun 2014 12:49:46 -0400 Joe Lawrence joe.lawre...@stratus.com wrote: Fixes the following smatch warning: drivers/message/fusion/mptctl.c:1369 mptctl_getiocinfo() warn: possible info leak 'karg' Signed-off-by: Joe Lawrence joe.lawre...@stratus.com Cc: Christoph Hellwig