Re: [PATCH v1 01/20] [SCSI] mpt3sas: Added Combined Reply Queue feature to extend up-to 96 MSIX vector support

2015-06-22 Thread Martin K. Petersen
Sreekanth == Sreekanth Reddy sreekanth.re...@avagotech.com writes: Sreekanth I will remove these extra brackets. but SAS3 HBA's less than Sreekanth C0 revision (which doesn't support this Combined Reply Queue Sreekanth feature) will support up to 16 MSI-X vectors. Ah, I missed that. Fair

Re: [PATCH v1 01/20] [SCSI] mpt3sas: Added Combined Reply Queue feature to extend up-to 96 MSIX vector support

2015-06-22 Thread Sreekanth Reddy
On Fri, Jun 19, 2015 at 8:27 PM, Martin K. Petersen martin.peter...@oracle.com wrote: Sreekanth == Sreekanth Reddy sreekanth.re...@avagotech.com writes: Sreekanth, It's fine that you outline the 96 / 12 = 8 layout in the patch description. But that relationship is not made clear when reading

[PATCH v1 01/20] [SCSI] mpt3sas: Added Combined Reply Queue feature to extend up-to 96 MSIX vector support

2015-06-19 Thread Sreekanth Reddy
In this patch, increased the number of MSIX vector support for SAS3 C0 HBAs to up-to 96. Following are changes that are done in this patch 1. Support this feature only for SAS3 C0 cards and also only when reply post free queue count is greater than 8. 2. Instead of using single

Re: [PATCH v1 01/20] [SCSI] mpt3sas: Added Combined Reply Queue feature to extend up-to 96 MSIX vector support

2015-06-19 Thread Johannes Thumshirn
On Fri, Jun 19, 2015 at 04:25:46PM +0530, Sreekanth Reddy wrote: In this patch, increased the number of MSIX vector support for SAS3 C0 HBAs to up-to 96. Following are changes that are done in this patch 1. Support this feature only for SAS3 C0 cards and also only when reply post free

Re: [PATCH v1 01/20] [SCSI] mpt3sas: Added Combined Reply Queue feature to extend up-to 96 MSIX vector support

2015-06-19 Thread Martin K. Petersen
Sreekanth == Sreekanth Reddy sreekanth.re...@avagotech.com writes: Sreekanth, It's fine that you outline the 96 / 12 = 8 layout in the patch description. But that relationship is not made clear when reading the code. Please add a comment describing why things are set up this way. @@ -1009,8