Re: [PATCH v3 2/2] Documentation/scsi: update scsi_eh.txt about ->host_failed

2016-06-06 Thread Wei Fang 

On 2016/6/7 11:22, Martin K. Petersen wrote:
>> "Wei" == Wei Fang  writes:
> 
> Wei,
> 
> Wei> Update the new rules of ->host_failed.
> 
> Are you going to incorporate the amendment from James?
> 

Yes, I'll send the patch soon.

Thanks,
Wei

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 2/2] Documentation/scsi: update scsi_eh.txt about ->host_failed

2016-06-06 Thread Martin K. Petersen 
> "Wei" == Wei Fang  writes:

Wei,

Wei> Update the new rules of ->host_failed.

Are you going to incorporate the amendment from James?

Thanks!

-- 
Martin K. Petersen  Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 2/2] Documentation/scsi: update scsi_eh.txt about ->host_failed

2016-06-02 Thread Greg KH 
On Thu, Jun 02, 2016 at 04:42:38PM +0800, Wei Fang wrote:
> Update the new rules of ->host_failed.
> 
> Signed-off-by: Wei Fang 
> ---
>  Documentation/scsi/scsi_eh.txt |2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)




This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
for how to do this properly.


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 2/2] Documentation/scsi: update scsi_eh.txt about ->host_failed

2016-06-02 Thread James Bottomley 
On Thu, 2016-06-02 at 16:42 +0800, Wei Fang wrote:
> Update the new rules of ->host_failed.
> 
> Signed-off-by: Wei Fang 

Changes look fine, but I was wondering if we could also add a note
about the new concurrency rules:

> ---
>  Documentation/scsi/scsi_eh.txt |2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/Documentation/scsi/scsi_eh.txt
> b/Documentation/scsi/scsi_eh.txt
> index 8638f61..9702c78 100644
> --- a/Documentation/scsi/scsi_eh.txt
> +++ b/Documentation/scsi/scsi_eh.txt
> @@ -263,7 +263,6 @@ scmd->allowed.
>  
>   3. scmd recovered
>  ACTION: scsi_eh_finish_cmd() is invoked to EH-finish scmd
> - - shost->host_failed--
>   - clear scmd->eh_eflags
>   - scsi_setup_cmd_retry()
>   - move from local eh_work_q to local eh_done_q

+   CONCURRENCY: at most one thread per separate eh_work_q to
+keep queue manipulation lockless

And the same addition in

   4. EH Completes

Probably

ACTION: scsi_eh_flush_done_q() retries scmds or notifies upper
layer of failure. May be called concurrently but must have
a no more than one thread per eh_work_q to manipulate the
queue locklessly

> @@ -276,6 +275,7 @@ scmd->allowed.
>   - if retry is necessary, scmd is requeued using
>scsi_queue_insert()
>   - otherwise, scsi_finish_command() is invoked for scmd
> + - zero shost->host_failed
>  LOCKING: queue or finish function performs appropriate locking
>  
>  

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v3 2/2] Documentation/scsi: update scsi_eh.txt about ->host_failed

2016-06-02 Thread Wei Fang 
Update the new rules of ->host_failed.

Signed-off-by: Wei Fang 
---
 Documentation/scsi/scsi_eh.txt |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Documentation/scsi/scsi_eh.txt b/Documentation/scsi/scsi_eh.txt
index 8638f61..9702c78 100644
--- a/Documentation/scsi/scsi_eh.txt
+++ b/Documentation/scsi/scsi_eh.txt
@@ -263,7 +263,6 @@ scmd->allowed.
 
  3. scmd recovered
 ACTION: scsi_eh_finish_cmd() is invoked to EH-finish scmd
-   - shost->host_failed--
- clear scmd->eh_eflags
- scsi_setup_cmd_retry()
- move from local eh_work_q to local eh_done_q
@@ -276,6 +275,7 @@ scmd->allowed.
- if retry is necessary, scmd is requeued using
   scsi_queue_insert()
- otherwise, scsi_finish_command() is invoked for scmd
+   - zero shost->host_failed
 LOCKING: queue or finish function performs appropriate locking
 
 
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html