Re: [PATCH v3 8/8] scsi: hisi_sas: Code cleanup and minor bug fixes

Hi Hannes, Thanks for checking this. > + } > return -EINVAL? >return 0; > } [ ... ] > + } > >return 0; > } return -EINVAL? > @@ -2408,7 +2410,7 @@ static void slot_err_v2_hw(struct hisi_hba *hisi_hba, >spin_lock_irqsave(_hba->lock, flags); >

Re: [PATCH v3 8/8] scsi: hisi_sas: Code cleanup and minor bug fixes

On 03/05/2018 03:48 PM, John Garry wrote: > From: Xiang Chen > > The patch does some code cleanup and fixes some small bugs: > - Correct return status of phy_up_v3_hw() > - Add static for function phy_get_max_linkrate_v3_hw() > - Change exception return status when no

[PATCH v3 8/8] scsi: hisi_sas: Code cleanup and minor bug fixes

From: Xiang Chen The patch does some code cleanup and fixes some small bugs: - Correct return status of phy_up_v3_hw() - Add static for function phy_get_max_linkrate_v3_hw() - Change exception return status when no reset method - Change magic value to ts->stat in