Re: [PATCH v5] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

Hi Christoph, thank you for taking the time to review and comment - my responses inline below. Am 03.04.2018 um 19:45 schrieb Christoph Hellwig: > Just a few style comments: > >> +static int zorro_esp_irq_pending(struct esp *); >> +static int cyber_esp_irq_pending(struct esp *); >> +static int

Re: [PATCH v5] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

On Tue, 3 Apr 2018, Christoph Hellwig wrote: > > +static void zorro_esp_send_pio_cmd(struct esp *esp, u32 addr, u32 > > esp_count, > > +u32 dma_count, int write, u8 cmd) > > +{ > > + struct zorro_esp_priv *zep = dev_get_drvdata(esp->dev); > > + u8 __iomem *fifo =

Re: [PATCH v5] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

On Tue, 3 Apr 2018, Christoph Hellwig wrote: > > > + > > + if (zep->zorro3) { > > + /* Only Fastlane Z3 for now - add switch for correct struct > > +* dma_registers size if adding any more > > +*/ > > + esp->dma_regs = ioremap_nocache(dmaaddr, > > +

Re: [PATCH v5] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

Just a few style comments: > +static int zorro_esp_irq_pending(struct esp *); > +static int cyber_esp_irq_pending(struct esp *); > +static int fastlane_esp_irq_pending(struct esp *); Please avoid forward declarations wherever possible. > +struct zorro_driver_data { > + const char *name; > +

[PATCH v5] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

From: Michael Schmitz New combined SCSI driver for all ESP based Zorro SCSI boards for m68k Amiga. Code largely based on board specific parts of the old drivers (blz1230.c, blz2060.c, cyberstorm.c, cyberstormII.c, fastlane.c which were removed after the 2.6 kernel series for