Re: [Xen-devel] [PATCH V4 2/4] Introduce xen-scsifront module

2014-08-12 Thread Juergen Gross
On 08/11/2014 07:50 PM, Christoph Hellwig wrote: On Mon, Aug 11, 2014 at 12:27:29PM +0200, Juergen Gross wrote: What do you mean with unusual? You mean transferring the EH action to Dom0? Yes. Note that hyperv tries something similar and they've run into timeout issues, you might want to

Re: [Xen-devel] [PATCH V4 2/4] Introduce xen-scsifront module

2014-08-11 Thread Juergen Gross
On 08/11/2014 11:54 AM, Christoph Hellwig wrote: + BUG_ON(sc-cmd_len VSCSIIF_MAX_COMMAND_SIZE); + + if (sc-cmd_len) I can't see how you can get a zero cmd_len here. Ahh, thanks for spotting this. In a previous version it could be zero in case of reset. +static int

Re: [Xen-devel] [PATCH V4 2/4] Introduce xen-scsifront module

2014-08-11 Thread Christoph Hellwig
On Mon, Aug 11, 2014 at 12:27:29PM +0200, Juergen Gross wrote: What do you mean with unusual? You mean transferring the EH action to Dom0? Yes. Note that hyperv tries something similar and they've run into timeout issues, you might want to read up the recent thread on that. +