Looks ok.
Acked-by: Chad Dupuis <chad.dup...@qlogic.com>

On Tue, 4 Nov 2014, Dan Carpenter wrote:

The bnx2fc_if_create() function returns NULL on failure, it never
returns an error pointer.

Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>

diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c 
b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
index 79e5c94..dfed4be 100644
--- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
+++ b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
@@ -1081,7 +1081,7 @@ static int bnx2fc_vport_create(struct fc_vport *vport, 
bool disabled)
        mutex_unlock(&bnx2fc_dev_lock);
        rtnl_unlock();

-       if (IS_ERR(vn_port)) {
+       if (!vn_port) {
                printk(KERN_ERR PFX "bnx2fc_vport_create (%s) failed\n",
                        netdev->name);
                return -EIO;

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to