[v3.16][v3.17][v3.18][ Regression] scsi: handle flush errors properly

2014-12-10 Thread Joseph Salisbury
Hello James, A kernel bug report was opened against Ubuntu [0]. After a kernel bisect, it was found that reverting the following commit resolved this bug: commit 89fb4cd1f717a871ef79fa7debbe840e3225cd54 Author: James Bottomley jbottom...@parallels.com Date: Thu Jul 3 19:17:34 2014 +0200

Re: [v3.16][v3.17][v3.18][ Regression] scsi: handle flush errors properly

2014-12-10 Thread Steven Haber
Hey Joe, Here's some context: The SCSI flush command was being treated by a zero-byte write, which means that if an error was returned, you wouldn't catch it until a subsequent write (or flush). The way writes work is that all possible bytes are written, and if something bad happens, an error

Re: [v3.16][v3.17][v3.18][ Regression] scsi: handle flush errors properly

2014-12-10 Thread James Bottomley
On Wed, 2014-12-10 at 17:08 -0500, Joseph Salisbury wrote: Hello James, A kernel bug report was opened against Ubuntu [0]. After a kernel bisect, it was found that reverting the following commit resolved this bug: If I read this bug report correctly, it's saying a USB attached device