Re: [PATCH 1/3] libsas: modify SATA error handler

2014-08-25 Thread Dan Williams
Some more comments below. [..] + + pmp = sata_srst_pmp(link); + + msecs = 0; + now = jiffies; + if (time_after(deadline, now)) + msecs = jiffies_to_msecs(deadline - now); + + memset(tf, 0, sizeof(struct ata_taskfile)); + tf.ctl =

RE: [PATCH 1/3] libsas: modify SATA error handler

2014-08-08 Thread Xiangliang Yu
Hi, Dan Hi, some notes below: On Thu, Apr 24, 2014 at 6:27 AM, Xiangliang Yu yxlr...@gmail.com wrote: Add support for SATA port softreset and port multiplier error handling. Some more detailed notes about the approach and any caveats would be appreciated. Signed-off-by: Xiangliang Yu

Re: [PATCH 1/3] libsas: modify SATA error handler

2014-08-07 Thread Dan Williams
[ adding yuxia...@marvell.com ] On Tue, Jun 3, 2014 at 6:41 PM, Dan Williams dan.j.willi...@intel.com wrote: Hi, some notes below: On Thu, Apr 24, 2014 at 6:27 AM, Xiangliang Yu yxlr...@gmail.com wrote: Add support for SATA port softreset and port multiplier error handling. Some more

RE: [PATCH 1/3] libsas: modify SATA error handler

2014-08-06 Thread Xiangliang Yu
; todd.e.bra...@intel.com; lukasz.do...@intel.com; linux-...@vger.kernel.org; linux-ker...@vger.kernel.org; linux-scsi@vger.kernel.org Subject: Re: [PATCH 1/3] libsas: modify SATA error handler On Tue, Jun 3, 2014 at 12:13 AM, Xiangliang Yu yuxia...@marvell.com wrote: Hi, How about the patch? I'll

Re: [PATCH 1/3] libsas: modify SATA error handler

2014-08-06 Thread Dan Williams
On Wed, Aug 6, 2014 at 3:50 AM, Xiangliang Yu yuxia...@marvell.com wrote: Hi, Dan James How about the patches about support for PM? Two months had passed since I submitted the patches. Thanks! Did you address my review comments? -- To unsubscribe from this list: send the line unsubscribe

RE: [PATCH 1/3] libsas: modify SATA error handler

2014-08-06 Thread Xiangliang Yu
...@parallels.com; t...@kernel.org; todd.e.bra...@intel.com; lukasz.do...@intel.com; linux-...@vger.kernel.org; linux-ker...@vger.kernel.org; linux-scsi@vger.kernel.org Subject: Re: [PATCH 1/3] libsas: modify SATA error handler On Wed, Aug 6, 2014 at 3:50 AM, Xiangliang Yu yuxia...@marvell.com wrote: Hi, Dan

RE: [PATCH 1/3] libsas: modify SATA error handler

2014-06-03 Thread Xiangliang Yu
Hi, How about the patch? From: Xiangliang Yu yxlr...@gmail.com Date: 2014-04-24 21:27 GMT+08:00 Subject: [PATCH 1/3] libsas: modify SATA error handler To: t...@kernel.org, jbottom...@parallels.com Cc: dan.j.willi...@intel.com, todd.e.bra...@intel.com, lukasz.do...@intel.com,

Re: [PATCH 1/3] libsas: modify SATA error handler

2014-06-03 Thread Dan Williams
On Tue, Jun 3, 2014 at 12:13 AM, Xiangliang Yu yuxia...@marvell.com wrote: Hi, How about the patch? I'll take a look today. Sorry for the latency. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 1/3] libsas: modify SATA error handler

2014-06-03 Thread Dan Williams
Hi, some notes below: On Thu, Apr 24, 2014 at 6:27 AM, Xiangliang Yu yxlr...@gmail.com wrote: Add support for SATA port softreset and port multiplier error handling. Some more detailed notes about the approach and any caveats would be appreciated. Signed-off-by: Xiangliang Yu