Re: [PATCH 22/82] remove linux/version.h from drivers/message/fus ion

2005-07-20 Thread Bernd Petrovitsch
On Tue, 2005-07-19 at 22:12 -0500, Matt Domsch wrote: On Tue, Jul 19, 2005 at 06:07:41PM -0600, Moore, Eric Dean wrote: [...] What you illustrated above is not going to work. If your doing #ifndef around a function, such as scsi_device_online, it's not going to compile when

Re: [PATCH 22/82] remove linux/version.h from drivers/message/fus ion

2005-07-20 Thread Matthew Wilcox
On Tue, Jul 19, 2005 at 10:12:49PM -0500, Matt Domsch wrote: What you illustrated above is not going to work. If your doing #ifndef around a function, such as scsi_device_online, it's not going to compile when scsi_device_online is already implemented in the kernel tree. The routine

Re: [PATCH 22/82] remove linux/version.h from drivers/message/fus ion

2005-07-20 Thread Nathan Lynch
Matt Domsch wrote: On Tue, Jul 19, 2005 at 06:07:41PM -0600, Moore, Eric Dean wrote: On Tuesday, July 12, 2005 8:17 PM, Matt Domsch wrote: In general, this construct: -#if (LINUX_VERSION_CODE KERNEL_VERSION(2,6,6)) -static int inline scsi_device_online(struct scsi_device

Re: [PATCH 22/82] remove linux/version.h from drivers/message/fus ion

2005-07-20 Thread Nish Aravamudan
On 7/19/05, Moore, Eric Dean [EMAIL PROTECTED] wrote: On Tuesday, July 12, 2005 8:17 PM, Matt Domsch wrote: In general, this construct: -#if (LINUX_VERSION_CODE KERNEL_VERSION(2,6,6)) -static int inline scsi_device_online(struct scsi_device *sdev) -{ - return sdev-online;

Re: [PATCH 22/82] remove linux/version.h from drivers/message/fus ion

2005-07-20 Thread Matt Domsch
On Wed, Jul 20, 2005 at 12:54:09PM -0500, Nathan Lynch wrote: Matt Domsch wrote: On Tue, Jul 19, 2005 at 06:07:41PM -0600, Moore, Eric Dean wrote: On Tuesday, July 12, 2005 8:17 PM, Matt Domsch wrote: In general, this construct: -#if (LINUX_VERSION_CODE KERNEL_VERSION(2,6,6))

RE: [PATCH 22/82] remove linux/version.h from drivers/message/fus ion

2005-07-19 Thread Moore, Eric Dean
On Tuesday, July 12, 2005 8:17 PM, Matt Domsch wrote: In general, this construct: -#if (LINUX_VERSION_CODE KERNEL_VERSION(2,6,6)) -static int inline scsi_device_online(struct scsi_device *sdev) -{ - return sdev-online; -} -#endif is better tested as: #ifndef

Re: [PATCH 22/82] remove linux/version.h from drivers/message/fus ion

2005-07-19 Thread Matt Domsch
On Tue, Jul 19, 2005 at 06:07:41PM -0600, Moore, Eric Dean wrote: On Tuesday, July 12, 2005 8:17 PM, Matt Domsch wrote: In general, this construct: -#if (LINUX_VERSION_CODE KERNEL_VERSION(2,6,6)) -static int inline scsi_device_online(struct scsi_device *sdev) -{ -

Re: [PATCH 22/82] remove linux/version.h from drivers/message/fus ion

2005-07-19 Thread Stephen Rothwell
On Tue, 19 Jul 2005 22:12:49 -0500 Matt Domsch [EMAIL PROTECTED] wrote: Sure it does, function names are defined symbols. I'm doing exactly this in my backport of the openipmi drivers to RHEL4 and SLES9. I missed the smiley, right :-) -- Cheers, Stephen Rothwell[EMAIL

Re: [PATCH 22/82] remove linux/version.h from drivers/message/fus ion

2005-07-13 Thread Christoph Hellwig
In general, this construct: -#if (LINUX_VERSION_CODE KERNEL_VERSION(2,6,6)) -static int inline scsi_device_online(struct scsi_device *sdev) -{ - return sdev-online; -} -#endif is better tested as: #ifndef scsi_device_inline static int inline scsi_device_online(struct

RE: [PATCH 22/82] remove linux/version.h from drivers/message/fus ion

2005-07-13 Thread Moore, Eric Dean
On Wednesday, July 13, 2005 8:38 AM, Christoph Hellwig wrote: In general, this construct: -#if (LINUX_VERSION_CODE KERNEL_VERSION(2,6,6)) -static int inline scsi_device_online(struct scsi_device *sdev) -{ - return sdev-online; -} -#endif is better tested

RE: [PATCH 22/82] remove linux/version.h from drivers/message/fus ion

2005-07-12 Thread Tom Duffy
On Sun, 2005-07-10 at 18:15 -0600, Moore, Eric Dean wrote: I'd rather you not kill linux_compat.h file. I use this file for compatibility of driver source across various kernel versions. I provide our customers with driver builds containing single source which needs to compile in kernels