Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-29 Thread Martin K. Petersen
> "KY" == KY Srinivasan writes: KY> We will fix this bug in the next release of Windows; we are also KY> looking at backporting the fix to prior versions of Windows. Excellent. Thanks for looking into this! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this lis

RE: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-29 Thread KY Srinivasan
om; > martin.peter...@oracle.com; linux-scsi@vger.kernel.org; > oher...@suse.com; gre...@linuxfoundation.org; jasow...@redhat.com > Subject: Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests > > On Mon, 2014-07-28 at 19:05 +, KY Srinivasan wrote: > > > > >

RE: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-28 Thread KY Srinivasan
om; > martin.peter...@oracle.com; linux-scsi@vger.kernel.org; > oher...@suse.com; gre...@linuxfoundation.org; jasow...@redhat.com > Subject: Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests > > On Mon, 2014-07-28 at 19:05 +, KY Srinivasan wrote: > > > > >

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-28 Thread James Bottomley
eeler; Christoph Hellwig; > > gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > > de...@linuxdriverproject.org; oher...@suse.com; a...@canonical.com; > > jasow...@redhat.com; jbottom...@parallels.com; linux- > > s...@vger.kernel.org > > Subject: Re: [PATCH v2 3/3] [

RE: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-28 Thread KY Srinivasan
r.kernel.org; > de...@linuxdriverproject.org; oher...@suse.com; a...@canonical.com; > jasow...@redhat.com; jbottom...@parallels.com; linux- > s...@vger.kernel.org > Subject: Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests > > >>>>> "KY" == KY Srinivasan

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-28 Thread Martin K. Petersen
> "KY" == KY Srinivasan writes: KY, KY> "At the time thin-provisioning was defined, the discovery KY> information was first proposed in READ CAPACITY 16 command. And then KY> moved into the new dedicated VPD page - B2h. You can see the KY> information reported in this VPD page is richer than

RE: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-28 Thread KY Srinivasan
r.kernel.org; > de...@linuxdriverproject.org; oher...@suse.com; a...@canonical.com; > jasow...@redhat.com; jbottom...@parallels.com; linux- > s...@vger.kernel.org > Subject: Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests > > >>>>> "KY" == KY Srinivas

RE: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-26 Thread KY Srinivasan
r.kernel.org; > de...@linuxdriverproject.org; oher...@suse.com; a...@canonical.com; > jasow...@redhat.com; jbottom...@parallels.com; linux- > s...@vger.kernel.org > Subject: Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests > > >>>>> "KY" == KY Srinivas

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-26 Thread Martin K. Petersen
> "KY" == KY Srinivasan writes: >> Great! I'd just like to have a reasonable level of confidence in >> what's happening down the stack before I entertain turning something >> on that's not being properly advertised. KY> As I look at the output of inquiry between Linux on Hyper-V and KY> nati

RE: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-26 Thread KY Srinivasan
r.kernel.org; > de...@linuxdriverproject.org; oher...@suse.com; a...@canonical.com; > jasow...@redhat.com; jbottom...@parallels.com; linux- > s...@vger.kernel.org > Subject: Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests > > >>>>> "KY" == KY Srinivasan wr

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-26 Thread Martin K. Petersen
> "KY" == KY Srinivasan writes: >> The LBP VPD page flags UNMAP as being supported. Do you actually >> support UNMAP to DSM TRIM SCSI-ATA translation? KY> I have been told by the Windows folks that this is done. I am trying KY> to get additional details. Great! I'd just like to have a reaso

RE: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-26 Thread KY Srinivasan
r.kernel.org; > de...@linuxdriverproject.org; oher...@suse.com; a...@canonical.com; > jasow...@redhat.com; jbottom...@parallels.com; linux- > s...@vger.kernel.org > Subject: Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests > > >>>>> "KY" == KY Srinivasan w

RE: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-26 Thread KY Srinivasan
om; > martin.peter...@oracle.com; linux-scsi@vger.kernel.org; > oher...@suse.com; gre...@linuxfoundation.org; jasow...@redhat.com > Subject: Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests > > On Fri, 2014-07-25 at 16:47 +, KY Srinivasan wrote: > > > > >

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-25 Thread James Bottomley
h Hellwig; KY Srinivasan; > > gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > > de...@linuxdriverproject.org; oher...@suse.com; a...@canonical.com; > > jasow...@redhat.com; jbottom...@parallels.com; linux- > > s...@vger.kernel.org > > Subject: R

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-25 Thread Martin K. Petersen
> "KY" == KY Srinivasan writes: KY> For the pass through case, the host validates the request and passes KY> the request to the device. However, not all scsi commands are KY> passed through even though the device it is being passed through may KY> support the command. WRITE_SAME is one such

RE: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-25 Thread KY Srinivasan
r.kernel.org; > de...@linuxdriverproject.org; oher...@suse.com; a...@canonical.com; > jasow...@redhat.com; jbottom...@parallels.com; linux- > s...@vger.kernel.org > Subject: Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests > > >>>>> "Sitsofe" == Sitsofe Whe

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-24 Thread Sitsofe Wheeler
On Thu, Jul 24, 2014 at 08:35:13AM -0700, Christoph Hellwig wrote: > On Thu, Jul 24, 2014 at 08:34:19AM -0700, Christoph Hellwig wrote: > > I agree - I'd like to pull in KY's simple fix as soon as I get a second > > review for it. > > Ok, looks like I just got that from Hannes. Let's see if there

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-24 Thread Martin K. Petersen
> "Sitsofe" == Sitsofe Wheeler writes: Sitsofe> So we can see it is really a SATA device that announces discard Sitsofe> correctly and supports discard through WRITE_SAME(16). No, that's the SATA device that announces support for DSM TRIM, and as a result the Linux SATL reports support for W

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-24 Thread Sitsofe Wheeler
On Thu, Jul 24, 2014 at 09:54:24AM -0400, Martin K. Petersen wrote: > > "Sitsofe" == Sitsofe Wheeler writes: > > Sitsofe> Fix incorrectly named variable. Some block devices (such as > Sitsofe> Hyper-V passthrough SSDs) support logical block provisioning > Sitsofe> (e.g. via UNMAP) but don't

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-24 Thread Christoph Hellwig
On Thu, Jul 24, 2014 at 08:34:19AM -0700, Christoph Hellwig wrote: > I agree - I'd like to pull in KY's simple fix as soon as I get a second > review for it. Ok, looks like I just got that from Hannes. Let's see if there's more to be done for the pass through case, but I'd rather wait for the nex

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-24 Thread Christoph Hellwig
On Thu, Jul 24, 2014 at 09:54:24AM -0400, Martin K. Petersen wrote: > I'm very much against short-circuiting the LBP logic in a passthrough > driver because then we might end up in the exact situation we were > trying to avoid with this patch series. Namely sending down commands > unsupported by th

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-24 Thread Martin K. Petersen
> "Sitsofe" == Sitsofe Wheeler writes: Sitsofe> Fix incorrectly named variable. Some block devices (such as Sitsofe> Hyper-V passthrough SSDs) support logical block provisioning Sitsofe> (e.g. via UNMAP) but don't set lbpme thus disabling discard. The fix for an SSD that is known to suppor