Re: Drivers: scsi: FLUSH timeout

2013-10-04 Thread Eric Seppanen
On Fri, Oct 4, 2013 at 5:18 AM, Ewan Milne wrote: > On Thu, 2013-10-03 at 13:48 -0700, Eric Seppanen wrote: >> Do I/O timeouts and flush timeouts need to be independently adjusted? >> If you're having trouble with slow operations, it seems likely to be >> across the board. >> >> Flush timeout coul

Re: Drivers: scsi: FLUSH timeout

2013-10-04 Thread James Bottomley
x-ker...@vger.kernel.org; > > de...@linuxdriverproject.org; > > linux-scsi@vger.kernel.org > > Subject: Re: Drivers: scsi: FLUSH timeout > > > > On Thu, Oct 3, 2013 at 5:09 AM, Nicholas A. Bellinger > > wrote: > > > > > > On Wed, 2013-10-02 at 18:29 +,

RE: Drivers: scsi: FLUSH timeout

2013-10-04 Thread KY Srinivasan
> -Original Message- > From: Eric Seppanen [mailto:e...@purestorage.com] > Sent: Thursday, October 03, 2013 1:49 PM > To: Nicholas A. Bellinger > Cc: KY Srinivasan; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; > linux-scsi@vger.kernel.org > Subje

Re: Drivers: scsi: FLUSH timeout

2013-10-04 Thread Ewan Milne
On Thu, 2013-10-03 at 13:48 -0700, Eric Seppanen wrote: > On Thu, Oct 3, 2013 at 5:09 AM, Nicholas A. Bellinger > wrote: > > > > On Wed, 2013-10-02 at 18:29 +, KY Srinivasan wrote: > > > Ideally, I want this to be adjustable like the way we can change the I/O > > > timeout. > > > Since that h

Re: Drivers: scsi: FLUSH timeout

2013-10-03 Thread Eric Seppanen
On Thu, Oct 3, 2013 at 5:09 AM, Nicholas A. Bellinger wrote: > > On Wed, 2013-10-02 at 18:29 +, KY Srinivasan wrote: > > Ideally, I want this to be adjustable like the way we can change the I/O > > timeout. > > Since that has been attempted earlier and rejected (not clear what the > > reason

RE: Drivers: scsi: FLUSH timeout

2013-10-03 Thread KY Srinivasan
; oher...@suse.com; > jbottom...@parallels.com; h...@infradead.org; linux-scsi@vger.kernel.org > Subject: Re: Drivers: scsi: FLUSH timeout > > On Wed, 2013-10-02 at 18:29 +, KY Srinivasan wrote: > > > > > -Original Message- > > > From: geert.uytterh

Re: Drivers: scsi: FLUSH timeout

2013-10-03 Thread James Bottomley
Srinivasan > > Cc: Mike Christie; Jack Wang; Greg KH; linux-ker...@vger.kernel.org; > > de...@linuxdriverproject.org; oher...@suse.com; jbottom...@parallels.com; > > h...@infradead.org; linux-scsi@vger.kernel.org > > Subject: Re: Drivers: scsi: FLUSH timeout > > > &g

Re: Drivers: scsi: FLUSH timeout

2013-10-03 Thread Nicholas A. Bellinger
Srinivasan > > Cc: Mike Christie; Jack Wang; Greg KH; linux-ker...@vger.kernel.org; > > de...@linuxdriverproject.org; oher...@suse.com; jbottom...@parallels.com; > > h...@infradead.org; linux-scsi@vger.kernel.org > > Subject: Re: Drivers: scsi: FLUSH timeout > > > &g

RE: Drivers: scsi: FLUSH timeout

2013-10-02 Thread KY Srinivasan
r.kernel.org; > de...@linuxdriverproject.org; oher...@suse.com; jbottom...@parallels.com; > h...@infradead.org; linux-scsi@vger.kernel.org > Subject: Re: Drivers: scsi: FLUSH timeout > > On Tue, Sep 24, 2013 at 11:53 PM, KY Srinivasan wrote: > > I am not sure how that magic number was arrived

Re: Drivers: scsi: FLUSH timeout

2013-09-25 Thread Geert Uytterhoeven
On Tue, Sep 24, 2013 at 11:53 PM, KY Srinivasan wrote: > I am not sure how that magic number was arrived at (the 60HZ number). We want > this to be little higher - "60 * HZ" means "60 seconds". > would there be any issues raising this to say 180 seconds. This is the value > we currently have

RE: Drivers: scsi: FLUSH timeout

2013-09-24 Thread KY Srinivasan
parallels.com; > h...@infradead.org; linux-scsi@vger.kernel.org > Subject: Re: Drivers: scsi: FLUSH timeout > > On 09/24/2013 07:35 AM, KY Srinivasan wrote: > > > > > >> -Original Message- > >> From: Jack Wang [mailto:xjtu...@gmail.com] > >> Sent: Tuesda

Re: Drivers: scsi: FLUSH timeout

2013-09-24 Thread Mike Christie
ct.org; >> oher...@suse.com; jbottom...@parallels.com; h...@infradead.org; linux- >> s...@vger.kernel.org; Mike Christie >> Subject: Re: Drivers: scsi: FLUSH timeout >> >> On 09/21/2013 07:24 AM, KY Srinivasan wrote: >>> >>> >>>> ---

Re: Drivers: scsi: FLUSH timeout

2013-09-24 Thread Bernd Schubert
...@infradead.org; linux- s...@vger.kernel.org; Mike Christie Subject: Re: Drivers: scsi: FLUSH timeout On 09/21/2013 07:24 AM, KY Srinivasan wrote: -Original Message- From: Greg KH [mailto:gre...@linuxfoundation.org] Sent: Friday, September 20, 2013 1:32 PM To: KY Srinivasan Cc: linux

RE: Drivers: scsi: FLUSH timeout

2013-09-24 Thread KY Srinivasan
ad.org; linux- > s...@vger.kernel.org; Mike Christie > Subject: Re: Drivers: scsi: FLUSH timeout > > On 09/21/2013 07:24 AM, KY Srinivasan wrote: > > > > > >> -Original Message- > >> From: Greg KH [mailto:gre...@linuxfoundation.org] > >> Sent: Fri

Re: Drivers: scsi: FLUSH timeout

2013-09-24 Thread Jack Wang
ct.org; >> oher...@suse.com; jbottom...@parallels.com; h...@infradead.org; linux- >> s...@vger.kernel.org >> Subject: Re: Drivers: scsi: FLUSH timeout >> >> On Fri, Sep 20, 2013 at 12:32:27PM -0700, K. Y. Srinivasan wrote: >>> The SD_FLUSH_TIMEOUT value is curr

RE: Drivers: scsi: FLUSH timeout

2013-09-20 Thread KY Srinivasan
ad.org; linux- > s...@vger.kernel.org > Subject: Re: Drivers: scsi: FLUSH timeout > > On Fri, Sep 20, 2013 at 12:32:27PM -0700, K. Y. Srinivasan wrote: > > The SD_FLUSH_TIMEOUT value is currently hardcoded. > > Hardcoded where? Please, more context. This is defined in scsi/sd.h:

Re: Drivers: scsi: FLUSH timeout

2013-09-20 Thread Laurence Oberman
I am thinking Srini meant in the sd_mod driver module. #define SD_FLUSH_TIMEOUT (60 * HZ) Laurence On Fri, Sep 20, 2013 at 4:32 PM, Greg KH wrote: > On Fri, Sep 20, 2013 at 12:32:27PM -0700, K. Y. Srinivasan wrote: >> The SD_FLUSH_TIMEOUT value is currently hardcoded. > > Hardcoded where? Plea

Re: Drivers: scsi: FLUSH timeout

2013-09-20 Thread Greg KH
On Fri, Sep 20, 2013 at 12:32:27PM -0700, K. Y. Srinivasan wrote: > The SD_FLUSH_TIMEOUT value is currently hardcoded. Hardcoded where? Please, more context. > On our cloud, we sometimes hit this timeout. I was wondering if we > could make this a module parameter. If this is acceptable, I can se