Re: UNMAP command parameter list

2014-11-10 Thread Andras Kovacs
Andras Kovacs akovacs at fixstars.com writes: Elliott, Robert (Server Storage Elliott at hp.com writes: That is the data transferred for the command, not in the command descriptor block itself. Thank you. Then I guess I'll find the Paramerer List in the struct scsi_data_buffer sdb

Re: UNMAP command parameter list

2014-11-10 Thread Martin K. Petersen
Andras == Andras Kovacs akov...@fixstars.com writes: Thank you. Then I guess I'll find the Paramerer List in the struct scsi_data_buffer sdb variable (within struct scsi_cmnd). Will check on Monday. Andras I've looked into it, but struct scsi_data_buffer doesn't contain Andras a byte array

Re: UNMAP command parameter list

2014-11-10 Thread Christoph Hellwig
On Mon, Nov 10, 2014 at 11:44:39AM -0500, Martin K. Petersen wrote: You'll have to traverse scatterlist and extract the descriptor from there. You can use scsi_for_each_sg() to walk the list. If you only care about in-kernel discards it's pretty easy since we only issue a single descriptor.

Re: UNMAP command parameter list

2014-11-10 Thread Martin K. Petersen
Christoph == Christoph Hellwig h...@infradead.org writes: Christoph Note that if the hardware doesn't actually implement UNMAP Christoph and you have to emulate something you're probably better off Christoph emulating WRITE SAME (16) with the UNMAP bit, as the format Christoph is a lot easier to

Re: UNMAP command parameter list

2014-11-10 Thread Andras Kovacs
Christoph Hellwig hch at infradead.org writes: On Mon, Nov 10, 2014 at 11:44:39AM -0500, Martin K. Petersen wrote: You'll have to traverse scatterlist and extract the descriptor from there. You can use scsi_for_each_sg() to walk the list. Thank you; I'm working on it. If you only

Re: UNMAP command parameter list

2014-11-08 Thread Andras Kovacs
Elliott, Robert (Server Storage Elliott at hp.com writes: That is the data transferred for the command, not in the command descriptor block itself. Thank you. Then I guess I'll find the Paramerer List in the struct scsi_data_buffer sdb variable (within struct scsi_cmnd). Will check on Monday.

RE: UNMAP command parameter list

2014-11-07 Thread Elliott, Robert (Server Storage)
-Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- ow...@vger.kernel.org] On Behalf Of Andras Kovacs Sent: Friday, 07 November, 2014 5:30 PM To: linux-scsi@vger.kernel.org Subject: UNMAP command parameter list Hi all, I'm trying to see what