Re: queue - sdev reference counting problem

2005-03-21 Thread Jens Axboe
On Fri, Mar 18 2005, Jens Axboe wrote: Hi, There is a problem with the way sdev is freed currently. The reason is really that there is a circular referencing problem: the sdev needs to hold on to the queue, but the queue (through the request function) also needs to hold on to the sdev.

Re: queue - sdev reference counting problem

2005-03-21 Thread James Bottomley
On Mon, 2005-03-21 at 15:59 +0100, Jens Axboe wrote: This is not even enough, since the queue lock is embedded in sdev structure. Guys, this is a serious issue. Oopsing a kernel is trivial with a hotplug device like a usb stick. Do you have the instructions to reproduce and a trace ... I've

Re: queue - sdev reference counting problem

2005-03-21 Thread Jens Axboe
On Mon, Mar 21 2005, James Bottomley wrote: On Mon, 2005-03-21 at 15:59 +0100, Jens Axboe wrote: This is not even enough, since the queue lock is embedded in sdev structure. Guys, this is a serious issue. Oopsing a kernel is trivial with a hotplug device like a usb stick. Do you have the

queue - sdev reference counting problem

2005-03-18 Thread Jens Axboe
Hi, There is a problem with the way sdev is freed currently. The reason is really that there is a circular referencing problem: the sdev needs to hold on to the queue, but the queue (through the request function) also needs to hold on to the sdev. The easiest way to work-around this problem is