Re: [V2 PATCH 04/11] aacraid: MSI-x support

2015-03-27 Thread Johannes Thumshirn
Mahesh Rajashekhara mahesh.rajashekh...@pmcs.com writes: Add MSI-x interrupt mode support. Signed-off-by: Mahesh Rajashekhara mahesh.rajashekh...@pmcs.com --- drivers/scsi/aacraid/aacraid.h | 80 - drivers/scsi/aacraid/comminit.c | 95 +-

[PATCH] advansys: fix compilation errors and warnings when CONFIG_PCI is not set

2015-06-03 Thread Johannes Thumshirn
Fix compilation errors on forgotten #include linux/dmapool.h and warnings when CONFIG_PCI is not set. Reported-by: Jim Davis jim.ep...@gmail.com Signed-off-by: Johannes Thumshirn jthumsh...@suse.de --- drivers/scsi/advansys.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [PATCH] megaraid_sas: insert missing space in kernel message

2015-06-10 Thread Johannes Thumshirn
)) { -- 2.1.4 Reviewed-by: Johannes Thumshirn jthumsh...@suse.de -- Johannes Thumshirn Storage jthumsh...@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G

Re: [PATCH] mvsas: always iounmap resources

2015-06-22 Thread Johannes Thumshirn
On Fri, Jun 12, 2015 at 08:31:38AM +0200, Hannes Reinecke wrote: On 05/22/2015 11:15 AM, Johannes Thumshirn wrote: In case pci_resource_start() or pci_resource_len() reutrn 0, mvsas_ioremap returns without doing an iounmap() of mvi-regs_ex. Found by the cocinelle tool. Signed-off

Re: [PATCH] SCSI-OSD: Delete an unnecessary check before the function call put_disk

2015-06-24 Thread Johannes Thumshirn
-info.html Reviewed-by: Johannes Thumshirn jthumsh...@suse.de -- Johannes Thumshirn Storage jthumsh...@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton

Re: [PATCH resend] mpt2sas: setpci reset kernel panic fix

2015-06-19 Thread Johannes Thumshirn
people debugging it) knew it will be already initialized and b) you don't need is already initialized check any more. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de +49 911 74053 689 SUSE LINUX GmbH

Re: [PATCH resend] mpt2sas: setpci reset kernel panic fix

2015-06-19 Thread Johannes Thumshirn
, even better. -- Johannes Thumshirn Storage jthumsh...@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg

Re: [PATCH v1 01/20] [SCSI] mpt3sas: Added Combined Reply Queue feature to extend up-to 96 MSIX vector support

2015-06-19 Thread Johannes Thumshirn
list_head delayed_tr_list; struct list_head delayed_tr_volume_list; u8 temp_sensors_count; -- 2.0.2 Reviewed-by: Johannes Thumshirn jthumsh...@suse.de -- Johannes Thumshirn Storage jthumsh...@suse.de

Re: [PATCH v1 06/20] [SCSI] mpt3sas: Provides the physical location of sas drives

2015-06-19 Thread Johannes Thumshirn
(sas_device_pg0.Slot); + _scsih_mark_responding_sas_device(ioc, sas_device_pg0); } out: -- 2.0.2 Reviewed-by: Johannes Thumshirn jthumsh...@suse.de -- Johannes Thumshirn Storage jthumsh...@suse.de +49 911 74053 689

Re: [PATCH 01/20] [SCSI] mpt3sas: Added Combined Reply Queue feature to extend up-to 96 MSIX vector support

2015-06-19 Thread Johannes Thumshirn
-- Johannes Thumshirn Storage jthumsh...@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list

Re: [PATCH 06/20] [SCSI] mpt3sas: Provides the physical location of sas drives

2015-06-19 Thread Johannes Thumshirn
]; Minor nit of different indent here, don't know if it is worth re-sending? Other than that: Reviewed-by: Johannes Thumshirn jthumsh...@suse.de -- Johannes Thumshirn Storage jthumsh...@suse.de +49 911 74053 689 SUSE LINUX GmbH

Re: [PATCH 01/20] [SCSI] mpt3sas: Added Combined Reply Queue feature to extend up-to 96 MSIX vector support

2015-06-19 Thread Johannes Thumshirn
On Fri, Jun 19, 2015 at 02:51:00PM +0530, Sreekanth Reddy wrote: On Fri, Jun 19, 2015 at 2:44 PM, Johannes Thumshirn jthumsh...@suse.de wrote: On Thu, Jun 18, 2015 at 03:27:26PM +0530, Sreekanth Reddy wrote: Hi, Any other review comments on this patch. please let us known if any

Re: [Patch V2 4/9] [SCSI] aacraid: Enable 64-bit write to controller register

2015-06-11 Thread Johannes Thumshirn
of writeq? -- 1.9.3 -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Johannes Thumshirn Storage jthumsh

Re: [PATCH 13/20] [SCSI] mpt3sas: MPI 2.5 Rev K (2.5.6) specifications

2015-06-15 Thread Johannes Thumshirn
://vger.kernel.org/majordomo-info.html Reviewed-by: Johannes Thumshirn jthumsh...@suse.de -- Johannes Thumshirn Storage jthumsh...@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard

Re: [PATCH 08/20] [SCSI] mpt3sas: Update MPI2 strings to MPI2.5

2015-06-15 Thread Johannes Thumshirn
*/ -- 2.0.2 -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Reviewed-by: Johannes Thumshirn jthumsh...@suse.de -- Johannes Thumshirn

Re: [PATCH 05/20] [SCSI] mpt3sas: MPI 2.5 Rev I (2.5.4) specifications.

2015-06-15 Thread Johannes Thumshirn
to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Reviewed-by: Johannes Thumshirn jthumsh...@suse.de -- Johannes Thumshirn Storage jthumsh...@suse.de +49 911 74053 689 SUSE LINUX GmbH

Re: [PATCH 09/20] [SCSI] mpt3sas: MPI 2.5 Rev J (2.5.5) specification and 2.00.34 header files

2015-06-15 Thread Johannes Thumshirn
(0x0004) -- 2.0.2 -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Reviewed-by: Johannes Thumshirn jthumsh...@suse.de -- Johannes

Re: [PATCH 07/20] [SCSI] mpt3sas: Bump mpt3sas Driver version to v5.100.00.00

2015-06-15 Thread Johannes Thumshirn
...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Reviewed-by: Johannes Thumshirn jthumsh...@suse.de -- Johannes Thumshirn Storage jthumsh...@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409

Re: [PATCH 10/20] [SCSI] mpt3sas: Add branding string support for OEM's HBA

2015-06-15 Thread Johannes Thumshirn
On Mon, Jun 15, 2015 at 04:41:56PM +0530, Sreekanth Reddy wrote: On Mon, Jun 15, 2015 at 3:16 PM, Johannes Thumshirn jthumsh...@suse.de wrote: On Fri, Jun 12, 2015 at 03:12:22PM +0530, Sreekanth Reddy wrote: Added the following Dell branding to the mpt3sas driver. VendorID DeviceID

Re: [PATCH 15/20] [SCSI] mpt3sas: Return host busy error status to SML when DMA mapping of scatter gather list fails for a SCSI command

2015-06-15 Thread Johannes Thumshirn
-info.html Reviewed-by: Johannes Thumshirn jthumsh...@suse.de -- Johannes Thumshirn Storage jthumsh...@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G

Re: [PATCH 20/20] [SCSI] mpt3sas : Bump mpt3sas driver version to 9.100.00.00

2015-06-15 Thread Johannes Thumshirn
...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Reviewed-by: Johannes Thumshirn jthumsh...@suse.de -- Johannes Thumshirn Storage jthumsh...@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409

Re: [PATCH 12/20] [SCSI] mpt3sas: Bump mpt3sas driver version to v6.100.00.00

2015-06-15 Thread Johannes Thumshirn
...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Reviewed-by: Johannes Thumshirn jthumsh...@suse.de -- Johannes Thumshirn Storage jthumsh...@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409

Re: [PATCH 04/20] [SCSI] mpt3sas: Remove redundancy code while freeing the controller resources.

2015-06-15 Thread Johannes Thumshirn
On Mon, Jun 15, 2015 at 03:56:56PM +0530, Sreekanth Reddy wrote: On Fri, Jun 12, 2015 at 6:10 PM, Johannes Thumshirn jthumsh...@suse.de wrote: On Fri, Jun 12, 2015 at 05:48:56PM +0530, Sreekanth Reddy wrote: On Fri, Jun 12, 2015 at 4:58 PM, Johannes Thumshirn jthumsh...@suse.de wrote

Re: [PATCH 18/20] [SCSI] mpt3sas: Call dma_mapping_error() API after mapping an address with dma_map_single() API

2015-06-15 Thread Johannes Thumshirn
: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Reviewed-by: Johannes Thumshirn jthumsh...@suse.de -- Johannes Thumshirn Storage jthumsh...@suse.de

Re: [PATCH 10/20] [SCSI] mpt3sas: Add branding string support for OEM's HBA

2015-06-15 Thread Johannes Thumshirn
to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html This might be something you might consider re-organizing for your code-base merge as well, as it leads to a lot of code duplication the more OEMs you have. -- Johannes Thumshirn

Re: [PATCH 19/20] [SCSI] mpt3sas: When device is blocked followed by unblock fails, unfreeze the I/Os

2015-06-15 Thread Johannes Thumshirn
this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Reviewed-by: Johannes Thumshirn jthumsh...@suse.de -- Johannes Thumshirn Storage jthumsh

Re: [PATCH 14/20] [SCSI] mpt3sas: Complete the SCSI command with DID_RESET status for log_info value 0x0x32010081

2015-06-15 Thread Johannes Thumshirn
= DID_SOFT_ERROR 16; break; -- 2.0.2 -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Johannes Thumshirn

Re: [PATCH 01/20] [SCSI] mpt3sas: Added Combined Reply Queue feature to extend up-to 96 MSIX vector support

2015-06-12 Thread Johannes Thumshirn
; -- 2.0.2 -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Johannes Thumshirn Storage jthumsh...@suse.de

Re: [PATCH 04/20] [SCSI] mpt3sas: Remove redundancy code while freeing the controller resources.

2015-06-12 Thread Johannes Thumshirn
; } -- 2.0.2 -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Johannes Thumshirn Storage jthumsh...@suse.de

Re: [PATCH 04/20] [SCSI] mpt3sas: Remove redundancy code while freeing the controller resources.

2015-06-12 Thread Johannes Thumshirn
On Fri, Jun 12, 2015 at 05:48:56PM +0530, Sreekanth Reddy wrote: On Fri, Jun 12, 2015 at 4:58 PM, Johannes Thumshirn jthumsh...@suse.de wrote: On Fri, Jun 12, 2015 at 03:12:16PM +0530, Sreekanth Reddy wrote: Removed the redundancy code while freeing the controller resources. Signed-off

Re: [PATCH 04/20] [SCSI] mpt3sas: Remove redundancy code while freeing the controller resources.

2015-06-18 Thread Johannes Thumshirn
the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Reviewed-by: Johannes Thumshirn jthumsh...@suse.de -- Johannes Thumshirn Storage jthumsh...@suse.de

Re: [PATCH 10/20] [SCSI] mpt3sas: Add branding string support for OEM's HBA

2015-06-18 Thread Johannes Thumshirn
to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Reviewed-by: Johannes Thumshirn jthumsh...@suse.de -- Johannes Thumshirn Storage jthumsh...@suse.de +49 911 74053 689 SUSE LINUX GmbH

Re: [PATCH 14/20 v1] [SCSI] mpt3sas: Complete the SCSI command with DID_RESET status for log_info value 0x0x32010081

2015-06-18 Thread Johannes Thumshirn
; } scmd-result = DID_SOFT_ERROR 16; break; -- 2.0.2 Reviewed-by: Johannes Thumshirn jthumsh...@suse.de -- Johannes Thumshirn Storage jthumsh...@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg

Re: [PATCH 1/1] scsi: Initialize sdp after NULL check of cmnd

2015-06-17 Thread Johannes Thumshirn
, scsi_result); -- 1.7.1 -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Reviewed-by: Johannes Thumshirn jthumsh...@suse.de -- Johannes Thumshirn

Re: [PATCH] mpt2sas: setpci reset kernel panic fix

2015-06-17 Thread Johannes Thumshirn
please format the patch according to Documentation/SubmittingPatches and re-send. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F

Re: [Patch V2 1/9] [SCSI] aacraid: Fix for logical device name and UID not exposed to the OS

2015-06-16 Thread Johannes Thumshirn
info at http://vger.kernel.org/majordomo-info.html Reviewed-by: Johannes Thumshirn jthumsh...@suse.de -- Johannes Thumshirn Storage jthumsh...@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F

Re: [Patch V2 3/9] [SCSI] aacraid: Enable MSI interrupt for series-6 controller

2015-06-16 Thread Johannes Thumshirn
-- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Reviewed-by: Johannes Thumshirn jthumsh...@suse.de -- Johannes Thumshirn

Re: [Patch V2 6/9] [SCSI] aacraid: Reset irq affinity hints before releasing irq

2015-06-16 Thread Johannes Thumshirn
in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Reviewed-by: Johannes Thumshirn jthumsh...@suse.de -- Johannes Thumshirn Storage jthumsh...@suse.de +49 911

Re: [Patch V2 7/9] [SCSI] aacraid: Unblock IOCTLs to controller once system resumed from suspend

2015-06-16 Thread Johannes Thumshirn
majordomo info at http://vger.kernel.org/majordomo-info.html Reviewed-by: Johannes Thumshirn jthumsh...@suse.de -- Johannes Thumshirn Storage jthumsh...@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F

Re: [Patch V2 9/9] [SCSI] aacraid: Update driver version

2015-06-16 Thread Johannes Thumshirn
#endif -- 1.9.3 -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Reviewed-by: Johannes Thumshirn jthumsh...@suse.de -- Johannes Thumshirn

Re: [PATCH] bfa: fix leak of bfad_im_port_index on module unload

2015-06-12 Thread Johannes Thumshirn
+851,8 @@ bfad_im_module_exit(void) if (bfad_im_scsi_vport_transport_template) fc_release_transport(bfad_im_scsi_vport_transport_template); + + idr_destroy(bfad_im_port_index); } void -- 1.9.1 Reviewed-by: Johannes Thumshirn jthumsh...@suse.de -- Johannes

Re: [PATCH v6 9/9] snic:Add Makefile, patch Kconfig, MAINTAINERS

2015-05-28 Thread Johannes Thumshirn
On Thu, May 28, 2015 at 09:49:08AM +, Narsimhulu Musini (nmusini) wrote: Hi Boaz, Sure, I will incorporate the comments and suggestions in next patch submittal. Thanks Narsimhulu As you're going to re-submit anyway, I have found several occurences of: [Insert appropriate license

Re: [PATCH] st: null pointer dereference panic caused by use after kref_put by st_open

2015-07-02 Thread Johannes Thumshirn
Seymour, Shane M shane.seym...@hp.com writes: Two SLES11 SP3 servers encountered similar crashes simultaneously following some kind of SAN/tape target issue: Thanks, Reviewed-by: Johannes Thumshirn jthumsh...@suse.com -- Johannes Thumshirn Storage

Re: [PATCH 1/1] we added changes in fnic driver patch 1.6.0.16 to acquire io_req_lock in fnic_queuecommand() before issuing I/O so that io completion is serialized. But when releasing the lock we chec

2015-07-03 Thread Johannes Thumshirn
the io lock */ - if (CMD_FLAGS(sc) FNIC_IO_INITIALIZED) + if (io_lock_acquired) spin_unlock_irqrestore(io_lock, flags); Can't you just use if (spin_is_locked(io_lock)) spin_unlock_irqrestore(io_lock, flags); atomic_dec(fnic-in_flight); Johannes -- Johannes

Re: [patch] mptfusion: prevent some memory corruption

2015-07-03 Thread Johannes Thumshirn
; -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Acked-by: Johannes Thumshirn jthumsh...@suse.de -- Johannes Thumshirn Storage

[PATCH] mvsas: always iounmap resources

2015-05-22 Thread Johannes Thumshirn
In case pci_resource_start() or pci_resource_len() reutrn 0, mvsas_ioremap returns without doing an iounmap() of mvi-regs_ex. Found by the cocinelle tool. Signed-off-by: Johannes Thumshirn jthumsh...@suse.de --- drivers/scsi/mvsas/mv_init.c | 5 - 1 file changed, 4 insertions(+), 1 deletion

[PATCH RESEND] mvsas: always iounmap resources

2015-07-07 Thread Johannes Thumshirn
In case pci_resource_start() or pci_resource_len() reutrn 0, mvsas_ioremap returns without doing an iounmap() of mvi-regs_ex. Found by the cocinelle tool. Signed-off-by: Johannes Thumshirn jthumsh...@suse.de Reviewed-by: Hannes Reinecke h...@suse.de --- drivers/scsi/mvsas/mv_init.c | 5 - 1

Re: [PATCH V3] fnic: check pci_map_single() return value

2015-08-13 Thread Johannes Thumshirn
with error %d\n, r); + return SCSI_MLQUEUE_HOST_BUSY; + } + int_to_scsilun(sc-device-lun, fc_lun); /* Enqueue the descriptor in the Copy WQ */ Looks good from my side. Reviewed-by: Johannes Thumshirn jthumsh...@suse.de -- Johannes Thumshirn

[PATCH] scsi: Export SCSI Inquiry data to sysfs

2015-08-13 Thread Johannes Thumshirn
2020 2020 010 4551 554d 4420 4456 522d 4d4f 2020 2020 020 2e32 2e33 024 Signed-off-by: Johannes Thumshirn jthumsh...@suse.de --- drivers/scsi/scsi_sysfs.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c

Re: [PATCH RESEND V2 3/7] scsi: storvsc: Untangle the storage protocol negotiation from the vmbus protocol negotiation.

2015-08-13 Thread Johannes Thumshirn
vmscsi_win8_extension), + }, + { + VMSTOR_PROTO_VERSION_WIN6, + PRE_WIN8_STORVSC_SENSE_BUFFER_SIZE, + sizeof(struct vmscsi_win8_extension), + } +}; + Thanks, Johannes -- Johannes Thumshirn Storage

Re: [patch] scsi: aic94xx: set an error code on failure

2015-08-18 Thread Johannes Thumshirn
in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Reviewed-by: Johannes Thumshirn jthumsh...@suse.de -- Johannes Thumshirn Storage jthumsh...@suse.de +49 911

Re: [patch] cxlflash: shift wrapping bug in afu_link_reset()

2015-08-18 Thread Johannes Thumshirn
); -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Reviewed-by: Johannes Thumshirn jthumsh...@suse.de -- Johannes Thumshirn

[PATCH] [SCSI] bfa: check if port is non NULL before dereferencing

2015-08-17 Thread Johannes Thumshirn
In bfa_fcs_lport_get_rport_max_speed() check if port is non NULL before dereferencing it's child port-fcs-bfa to trl_enabled. NB: I'm not entirely sure if port can even be NULL, so the check for NULL might be useless as well. Signed-off-by: Johannes Thumshirn jthumsh...@suse.de --- drivers/scsi

[PATCH] lpfc: Fix possible use-after-free and double free in lpfc_mbx_cmpl_rdp_page_a2()

2015-08-17 Thread Johannes Thumshirn
. This is the use after free. Following the use after free mp gets kfree()d again which is a double free. Signed-off-by: Johannes Thumshirn jthumsh...@suse.de --- drivers/scsi/lpfc/lpfc_mbox.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_mbox.c b/drivers

Re: [PATCH] pm80xx: Don't override ts-stat on IO_OPEN_CNX_ERROR_HW_RESOURCE_BUSY

2015-08-17 Thread Johannes Thumshirn
Jack Wang xjtu...@gmail.com writes: 2015-08-17 15:04 GMT+02:00 Johannes Thumshirn jthumsh...@suse.de: In case XXX returns with a status of IO_OPEN_CNX_ERROR_HW_RESOURCE_BUSY Apparently I've hit enter to fast. This shouldn't be XXX but psataPayload-status. I'll be sending a v2 :-(. ts-stat

[PATCH] pm80xx: Don't override ts-stat on IO_OPEN_CNX_ERROR_HW_RESOURCE_BUSY

2015-08-17 Thread Johannes Thumshirn
In case XXX returns with a status of IO_OPEN_CNX_ERROR_HW_RESOURCE_BUSY ts-stat gets set to SAS_OPEN_REJECT but a missing 'break' statement causes a fallthrough to the default handler of the switch statement overriding ts-stat to SAS_DEV_NO_RESPONSE. Signed-off-by: Johannes Thumshirn jthumsh

[PATCH v2] pm80xx: Don't override ts-stat on IO_OPEN_CNX_ERROR_HW_RESOURCE_BUSY

2015-08-17 Thread Johannes Thumshirn
In case psataPayload-status has a status of IO_OPEN_CNX_ERROR_HW_RESOURCE_BUSY ts-stat gets set to SAS_OPEN_REJECT but a missing 'break' statement causes a fallthrough to the default handler of the switch statement overriding ts-stat to SAS_DEV_NO_RESPONSE. Signed-off-by: Johannes Thumshirn

Re: [PATCH] lpfc: Fix possible use-after-free and double free in lpfc_mbx_cmpl_rdp_page_a2()

2015-08-18 Thread Johannes Thumshirn
Sebastian Herbszt herb...@gmx.de writes: Johannes Thumshirn wrote: If the bf_get() call in lpfc_mbx_cmpl_rdp_page_a2() does succeeds, execution continues normally and mp gets kfree()d. If the subsequent call to lpfc_sli_issue_mbox() fails execution jumps to the error label where

Re: [PATCH] SCSI: Fix NULL pointer dereference in runtime PM

2015-08-18 Thread Johannes Thumshirn
; } -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Reviewed-by: Johannes Thumshirn jthumsh...@suse.de -- Johannes Thumshirn

Re: [PATCH] scsi/be2iscsi: Fix logical-not-parentheses compilation warning

2015-08-04 Thread Johannes Thumshirn
); sgl-va = virtual_address; Given the above is swapped: Reviewed-by: Johannes Thumshirn jthumsh...@suse.de -- Johannes Thumshirn Storage jthumsh...@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409

Re: [PATCH] megaraid_sas: fix missing { } braces

2015-08-04 Thread Johannes Thumshirn
; + } } megasas_return_cmd(instance, cmd); For the curly braces part: Reviewed-by: Johannes Thumshirn jthumsh...@suse.de While you're up to it, care to check drivers/scsi/bfa as well? There was a patch somewhen in the past but it seems it wasn't applied. But if found this bugzilla entry https

Re: [TRIVIAL PATCH] block: Correct misuses of 0x%decimal

2015-08-03 Thread Johannes Thumshirn
in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Reviewed-by: Johannes Thumshirn jthumsh...@suse.de -- Johannes Thumshirn Storage jthumsh...@suse.de +49 911

Re: [PATCH v3] mpt2sas: setpci reset kernel oops fix

2015-08-06 Thread Johannes Thumshirn
-lsL0P1VTbdAQ9zpAXLjCCl4LS3bUhIe= -- Nagarajkumar Narayanan Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J

Re: [PATCH] scsi/be2iscsi: Fix logical-not-parentheses compilation warning

2015-08-07 Thread Johannes Thumshirn
*virtual_address, { WARN_ON(!virtual_address); WARN_ON(!physical_address); - WARN_ON(!length 0); + WARN_ON(length == 0); WARN_ON(!sgl); sgl-va = virtual_address; Looks good. Reviewed-by: Johannes Thumshirn jthumsh...@suse.de -- Johannes Thumshirn

Re: [PATCH RESEND V2 3/7] scsi: storvsc: Untangle the storage protocol negotiation from the vmbus protocol negotiation.

2015-08-14 Thread Johannes Thumshirn
KY Srinivasan k...@microsoft.com writes: -Original Message- From: Johannes Thumshirn [mailto:jthumsh...@suse.de] Sent: Thursday, August 13, 2015 7:34 AM To: KY Srinivasan k...@microsoft.com; Keith Mange keith.ma...@microsoft.com Cc: gre...@linuxfoundation.org; linux-ker

[PATCH v2] scsi: Export SCSI Inquiry data to sysfs

2015-08-14 Thread Johannes Thumshirn
2020 2020 010 4551 554d 4420 4456 522d 4d4f 2020 2020 020 2e32 2e33 024 Signed-off-by: Johannes Thumshirn jthumsh...@suse.de Reviewed-by: Hannes Reinecke h...@suse.de --- Chanes to v1: * Correct typo userlang - userland in commit message. drivers/scsi/scsi_sysfs.c | 24

Re: [PATCH] fnic: check pci_map_single() return value

2015-08-12 Thread Johannes Thumshirn
-device-lun, fc_lun); /* Enqueue the descriptor in the Copy WQ */ Thanks -- Johannes Thumshirn Storage jthumsh...@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J

Re: [PATCH V2] fnic: check pci_map_single() return value

2015-08-12 Thread Johannes Thumshirn
)) { pci_unmap_single(fnic-pdev, pa, skb-len, PCI_DMA_TODEVICE); @@ -1071,6 +1091,12 @@ static int fnic_send_frame(struct fnic *fnic, struct fc_frame *fp) pa = pci_map_single(fnic-pdev, eth_hdr, tot_len, PCI_DMA_TODEVICE); [..] Otherwise: Reviewed-by: Johannes Thumshirn jthumsh...@suse.de -- Johannes

Re: [PATCH] csiostor: Use list_for_each_safe instead of re-implementing it

2015-07-16 Thread Johannes Thumshirn
); Reviewed-by: Johannes Thumshirn jthumsh...@suse.de -- Johannes Thumshirn Storage jthumsh...@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284

Re: [PATCH] SCSI: mvsas: Fix NULL pointer dereference in mvs_slot_task_free

2015-10-21 Thread Johannes Thumshirn
On Wed, 2015-10-21 at 17:26 +0300, Dāvis Mosāns wrote: > 2015-10-21 16:47 GMT+03:00 Johannes Thumshirn <jthumsh...@suse.de>: > > On Wed, 2015-10-21 at 16:18 +0300, Dāvis Mosāns wrote: > > > 2015-10-21 10:33 GMT+03:00 Johannes Thumshirn <jthumsh...@suse.de > > >

Re: [PATCH] scsi: wd719x: Use module_pci_driver

2015-10-22 Thread Johannes Thumshirn
oid __exit wd719x_exit(void) > -{ > - pci_unregister_driver(_pci_driver); > -} > - > -module_init(wd719x_init); > -module_exit(wd719x_exit); > +module_pci_driver(wd719x_pci_driver); >   >  MODULE_DESCRIPTION("Western Digital WD7193/7197/7296 SCSI driver"); >

Re: [PATCH] scsi: wd719x: Remove use of macro DEFINE_PCI_DEVICE_TABLE

2015-10-22 Thread Johannes Thumshirn
ic void wd719x_pci_remove(struct pci_dev > *pdev) >   scsi_host_put(sh); >  } >   > -static DEFINE_PCI_DEVICE_TABLE(wd719x_pci_table) = { > +static const struct pci_device_id wd719x_pci_table[] = { >   { PCI_DEVICE(PCI_VENDOR_ID_WD, 0x3296) }, >   {} >  };

Re: [PATCH] scsi: restart list search after unlock in scsi_remove_target

2015-10-26 Thread Johannes Thumshirn
On Mon, 2015-10-19 at 16:35 +0200, Christoph Hellwig wrote: > When dropping a lock while iterating a list we must restart the > search > as other threads could have manipulated the list under us.  Without > this > we can get stuck in an endless loop. > > Reported-by: Johann

Re: [PATCH 1/3] megaraid_sas: Convert dev_printk to dev_

2015-10-27 Thread Johannes Thumshirn
megasas_probe_one(struct pci_dev > *pdev, >   > >evt_detail_h); >   >   if (!instance->evt_detail) { > - dev_printk(KERN_DEBUG, >dev, "Failed to > allocate memory for " > +

Re: [PATCH 2/3] megaraid_sas: Convert printk to printk_

2015-10-27 Thread Johannes Thumshirn
debug("megasas: failed to open device node\n"); >   return rval; >   } >   > @@ -6752,7 +6752,7 @@ static int __init megasas_init(void) >   rval = pci_register_driver(_pci_driver); >   >   if (rval) { > - printk(KERN_DEBUG "megasas: PCI hotplug registration > failed \n"); > + pr_debug("megasas: PCI hotplug registration failed > \n"); >   goto err_pcidrv; >   } >   Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/3] megaraid_sas: return -ENOMEM when create DMA pool for cmd frames failed

2015-10-27 Thread Johannes Thumshirn
frame pool and assign one frame to each cmd >    */ >   if (megasas_create_frame_pool(instance)) { > - dev_dbg(>pdev->dev, "Error creating frame > DMA pool\n"); > + dev_err(>pdev->dev, "Error creating frame > DM

Re: [PATCH] scsi: restart list search after unlock in scsi_remove_target

2015-10-27 Thread Johannes Thumshirn
On Mon, 2015-10-19 at 16:35 +0200, Christoph Hellwig wrote: > When dropping a lock while iterating a list we must restart the > search > as other threads could have manipulated the list under us.  Without > this > we can get stuck in an endless loop. > > Reported-by: Johann

Re: [PATCH] SCSI: mvsas: Fix NULL pointer dereference in mvs_slot_task_free

2015-10-21 Thread Johannes Thumshirn
On Wed, 2015-10-21 at 16:18 +0300, Dāvis Mosāns wrote: > 2015-10-21 10:33 GMT+03:00 Johannes Thumshirn <jthumsh...@suse.de>: > > On Tue, 2015-10-20 at 20:41 +0300, Dāvis Mosāns wrote: > > > 2015-08-21 7:29 GMT+03:00 Dāvis Mosāns <davis...@gmail.com>: >

Re: [patch] hpsa: logical vs bitwise AND typo

2015-11-12 Thread Johannes Thumshirn
if (*options & HPSA_DIAG_OPTS_DISABLE_RLD_CACHING) >   goto out; >   >  errout: Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" > in > the body of a message to ma

[PATCH RESEND] scsi: Export SCSI Inquiry data to sysfs

2015-11-09 Thread Johannes Thumshirn
2020 2020 010 4551 554d 4420 4456 522d 4d4f 2020 2020 020 2e32 2e33 024 Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> Reviewed-by: Hannes Reinecke <h...@suse.de> --- 1st sent on Aug. 14 2015 1st resend on Oct. 30 2015 drivers/scsi/scsi_sysfs.c | 24 +++

Re: [RESEND PATCH v3] scsi: stex: Remove use of struct timeval

2015-10-30 Thread Johannes Thumshirn
conds, which returns a 64-bit seconds value. Thanks for the conversion. Can you please check if other (scsi) drivers have the same y2038 issues? A quick "git grep do_gettimeofday drivers/scsi/  | wc -l" reveals 30 occurrences (of cause not all are problematic). Other than that Reviewed-

Re: [PATCH] scsi: restart list search after unlock in scsi_remove_target

2015-10-30 Thread Johannes Thumshirn
Hi Bart, On Tue, 2015-10-27 at 13:14 -0700, Bart Van Assche wrote: > On 10/26/2015 01:35 AM, Johannes Thumshirn wrote: > > I haven't heard anything from the original reporter of the lockup > > but > > my test's went all O.K., so > > > > Tested-by: Johan

[PATCH RESEND] scsi: Export SCSI Inquiry data to sysfs

2015-10-30 Thread Johannes Thumshirn
2020 2020 010 4551 554d 4420 4456 522d 4d4f 2020 2020 020 2e32 2e33 024 Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> Reviewed-by: Hannes Reinecke <h...@suse.de> --- drivers/scsi/scsi_sysfs.c | 24 1 file changed, 24 insertions(+) diff --g

Re: [PATCH v4.3-rc7] be2iscsi : Fix bogus WARN_ON length check

2015-10-30 Thread Johannes Thumshirn
Hi Tim, tim.gard...@canonical.com writes: > From: Tim Gardner > > drivers/scsi/be2iscsi/be_main.c: In function 'be_sgl_create_contiguous': > drivers/scsi/be2iscsi/be_main.c:3187:18: warning: logical not is only applied > to the left hand side of comparison

Re: [RESEND PATCH] [SCSI] mvumi: 64bit value for seconds_since1970

2015-10-30 Thread Johannes Thumshirn
. > This patch uses ktime_get_real_seconds() instead since it provides a > 64-bit seconds value, which is 2038 safe. > > Signed-off-by: Tina Ruchandani <ruchandani.t...@gmail.com> Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> > --- >  drivers/scsi/mvumi.c | 10 +

Re: [RESEND PATCH] qla2xxx: Remove use of 'struct timeval'

2015-10-30 Thread Johannes Thumshirn
gt; The patch uses ktime_get_real_seconds() which returns a 64-bit > seconds value. > > Signed-off-by: Tina Ruchandani <ruchandani.t...@gmail.com> Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> > --- >  drivers/scsi/qla2xxx/qla_mr.c | 5 ++--- >  1 file changed,

Re: [PATCH 0/3] SCSI: Fix hard lockup in scsi_remove_target()

2015-10-14 Thread Johannes Thumshirn
On Wed, 2015-10-14 at 07:30 -0700, James Bottomley wrote: > On Wed, 2015-10-14 at 15:50 +0200, Johannes Thumshirn wrote: > > Removing a SCSI target via scsi_remove_target() suspected to be > > racy. When a > > sibling get's removed from the list it can occassionly ha

Re: [PATCH 0/3] SCSI: Fix hard lockup in scsi_remove_target()

2015-10-15 Thread Johannes Thumshirn
On Wed, 2015-10-14 at 16:22 -0400, Ewan Milne wrote: > On Wed, 2015-10-14 at 07:30 -0700, James Bottomley wrote: > > On Wed, 2015-10-14 at 15:50 +0200, Johannes Thumshirn wrote: > > > Removing a SCSI target via scsi_remove_target() suspected to be > > > racy. When a

Re: [PATCH 0/3] SCSI: Fix hard lockup in scsi_remove_target()

2015-10-14 Thread Johannes Thumshirn
Zitat von James Bottomley <james.bottom...@hansenpartnership.com>: On Wed, 2015-10-14 at 16:39 +0200, Johannes Thumshirn wrote: On Wed, 2015-10-14 at 07:30 -0700, James Bottomley wrote: > On Wed, 2015-10-14 at 15:50 +0200, Johannes Thumshirn wrote: > > Removing a

Re: [PATCH 0/3] SCSI: Fix hard lockup in scsi_remove_target()

2015-10-14 Thread Johannes Thumshirn
Zitat von Christoph Hellwig <h...@infradead.org>: On Wed, Oct 14, 2015 at 04:39:07PM +0200, Johannes Thumshirn wrote: removal. This is what my initial proposal did as well. Christoph wanted me to decouple the whole process from the host_lock though and this is what this patches do as we

Re: dm-multipath test scripts

2015-10-07 Thread Johannes Thumshirn
On Wed, 2015-10-07 at 05:39 +, Junichi Nomura wrote: > This is a set of scripts for kernel-side dm-multipath testing. > Current > set of scripts are stress testing of extreme situation and its > coverage > is limited. But recently found dm-mpath regressions should be > detectable > with this.

Re: [PATCH 0/3] SCSI: Fix hard lockup in scsi_remove_target()

2015-10-16 Thread Johannes Thumshirn
On Wed, 2015-10-14 at 11:18 -0700, Christoph Hellwig wrote: > On Wed, Oct 14, 2015 at 08:45:56AM -0700, James Bottomley wrote: > > OK, so I really need you to separate the problems. Fixing the bug [..] > > Johannes, can you test the patch below? I've tested your patch and it doesn't show the

Re: [PATCH] scsi: mvsas: fix misleading indentation

2015-10-20 Thread Johannes Thumshirn
SAS_ADDR(dev->sas_addr)); >   > - rc = SAS_PHY_DOWN; > - return rc; > + rc = SAS_PHY_DOWN; > + return rc; >   } >   tei.port = dev->port->lldd_port; >   if (tei.port && !t

Re: [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management

2015-10-14 Thread Johannes Thumshirn
*sht, int privsize) > > fail_kthread: > kthread_stop(shost->ehandler); > + fail_index_remove: > + ida_simple_remove(_index_ida, shost->host_no); > fail_kfree: > kfree(shost); > return NULL; > @@ -588,6 +593,7 @@ int scsi_init_hosts(void) >

[PATCH 1/3] SCSI: Introduce device_lock and target_lock in Scsi_Host

2015-10-14 Thread Johannes Thumshirn
Introduce target_lock and device_lock to untangle the __devices and __targets lists from the host_lock. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/scsi/53c700.c | 3 +++ drivers/scsi/hosts.c | 2 ++ drivers/scsi/scsi.c | 8 driver

[PATCH 2/3] SCSI: Rework list handling in scsi_target_remove

2015-10-14 Thread Johannes Thumshirn
Rework the list handling in scsi_target_remove(). The new version introduces a reap list for targets. Targets that shall be removed are placed on the reap list and can then be reaped later on. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/scsi/scsi_sysfs.

[PATCH 3/3] SCSI: Rework list handling in __scsi_target_remove

2015-10-14 Thread Johannes Thumshirn
Rework the list handling in __scsi_target_remove(). The new version introduces a reap list for devices. Devices that shall be removed are placed on the reap list and can then be removed later on. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/scsi/scsi_sysfs.

[PATCH 0/3] SCSI: Fix hard lockup in scsi_remove_target()

2015-10-14 Thread Johannes Thumshirn
dprobe $module; mount $mountpoint; done This is a follow up of the patch proposed here: http://marc.info/?l=linux-scsi=144377409311774=2 incorporating Christoph's comment Johannes Thumshirn (3): SCSI: Introduce device_lock and target_lock in Scsi_Host SCSI: Rework list ha

Re: [PATCH] SCSI: mvsas: Fix NULL pointer dereference in mvs_slot_task_free

2015-10-21 Thread Johannes Thumshirn
ot_idx) > >  { > > +   if (!slot) > > +   return; > > if (!slot->task) > > return; > > if (!sas_protocol_ata(task->task_proto)) > > -- > > 2.5.0 > > > > Can this get

[PATCH] lpfc: Destroy lpfc_hba_index IDR on module exit

2015-07-08 Thread Johannes Thumshirn
, defines_module_exit.exit; @@ exit(void) { ... idr_destroy(idr); ... } @ missing_module_idr_destroy depends on declares_idr defines_module_exit !on_exit_calls_destroy @ identifier declares_idr.idr, defines_module_exit.exit; @@ exit(void) { ... +idr_destroy(idr); } /SmPL Signed-off-by: Johannes Thumshirn

  1   2   3   4   5   6   7   8   9   10   >