Re: [PATCH 0/3] Insert ATA transport objects in SCSI syfs topology.

2012-09-28 Thread Aaron Lu
On Thu, Sep 27, 2012 at 12:04:01PM -0700, Gwendal Grignou wrote: This set of patches improve ATA transport classes integration with SCSI objects. Before [2.6.x] Ata and scsi transport class where separated: `--:09:00.0 | `--ata1 | | `--port_port | | `--link1 | | |

Re: [PATCH 3/3] libata: Change transport topology layout

2012-09-28 Thread Aaron Lu
On Thu, Sep 27, 2012 at 12:04:04PM -0700, Gwendal Grignou wrote: Integrate ata objects [port, link, device] with scsi objects. The path of a scsi device is: .../:00:1f.2/host0/ata1/link1/dev1.0/target0:0:0/0:0:0:0 After test, I noticed that this will break the current ata acpi binding

Re: [usb-storage] Re: usb3 fails to write when using usb3 hub in usb3 port

2012-09-28 Thread Adrian Sandu
Adrian, I think that the suggestion about checking the power supply, the cabling, the grounding screws, and anything of like nature that has been omitted from this list is a very good idea. If successful it would eliminate the problem for you, as well as resolving the mystery. Unresolved

Re: [PATCH scsi] Short the path length of scsi_cmd_to_driver()

2012-09-28 Thread Li Zhong
On Thu, 2012-09-27 at 13:43 -0400, Martin K. Petersen wrote: Li == Li Zhong zh...@linux.vnet.ibm.com writes: @@ -845,8 +844,11 @@ static int scsi_send_eh_cmnd(struct scsi_cmnd *scmd, unsigned char *cmnd, scsi_eh_restore_cmnd(scmd, ses); -if (sdrv sdrv-eh_action) -

Re: [PATCH scsi] Short the path length of scsi_cmd_to_driver()

2012-09-28 Thread James Bottomley
On Thu, 2012-09-27 at 13:43 -0400, Martin K. Petersen wrote: Li == Li Zhong zh...@linux.vnet.ibm.com writes: @@ -845,8 +844,11 @@ static int scsi_send_eh_cmnd(struct scsi_cmnd *scmd, unsigned char *cmnd, scsi_eh_restore_cmnd(scmd, ses); -if (sdrv sdrv-eh_action) -

Re: [PATCH scsi] Add NULL checking of return value from scsi_cmd_to_driver()

2012-09-28 Thread James Bottomley
On Thu, 2012-09-27 at 13:41 -0400, Martin K. Petersen wrote: James == James Bottomley james.bottom...@hansenpartnership.com writes: I'm fine with having the eh action be triggered for FS requests only, if that's what you're asking? James Sort of ... I was thinking do it for all non

Re: [PATCH v7 2/6] scsi: sr: support runtime pm

2012-09-28 Thread Aaron Lu
On 09/27/2012 06:46 PM, Oliver Neukum wrote: On Tuesday 25 September 2012 16:01:35 Aaron Lu wrote: On Mon, Sep 24, 2012 at 11:40:18PM +0200, Rafael J. Wysocki wrote: On Monday, September 24, 2012, Aaron Lu wrote: On Mon, Sep 24, 2012 at 02:55:31PM +0200, Rafael J. Wysocki wrote: I just

Re: [usb-storage] Re: usb3 fails to write when using usb3 hub in usb3 port

2012-09-28 Thread Adrian Sandu
The only solution I see is to buy something else, like an Asus EB1501P-B057E .. I need something small and fast enough .. :| Maybe any other recommendations ? ( other root chipset / atom cpu .. small powered .. etc. ) -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the

Re: [bug report] [SCSI] mvumi: GFP_KERNEL under spin lock

2012-09-28 Thread Dan Carpenter
Whatever happened with this? You could just change the GFP_KERNEL to GFP_ATOMIC. regards, dan carpenter On Tue, Aug 14, 2012 at 05:59:27PM +0300, Dan Carpenter wrote: Hello Jianyun Li, The patch f0c568a478f0: [SCSI] mvumi: Add Marvell UMI driver from May 11, 2011, leads to the following

Re: [bug report] [SCSI] mvumi: GFP_KERNEL under spin lock

2012-09-28 Thread Dan Carpenter
On Fri, Sep 28, 2012 at 02:30:22PM +0300, Dan Carpenter wrote: Whatever happened with this? You could just change the GFP_KERNEL to GFP_ATOMIC. Ah, that email address is dead is what happened. I'll send a patch that changes this to GFP_ATOMIC. regards, dan carpenter -- To unsubscribe from

Re: [SCSI PATCH] sd: max-retries becomes configurable

2012-09-28 Thread Dan Williams
On Wed, Sep 26, 2012 at 7:20 PM, Martin K. Petersen martin.peter...@oracle.com wrote: James == James Bottomley james.bottom...@hansenpartnership.com writes: James On Mon, 2012-09-24 at 17:00 -0400, Jeff Garzik wrote: drivers/scsi/sd.c | 4 drivers/scsi/sd.h | 2 +- 2 files changed, 5

[PATCH 00/17] Updates for the be2iscsi driver.

2012-09-28 Thread John Soni Jose
Patches to update the be2iscsi driver. These patches were generated against the scsi tree misc heads. Jayamohan Kallickal (1): be2iscsi: Fix the kernel panic in blkiopoll disable mode John Soni Jose (15): be2iscsi: Display Completion Event string instead of opcode be2iscsi: Fix memory

[PATCH 01/17] be2iscsi: Fix the issue with soft reset.

2012-09-28 Thread John Soni Jose
From: Minh Tran minhduc.t...@emulex.com Fixed soft_reset problem which driver modified all 32bit before a write on second pass. Signed-off-by: Minh Tran minhduc.t...@emulex.com Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com --- drivers/scsi/be2iscsi/be_cmds.c |2 +- 1

[PATCH 02/17] be2iscsi: Display Completion Event string instead of opcode

2012-09-28 Thread John Soni Jose
Display the event string along with the opcode and CID on which the event has occured. Signed-off-by: John Soni Jose sony.joh...@emulex.com Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com --- drivers/scsi/be2iscsi/be_cmds.h |2 - drivers/scsi/be2iscsi/be_main.c | 88

[PATCH 03/17] be2iscsi: Fix memory leak in control path of driver

2012-09-28 Thread John Soni Jose
In contorl path of the driver the task was mapped using pci_map_single which was not unmapped when the completion for the task had come. Signed-off-by: John Soni Jose sony.joh...@emulex.com Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com --- drivers/scsi/be2iscsi/be_main.c |

[PATCH 04/17] be2iscsi: Fix max supported EQ count to 8.

2012-09-28 Thread John Soni Jose
The maximum EQ that can be created for a function is 8. Check the CPU online count and create only 8 EQ if CPU_Count = 8 Signed-off-by: John Soni Jose sony.joh...@emulex.com Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com --- drivers/scsi/be2iscsi/be_main.c | 23

[PATCH 05/17] be2iscsi: Display driver name and version in device attribute

2012-09-28 Thread John Soni Jose
Signed-off-by: John Soni Jose sony.joh...@emulex.com Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com --- drivers/scsi/be2iscsi/be_main.c |2 ++ drivers/scsi/be2iscsi/be_mgmt.c | 16 drivers/scsi/be2iscsi/be_mgmt.h |3 +++ 3 files changed, 21

[PATCH 06/17] be2iscsi: Issue an FLR when driver is loaded.

2012-09-28 Thread John Soni Jose
Issue Function Level Reset everytime driver is loaded. Signed-off-by: John Soni Jose sony.joh...@emulex.com Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com --- drivers/scsi/be2iscsi/be_main.c | 39 --- 1 files changed, 12 insertions(+), 27

[PATCH 07/17] be2iscsi: Fix the kernel panic in blkiopoll disable mode

2012-09-28 Thread John Soni Jose
From: Jayamohan Kallickal jayamohan.kallic...@emulex.com Fix kernel panic issue while running IO in blk_iopoll disable mode. Creating UNBOUND WQ for each EQ in the driver. Signed-off-by: John Soni Jose sony.joh...@emulex.com Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com ---

[PATCH 09/17] be2iscsi: Fix support for Skyhawk Adapters

2012-09-28 Thread John Soni Jose
Fix support for Skyhawk adapter by populating the pci_id_table Signed-off-by: John Soni Jose sony.joh...@emulex.com Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com --- drivers/scsi/be2iscsi/be.h |2 +- drivers/scsi/be2iscsi/be_main.c |3 +++

[PATCH 10/17] be2iscsi: Fix max EQ supported by the driver.

2012-09-28 Thread John Soni Jose
Fix the max EQ created when driver is loaded. The max EQ for BE3 adapter will be 8 and for Skyhawk it will be 64. Signed-off-by: John Soni Jose sony.joh...@emulex.com Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com --- drivers/scsi/be2iscsi/be_main.c | 15 +--

[PATCH 11/17] be2iscsi: Fix CQ create MBX CMD for Skyhawk.

2012-09-28 Thread John Soni Jose
Fix the CQ creation for Skyhawk by creating version V2 of the MBOX Cmd. Signed-off-by: John Soni Jose sony.joh...@emulex.com Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com --- drivers/scsi/be2iscsi/be_cmds.c | 38 +++---

[PATCH 12/17] be2iscsi: Fix WRB support for Skyhawk adapters.

2012-09-28 Thread John Soni Jose
Fix the latest WRB support for Skyhawk adapter by using V2 version. Signed-off-by: John Soni Jose sony.joh...@emulex.com Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com --- drivers/scsi/be2iscsi/be_main.c | 265 +--

[PATCH 13/17] be2iscsi: Fix context update for session in Skyhawk.

2012-09-28 Thread John Soni Jose
Fix the context update of a session in Skyhawk using the V2 version. Signed-off-by: John Soni Jose sony.joh...@emulex.com Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com --- drivers/scsi/be2iscsi/be_iscsi.c |8 ++ drivers/scsi/be2iscsi/be_main.c | 69 ++-

[PATCH 14/17] be2iscsi: Fix Task Completion Event handling for Skyhawk

2012-09-28 Thread John Soni Jose
Fix the Completion events returned by the FW for Skyhawk. Signed-off-by: John Soni Jose sony.joh...@emulex.com Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com --- drivers/scsi/be2iscsi/be_cmds.h | 53 drivers/scsi/be2iscsi/be_main.c | 267

[PATCH 15/17] be2iscsi: Fix issue of displaying adapter family.

2012-09-28 Thread John Soni Jose
Fix the issue of displaying adapter family by creating new sys attribute. Signed-off-by: John Soni Jose sony.joh...@emulex.com Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com --- drivers/scsi/be2iscsi/be_main.c |2 ++ drivers/scsi/be2iscsi/be_mgmt.c | 38

[PATCH 16/17] be2iscsi: Fix the copyright information

2012-09-28 Thread John Soni Jose
Signed-off-by: John Soni Jose sony.joh...@emulex.com Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com --- drivers/scsi/be2iscsi/be.h |2 +- drivers/scsi/be2iscsi/be_cmds.c |2 +- drivers/scsi/be2iscsi/be_cmds.h |2 +- drivers/scsi/be2iscsi/be_iscsi.c |2 +-

[PATCH 17/17] be2iscsi: Bump the driver version

2012-09-28 Thread John Soni Jose
Signed-off-by: John Soni Jose sony.joh...@emulex.com Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com --- drivers/scsi/be2iscsi/be_main.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/be2iscsi/be_main.h b/drivers/scsi/be2iscsi/be_main.h

Re: [PATCH v7 2/6] scsi: sr: support runtime pm

2012-09-28 Thread Aaron Lu
[Adding more people and list back in] On 09/29/2012 05:46 AM, Rafael J. Wysocki wrote: On Friday, September 28, 2012, Aaron Lu wrote: On 09/28/2012 07:15 AM, Rafael J. Wysocki wrote: On Thursday, September 27, 2012, Aaron Lu wrote: On 09/27/2012 05:37 AM, Rafael J. Wysocki wrote: Say the

[PATCH v2 scsi] Short the path length of scsi_cmd_to_driver()

2012-09-28 Thread Li Zhong
As suggested by James: this patch tries to short the path length of scsi_cmd_to_driver(). As only REQ_TYPE_BLOCK_PC commands can be submitted without a driver, so we could avoid the related NULL checking, as long as we make sure we don't use it for REQ_TYPE_BLOCK_PC type commands. Plus, this fixes