[PATCH] scsi_prep_fn() check for empty queue

2013-06-26 Thread Maxim Uvarov
This fix: end_request: I/O error, dev sdc, sector 976576 rport-0:0-3: blocked FC remote port time out: removing target and saving binding BUG: unable to handle kernel NULL pointer dereference at 0400 IP: [812f0cc2] scsi_prep_state_check+0xe/0x99 [812f1f9d]

Re: [PATCH] scsi_prep_fn() check for empty queue

2013-06-26 Thread Bart Van Assche
On 06/26/13 11:02, Maxim Uvarov wrote: This fix: end_request: I/O error, dev sdc, sector 976576 rport-0:0-3: blocked FC remote port time out: removing target and saving binding BUG: unable to handle kernel NULL pointer dereference at 0400 IP: [812f0cc2]

Re: [PATCH 8/9] scsi/pm8001: use pdev-pm_cap instead of pci_find_capability(..,PCI_CAP_ID_PM)

2013-06-26 Thread Jack Wang
On 06/18/2013 10:23 AM, Yijing Wang wrote: Pci core has been saved pm cap register offset by pdev-pm_cap in pci_pm_init() in init path. So we can use pdev-pm_cap instead of using pci_find_capability(pdev, PCI_CAP_ID_PM) for better performance and simplified code. I think Lindar already

Re: [PATCH 8/9] scsi/pm8001: use pdev-pm_cap instead of pci_find_capability(..,PCI_CAP_ID_PM)

2013-06-26 Thread Yijing Wang
On 2013/6/26 17:33, Jack Wang wrote: On 06/18/2013 10:23 AM, Yijing Wang wrote: Pci core has been saved pm cap register offset by pdev-pm_cap in pci_pm_init() in init path. So we can use pdev-pm_cap instead of using pci_find_capability(pdev, PCI_CAP_ID_PM) for better performance and

[PATCH V1 2/4] libiscsi: Exporting new attrs for iscsi session and connection in sysfs

2013-06-26 Thread vikas.chaudhary
From: Adheer Chandravanshi adheer.chandravan...@qlogic.com Signed-off-by: Adheer Chandravanshi adheer.chandravan...@qlogic.com Signed-off-by: Vikas Chaudhary vikas.chaudh...@qlogic.com --- drivers/scsi/libiscsi.c | 98 + include/scsi/libiscsi.h |

[PATCH V1 3/4] qla4xxx: Exporting new attrs for iscsi session and connection in sysfs

2013-06-26 Thread vikas.chaudhary
From: Adheer Chandravanshi adheer.chandravan...@qlogic.com Signed-off-by: Adheer Chandravanshi adheer.chandravan...@qlogic.com Signed-off-by: Vikas Chaudhary vikas.chaudh...@qlogic.com --- drivers/scsi/qla4xxx/ql4_os.c | 203 ++ 1 file changed, 146

Re: [PATCH 0/8] qla4xxx: Updates for scsi misc branch

2013-06-26 Thread Vikas Chaudhary
-Original Message- From: Vikas vikas.chaudh...@qlogic.com Date: Thursday 9 May 2013 3:32 PM To: jbottom...@parallels.com jbottom...@parallels.com, Mike Christie micha...@cs.wisc.edu Cc: scsi linux-scsi@vger.kernel.org, Admin vikas.chaudh...@qlogic.com, Lalit Chandivade

RE: [PATCH V3 0/5] Drivers: scsi: storvsc

2013-06-26 Thread KY Srinivasan
-Original Message- From: KY Srinivasan Sent: Monday, June 17, 2013 9:32 AM To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; oher...@suse.com; jbottom...@parallels.com; h...@infradead.org; linux-scsi@vger.kernel.org Subject: RE: [PATCH V3

Re: [PATCH 1/1] bfa: Fixes for 0-terminated strncpy and possible null pointer dereference

2013-06-26 Thread James Bottomley
On Wed, 2013-05-15 at 21:41 +0200, Jakob Normark wrote: This patch fixes two cppcheck errors in drivers/scsi/bfa/bfad_im.c Signed-off-by: Jakob Normark jakobnorm...@gmail.com --- drivers/scsi/bfa/bfad_im.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git

Re: [PATCH 0/4] qla4xxx: Updates for scsi misc branch

2013-06-26 Thread Mike Christie
On 06/26/2013 07:11 AM, vikas.chaudh...@qlogic.com wrote: From: Vikas Chaudhary vikas.chaudh...@qlogic.com James, Following patches are to display additional iSCSI connection and session parameters in sysfs. Please apply these patches to the scsi tree misc branch at your earliest

Re: [PATCH] cxgb4i: add support for t5 adapter

2013-06-26 Thread Mike Christie
On 05/29/2013 07:13 PM, k...@chelsio.com wrote: [PATCH] cxgb4i: add support for T5 adapter From: Karen Xie k...@chelsio.com Adds support for Chelsio T5 adapter. Signed-off-by: Karen Xie k...@chelsio.com Sorry for the late reply on this. I thought it got merged already. Patch looks ok.

[PATCH 05/10] scsi: ufs: Fix the response UPIU length setting

2013-06-26 Thread Santosh Y
From: Sujit Reddy Thumma sthu...@codeaurora.org The response UPIU length should be in DWORD and not in bytes. Signed-off-by: Maya Erez me...@codeaurora.org Signed-off-by: Sujit Reddy Thumma sthu...@codeaurora.org Signed-off-by: Santosh Y santos...@gmail.com diff --git

[PATCH 02/10] scsi: ufs: amend interrupt configuration

2013-06-26 Thread Santosh Y
From: Seungwon Jeon tgih@samsung.com It makes interrupt setting more flexible especially for disabling. And wrong bit mask is fixed for ver 1.0. [17:16] is added for mask. Signed-off-by: Seungwon Jeon tgih@samsung.com Tested-by: Maya Erez me...@codeaurora.org Signed-off-by: Santosh Y

[PATCH 04/10] scsi: ufs: rework link start-up process

2013-06-26 Thread Santosh Y
From: Seungwon Jeon tgih@samsung.com Link start-up requires long time with multiphase handshakes between UFS host and device. This affects driver's probe time. This patch let link start-up run asynchronously. Link start-up will be executed at the end of prove separately. Along with this

[PATCH 01/10] scsi: ufs: wrap the i/o access operations

2013-06-26 Thread Santosh Y
From: Seungwon Jeon tgih@samsung.com Simplify operations with hiding mmio_base. Signed-off-by: Seungwon Jeon tgih@samsung.com Tested-by: Maya Erez me...@codeaurora.org Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index

[PATCH 00/10] scsi: ufs: link start-up rework and other fixes

2013-06-26 Thread Santosh Y
Hi James, Please merge the following patches to 'misc' branch. Thanks, Santosh Akinobu Mita (4): ufshcd-pltfrm: add missing empty slot in ufs_of_match[] ufs: fix register address in UIC error interrupt handling ufshcd-pltfrm: remove unnecessary dma_set_coherent_mask() call ufs: fix DMA

[PATCH 07/10] ufshcd-pltfrm: add missing empty slot in ufs_of_match[]

2013-06-26 Thread Santosh Y
From: Akinobu Mita m...@fixstars.com of_match_table member in struct device_driver must be terminated by empty slot as a sentinel. Signed-off-by: Akinobu Mita m...@fixstars.com Cc: Vinayak Holikatti vinholika...@gmail.com Cc: James E.J. Bottomley jbottom...@parallels.com Cc:

[PATCH 03/10] scsi: ufs: remove version check before IS reg clear

2013-06-26 Thread Santosh Y
From: Seungwon Jeon tgih@samsung.com There is no need to check the version to clear the interrupt status. And the order is changed prior to actual handling. Signed-off-by: Seungwon Jeon tgih@samsung.com Tested-by: Maya Erez me...@codeaurora.org Signed-off-by: Santosh Y

[PATCH 06/10] scsi: ufs: use devres functions for ufshcd

2013-06-26 Thread Santosh Y
From: Seungwon Jeon tgih@samsung.com This patch replaces normal calls for resource allocation with devm_*() derivative functions. It makes resource freeing simpler. Signed-off-by: Seungwon Jeon tgih@samsung.com Signed-off-by: Santosh Y santos...@gmail.com diff --git

[PATCH 08/10] ufs: fix register address in UIC error interrupt handling

2013-06-26 Thread Santosh Y
From: Akinobu Mita m...@fixstars.com In UIC error interrupt handling, it checks if UIC data link layer error code indicates PA_INIT_ERROR in order to determine whether a fatal error handling is needed or not. But the code tries to read UIC data link layer error code from wrong

[PATCH 09/10] ufshcd-pltfrm: remove unnecessary dma_set_coherent_mask() call

2013-06-26 Thread Santosh Y
From: Akinobu Mita m...@fixstars.com Changing the device coherent dma mask to the value that currently set has no effect. Signed-off-by: Akinobu Mita m...@fixstars.com Cc: Vinayak Holikatti vinholika...@gmail.com Cc: James E.J. Bottomley jbottom...@parallels.com Cc: linux-scsi@vger.kernel.org

[PATCH 10/10] ufs: fix DMA mask setting

2013-06-26 Thread Santosh Y
From: Akinobu Mita m...@fixstars.com If the controller doesn't support 64-bit addressing mode, it must not set the DMA mask to 64-bit. But it's unconditionally trying to set to 64-bit without checking 64-bit addressing support in the controller capabilities. It was correctly checked before

[PATCH 01/10] scsi: ufs: wrap the i/o access operations

2013-06-26 Thread Santosh Y
From: Seungwon Jeon tgih@samsung.com Simplify operations with hiding mmio_base. Signed-off-by: Seungwon Jeon tgih@samsung.com Tested-by: Maya Erez me...@codeaurora.org Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index

[PATCH 04/10] scsi: ufs: rework link start-up process

2013-06-26 Thread Santosh Y
From: Seungwon Jeon tgih@samsung.com Link start-up requires long time with multiphase handshakes between UFS host and device. This affects driver's probe time. This patch let link start-up run asynchronously. Link start-up will be executed at the end of prove separately. Along with this

[PATCH 06/10] scsi: ufs: use devres functions for ufshcd

2013-06-26 Thread Santosh Y
From: Seungwon Jeon tgih@samsung.com This patch replaces normal calls for resource allocation with devm_*() derivative functions. It makes resource freeing simpler. Signed-off-by: Seungwon Jeon tgih@samsung.com Signed-off-by: Santosh Y santos...@gmail.com diff --git

[PATCH 09/10] ufshcd-pltfrm: remove unnecessary dma_set_coherent_mask() call

2013-06-26 Thread Santosh Y
From: Akinobu Mita m...@fixstars.com Changing the device coherent dma mask to the value that currently set has no effect. Signed-off-by: Akinobu Mita m...@fixstars.com Cc: Vinayak Holikatti vinholika...@gmail.com Cc: James E.J. Bottomley jbottom...@parallels.com Cc: linux-scsi@vger.kernel.org

Re: [PATCH 1/2] scsi: ufs: Add support for host assisted background operations

2013-06-26 Thread Santosh Y
On Thu, Jun 13, 2013 at 7:50 PM, Sujit Reddy Thumma sthu...@codeaurora.org wrote: Background operations in the UFS device can be disabled by the host to reduce the response latency of transfer requests. Add support for enabling/disabling the background operations during runtime suspend/resume

[PATCH 1/1] scsi/megaraid: minor cut and paste error fixed.

2013-06-26 Thread James Georgas
This looks like a cut and paste typo to me. Both of the megasas_read_fw_status_reg_* functions involved are identical though, so there was no bad behaviour. I changed it for consistency and clarity. Signed-off-by: James Georgas soulpa...@gmail.com --- drivers/scsi/megaraid/megaraid_sas_base.c |

[Bug 60191] New: Bad flush cache

2013-06-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=60191 Summary: Bad flush cache Product: IO/Storage Version: 2.5 Kernel Version: 3.8.13 Platform: All OS/Version: Linux Tree: Mainline Status: NEW Severity: normal

Re: [PATCH 9/9] vhost/scsi: Convert to se_cmd-cmd_kref TARGET_SCF_ACK_KREF usage

2013-06-26 Thread Asias He
On Fri, Jun 07, 2013 at 09:34:24PM +, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch coverts vhost/scsi to se_cmd-cmd_kref TARGET_SCF_ACK_KREF usage, instead of assuming that vhost_scsi_free_cmd() is always called before TCM processing is completed

Re: [PATCH 3/5] Drivers: scsi: storvsc: Implement multi-channel support

2013-06-26 Thread James Bottomley
On Tue, 2013-06-04 at 12:05 -0700, K. Y. Srinivasan wrote: Implement multi-channel support for the storage devices. This doesn't compile: CC [M] drivers/scsi/storvsc_drv.o drivers/scsi/storvsc_drv.c: In function ‘handle_sc_creation’: drivers/scsi/storvsc_drv.c:763:35: error: ‘struct

Re: [PATCH V3 0/5] Drivers: scsi: storvsc

2013-06-26 Thread James Bottomley
On Wed, 2013-06-26 at 12:58 +, KY Srinivasan wrote: -Original Message- From: KY Srinivasan Sent: Monday, June 17, 2013 9:32 AM To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; oher...@suse.com; jbottom...@parallels.com;

[PATCH v2 06/10] scsi: ufs: use devres functions for ufshcd

2013-06-26 Thread Seungwon Jeon
This patch replaces normal calls for resource allocation with devm_*() derivative functions. It makes resource freeing simpler. Signed-off-by: Seungwon Jeon tgih@samsung.com Signed-off-by: Santosh Y santos...@gmail.com --- Change in v2: [NOTE: There are no conflicts with the following