RE: [PATCH/RFC V2 10/16] scsi: ufs: add UFS power management support

2014-08-20 Thread Dong, Chuanxiao
-Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-ow...@vger.kernel.org] On Behalf Of Dolev Raviv Sent: Thursday, August 14, 2014 9:31 PM To: james.bottom...@hansenpartnership.com; h...@infradead.org Cc: linux-scsi@vger.kernel.org;

Re: [PATCH v3 0/17] arcmsr: change note since v13 or v2

2014-08-20 Thread Ching Huang
Hi Christoph, Thanks for your effort to fix up errors and apply the patches of arcmsr to a branch. It is great. Regards, Ching Huang On Tue, 2014-08-19 at 08:02 -0700, Christoph Hellwig wrote: Hi Ching, I've fixed up various checkpatch errors and fixed up some descriptions and applied the

Re: [PATCH] scsi.mq:Added enable_cmd_list flags in hostt to reduce lock contention

2014-08-20 Thread Bart Van Assche
On 08/19/14 20:17, kashyap.de...@avagotech.com wrote: + if (shost-hostt-enable_cmd_list) { This code is in the hot path which means that caching enable_cmd_list in struct Scsi_Host (as is done for many other SCSI host parameters) probably will (slightly) improve performance further.

How to get the number of VFs assigned to the guests in XEN

2014-08-20 Thread Sreekanth Reddy
HI, For SRIOV support, currently in the KVM environment, mpt3sas driver can use the API pci_vfs_assigned() to know the number of VFs that are currently assigned to the running VMs. So that during the PF driver unload time, if the return value of this API is greater than zero the our driver won't

Re: Sym2 scsi hang on boot on sparc64

2014-08-20 Thread Meelis Roos
Bisection (on PA-RISC) points to: 71e75c97f97a9645d25fbf3d8e4165a558f18747 is the first bad commit commit 71e75c97f97a9645d25fbf3d8e4165a558f18747 Author: Christoph Hellwig h...@lst.de Date: Fri Apr 11 19:07:01 2014 +0200 scsi: convert device_busy to atomic_t That's

RE: [PATCH] scsi.mq:Added enable_cmd_list flags in hostt to reduce lock contention

2014-08-20 Thread Kashyap Desai
-Original Message- From: Bart Van Assche [mailto:bvanass...@acm.org] Sent: Wednesday, August 20, 2014 4:18 PM To: kashyap.de...@avagotech.com; linux-scsi@vger.kernel.org Cc: aacr...@adaptec.com; elli...@hp.com; jbottom...@parallels.com; h...@infradead.org Subject: Re: [PATCH]

RE: [PATCH] scsi.mq:Added enable_cmd_list flags in hostt to reduce lock contention

2014-08-20 Thread Kashyap Desai
-Original Message- From: Christoph Hellwig [mailto:h...@infradead.org] Sent: Wednesday, August 20, 2014 6:11 PM To: Kashyap Desai Cc: Bart Van Assche; linux-scsi@vger.kernel.org; aacr...@adaptec.com; elli...@hp.com; jbottom...@parallels.com; h...@infradead.org Subject: Re: [PATCH]

Re: How to get the number of VFs assigned to the guests in XEN

2014-08-20 Thread Alex Williamson
On Wed, 2014-08-20 at 16:39 +0530, Sreekanth Reddy wrote: HI, For SRIOV support, currently in the KVM environment, mpt3sas driver can use the API pci_vfs_assigned() to know the number of VFs that are currently assigned to the running VMs. So that during the PF driver unload time, if the

Re: [PATCH] scsi.mq:Added enable_cmd_list flags in hostt to reduce lock contention

2014-08-20 Thread Christoph Hellwig
On Wed, Aug 20, 2014 at 06:08:37PM +0530, Kashyap Desai wrote: This code is in the hot path which means that caching enable_cmd_list in struct Scsi_Host (as is done for many other SCSI host parameters) probably will (slightly) improve performance further. Otherwise this patch looks fine

Re: [PATCH] bnx2fc: fix incorrect DMA memory mapping in bnx2fc_map_sg()

2014-08-20 Thread Martin K. Petersen
Christoph == Christoph Hellwig h...@infradead.org writes: Christoph Can I get a review for this one, please? Looks good to me. Reviewed-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line

[PATCH/RESEND] scsi.mq: Added use_cmd_list flag in scsi_host to reduce lock contention

2014-08-20 Thread Kashyap.Desai
Comment provided by Bart Van and Chris H is addressed in this patch. Add use_cmd_list flag in scsi_host to indicate scs.mq stack to keep track of cmd_list per sdev. Default behaviour is not to keep track of cmd_list per sdev, as this may introduce lock contention. (overhead is more on

Re: [RFC 09/10] scsi: sd: Avoid sending medium write commands if device is write protected

2014-08-20 Thread Martin K. Petersen
Christoph == Christoph Hellwig h...@infradead.org writes: Christoph This looks reasonable to me. I agree. Reviewed-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in

Re: [Xen-devel] [PATCH V5 2/5] Add XEN pvSCSI protocol description

2014-08-20 Thread Konrad Rzeszutek Wilk
On Mon, Aug 18, 2014 at 11:31:47AM +0200, jgr...@suse.com wrote: From: Juergen Gross jgr...@suse.com Add the definition of pvSCSI protocol used between the pvSCSI frontend in a XEN domU and the pvSCSI backend in a XEN driver domain (usually Dom0). This header was originally provided by

Re: [Xen-devel] [PATCH V5 5/5] add xen pvscsi maintainer

2014-08-20 Thread Konrad Rzeszutek Wilk
On Mon, Aug 18, 2014 at 11:31:50AM +0200, jgr...@suse.com wrote: From: Juergen Gross jgr...@suse.com Add myself as maintainer for the Xen pvSCSI stuff. Signed-off-by: Juergen Gross jgr...@suse.com Acked-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- MAINTAINERS | 8 1

Re: [Xen-devel] [PATCH V5 1/5] xen/events: support threaded irqs for interdomain event channels

2014-08-20 Thread Konrad Rzeszutek Wilk
On Mon, Aug 18, 2014 at 11:31:46AM +0200, jgr...@suse.com wrote: From: Juergen Gross jgr...@suse.com Export bind_interdomain_evtchn_to_irq() so drivers can use threaded interrupt handlers with: irq = bind_interdomain_evtchn_to_irq(remote_dom, remote_port); if (irq 0) /* error */

[PATCH/RESEND] scsi.mq: Added use_cmd_list flag in scsi_host to reduce lock contention

2014-08-20 Thread Kashyap.Desai
Comment provided by Bart Van and Chris H is addressed in this patch. Add use_cmd_list flag in scsi_host to indicate scs.mq stack to keep track of cmd_list per sdev. Default behaviour is not to keep track of cmd_list per sdev, as this may introduce lock contention. (overhead is more on

Re: [Xen-devel] [PATCH V5 2/5] Add XEN pvSCSI protocol description

2014-08-20 Thread Juergen Gross
On 08/20/2014 03:25 PM, Konrad Rzeszutek Wilk wrote: On Mon, Aug 18, 2014 at 11:31:47AM +0200, jgr...@suse.com wrote: From: Juergen Gross jgr...@suse.com Add the definition of pvSCSI protocol used between the pvSCSI frontend in a XEN domU and the pvSCSI backend in a XEN driver domain (usually

Re: How to get the number of VFs assigned to the guests in XEN

2014-08-20 Thread Alex Williamson
On Wed, 2014-08-20 at 19:14 +0530, Sreekanth Reddy wrote: Thanks Alex, Then, Is there any other ways to stop accidental unload of PF driver while still some VFs are accessing by the running VMs. I believe the reason pci_vfs_assigned() and the pci_dev flag that backs it exists is because

Re: [PATCH/RESEND] scsi.mq: Added use_cmd_list flag in scsi_host to reduce lock contention

2014-08-20 Thread Martin K. Petersen
Kashyap == kashyap.de...@avagotech.com writes: Kashyap Comment provided by Bart Van and Chris H is addressed in this Kashyap patch. Add use_cmd_list flag in scsi_host to indicate scs.mq Kashyap stack to keep track of cmd_list per sdev. Kashyap Default behaviour is not to keep track of

Re: [PATCH] bnx2fc: fix incorrect DMA memory mapping in bnx2fc_map_sg()

2014-08-20 Thread Eddie Wai
On Mon, 2014-08-04 at 10:20 +0200, Maurizio Lombardi wrote: In the bnx2fc_map_sg() function, the original behaviour is to allocate the DMA memory by directly calling dma_map_sg() instead of using scsi_dma_map(). In contrast, bnx2fc_unmap_sg_list() calls scsi_dma_unmap(). The problem is

[RFCv2 1/4] target: Remove unneeded check in sbc_parse_cdb

2014-08-20 Thread Andy Grover
The check of SCF_SCSI_DATA_CDB seems to be a remnant from before hch's refactoring of this function. There are no places where that flag is set that cmd-execute_cmd isn't also set. Signed-off-by: Andy Grover agro...@redhat.com --- drivers/target/target_core_sbc.c | 2 +- 1 file changed, 1

[RFCv2 2/4] uio: Export definition of struct uio_device

2014-08-20 Thread Andy Grover
In order to prevent a O(n) search of the filesystem to link up its uio node with its target configuration, TCMU needs to know the minor number that UIO assigned. Expose the definition of this struct so TCMU can access this field. Signed-off-by: Andy Grover agro...@redhat.com ---

[RFCv2 0/4] Userspace pass-through storage engine (backend)

2014-08-20 Thread Andy Grover
Hi all, Here is version two of the userspace passthrough backstore code I've been working on. You can find some documentation on the design in last patch. Please let me know what you think about the design and the code. Thanks -- Andy Changes since version 1: * Use netlink for reporting device

[RFCv2 3/4] target: Add a user-passthrough backstore

2014-08-20 Thread Andy Grover
Add a LIO storage engine that presents commands to userspace for execution. This would allow more complex backstores to be implemented out-of-kernel, and also make experimentation a-la FUSE (but at the SCSI level -- SUSE?) possible. It uses a mmap()able UIO device per LUN to share a command ring

[RFCv2 4/4] target: Add documentation on the target userspace pass-through driver

2014-08-20 Thread Andy Grover
Describes the driver and its interface to make it possible for user programs to back a LIO-exported LUN. Signed-off-by: Andy Grover agro...@redhat.com --- Documentation/target/tcmu-design.txt | 229 +++ 1 file changed, 229 insertions(+) create mode 100644

Re: [PATCH v3 00/13] scsi: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-08-20 Thread Alexander Gordeev
On Tue, Aug 19, 2014 at 10:00:47AM -0700, Christoph Hellwig wrote: Thanks, I've applied patches 1 to 7 to the drivers-for-3.18 branch. Thanks, Christoph! Not sure how to handle the rest, though. Chelsio driver has no maintainers and none of be2iscsi, pmcraid and csiostor has been reviewed

Re: [RESEND][PATCH 4/4] [SCSI]fnic: assign FIP_ALL_FCF_MACS to fcoe_all_fcfs

2014-08-20 Thread Hiral Shah (hishah)
On 5/2/14, 5:46 PM, Hiral Shah (hishah) his...@cisco.com wrote: 1) Assgning FIP_ALL_FCF_MACS to fcoe_all_fcfs allows VLAN request to be sent to correct Mac address for VLAN Discovery otherwise VLAN request will be sent to invalid address hence FLOGI never happens. 2) Simplify the

[Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN

2014-08-20 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=80711 --- Comment #10 from Alan Stern st...@rowland.harvard.edu --- On Tue, 19 Aug 2014, Christoph Hellwig wrote: On Thu, Aug 07, 2014 at 11:58:37AM -0400, Alan Stern wrote: On Wed, Aug 06, 2014 at 04:02:22PM -0400, Alan Stern wrote: I doubt

Re: [Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN

2014-08-20 Thread Alan Stern
On Tue, 19 Aug 2014, Christoph Hellwig wrote: On Thu, Aug 07, 2014 at 11:58:37AM -0400, Alan Stern wrote: On Wed, Aug 06, 2014 at 04:02:22PM -0400, Alan Stern wrote: I doubt either of them forces users to hack up flags for these cases. Why was this change needed in the first

Re: [PATCH v3 00/13] scsi: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-08-20 Thread Christoph Hellwig
On Wed, Aug 20, 2014 at 08:14:17PM +0100, Alexander Gordeev wrote: I've applied patches 1 to 7 to the drivers-for-3.18 branch. Thanks, Christoph! Not sure how to handle the rest, though. Chelsio driver has no maintainers and none of be2iscsi, pmcraid and csiostor has been reviewed for

Problem with USB-to-SATA adapters

2014-08-20 Thread Dale R. Worley
I don't know if this is the correct place for this problem, but you people can probably tell me the correct place. I have two USB to SATA adapter dongles. In general, they work fine. However I've discovered that one of them handles large (1 TB and above) drives correctly and one does not. In

Re: How to get the number of VFs assigned to the guests in XEN

2014-08-20 Thread Konrad Rzeszutek Wilk
On Wed, Aug 20, 2014 at 04:33:29PM +0530, Sreekanth Reddy wrote: HI, For SRIOV support, currently in the KVM environment, mpt3sas driver can use the API pci_vfs_assigned() to know the number of VFs that are currently assigned to the running VMs. So that during the PF driver unload time,

Re: Problem with USB-to-SATA adapters

2014-08-20 Thread James Bottomley
On Wed, 2014-08-20 at 16:18 -0400, Dale R. Worley wrote: I don't know if this is the correct place for this problem, but you people can probably tell me the correct place. linux-usb can probably also help (cc'd). I have two USB to SATA adapter dongles. In general, they work fine. However